Jump to content

1.12.2 How to make a life steal enchantment by percentage [SOLVED]


Enderlook

Recommended Posts

Actually, I have done one:

	@Override
	public void onEntityDamaged (EntityLivingBase user, Entity target, int level) {
		user.heal(1 + level);
	}

...

But I have a problem, this heals the player a flat amount. My idea is to heal the player a percentage of the damage dealt to the target. How can I get the amount of damaged provoked to the enemy in order to calculate my life steal?

Edited by Enderlook
Link to comment
Share on other sites

4 hours ago, Enderlook said:

But I have a problem, this heals the player a flat amount. My idea is to heal the player a percentage of the damage dealt to the target. How can I get the amount of damaged provoked to the enemy in order to calculate my life steal?

You're not able to apply your Enchantment Effect in that method. You will need to subscribe to the LivingDamageEvent or LivingAttackEvent.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

55 minutes ago, Animefan8888 said:

You're not able to apply your Enchantment Effect in that method. You will need to subscribe to the LivingDamageEvent or LivingAttackEvent.

Ok, I've tried with this code (and the same with LivingDamageEvent) but it seems don't work:

	@SubscribeEvent
	public void vampire(LivingAttackEvent event) {
		Object attacker = event.getSource().getTrueSource();
		if (attacker instanceof EntityLivingBase) {
			EntityLivingBase entityAttacker = (EntityLivingBase)attacker;
			if(!entityAttacker.getEntityWorld().isRemote) {
				int level = EnchantmentHelper.getEnchantmentLevel(ENCHANTEMNT_VAMPIRISM, entityAttacker.getHeldItemMainhand());
				entityAttacker.heal(event.getAmount() * (level / 5));
			}	
		}	
	}

What am I doing wrong?

Link to comment
Share on other sites

14 minutes ago, Animefan8888 said:

Is your event registered?

... isn't "@SubscribeEvent" the way to register the event? I've another event registered in that way (for another enchantment) and they work. All of them are registered in the same class under the "@EventBusSubscriber(modid=ExtraCraft.MOD_ID)"

Link to comment
Share on other sites

7 minutes ago, Enderlook said:

Ups, I've forgotten that. And which method is better? Register them like I do, or in the other way?

It ultimately doesn't matter.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.