Jump to content

Game Crash from Apple Drop - 1.12.2


UM3 F0R TH3 W1N

Recommended Posts

I have recently been working on having my custom apple drop from oak trees and dark oak trees, however as I was testing it the game crashed, here's the crash log: https://hastebin.com/xifabokeci.sql.

Here's ApplesFromLeavesEvent.java: https://hastebin.com/alipepoqok.java.

If you need any other classes tell me.

Thanks for the help in advance!

 

Link to comment
Share on other sites

im currently testing this code here:

if(event.getState().getBlock() == Blocks.LEAVES.getDefaultState().withProperty(BlockOldLeaf.VARIANT, BlockPlanks.EnumType.OAK))
        {
            event.getDrops().add(new ItemStack(ItemInit.GREEN_APPLE));
            event.setDropChance(0.05f);
        }
        
        else if(event.getState().getBlock() == Blocks.LEAVES2.getDefaultState().withProperty(BlockNewLeaf.VARIANT, BlockPlanks.EnumType.DARK_OAK))
        {
            event.getDrops().add(new ItemStack(ItemInit.GREEN_APPLE));
            event.setDropChance(0.05f);
        }

Link to comment
Share on other sites

HarvestDropsEvent can be called for any block in the game, 99% of which won't have the BlockOldLeaf.VARIANT property in their block state. As you've seen, calling IBlockState#getValue with an invalid property throws an exception.

 

You need to check the Block itself first, use IBlockState#getBlock to get it and then check that it's equal to Blocks.LEAVES/Blocks.LEAVES2.

 

16 minutes ago, UM3 F0R TH3 W1N said:

if(event.getState().getBlock() == Blocks.LEAVES.getDefaultState().withProperty(BlockOldLeaf.VARIANT, BlockPlanks.EnumType.OAK))

IBlockState#getBlock returns a Block, which will never be equal to an IBlockState. You need to check the Block and the properties in two separate expressions within the if condition.

 

Edit: It looks like @diesieben07 already explained most of this in your previous threads. Please stop creating new threads for the same topic.

Edited by Choonster

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.