Jump to content

[1.12.2] Dynamic Recipes


TLHPoE

Recommended Posts

Hello, I was referencing this post in order to add my dynamic recipe, but it recommends using a class (RecipeSorter) that is marked as deprecated. How do I register my recipe?

 

I have my IRecipe class (plus its factory):

Spoiler

package com.kain24.quickconsume.recipe;

import com.google.gson.JsonObject;
import com.kain24.quickconsume.item.ItemPotionBag;
import net.minecraft.inventory.InventoryCrafting;
import net.minecraft.item.ItemPotion;
import net.minecraft.item.ItemStack;
import net.minecraft.item.crafting.IRecipe;
import net.minecraft.potion.PotionUtils;
import net.minecraft.world.World;
import net.minecraftforge.common.crafting.IRecipeFactory;
import net.minecraftforge.common.crafting.JsonContext;
import net.minecraftforge.registries.IForgeRegistryEntry;

public class PotionBagRecipe
        extends IForgeRegistryEntry.Impl<IRecipe>
        implements IRecipe {
    @Override
    public boolean matches(InventoryCrafting inv, World worldIn) {
        ItemStack bag = null;
        ItemStack potion = null;
        int amt = 0;

        for(int i = 0; i < inv.getSizeInventory(); i++) {
            ItemStack is = inv.getStackInSlot(i);

            if(is.getItem() instanceof ItemPotionBag) {
                if(bag != null) {
                    return false; //2 bags in grid = NO
                } else {
                    bag = is;
                }
            } else if(is.getItem() instanceof ItemPotion) {
                if(potion != null) {
                    if(PotionUtils.getFullEffectsFromItem(is).equals(PotionUtils.getFullEffectsFromItem(potion))) {
                        amt++;
                    } else {
                        return false; //2 different potions = NO
                    }
                } else {
                    potion = is;
                    amt++;
                }
            }
        }

        if(bag != null && potion != null) {
            ItemStack storedPotion = ItemPotionBag.getPotionType(bag);

            if(storedPotion.isEmpty() ||
                    PotionUtils.getFullEffectsFromItem(storedPotion).equals(PotionUtils.getFullEffectsFromItem(potion))) {
                if(ItemPotionBag.getAmountStored(bag) + amt > ItemPotionBag.getMax()) {
                    return false; //Overfill bag = NO
                }

                return true;
            }
        }

        return false;
    }

    @Override
    public ItemStack getCraftingResult(InventoryCrafting inv) {
        ItemStack bag = null;
        ItemStack potion = null;
        int amt = 0;

        for(int i = 0; i < inv.getSizeInventory(); i++) {
            ItemStack is = inv.getStackInSlot(i);

            if(is.getItem() instanceof ItemPotionBag) {
                bag = is.copy();
            } else if(is.getItem() instanceof ItemPotion) {
                potion = is;
                amt++;
            }
        }

        ItemPotionBag.setPotionType(bag, potion);
        ItemPotionBag.setAmountStored(bag, ItemPotionBag.getAmountStored(bag) + amt);

        return bag;
    }

    @Override
    public boolean canFit(int width, int height) {
        return width * height > 1;
    }

    @Override
    public ItemStack getRecipeOutput() {
        return ItemStack.EMPTY;
    }

    @Override
    public boolean isDynamic() {
        return true;
    }

    public static class Factory implements IRecipeFactory {
        @Override
        public IRecipe parse(JsonContext ctx, JsonObject json) {
            return new PotionBagRecipe();
        }
    }
}

 

 

 

And then I have my _factories.json (located in assets/quickconsume/recipes):

Spoiler

{
  "recipes": {
    "potion_bag_store": "com.kain24.quickconsume.recipe.PotionBagRecipe$Factory"
  }
}

 

 

 

Edited by TLHPoE

Kain

Link to comment
Share on other sites

14 minutes ago, diesieben07 said:

You don't need RecipeSorter anymore. If your factory is registered (like it is), you can just create JSON files like for any other recipe using that factory.

So the recipe I'm adding is to craft any amount of potions with my item, and the result is my item with some more NBT data attached to it. What would the JSON file look like? I've tried just adding a generic shapeless recipe with my item as both the ingredient and result:

Spoiler

{
  "type": "minecraft:crafting_shapeless",
  "group": "quickconsume",
  "ingredients": [
    {
      "item": "quickconsume:potion_bag"
    }
  ],
  "result": {
    "item": "quickconsume:potion_bag"
  }
}

 

 

The recipe doesn't load. Is there a specific type I'm missing? I can't seem to find any recipes like this in Minecraft to reference.

Kain

Link to comment
Share on other sites

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

18 minutes ago, Draco18s said:

Yes, I'm aware now. In the other post you referenced RecipeSorter, which I assumed was the main method of registering the recipe. Didn't see the mold_bucket recipe though, so my bad.

Kain

Link to comment
Share on other sites

9 minutes ago, TLHPoE said:

Yes, I'm aware now. In the other post you referenced RecipeSorter, which I assumed was the main method of registering the recipe. Didn't see the mold_bucket recipe though, so my bad.

Not directly. It was in the code I linked to, but my actual post never says anything about RecipeSorter. It might only be there as a holdover from before it was deprecated.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.