Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

Redstone Lamp issues and questions.


Recommended Posts

Just came back after a short break from working on mods and the holidays and not finding much reference material to work with. At this point the game loads, I place the missing texture block and can activate it, however it turns into a redstone lamp. I am not sure if this is a .json issue, or .class at this point, however I'm leaning towards .json.

 

Redstone lamp class:

Spoiler

package com.kaelym.elypsis.blocks;

import com.kaelym.elypsis.ElypsisMod;

import net.minecraft.block.BlockRedstoneLight;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;


public class CustomRedstoneLight extends BlockRedstoneLight
{
    private static boolean isOn;

    public CustomRedstoneLight(boolean isOn)
    {
        super(isOn);
        this.isOn = isOn;

        if (isOn)
        {
            this.setLightLevel(1.0F);
        }
    }

    public CustomRedstoneLight(Material material, String unlocalizedName, String registryName) {
        super(isOn);
        setUnlocalizedName(ElypsisMod.MODID + "." + unlocalizedName);
        setRegistryName(registryName);
        setCreativeTab(ElypsisMod.ElypsisCustom_TAB);
        setSoundType(blockSoundType);
}    
}

ModelRegistryHandler (just the snip of the particular registration for this and RegistryHandler)

Spoiler

  registerModel(Item.getItemFromBlock(CustLight.BLUE_FLOWERLAMP));
       

RegistryHandler:

Spoiler

 new CustomRedstoneLight(Material.REDSTONE_LIGHT, "blue_flowerlamp", "blue_flowerlamp"),
                   

new ItemBlock(CustLight.BLUE_FLOWERLAMP).setRegistryName(CustLight.BLUE_FLOWERLAMP.getRegistryName()),

 

CustLight class:

Spoiler

package com.kaelym.elypsis.init;
import com.kaelym.elypsis.ElypsisMod;

import net.minecraft.block.Block;
import net.minecraftforge.fml.common.registry.GameRegistry.ObjectHolder;

@ObjectHolder(ElypsisMod.MODID)
public class CustLight {

    //G    
    //Glowstone
    public static final Block GLOW_BLUE_BLOCK=null, GLOW_GREEN_BLOCK=null,
            GLOW_PURPLE_BLOCK=null, GLOW_ORANGE_BLOCK=null, GLOW_MAGENTA_BLOCK=null;
    //R
    //Redstone lamps
    public static final Block BLUE_FLOWERLAMP=null;
        
}

CustomRedstoneLight class:

Spoiler

package com.kaelym.elypsis.blocks;

import com.kaelym.elypsis.ElypsisMod;

import net.minecraft.block.BlockRedstoneLight;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;


public class CustomRedstoneLight extends BlockRedstoneLight
{
    private static boolean isOn;

    public CustomRedstoneLight(boolean isOn)
    {
        super(isOn);
        this.isOn = isOn;

        if (isOn)
        {
            this.setLightLevel(1.0F);
        }
    }

 

Jsons:

Spoiler

elypsis:blockstates/blue_flowerlamp

 

{"forge_marker": 1,
"defaults": {
"model": "elypsis:blue_flowerlamp_off"
},
"variants": {
    "powered=false": ("model":"elypsis:blue_flowerlamp_off")
    "powered=true": ("model":"elypsis:blue_flowerlamp_on")
"normal": [{}],
"inventory": [{}]
}
}

 

elypsis/models/block/blue_flowerlamp_off

 

 

{
    "parent": "block/cube_all",
    "textures": {
        "all": "elypsis:blocks/blue_flowerlamp_off"
    }
}

 

 

elypsis/models/block/blue_flowerlamp_on

 

{
    "parent": "block/cube_all",
    "textures": {
        "all": "elypsis:blocks/blue_flowerlamp_on"
    }
}

 

 

elypsis/models/item/blue_flowerlamp

 

 

Crash:

Spoiler

[15:47:42] [Client thread/ERROR] [FML]: Could not load vanilla model parent 'elypsis:blocks/blue_flowerlamp_off' for 'net.minecraft.client.renderer.block.model.ModelBlock@64d11323'
net.minecraftforge.client.model.ModelLoaderRegistry$LoaderException: Exception loading model elypsis:blocks/blue_flowerlamp_off with loader VanillaLoader.INSTANCE, skipping
    at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:161) ~[ModelLoaderRegistry.class:?]
    at net.minecraftforge.client.model.ModelLoaderRegistry.getModelOrLogError(ModelLoaderRegistry.java:211) [ModelLoaderRegistry.class:?]
    at net.minecraftforge.client.model.ModelLoader$VanillaModelWrapper.getTextures(ModelLoader.java:387) [ModelLoader$VanillaModelWrapper.class:?]
    at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:171) [ModelLoaderRegistry.class:?]
    at net.minecraftforge.client.model.ModelLoader.loadItemModels(ModelLoader.java:302) [ModelLoader.class:?]
    at net.minecraft.client.renderer.block.model.ModelBakery.loadVariantItemModels(ModelBakery.java:175) [ModelBakery.class:?]
    at net.minecraftforge.client.model.ModelLoader.setupModelRegistry(ModelLoader.java:151) [ModelLoader.class:?]
    at net.minecraft.client.renderer.block.model.ModelManager.onResourceManagerReload(ModelManager.java:28) [ModelManager.class:?]
    at net.minecraft.client.resources.SimpleReloadableResourceManager.registerReloadListener(SimpleReloadableResourceManager.java:121) [SimpleReloadableResourceManager.class:?]
    at net.minecraft.client.Minecraft.init(Minecraft.java:560) [Minecraft.class:?]
    at net.minecraft.client.Minecraft.run(Minecraft.java:422) [Minecraft.class:?]
    at net.minecraft.client.main.Main.main(Main.java:118) [Main.class:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_191]
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_191]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_191]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_191]
    at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
    at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_191]
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_191]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_191]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_191]
    at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]
    at GradleStart.main(GradleStart.java:25) [start/:?]
Caused by: java.io.FileNotFoundException: elypsis:models/blocks/blue_flowerlamp_off.json
    at net.minecraft.client.resources.FallbackResourceManager.getResource(FallbackResourceManager.java:69) ~[FallbackResourceManager.class:?]
    at net.minecraft.client.resources.SimpleReloadableResourceManager.getResource(SimpleReloadableResourceManager.java:65) ~[SimpleReloadableResourceManager.class:?]
    at net.minecraft.client.renderer.block.model.ModelBakery.loadModel(ModelBakery.java:334) ~[ModelBakery.class:?]
    at net.minecraftforge.client.model.ModelLoader.access$1400(ModelLoader.java:115) ~[ModelLoader.class:?]
    at net.minecraftforge.client.model.ModelLoader$VanillaLoader.loadModel(ModelLoader.java:861) ~[ModelLoader$VanillaLoader.class:?]
    at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:157) ~[ModelLoaderRegistry.class:?]
    ... 23 more
[15:47:44] [Client thread/INFO] [FML]: Max texture size: 16384
[15:47:45] [Client thread/INFO] [minecraft/TextureMap]: Created: 1024x512 textures-atlas
[15:47:46] [Client thread/ERROR] [FML]: Exception loading model for variant elypsis:blue_flowerlamp#normal for blockstate "elypsis:blue_flowerlamp"
net.minecraftforge.client.model.ModelLoaderRegistry$LoaderException: Exception loading model elypsis:blue_flowerlamp#normal with loader VariantLoader.INSTANCE, skipping
    at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:161) ~[ModelLoaderRegistry.class:?]
    at net.minecraftforge.client.model.ModelLoader.registerVariant(ModelLoader.java:235) ~[ModelLoader.class:?]
    at net.minecraft.client.renderer.block.model.ModelBakery.loadBlock(ModelBakery.java:153) ~[ModelBakery.class:?]
    at net.minecraftforge.client.model.ModelLoader.loadBlocks(ModelLoader.java:223) ~[ModelLoader.class:?]
    at net.minecraftforge.client.model.ModelLoader.setupModelRegistry(ModelLoader.java:150) ~[ModelLoader.class:?]
    at net.minecraft.client.renderer.block.model.ModelManager.onResourceManagerReload(ModelManager.java:28) [ModelManager.class:?]
    at net.minecraft.client.resources.SimpleReloadableResourceManager.registerReloadListener(SimpleReloadableResourceManager.java:121) [SimpleReloadableResourceManager.class:?]
    at net.minecraft.client.Minecraft.init(Minecraft.java:560) [Minecraft.class:?]
    at net.minecraft.client.Minecraft.run(Minecraft.java:422) [Minecraft.class:?]
    at net.minecraft.client.main.Main.main(Main.java:118) [Main.class:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_191]
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_191]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_191]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_191]
    at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
    at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_191]
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_191]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_191]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_191]
    at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]
    at GradleStart.main(GradleStart.java:25) [start/:?]
Caused by: net.minecraft.client.renderer.block.model.ModelBlockDefinition$MissingVariantException
    at net.minecraft.client.renderer.block.model.ModelBlockDefinition.getVariant(ModelBlockDefinition.java:83) ~[ModelBlockDefinition.class:?]
    at net.minecraftforge.client.model.ModelLoader$VariantLoader.loadModel(ModelLoader.java:1175) ~[ModelLoader$VariantLoader.class:?]
    at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:157) ~[ModelLoaderRegistry.class:?]
    ... 21 more
[15:47:46] [Client thread/ERROR] [FML]: Exception loading blockstate for the variant elypsis:blue_flowerlamp#normal:
java.lang.Exception: Could not load model definition for variant elypsis:blue_flowerlamp
    at net.minecraftforge.client.model.ModelLoader.getModelBlockDefinition(ModelLoader.java:269) ~[ModelLoader.class:?]
    at net.minecraft.client.renderer.block.model.ModelBakery.loadBlock(ModelBakery.java:121) ~[ModelBakery.class:?]
    at net.minecraftforge.client.model.ModelLoader.loadBlocks(ModelLoader.java:223) ~[ModelLoader.class:?]
    at net.minecraftforge.client.model.ModelLoader.setupModelRegistry(ModelLoader.java:150) ~[ModelLoader.class:?]
    at net.minecraft.client.renderer.block.model.ModelManager.onResourceManagerReload(ModelManager.java:28) [ModelManager.class:?]
    at net.minecraft.client.resources.SimpleReloadableResourceManager.registerReloadListener(SimpleReloadableResourceManager.java:121) [SimpleReloadableResourceManager.class:?]
    at net.minecraft.client.Minecraft.init(Minecraft.java:560) [Minecraft.class:?]
    at net.minecraft.client.Minecraft.run(Minecraft.java:422) [Minecraft.class:?]
    at net.minecraft.client.main.Main.main(Main.java:118) [Main.class:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_191]
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_191]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_191]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_191]
    at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
    at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_191]
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_191]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_191]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_191]
    at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]
    at GradleStart.main(GradleStart.java:25) [start/:?]
Caused by: java.lang.RuntimeException: Encountered an exception when loading model definition of 'elypsis:blue_flowerlamp' from: 'elypsis:blockstates/blue_flowerlamp.json' in resourcepack: 'FMLFileResourcePack:Elypsis Mod'
    at net.minecraft.client.renderer.block.model.ModelBakery.loadModelBlockDefinition(ModelBakery.java:246) ~[ModelBakery.class:?]
    at net.minecraft.client.renderer.block.model.ModelBakery.loadMultipartMBD(ModelBakery.java:223) ~[ModelBakery.class:?]
    at net.minecraft.client.renderer.block.model.ModelBakery.getModelBlockDefinition(ModelBakery.java:208) ~[ModelBakery.class:?]
    at net.minecraftforge.client.model.ModelLoader.getModelBlockDefinition(ModelLoader.java:265) ~[ModelLoader.class:?]
    ... 20 more
Caused by: com.google.gson.JsonSyntaxException: com.google.gson.stream.MalformedJsonException: Unterminated object at line 6 column 28 path $.variants.
    at com.google.gson.Gson.fromJson(Gson.java:902) ~[Gson.class:?]
    at com.google.gson.Gson.fromJson(Gson.java:852) ~[Gson.class:?]
    at com.google.gson.Gson.fromJson(Gson.java:801) ~[Gson.class:?]
    at com.google.gson.Gson.fromJson(Gson.java:773) ~[Gson.class:?]
    at net.minecraftforge.client.model.BlockStateLoader.load(BlockStateLoader.java:80) ~[BlockStateLoader.class:?]
    at net.minecraft.client.renderer.block.model.ModelBlockDefinition.parseFromReader(ModelBlockDefinition.java:42) ~[ModelBlockDefinition.class:?]
    at net.minecraft.client.renderer.block.model.ModelBakery.loadModelBlockDefinition(ModelBakery.java:242) ~[ModelBakery.class:?]
    at net.minecraft.client.renderer.block.model.ModelBakery.loadMultipartMBD(ModelBakery.java:223) ~[ModelBakery.class:?]
    at net.minecraft.client.renderer.block.model.ModelBakery.getModelBlockDefinition(ModelBakery.java:208) ~[ModelBakery.class:?]
    at net.minecraftforge.client.model.ModelLoader.getModelBlockDefinition(ModelLoader.java:265) ~[ModelLoader.class:?]
    ... 20 more
Caused by: com.google.gson.stream.MalformedJsonException: Unterminated object at line 6 column 28 path $.variants.
    at com.google.gson.stream.JsonReader.syntaxError(JsonReader.java:1559) ~[JsonReader.class:?]
    at com.google.gson.stream.JsonReader.doPeek(JsonReader.java:491) ~[JsonReader.class:?]
    at com.google.gson.stream.JsonReader.skipValue(JsonReader.java:1224) ~[JsonReader.class:?]
    at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:218) ~[ReflectiveTypeAdapterFactory$Adapter.class:?]
    at com.google.gson.Gson.fromJson(Gson.java:887) ~[Gson.class:?]
    at com.google.gson.Gson.fromJson(Gson.java:852) ~[Gson.class:?]
    at com.google.gson.Gson.fromJson(Gson.java:801) ~[Gson.class:?]
    at com.google.gson.Gson.fromJson(Gson.java:773) ~[Gson.class:?]
    at net.minecraftforge.client.model.BlockStateLoader.load(BlockStateLoader.java:80) ~[BlockStateLoader.class:?]
    at net.minecraft.client.renderer.block.model.ModelBlockDefinition.parseFromReader(ModelBlockDefinition.java:42) ~[ModelBlockDefinition.class:?]
    at net.minecraft.client.renderer.block.model.ModelBakery.loadModelBlockDefinition(ModelBakery.java:242) ~[ModelBakery.class:?]
    at net.minecraft.client.renderer.block.model.ModelBakery.loadMultipartMBD(ModelBakery.java:223) ~[ModelBakery.class:?]
    at net.minecraft.client.renderer.block.model.ModelBakery.getModelBlockDefinition(ModelBakery.java:208) ~[ModelBakery.class:?]
    at net.minecraftforge.client.model.ModelLoader.getModelBlockDefinition(ModelLoader.java:265) ~[ModelLoader.class:?]
    ... 20 more

 

Edited by Kaelym
grammar problems.
Link to post
Share on other sites

Threw my stuff at a Json validator, it seems the Blockstate is the problem. Does anyone mind explaining how what is did is wrong so I better understand for future jsons, or have a reference towards this particular instance?

 

Link to post
Share on other sites
41 minutes ago, Kaelym said:

{"forge_marker": 1,
"defaults": {
"model": "elypsis:blue_flowerlamp_off"
},
"variants": {
    "powered=false": ("model":"elypsis:blue_flowerlamp_off")
    "powered=true": ("model":"elypsis:blue_flowerlamp_on")
"normal": [{}],
"inventory": [{}]
}
}

This is not how JSON works. (  has no meaning at that position.

  • Thanks 1
Link to post
Share on other sites

thank you, i literally JUST changed that out! the model is still not working though, here is updated json:

 

Spoiler

{
    "forge_marker": 1,
    "defaults": {
        "model": "elypsis:blue_flowerlamp_off"
    },
    "variants": {
        "powered = false": {
            "model": "elypsis:blue_flowerlamp_off"
        },
        "powered = true": {
            "model": "elypsis:blue_flowerlamp_on"
        },
        "normal": [{}],
        "inventory": [{}]
    }
}

 

I'm sure the rest is just a silly mistake.

 

Thank you very much!

 

Link to post
Share on other sites
Spoiler

[16:39:34] [Client thread/ERROR] [FML]: Could not load vanilla model parent 'elypsis:blocks/blue_flowerlamp_off' for 'net.minecraft.client.renderer.block.model.ModelBlock@de58d71'
net.minecraftforge.client.model.ModelLoaderRegistry$LoaderException: Exception loading model elypsis:blocks/blue_flowerlamp_off with loader VanillaLoader.INSTANCE, skipping
    at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:161) ~[ModelLoaderRegistry.class:?]
    at net.minecraftforge.client.model.ModelLoaderRegistry.getModelOrLogError(ModelLoaderRegistry.java:211) [ModelLoaderRegistry.class:?]
    at net.minecraftforge.client.model.ModelLoader$VanillaModelWrapper.getTextures(ModelLoader.java:387) [ModelLoader$VanillaModelWrapper.class:?]
    at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:171) [ModelLoaderRegistry.class:?]
    at net.minecraftforge.client.model.ModelLoader.loadItemModels(ModelLoader.java:302) [ModelLoader.class:?]
    at net.minecraft.client.renderer.block.model.ModelBakery.loadVariantItemModels(ModelBakery.java:175) [ModelBakery.class:?]
    at net.minecraftforge.client.model.ModelLoader.setupModelRegistry(ModelLoader.java:151) [ModelLoader.class:?]
    at net.minecraft.client.renderer.block.model.ModelManager.onResourceManagerReload(ModelManager.java:28) [ModelManager.class:?]
    at net.minecraft.client.resources.SimpleReloadableResourceManager.registerReloadListener(SimpleReloadableResourceManager.java:121) [SimpleReloadableResourceManager.class:?]
    at net.minecraft.client.Minecraft.init(Minecraft.java:560) [Minecraft.class:?]
    at net.minecraft.client.Minecraft.run(Minecraft.java:422) [Minecraft.class:?]
    at net.minecraft.client.main.Main.main(Main.java:118) [Main.class:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_191]
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_191]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_191]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_191]
    at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
    at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_191]
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_191]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_191]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_191]
    at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]
    at GradleStart.main(GradleStart.java:25) [start/:?]
Caused by: java.io.FileNotFoundException: elypsis:models/blocks/blue_flowerlamp_off.json
    at net.minecraft.client.resources.FallbackResourceManager.getResource(FallbackResourceManager.java:69) ~[FallbackResourceManager.class:?]
    at net.minecraft.client.resources.SimpleReloadableResourceManager.getResource(SimpleReloadableResourceManager.java:65) ~[SimpleReloadableResourceManager.class:?]
    at net.minecraft.client.renderer.block.model.ModelBakery.loadModel(ModelBakery.java:334) ~[ModelBakery.class:?]
    at net.minecraftforge.client.model.ModelLoader.access$1400(ModelLoader.java:115) ~[ModelLoader.class:?]
    at net.minecraftforge.client.model.ModelLoader$VanillaLoader.loadModel(ModelLoader.java:861) ~[ModelLoader$VanillaLoader.class:?]
    at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:157) ~[ModelLoaderRegistry.class:?]
    ... 23 more
[16:39:37] [Client thread/INFO] [FML]: Max texture size: 16384
[16:39:37] [Client thread/INFO] [minecraft/TextureMap]: Created: 1024x512 textures-atlas
[16:39:38] [Client thread/ERROR] [FML]: Exception loading model for variant elypsis:blue_flowerlamp#normal for blockstate "elypsis:blue_flowerlamp"
net.minecraftforge.client.model.ModelLoaderRegistry$LoaderException: Exception loading model elypsis:blue_flowerlamp#normal with loader VariantLoader.INSTANCE, skipping
    at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:161) ~[ModelLoaderRegistry.class:?]
    at net.minecraftforge.client.model.ModelLoader.registerVariant(ModelLoader.java:235) ~[ModelLoader.class:?]
    at net.minecraft.client.renderer.block.model.ModelBakery.loadBlock(ModelBakery.java:153) ~[ModelBakery.class:?]
    at net.minecraftforge.client.model.ModelLoader.loadBlocks(ModelLoader.java:223) ~[ModelLoader.class:?]
    at net.minecraftforge.client.model.ModelLoader.setupModelRegistry(ModelLoader.java:150) ~[ModelLoader.class:?]
    at net.minecraft.client.renderer.block.model.ModelManager.onResourceManagerReload(ModelManager.java:28) [ModelManager.class:?]
    at net.minecraft.client.resources.SimpleReloadableResourceManager.registerReloadListener(SimpleReloadableResourceManager.java:121) [SimpleReloadableResourceManager.class:?]
    at net.minecraft.client.Minecraft.init(Minecraft.java:560) [Minecraft.class:?]
    at net.minecraft.client.Minecraft.run(Minecraft.java:422) [Minecraft.class:?]
    at net.minecraft.client.main.Main.main(Main.java:118) [Main.class:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_191]
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_191]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_191]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_191]
    at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
    at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_191]
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_191]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_191]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_191]
    at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]
    at GradleStart.main(GradleStart.java:25) [start/:?]
Caused by: net.minecraftforge.client.model.ModelLoaderRegistry$LoaderException: Exception loading model elypsis:block/blocks/blue_flowerlamp_off with loader VanillaLoader.INSTANCE, skipping
    at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:161) ~[ModelLoaderRegistry.class:?]
    at net.minecraftforge.client.model.ModelLoader$WeightedRandomModel.<init>(ModelLoader.java:658) ~[ModelLoader$WeightedRandomModel.class:?]
    at net.minecraftforge.client.model.ModelLoader$VariantLoader.loadModel(ModelLoader.java:1176) ~[ModelLoader$VariantLoader.class:?]
    at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:157) ~[ModelLoaderRegistry.class:?]
    ... 21 more
Caused by: java.io.FileNotFoundException: elypsis:models/block/blocks/blue_flowerlamp_off.json
    at net.minecraft.client.resources.FallbackResourceManager.getResource(FallbackResourceManager.java:69) ~[FallbackResourceManager.class:?]
    at net.minecraft.client.resources.SimpleReloadableResourceManager.getResource(SimpleReloadableResourceManager.java:65) ~[SimpleReloadableResourceManager.class:?]
    at net.minecraft.client.renderer.block.model.ModelBakery.loadModel(ModelBakery.java:334) ~[ModelBakery.class:?]
    at net.minecraftforge.client.model.ModelLoader.access$1400(ModelLoader.java:115) ~[ModelLoader.class:?]
    at net.minecraftforge.client.model.ModelLoader$VanillaLoader.loadModel(ModelLoader.java:861) ~[ModelLoader$VanillaLoader.class:?]
    at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:157) ~[ModelLoaderRegistry.class:?]
    at net.minecraftforge.client.model.ModelLoader$WeightedRandomModel.<init>(ModelLoader.java:658) ~[ModelLoader$WeightedRandomModel.class:?]
    at net.minecraftforge.client.model.ModelLoader$VariantLoader.loadModel(ModelLoader.java:1176) ~[ModelLoader$VariantLoader.class:?]
    at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:157) ~[ModelLoaderRegistry.class:?]
    ... 21 more

problem seems easy enough :) just finding the json that's causing the problems again lol.

Link to post
Share on other sites

there's a lot of lines of code so I will cut out the bulk of it to save time

 

model registry:

Spoiler

package com.kaelym.elypsis.util;

import com.kaelym.elypsis.init.ModItems;
import com.kaelym.elypsis.init.CustLight;
import com.kaelym.elypsis.init.CustomBlocks;
import com.kaelym.elypsis.init.CustomStairs;
import com.kaelym.elypsis.init.ModBlocks;
import com.kaelym.elypsis.blocks.CustomBaseBlocks;
import com.kaelym.elypsis.blocks.CustomLightBlocks;
import com.kaelym.elypsis.blocks.ElypsisGens;
import com.kaelym.elypsis.init.ElypsisGen;

import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.relauncher.Side;

@EventBusSubscriber(Side.CLIENT)
public class ModelRegistryHandler {
 

    @SubscribeEvent
    public static void registerModels(ModelRegistryEvent event) {
     //Items
        //Gems
        registerModel(ModItems.AMBER);

 

//L  
        //Lamps
        registerModel(Item.getItemFromBlock(CustLight.BLUE_FLOWERLAMP));
        
        
        //Lily Paneling
        registerModel(Item.getItemFromBlock(CustomBlocks.LILYBLUE_BLOCK));
        registerModel(Item.getItemFromBlock(CustomBlocks.LILYPINK_BLOCK));
        registerModel(Item.getItemFromBlock(CustomBlocks.LILYPURPLE_BLOCK));
        registerModel(Item.getItemFromBlock(CustomBlocks.LILYYELLOW_BLOCK))

 

   //W
        //Wool
        registerModel(Item.getItemFromBlock(ModBlocks.NEW_GREEN_WOOL)); };
    
private static void registerModel(Item item) {
        ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(item.getRegistryName(), "inventory"));
    }
 
}

registry handler:

Spoiler

package com.kaelym.elypsis.util;


import com.kaelym.elypsis.ElypsisMod;
import com.kaelym.elypsis.blocks.BlockBasic;
import com.kaelym.elypsis.blocks.CustomRockPillars;
import com.kaelym.elypsis.blocks.CustStairs;
import com.kaelym.elypsis.blocks.CustomBaseBlocks;
import com.kaelym.elypsis.blocks.CustomLightBlocks;
import com.kaelym.elypsis.blocks.CustomRedstoneLight;
//import com.kaelym.elypsis.blocks.CustomRedstoneLight;
import com.kaelym.elypsis.blocks.GlassBlocks;
import com.kaelym.elypsis.blocks.RockPillars;
import com.kaelym.elypsis.item.ItemBasic;
import com.kaelym.elypsis.init.CustLight;
import com.kaelym.elypsis.init.CustomBlocks;
import com.kaelym.elypsis.init.CustomStairs;
import com.kaelym.elypsis.init.ModBlocks;
import com.kaelym.elypsis.init.ElypsisGen;
import com.kaelym.elypsis.blocks.ElypsisGens;

import net.minecraft.block.Block;
import net.minecraft.block.BlockStone;
import net.minecraft.block.material.Material;
import net.minecraft.init.Blocks;
import net.minecraft.item.Item;
import net.minecraft.item.ItemBlock;
import net.minecraftforge.event.RegistryEvent.Register;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

@EventBusSubscriber
public class RegistryHandler {

   @SubscribeEvent
   public static void registerBlocks(Register<Block> event) {
       final Block [] blocks = {
        //Item Blocks
               new CustomBaseBlocks(Material.ROCK, "amber_block", "amber_block"),

      //L
               //Lamps
               new CustomRedstoneLight(Material.REDSTONE_LIGHT, "blue_flowerlamp", "blue_flowerlamp"),
                  

              
        //W      
               //Wool
               new ItemBlock(ModBlocks.NEW_GREEN_WOOL).setRegistryName(ModBlocks.NEW_GREEN_WOOL.getRegistryName()),
              
       };
     event.getRegistry().registerAll(items);
     event.getRegistry().registerAll(itemBlocks);
  }}

 

 

Link to post
Share on other sites
1 minute ago, Kaelym said:

Material material, String unlocalizedName, String registryName

Yes, but that is not the case for CustomRedstoneLight:

1 hour ago, Kaelym said:

public class CustomRedstoneLight extends BlockRedstoneLight
{
    private static boolean isOn;

    public CustomRedstoneLight(boolean isOn)
    {
        super(isOn);
        this.isOn = isOn;

        if (isOn)
        {
            this.setLightLevel(1.0F);
        }
    }

 

  • Thanks 1
Link to post
Share on other sites
1 minute ago, Kaelym said:

ah, I think i see what your saying. Simply because I added the constructor later in the code it doesn't apply to the first bit?

What?

 

You are calling a constructor here:

21 minutes ago, Kaelym said:

new CustomRedstoneLight(Material.REDSTONE_LIGHT, "blue_flowerlamp", "blue_flowerlamp"),

 

This constructor is not present in the code for CustomRedstoneLight that was posted.

I am merely asking you to provide consistent code.

  • Thanks 1
Link to post
Share on other sites

i see, sorry for the miscommunication then. I thought I updated that before my initial post . the full redstone light file is here.

Spoiler

package com.kaelym.elypsis.blocks;

import com.kaelym.elypsis.ElypsisMod;

import net.minecraft.block.BlockRedstoneLight;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;


public class CustomRedstoneLight extends BlockRedstoneLight
{    public CustomRedstoneLight(Material material, String unlocalizedName, String registryName) {
        super(isOn);
        setUnlocalizedName(ElypsisMod.MODID + "." + unlocalizedName);
        setRegistryName(registryName);
        setCreativeTab(ElypsisMod.ElypsisCustom_TAB);
        setSoundType(blockSoundType); }    
    private static boolean isOn;

    public CustomRedstoneLight(boolean isOn)
    {    super(isOn);
        this.isOn = isOn;
        if (isOn)
        { this.setLightLevel(1.0F); }}}
 

after rearranging the way it is coded and putting the boolean line after the constructor it is (mostly) working now. I walked away for coffee and a moment to think about it. thank you for everything you've helped with so far, though.

Link to post
Share on other sites

visual representation of current problem. Capture5.PNG.eceddd7450488ff6d0eb95f64411f357.PNG

 

 

updated code: redstonelight

Spoiler

package com.kaelym.elypsis.blocks;

import com.kaelym.elypsis.ElypsisMod;

import net.minecraft.block.BlockRedstoneLight;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;


public class CustomRedstoneLight extends BlockRedstoneLight
{

    private boolean isOn;

    public CustomRedstoneLight(boolean isOn, Material material, String unlocalizedName, String registryName) {
        super(isOn);
        setUnlocalizedName(ElypsisMod.MODID + "." + unlocalizedName);
        setRegistryName(registryName);
        setCreativeTab(ElypsisMod.ElypsisCustom_TAB);
        setSoundType(blockSoundType);

        this.isOn = isOn;
        if (isOn);
        {this.setLightLevel(1.0F);
    
    }    }
}

 

registry

Spoiler

 //Lamps
               new ItemBlock(CustLight.BLUE_FLOWERLAMP).setRegistryName(CustLight.BLUE_FLOWERLAMP.getRegistryName()),
               
                //Lamps
               new CustomRedstoneLight(false, Material.GLASS, "blue_flowerlamp", "blue_flowerlamp"),
                  

model:

Spoiler

  registerModel(Item.getItemFromBlock(CustLight.BLUE_FLOWERLAMP));

CustLight remained the same,

 

new blockstate file:

Spoiler

{
    "forge_marker": 1,
    "defaults": {
        "textures": {
            "all": "elypsis:blocks/blue_flowerlamp_off"
        },
        "model": "cube_all",
        "uvlock": true
    },
    "variants": {
        "powered = false": {
            "model": "elypsis:blocks/blue_flowerlamp_off"
        },
        "powered = true": {
            "model": "elypsis:blocks/blue_flowerlamp_on"
        },
        "normal": [{}],
        "inventory": [{}]
    }
}

block: (trying several, so these will most likely be wrong upon current post. also used two separate ones so you know which I have tried.)

Spoiler

{
    "parent": "elypsis:blocks/blue_flowerlamp_off",

    "variants": {
        "powered = false": {
            "model": "elypsis:blocks/blue_flowerlamp_off"
        },
    }
}

 

{
    "parent": "block/cube_all",
    "textures": {
        "all": "elypsis:blocks/Blue_flowerlamp_on"
    }
}

 

Also, as a note, there are NO errors in my console, including debug mode.

Edited by Kaelym
missed information.
Link to post
Share on other sites

narrowed down to :

 

 

        "powered = false": {
            "model": "elypsis:blocks/blue_flowerlamp_off"
        },
        "powered = true": {
            "model": "elypsis:blocks/blue_flowerlamp_on"
        },

 

this is not changing the block while powered. Am I using the wrong boolean? or just using the one I have inappropriately?

 

Link to post
Share on other sites

Just a clarification on my error:

the block when pulled out of creative looks fine, the item model is fine, and placement (no power ever) looks fine.

 

My problem: once the block is given power, it turns into a redstone lamp, even if you remove power.

 

Sorry if i seem a bit impatient for answers, I've been trying to get this right for a couple weeks now. (before break included)

 

Also, to make changes easier and less likely to mistype, I edited the block in question from blue_flowerlamp to blue_lamp, I found myself typing florwering after a while. ? any instances of flowerlamp you find, are gone in my base code and if you find one in my github feel free to point it out so i can change it to what it is supposed to be.

Edited by Kaelym
Link to post
Share on other sites

public class CustomRedstoneLight extends BlockRedstoneLight

{

private boolean isOn;

public CustomRedstoneLight(boolean isOn, Material material, String unlocalizedName, String registryName) {

super(isOn);

setUnlocalizedName(ElypsisMod.MODID + "." + unlocalizedName);

setRegistryName(registryName);

setCreativeTab(ElypsisMod.ElypsisCustom_TAB);

setSoundType(blockSoundType);

this.isOn = isOn;

if (isOn);

{this.setLightLevel(1.0F);

} }

}

You're not overriding wherever the redstone lamp sets its block state to "on".

  • Thanks 1

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to post
Share on other sites
Quote

   public void onBlockAdded(World worldIn, BlockPos pos, IBlockState state)
    {
        if (!worldIn.isRemote)
        {
            if (this.isOn && !worldIn.isBlockPowered(pos))
            {
                worldIn.setBlockState(pos, Blocks.REDSTONE_LAMP.getDefaultState(), 2);
            }
            else if (!this.isOn && worldIn.isBlockPowered(pos))
            {
                worldIn.setBlockState(pos, Blocks.LIT_REDSTONE_LAMP.getDefaultState(), 2);
            }
        }
    }

    /**
     * Called when a neighboring block was changed and marks that this state should perform any checks during a neighbor
     * change. Cases may include when redstone power is updated, cactus blocks popping off due to a neighboring solid
     * block, etc.
     */
    public void neighborChanged(IBlockState state, World worldIn, BlockPos pos, Block blockIn, BlockPos fromPos)
    {
        if (!worldIn.isRemote)
        {
            if (this.isOn && !worldIn.isBlockPowered(pos))
            {
                worldIn.scheduleUpdate(pos, this, 4);
            }
            else if (!this.isOn && worldIn.isBlockPowered(pos))
            {
                worldIn.setBlockState(pos, Blocks.LIT_REDSTONE_LAMP.getDefaultState(), 2);
            }
        }
    }

    public void updateTick(World worldIn, BlockPos pos, IBlockState state, Random rand)
    {
        if (!worldIn.isRemote)
        {
            if (this.isOn && !worldIn.isBlockPowered(pos))
            {
                worldIn.setBlockState(pos, Blocks.REDSTONE_LAMP.getDefaultState(), 2);
            }
        }
    }

    /**
     * Get the Item that this Block should drop when harvested.
     */

Am I right in assuming this is what I need to be Overriding, or is there a better reference I can <should> be looking at? I'm getting a lot of errors over void, no imports available for updateTick etc... If this isn't it Ii'll continue my pursuits down the rabbit hole, gotta land eventually!

Edited by Kaelym
Link to post
Share on other sites

Yes, the last post was what I needed. however... New problem! My block is stuck in 'on'. What do I need to turn it off? or at least a reference to what I need to look at, to turn it off.

 

Sorry, i'm a problem child! if there's an error that can be done, I'll find it at least once.  =]

 

 

.Class:

CustomRedstoneLight.Class

CustLight.class

 

Handlers:

ModelRegistryHandler

RegistryHandler

 

Json:

Blockstates

Models

 

I will continue flipping through the reference and see if I have a "Eureka!" moment.

Edited by Kaelym
fixed one of the two problems (lighting)
Link to post
Share on other sites

try stepping through your code with the debugger

  • Thanks 1

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.