Jump to content
  • Home
  • Files
  • Docs
Topics
  • All Content

  • This Topic
  • This Forum

  • Advanced Search
  • Existing user? Sign In  

    Sign In



    • Not recommended on shared computers


    • Forgot your password?

  • Sign Up
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • Help creating a ring of particles.
Currently Supported: 1.16.X (Latest) and 1.15.X (LTS)
Sign in to follow this  
Followers 1
EmeraldJelly

Help creating a ring of particles.

By EmeraldJelly, January 10, 2019 in Modder Support

  • Reply to this topic
  • Start new topic

Recommended Posts

EmeraldJelly    2

EmeraldJelly

EmeraldJelly    2

  • Stone Miner
  • EmeraldJelly
  • Members
  • 2
  • 53 posts
Posted January 10, 2019

Hi! I'm trying to figure out how to make a ring of particles around a specific location. Can someone please help me with that, thanks! <3

 

Here is the code I have so far, math I believe is right but it simply isn't working. 

 

https://hastebin.com/etizajuhoj.cpp

 

The spawnParticleGlow code is as followed.

 

public static void spawnParticleGlow(World world, float x, float y, float z, float vx, float vy, float vz, float r,
			float g, float b, float a, float scale, int lifetime) {
		if (MysticalLib.proxy instanceof ClientProxy) {
			counter += random.nextInt(3);
			if (counter % (Minecraft.getMinecraft().gameSettings.particleSetting == 0 ? 1
					: 2 * Minecraft.getMinecraft().gameSettings.particleSetting) == 0) {
				ClientProxy.particleRenderer.spawnParticle(world, LibRegistry.PARTICLE_GLOW, x, y, z, vx, vy, vz,
						lifetime, r, g, b, a, scale);
			}
		}
	}

 

 

Thanks! :) 

  • Quote

Share this post


Link to post
Share on other sites

Cadiboo    365

Cadiboo

Cadiboo    365

  • Reality Controller
  • Cadiboo
  • Members
  • 365
  • 3624 posts
Posted January 10, 2019
10 hours ago, EmeraldJelly said:

if (MysticalLib.proxy instanceof ClientProxy) {

don't do that, please

Take a look at https://stackoverflow.com/questions/22663479/how-to-make-a-ellipse-from-points

  • Quote

About Me

Spoiler

My Discord - Cadiboo#8887

My Website - Cadiboo.github.io

My Mods - Cadiboo.github.io/projects

My Tutorials - Cadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Share this post


Link to post
Share on other sites

EmeraldJelly    2

EmeraldJelly

EmeraldJelly    2

  • Stone Miner
  • EmeraldJelly
  • Members
  • 2
  • 53 posts
Posted January 10, 2019

I have ellipse math already, check the hastebin link. And that link isn't very helpful to me, sorry. 

  • Quote

Share this post


Link to post
Share on other sites

unassigned    13

unassigned

unassigned    13

  • Creeper Killer
  • unassigned
  • Members
  • 13
  • 103 posts
Posted January 10, 2019
17 hours ago, EmeraldJelly said:

but it simply isn't working

What isn't simply working? Are the particles not spawning?

  • Quote

Currently developing: https://github.com/unassignedxd/Dynamic-Quarries

 

Share this post


Link to post
Share on other sites

EmeraldJelly    2

EmeraldJelly

EmeraldJelly    2

  • Stone Miner
  • EmeraldJelly
  • Members
  • 2
  • 53 posts
Posted January 10, 2019

Yes, the particles are spawning, though they aren't moving in a circle like intended. 

  • Quote

Share this post


Link to post
Share on other sites

EmeraldJelly    2

EmeraldJelly

EmeraldJelly    2

  • Stone Miner
  • EmeraldJelly
  • Members
  • 2
  • 53 posts
Posted January 11, 2019

Bump

 

  • Quote

Share this post


Link to post
Share on other sites

jabelar    593

jabelar

jabelar    593

  • Reality Controller
  • jabelar
  • Members
  • 593
  • 3266 posts
Posted January 11, 2019

I don't think your code will move them in a circle. It might spawn them in a circle, although the code for that looks a little weird for that too.

 

Let's go through you update() method in the hastebin link.

 

The first important thing is -- where is this update code? If you want to move the particles it would need to be in the particle class, but I kind of suspect you have it somewhere else like in an entity. 

 

So your first mistake is that your code isn't moving the particles, it is just spawning them constantly. It might also be possible to used particles in fixed positions and "animate" them by killing and spawning them quickly but I don't think it would work well visually. So I think you need your particle class to remember the center of the circle and the angle, and then in the update method for the particle you would add some angle and adjust the position (not respawn) accordingly.

 

Additionally, I think your math is still suspicious. Your code to use trigonometry to adjust the X and Z positions looks like:
     double angle = Math.toRadians(degrees);
     double vx = (pos.getX() + 0.3) * Math.cos(angle) - pos.getZ() * Math.sin(angle);
     double vz = pos.getX() * Math.sin(angle) + pos.getZ() * Math.cos(angle);

 

I'm pretty sure the math is wrong here. The X and Z positions are the values in the world, so they can be numbers like 600 or 0 or -600. Instead I think you should be multiplying by a radius for the circle as the vx and vz fields presumably indicate the difference in position relative to the center. Also, you're mixing up the two dimensions. Sin and Cos functions already take and angle and separate it into the two dimensional components, so I think it should be something more like:

     double angle = Math.toRadians(degrees);

     double radius = 2.0D;
     double vx = radius * Math.cos(angle);
     double vz = radius * Math.sin(angle);

 

Then instead spawning the particles again, you should just move them. Also, you shouldn't move them based on current position, but recalculate from the center of the circle. So the new positions would be something like (this is pseudo code because you need to put the code into the right place with a field for the center:  

     this.setPos(particleCenterX + vx, this.getPosY(), particleCenterZ + vz);

 

Summary

 

Putting it all together:

  1. The movement code needs to be in the update for the particle class which runs on the client side. You can't just keep spawning particles.
  2. I would have the particle "remember" where the center of the circle should be.
  3. You need to have a sense of "radius" for the circle.
  4. You simply update the particle position with very simple trigonometry such as center + radius * cos(angle) 
  • Thanks 1
  • Quote

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Share this post


Link to post
Share on other sites

EmeraldJelly    2

EmeraldJelly

EmeraldJelly    2

  • Stone Miner
  • EmeraldJelly
  • Members
  • 2
  • 53 posts
Posted January 12, 2019

Wow. You are very helpful! i'll give that a try, thanks for not just posting a link to a stackoverflow;D

  • Quote

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

    • Insert image from URL
×
  • Desktop
  • Tablet
  • Phone
Sign in to follow this  
Followers 1
Go To Topic Listing



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Gubipe
      What is the method to left click?

      By Gubipe · Posted 26 minutes ago

      I am trying to make a custom autoclicker for my client side mod which will be used on my smp server so that when someone presses down the key "v" it will toggle an autoclicker for them. I was wondering if anyone could tell me what the method is to register a left click? I would appreciate it!
    • DaemonUmbra
      tempête de Neige primal winter

      By DaemonUmbra · Posted 59 minutes ago

      Please keep this forum in English. Are you a developer for the mod or are you a player?
    • DaemonUmbra
      3rd party hosted Server wont launch

      By DaemonUmbra · Posted 1 hour ago

      This is coming out of Linux, not Forge. Apparently the system you're using has hit its limit for file watches, and given that the default on my Linux instance is 524288 I'm inclined to believe that your hosting provide has either set a limit that's much lower, or is cramming tons of servers onto one machine. Either way this sounds to me like you need a better hosting provider.
    • iHamster
      Stuck with block movement

      By iHamster · Posted 1 hour ago

      I take it as a type of suggestion one can't decline  
    • Draco18s
      Stuck with block movement

      By Draco18s · Posted 1 hour ago

      Why the fauk does your renderer change what blocks are in the world? That's not the job of a renderer.
  • Topics

    • Gubipe
      0
      What is the method to left click?

      By Gubipe
      Started 27 minutes ago

    • Ronshark
      1
      tempête de Neige primal winter

      By Ronshark
      Started 3 hours ago

    • BoGuBoy
      1
      3rd party hosted Server wont launch

      By BoGuBoy
      Started 4 hours ago

    • iHamster
      12
      Stuck with block movement

      By iHamster
      Started January 6

    • awsfte
      2
      awsfte

      By awsfte
      Started 2 hours ago

  • Who's Online (See full list)

    • Gubipe
    • Danebi
    • BoGuBoy
    • XmasAspire
    • AubriTheHuman
    • ElpisII
    • Choonster
    • The_Raven
    • ozi
    • FloweyTF
    • Woodside
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • Help creating a ring of particles.
  • Theme

Copyright © 2019 ForgeDevelopment LLC · Ads by Longitude Ads LLC Powered by Invision Community