Jump to content
  • Home
  • Files
  • Docs
Topics
  • All Content

  • This Topic
  • This Forum

  • Advanced Search
  • Existing user? Sign In  

    Sign In



    • Not recommended on shared computers


    • Forgot your password?

  • Sign Up
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • Help creating a ring of particles.
Currently Supported: 1.16.X (Latest) and 1.15.X (LTS)
Sign in to follow this  
Followers 1
EmeraldJelly

Help creating a ring of particles.

By EmeraldJelly, January 10, 2019 in Modder Support

  • Reply to this topic
  • Start new topic

Recommended Posts

EmeraldJelly    2

EmeraldJelly

EmeraldJelly    2

  • Stone Miner
  • EmeraldJelly
  • Members
  • 2
  • 53 posts
Posted January 10, 2019

Hi! I'm trying to figure out how to make a ring of particles around a specific location. Can someone please help me with that, thanks! <3

 

Here is the code I have so far, math I believe is right but it simply isn't working. 

 

https://hastebin.com/etizajuhoj.cpp

 

The spawnParticleGlow code is as followed.

 

public static void spawnParticleGlow(World world, float x, float y, float z, float vx, float vy, float vz, float r,
			float g, float b, float a, float scale, int lifetime) {
		if (MysticalLib.proxy instanceof ClientProxy) {
			counter += random.nextInt(3);
			if (counter % (Minecraft.getMinecraft().gameSettings.particleSetting == 0 ? 1
					: 2 * Minecraft.getMinecraft().gameSettings.particleSetting) == 0) {
				ClientProxy.particleRenderer.spawnParticle(world, LibRegistry.PARTICLE_GLOW, x, y, z, vx, vy, vz,
						lifetime, r, g, b, a, scale);
			}
		}
	}

 

 

Thanks! :) 

  • Quote

Share this post


Link to post
Share on other sites

Cadiboo    365

Cadiboo

Cadiboo    365

  • Reality Controller
  • Cadiboo
  • Members
  • 365
  • 3624 posts
Posted January 10, 2019
10 hours ago, EmeraldJelly said:

if (MysticalLib.proxy instanceof ClientProxy) {

don't do that, please

Take a look at https://stackoverflow.com/questions/22663479/how-to-make-a-ellipse-from-points

  • Quote

About Me

Spoiler

My Discord - Cadiboo#8887

My Website - Cadiboo.github.io

My Mods - Cadiboo.github.io/projects

My Tutorials - Cadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Share this post


Link to post
Share on other sites

EmeraldJelly    2

EmeraldJelly

EmeraldJelly    2

  • Stone Miner
  • EmeraldJelly
  • Members
  • 2
  • 53 posts
Posted January 10, 2019

I have ellipse math already, check the hastebin link. And that link isn't very helpful to me, sorry. 

  • Quote

Share this post


Link to post
Share on other sites

unassigned    13

unassigned

unassigned    13

  • Creeper Killer
  • unassigned
  • Members
  • 13
  • 103 posts
Posted January 10, 2019
17 hours ago, EmeraldJelly said:

but it simply isn't working

What isn't simply working? Are the particles not spawning?

  • Quote

Currently developing: https://github.com/unassignedxd/Dynamic-Quarries

 

Share this post


Link to post
Share on other sites

EmeraldJelly    2

EmeraldJelly

EmeraldJelly    2

  • Stone Miner
  • EmeraldJelly
  • Members
  • 2
  • 53 posts
Posted January 10, 2019

Yes, the particles are spawning, though they aren't moving in a circle like intended. 

  • Quote

Share this post


Link to post
Share on other sites

EmeraldJelly    2

EmeraldJelly

EmeraldJelly    2

  • Stone Miner
  • EmeraldJelly
  • Members
  • 2
  • 53 posts
Posted January 11, 2019

Bump

 

  • Quote

Share this post


Link to post
Share on other sites

jabelar    594

jabelar

jabelar    594

  • Reality Controller
  • jabelar
  • Members
  • 594
  • 3266 posts
Posted January 11, 2019

I don't think your code will move them in a circle. It might spawn them in a circle, although the code for that looks a little weird for that too.

 

Let's go through you update() method in the hastebin link.

 

The first important thing is -- where is this update code? If you want to move the particles it would need to be in the particle class, but I kind of suspect you have it somewhere else like in an entity. 

 

So your first mistake is that your code isn't moving the particles, it is just spawning them constantly. It might also be possible to used particles in fixed positions and "animate" them by killing and spawning them quickly but I don't think it would work well visually. So I think you need your particle class to remember the center of the circle and the angle, and then in the update method for the particle you would add some angle and adjust the position (not respawn) accordingly.

 

Additionally, I think your math is still suspicious. Your code to use trigonometry to adjust the X and Z positions looks like:
     double angle = Math.toRadians(degrees);
     double vx = (pos.getX() + 0.3) * Math.cos(angle) - pos.getZ() * Math.sin(angle);
     double vz = pos.getX() * Math.sin(angle) + pos.getZ() * Math.cos(angle);

 

I'm pretty sure the math is wrong here. The X and Z positions are the values in the world, so they can be numbers like 600 or 0 or -600. Instead I think you should be multiplying by a radius for the circle as the vx and vz fields presumably indicate the difference in position relative to the center. Also, you're mixing up the two dimensions. Sin and Cos functions already take and angle and separate it into the two dimensional components, so I think it should be something more like:

     double angle = Math.toRadians(degrees);

     double radius = 2.0D;
     double vx = radius * Math.cos(angle);
     double vz = radius * Math.sin(angle);

 

Then instead spawning the particles again, you should just move them. Also, you shouldn't move them based on current position, but recalculate from the center of the circle. So the new positions would be something like (this is pseudo code because you need to put the code into the right place with a field for the center:  

     this.setPos(particleCenterX + vx, this.getPosY(), particleCenterZ + vz);

 

Summary

 

Putting it all together:

  1. The movement code needs to be in the update for the particle class which runs on the client side. You can't just keep spawning particles.
  2. I would have the particle "remember" where the center of the circle should be.
  3. You need to have a sense of "radius" for the circle.
  4. You simply update the particle position with very simple trigonometry such as center + radius * cos(angle) 
  • Thanks 1
  • Quote

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Share this post


Link to post
Share on other sites

EmeraldJelly    2

EmeraldJelly

EmeraldJelly    2

  • Stone Miner
  • EmeraldJelly
  • Members
  • 2
  • 53 posts
Posted January 12, 2019

Wow. You are very helpful! i'll give that a try, thanks for not just posting a link to a stackoverflow;D

  • Quote

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

    • Insert image from URL
×
  • Desktop
  • Tablet
  • Phone
Sign in to follow this  
Followers 1
Go To Topic Listing



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • JayNeedsHelp
      How can I fix this encoding issue?

      By JayNeedsHelp · Posted 1 hour ago

      Hey so I'm creating a forge mod and I'm trying to use the "§" character but I'm getting an illegal character error in the compiler. I've tried using the -encoding option in the compiler, I've also tried converting the file to UTF-8 without BOM, but it wasn't UTF-8 BOM in the first place. I was making a jar mod with mcp in eclipse and everything was working just fine with these characters, which I'm now moving to a forge mod. I'm using IntelliJ Community IDEA currently.   Here's a link to part of the error list: https://jay-hosts-a.dark-web.store/6AXsbJqG. Obviously the other errors were due to the illegal character error but I thought I might as well show it. I'm making a forge mod for 1.12.2, forgegradle is version 2.3-SNAPSHOT and I'm using mixingradle-0.6-SNAPSHOT.   I'm not sure how to fix this and any help would be greatly appreciated.
    • mchase
      Forge crashing

      By mchase · Posted 1 hour ago

      I downloaded and installed forge for 1.16.4 and it shows up in my installations and will start to open but then crashes and gives me "exit code 255". I am on MacOS if that makes a difference. it says The game crashed whilst initializing game Error: java.lang.IllegalStateException: GLFW error before init: [0x10008]Cocoa: Failed to find service port for display Exit Code: 255 does forge just not work on Mac? am I missing something? please help
    • MiToKonndria
      cant download pixelmon

      By MiToKonndria · Posted 2 hours ago

      when i click install on the Pixelmon modpack it gets to 42% and mod 3 out of 7 and then gives me the error message: Timeout attempting to download: "https://edge.forgecdn.net/files/3072/298/pixelmon-1.12.2-8.1.2-universal.jar"
    • lupicus
      can someone help with server crashing

      By lupicus · Posted 2 hours ago

      Looks like Wonderful Enchantments has problems, try and remove it.
    • Draco18s
      can someone help with server crashing

      By Draco18s · Posted 2 hours ago

      Surprise, accessing the client thread from the server thread isn't possible. Bitch at the author of wonderfulenchantments.
  • Topics

    • JayNeedsHelp
      0
      How can I fix this encoding issue?

      By JayNeedsHelp
      Started 1 hour ago

    • mchase
      0
      Forge crashing

      By mchase
      Started 1 hour ago

    • MiToKonndria
      0
      cant download pixelmon

      By MiToKonndria
      Started 2 hours ago

    • IRONDALEK
      3
      can someone help with server crashing

      By IRONDALEK
      Started 7 hours ago

    • Twu
      0
      Need help with Potion Brewing recipes

      By Twu
      Started 2 hours ago

  • Who's Online (See full list)

    • Zeher_Monkey
    • ChubzRequiem
    • xXCrazy_CactusXx
    • mcnuggies
    • LK1905
    • Choonster
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • Help creating a ring of particles.
  • Theme

Copyright © 2019 ForgeDevelopment LLC · Ads by Longitude Ads LLC Powered by Invision Community