Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.12.2] Add delay to Custom TNT explode


funsize888
 Share

Recommended Posts

Hello, I have made a custom TNT with a custom explosion, but I wanted the explosion to be huge, like 1,000,000+ blocks. It works fine but obviously there is a huge lag when detonating, I was wondering how I could add a very slight delay between each time a block is removed. Here is my code: 

static int tick = 0;
    @SubscribeEvent
	public static void onClientTick(TickEvent.ClientTickEvent event) {
    	
	if(tick == 80) {
	
		
	System.out.print("DELAY");
	tick = 0;
	
    }
	 tick++;
    }
    	

    /**
     * Does the first part of the explosion (destroy blocks)
     */
    @Override
    public void doExplosionA()
    {
    	
        Set<BlockPos> set = Sets.<BlockPos>newHashSet();
       
       long time = world.getWorldTime();
       int blocksDestroyed = 0; 
       int radius = this.size;
       int center = radius / 2;
       
       
    	   for (int j = center - radius; j < center + radius; j++)
        {
            for (int k = center - radius; k < center + radius; k++)
            {
                for (int l = center - radius; l < center + radius; l++)
                {
                	
                	double distSq = (j-center) * (j-center) + (k-center) * (k-center) + (l-center) * (l-center);
                	
                	
                	if(distSq <= (radius) * (radius)) {
                		
                		BlockPos pos = new BlockPos(x + j - center, y + k - center, z + l - center);
                		if(world.getBlockState (pos) != Blocks.BEDROCK.getDefaultState()){
                			
                			
                			world.setBlockState(pos, Blocks.AIR.getDefaultState());
                			
                			

I added the ClientTickEvent, because I thought it would be the way to go, but cant figure out how to add the delay after each block gets removed. Any help is appreciated, thanks.

Link to comment
Share on other sites

3 hours ago, funsize888 said:

1,000,000+ blocks

This isn’t viable. I would say 1024 blocks (16 chunks) is the absolute max, and I would reccomend something like 64-128.

You need to subscribe to the server tick event. I would do this by keeping track of what position I was at, and effectively distributing the nested for loop over multiple ticks. Remember to keep track of which explosion you’re doing

Edited by Cadiboo

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

1 hour ago, Cadiboo said:

This isn’t viable. I would say 1024 blocks (16 chunks) is the absolute max, and I would reccomend something like 64-128.

You need to subscribe to the server tick event. I would do this by keeping track of what position I was at, and effectively distributing the nested for loop over multiple ticks. Remember to keep track of which explosion you’re doing

What do you mean by keep track of the position im at? or which explosion, its only one explosion.

Link to comment
Share on other sites

1 hour ago, funsize888 said:

What do you mean by keep track of the position im at?

I would turn the for loop into something that executes every tick.

 

1 hour ago, funsize888 said:

which explosion, its only one explosion.

What if another explosion happens while the first is still happening? Because you aren’t doing everything all at once, other stuff can happen in the meantime

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

21 hours ago, Cadiboo said:

I would turn the for loop into something that executes every tick.

 

What if another explosion happens while the first is still happening? Because you aren’t doing everything all at once, other stuff can happen in the meantime

ok so now I have this: 

 static int tick = 0;
    static int timer = 0;
    @SubscribeEvent
	public static void onServerTick(TickEvent.ServerTickEvent event) {
    	
    	if(tick == 40) {
    		
    		
    		
    		tick = 0;
    		timer++;
    		System.out.print(timer);
    		if(timer >= 20) {
    			timer = 0;
    		}
    	}tick++;
    }
    
    		
    		

    
    	

    /**
     * Does the first part of the explosion (destroy blocks)
     */
    @Override
    public void doExplosionA()
    {
    	
        Set<BlockPos> set = Sets.<BlockPos>newHashSet();
        Set<IBlockState> states = Sets.<IBlockState>newHashSet();
       
       long time = world.getWorldTime();
       int blocksDestroyed = 0; 
       int radius = this.size;
       int center = radius / 2;
       
       if(timer == 20) {
    	   for (int j = center - radius; j < center + radius; j++)
        {
            for (int k = center - radius; k < center + radius; k++)
            {
                for (int l = center - radius; l < center + radius; l++)
                {
                	
                	double distSq = (j-center) * (j-center) + (k-center) * (k-center) + (l-center) * (l-center);
                	
                	
                	if(distSq <= (radius) * (radius)) {
                		
                		BlockPos pos = new BlockPos(x + j - center, y + k - center, z + l - center);
                		if(world.getBlockState (pos) != Blocks.BEDROCK.getDefaultState()){
                			
                			
                			
                			
                			world.setBlockToAir(pos);
                			timer = 0;
                			
                				
                				blocksDestroyed++;
                				System.out.println(timer);
                				
               			
                		}
                	}
                }
                	
            }
            
        }
            
        }

but obviously the if statement will only run if the timer = 20. So the code isnt run at all. how do I wait for the timer to = 20?

Link to comment
Share on other sites

What is that code meant to do? It’s not valid java

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

15 hours ago, Cadiboo said:

What is that code meant to do? It’s not valid java

That’s the part  struggling with, I’m not sure how I would delay the for loop for a certain amount of ticks. 

 

Maybe I could save all the blocks from the loop and place them one by one with a delay?

Edited by funsize888
Link to comment
Share on other sites

You need to find a way to distribute your logic over multiple ticks. Pre-generating a list of coordinates would work, but would use up massive amounts of memory. I would distribute my loop over multiple ticks

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.