Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

Inconsistency in styling


DutchM
 Share

Recommended Posts

More of a ... idk what to call it not really bug but weirdness in the code... report than a suggestion, but I don't know where else to put it. I don't quite get why EntityPlayer#openGui deviates from Java styleguides, even though the rest of the code seems to follow them neatly. To clarify: GUI is an acronym and thus should be spelled in all caps like this: EntityPlayer#openGUI, not EntityPlayer#openGui. I don't understand why this method specifically deviates from this, especially since other abbreviations I have encountered in the code are fully capitalized.

Link to comment
Share on other sites

3 hours ago, DutchM said:

More of a ... idk what to call it not really bug but weirdness in the code... report than a suggestion, but I don't know where else to put it. I don't quite get why EntityPlayer#openGui deviates from Java styleguides, even though the rest of the code seems to follow them neatly. To clarify: GUI is an acronym and thus should be spelled in all caps like this: EntityPlayer#openGUI, not EntityPlayer#openGui. I don't understand why this method specifically deviates from this, especially since other abbreviations I have encountered in the code are fully capitalized.

Mojang obfuscates the vanilla source code. Forge uses a tool called MCP which supplies names for each variable/method/parameter. However, those names are supplied by the community, which is why there are consistency issues throughout the code.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

5 minutes ago, larsgerrits said:

Mojang obfuscates the vanilla source code. Forge uses a tool called MCP which supplies names for each variable/method/parameter. However, those names are supplied by the community, which is why there are consistency issues throughout the code.

EntityPlayer#openGui is a Forge method.

Link to comment
Share on other sites

29 minutes ago, diesieben07 said:

EntityPlayer#openGui is a Forge method.

I thought it was a vanilla method patched by Forge... My mistake!

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

Wed on't strictly follow the Java guidelines. Yes GUI is a acronym, but in the programming world, it is a word of it's own. So it can go either way.

This is a non-issue.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Patreon: http://www.patreon.com/lexmanos
Paypal: http://paypal.me/LexManos

BitCoin: 1Q8rWvUNMM2T1ZfDaFeeYQyVXtYoeT6tTn

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Tried, still crashes with mods and no resourcepacks  
    • Ah, I'm dumb. Made a topic when explicitly told not to on the banner above. My bad.
    • 2021-10-28 15:22:50,623 WARN Unable to instantiate org.fusesource.jansi.WindowsAnsiOutputStream 2021-10-28 15:22:50,624 WARN Unable to instantiate org.fusesource.jansi.WindowsAnsiOutputStream [15:22:50] [main/INFO] [LaunchWrapper]: Loading tweak class name net.minecraftforge.fml.common.launcher.FMLTweaker [15:22:50] [main/INFO] [LaunchWrapper]: Using primary tweak class name net.minecraftforge.fml.common.launcher.FMLTweaker [15:22:50] [main/INFO] [LaunchWrapper]: Calling tweak class net.minecraftforge.fml.common.launcher.FMLTweaker [15:22:50] [main/INFO] [FML]: Forge Mod Loader version 11.15.1.2318 for Minecraft 1.8.9 loading [15:22:50] [main/INFO] [FML]: Java is Java HotSpot(TM) 64-Bit Server VM, version 1.8.0_51, running on Windows 10:amd64:10.0, installed at C:\Users\silic\AppData\Roaming\.tlauncher\mojang_jre\jre-legacy\windows-x64\jre-legacy [15:22:50] [main/FATAL] [FML]: There appear to be jars extracted into the mods directory. This is VERY BAD and will almost NEVER WORK WELL [15:22:50] [main/FATAL] [FML]: You should place original jars only in the mods directory. NEVER extract them to the mods directory. [15:22:50] [main/FATAL] [FML]: The directories below appear to be extracted jar files. Fix this before you continue. [15:22:50] [main/FATAL] [FML]: Directory 1.17 contains [MANIFEST.MF] 2021-10-28 15:22:50,748 WARN Unable to instantiate org.fusesource.jansi.WindowsAnsiOutputStream 2021-10-28 15:22:50,759 WARN Unable to instantiate org.fusesource.jansi.WindowsAnsiOutputStream 2021-10-28 15:22:50,759 WARN Unable to instantiate org.fusesource.jansi.WindowsAnsiOutputStream [15:22:50] [main/ERROR] : Could not save crash report to C:\Users\silic\AppData\Roaming\.minecraft\crash-reports\fml-crash-2021-10-28_15:22:50.txt java.io.FileNotFoundException: C:\Users\silic\AppData\Roaming\.minecraft\crash-reports\fml-crash-2021-10-28_15:22:50.txt (The filename, directory name, or volume label syntax is incorrect)     at java.io.FileOutputStream.open0(Native Method) ~[?:1.8.0_51]     at java.io.FileOutputStream.open(FileOutputStream.java:270) ~[?:1.8.0_51]     at java.io.FileOutputStream.<init>(FileOutputStream.java:213) ~[?:1.8.0_51]     at java.io.FileOutputStream.<init>(FileOutputStream.java:162) ~[?:1.8.0_51]     at java.io.FileWriter.<init>(FileWriter.java:90) ~[?:1.8.0_51]     at b.a(SourceFile:227) [b.class:?]     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_51]     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_51]     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_51]     at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_51]     at net.minecraftforge.fml.relauncher.CoreModManager.discoverCoreMods(CoreModManager.java:305) [forge-1.8.9-11.15.1.2318-1.8.9.jar:?]     at net.minecraftforge.fml.relauncher.CoreModManager.handleLaunch(CoreModManager.java:246) [forge-1.8.9-11.15.1.2318-1.8.9.jar:?]     at net.minecraftforge.fml.relauncher.FMLLaunchHandler.setupHome(FMLLaunchHandler.java:95) [forge-1.8.9-11.15.1.2318-1.8.9.jar:?]     at net.minecraftforge.fml.relauncher.FMLLaunchHandler.setupClient(FMLLaunchHandler.java:72) [forge-1.8.9-11.15.1.2318-1.8.9.jar:?]     at net.minecraftforge.fml.relauncher.FMLLaunchHandler.configureForClientLaunch(FMLLaunchHandler.java:34) [forge-1.8.9-11.15.1.2318-1.8.9.jar:?]     at net.minecraftforge.fml.common.launcher.FMLTweaker.injectIntoClassLoader(FMLTweaker.java:119) [forge-1.8.9-11.15.1.2318-1.8.9.jar:?]     at net.minecraft.launchwrapper.Launch.launch(Launch.java:115) [launchwrapper-1.12.jar:?]     at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?] [15:22:50] [main/INFO] [STDOUT]: [net.minecraftforge.fml.relauncher.CoreModManager:discoverCoreMods:306]: #@!@# FML has crashed the game deliberately. Crash report saved to: #@!@# C:\Users\silic\AppData\Roaming\.minecraft\crash-reports\fml-crash-2021-10-28_15:22:50.txt [15:22:50] [main/INFO] [STDERR]: [net.minecraftforge.fml.relauncher.FMLLaunchHandler:setupHome:99]: java.lang.RuntimeException: Extracted mod jars found, loading will NOT continue [15:22:50] [main/INFO] [STDERR]: [net.minecraftforge.fml.relauncher.FMLLaunchHandler:setupHome:99]:     at net.minecraftforge.fml.relauncher.CoreModManager.discoverCoreMods(CoreModManager.java:298) [15:22:50] [main/INFO] [STDERR]: [net.minecraftforge.fml.relauncher.FMLLaunchHandler:setupHome:99]:     at net.minecraftforge.fml.relauncher.CoreModManager.handleLaunch(CoreModManager.java:246) [15:22:50] [main/INFO] [STDERR]: [net.minecraftforge.fml.relauncher.FMLLaunchHandler:setupHome:99]:     at net.minecraftforge.fml.relauncher.FMLLaunchHandler.setupHome(FMLLaunchHandler.java:95) [15:22:50] [main/INFO] [STDERR]: [net.minecraftforge.fml.relauncher.FMLLaunchHandler:setupHome:99]:     at net.minecraftforge.fml.relauncher.FMLLaunchHandler.setupClient(FMLLaunchHandler.java:72) [15:22:50] [main/INFO] [STDERR]: [net.minecraftforge.fml.relauncher.FMLLaunchHandler:setupHome:99]:     at net.minecraftforge.fml.relauncher.FMLLaunchHandler.configureForClientLaunch(FMLLaunchHandler.java:34) [15:22:50] [main/INFO] [STDERR]: [net.minecraftforge.fml.relauncher.FMLLaunchHandler:setupHome:99]:     at net.minecraftforge.fml.common.launcher.FMLTweaker.injectIntoClassLoader(FMLTweaker.java:119) [15:22:50] [main/INFO] [STDERR]: [net.minecraftforge.fml.relauncher.FMLLaunchHandler:setupHome:99]:     at net.minecraft.launchwrapper.Launch.launch(Launch.java:115) [15:22:50] [main/INFO] [STDERR]: [net.minecraftforge.fml.relauncher.FMLLaunchHandler:setupHome:99]:     at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [15:22:50] [main/ERROR] [FML]: An error occurred trying to configure the minecraft home at C:\Users\silic\AppData\Roaming\.minecraft for Forge Mod Loader java.lang.RuntimeException: Extracted mod jars found, loading will NOT continue     at net.minecraftforge.fml.relauncher.CoreModManager.discoverCoreMods(CoreModManager.java:298) ~[forge-1.8.9-11.15.1.2318-1.8.9.jar:?]     at net.minecraftforge.fml.relauncher.CoreModManager.handleLaunch(CoreModManager.java:246) ~[forge-1.8.9-11.15.1.2318-1.8.9.jar:?]     at net.minecraftforge.fml.relauncher.FMLLaunchHandler.setupHome(FMLLaunchHandler.java:95) [forge-1.8.9-11.15.1.2318-1.8.9.jar:?]     at net.minecraftforge.fml.relauncher.FMLLaunchHandler.setupClient(FMLLaunchHandler.java:72) [forge-1.8.9-11.15.1.2318-1.8.9.jar:?]     at net.minecraftforge.fml.relauncher.FMLLaunchHandler.configureForClientLaunch(FMLLaunchHandler.java:34) [forge-1.8.9-11.15.1.2318-1.8.9.jar:?]     at net.minecraftforge.fml.common.launcher.FMLTweaker.injectIntoClassLoader(FMLTweaker.java:119) [forge-1.8.9-11.15.1.2318-1.8.9.jar:?]     at net.minecraft.launchwrapper.Launch.launch(Launch.java:115) [launchwrapper-1.12.jar:?]     at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?] [15:22:50] [main/ERROR] [LaunchWrapper]: Unable to launch java.lang.RuntimeException: Extracted mod jars found, loading will NOT continue     at net.minecraftforge.fml.relauncher.CoreModManager.discoverCoreMods(CoreModManager.java:298) ~[forge-1.8.9-11.15.1.2318-1.8.9.jar:?]     at net.minecraftforge.fml.relauncher.CoreModManager.handleLaunch(CoreModManager.java:246) ~[forge-1.8.9-11.15.1.2318-1.8.9.jar:?]     at net.minecraftforge.fml.relauncher.FMLLaunchHandler.setupHome(FMLLaunchHandler.java:95) ~[forge-1.8.9-11.15.1.2318-1.8.9.jar:?]     at net.minecraftforge.fml.relauncher.FMLLaunchHandler.setupClient(FMLLaunchHandler.java:72) ~[forge-1.8.9-11.15.1.2318-1.8.9.jar:?]     at net.minecraftforge.fml.relauncher.FMLLaunchHandler.configureForClientLaunch(FMLLaunchHandler.java:34) ~[forge-1.8.9-11.15.1.2318-1.8.9.jar:?]     at net.minecraftforge.fml.common.launcher.FMLTweaker.injectIntoClassLoader(FMLTweaker.java:119) ~[forge-1.8.9-11.15.1.2318-1.8.9.jar:?]     at net.minecraft.launchwrapper.Launch.launch(Launch.java:115) [launchwrapper-1.12.jar:?]     at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?] Exception in thread "main" [15:22:50] [main/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:1052]: net.minecraftforge.fml.relauncher.FMLSecurityManager$ExitTrappedException [15:22:50] [main/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:1052]:     at net.minecraftforge.fml.relauncher.FMLSecurityManager.checkPermission(FMLSecurityManager.java:30) [15:22:50] [main/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:1052]:     at java.lang.SecurityManager.checkExit(SecurityManager.java:761) [15:22:50] [main/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:1052]:     at java.lang.Runtime.exit(Runtime.java:107) [15:22:50] [main/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:1052]:     at java.lang.System.exit(System.java:971) [15:22:50] [main/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:1052]:     at net.minecraft.launchwrapper.Launch.launch(Launch.java:138) [15:22:50] [main/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:1052]:     at net.minecraft.launchwrapper.Launch.main(Launch.java:28)  
    • fdjshfmiysdfhpuiosd
    • These libraries failed to download. try again.   commons-io:commons-io:2.4  
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.