Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

Armor damage with random


Cris16228
 Share

Recommended Posts

Hello guys,

I was trying to create a "Revival" status effect with a debuff on it, basically, if you wear the armor it set your health to 0.5 (Half hearth), it adds a regen effect and it damages the armor

this is my revival class:

Spoiler

@EventBusSubscriber
public class EventHandler {

	private static Random random = new Random();

	@SubscribeEvent
	public static void onDeath(LivingDeathEvent event) {
		if (event.getEntityLiving() instanceof EntityPlayer) {
			EntityPlayer player = (EntityPlayer) event.getEntityLiving();
			boolean isActive = false;
			boolean damageArmor = false;
			int min = Config.revivaldamagemin;
			int max = Config.revivaldamagemax;
			int randomDamage = random.nextInt(max - min + 1) + min;
			if (player.isPotionActive(InitPotions.REVIVAL_EFFECT))
				isActive = true;
			if (Config.revivaldamagearmor == true)
				damageArmor = true;

			if (isActive) {
				event.setCanceled(true);
				player.setHealth(0.5F);
				player.addPotionEffect(new PotionEffect(Potion.getPotionById(10),
						10 * 20, 3));

				if (damageArmor) {
					if (player.inventory.armorItemInSlot(0) != null && player.inventory.armorItemInSlot(1) != null
							&& player.inventory.armorItemInSlot(2) != null
							&& player.inventory.armorItemInSlot(3) != null) {
						player.inventory.damageArmor(randomDamage);
						player.sendMessage(new TextComponentString("Danno: " + String.valueOf(randomDamage)));
					}
				}
			}
		}
	}
}

 

 

I tried to debug it with a send message with the random number (Sorry for the String "Danno:  " but I'm Italian) and in chat it gives me random damage from 5 (min in config) to 13 (max in config) but the armor takes only a bit of damage and not full.

Does

player.inventory.damageArmor(randomDamage);

make an addition of the random and does it as damage to armor pieces?

Do I have to use something else? I want to damage all the armor with the random int given by the random and if I can ask how can I kill ( /kill {player} ) someone if he has the revival effect?

2019-02-17_14.19.52.png

2019-02-17_14.20.21.png

Link to comment
Share on other sites

1. 

47 minutes ago, Cris16228 said:

if (player.inventory.armorItemInSlot(0) != null && player.inventory.armorItemInSlot(1) != null && player.inventory.armorItemInSlot(2) != null && player.inventory.armorItemInSlot(3) != null)

ItemStack does not support null. Use ItemStack#isEmpty instead.

 

2. You are not doing anything to make the armor take randomized damage, so of course it will only take one damage at a time.

 

3. 

47 minutes ago, Cris16228 said:

Does


player.inventory.damageArmor(randomDamage);

make an addition of the random and does it as damage to armor pieces?

No (and I don't see why it should). You have to implement the randomized damage part yourself.

Edited by DavidM

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

2 hours ago, DavidM said:

1. 

ItemStack does not support null. Use ItemStack#isEmpty instead.

That's why if I wear an armor with a custom effect Minecraft crashes saying that the error is in the check line?????

(No, keep crash)

 

Thanks, I fixed it

Edited by Cris16228
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • @RideableEntitiesModElements.ModElement.Tag public class BabytigerEntity extends RideableEntitiesModElements.ModElement { public static EntityType entity = (EntityType.Builder.<CustomEntity>create(CustomEntity::new, EntityClassification.MONSTER) .setShouldReceiveVelocityUpdates(true).setTrackingRange(64).setUpdateInterval(3).setCustomClientFactory(CustomEntity::new) .size(0.6f, 1.8f)).build("babytiger").setRegistryName("babytiger"); public BabytigerEntity(RideableEntitiesModElements instance) { super(instance, 4); FMLJavaModLoadingContext.get().getModEventBus().register(new BabytigerRenderer.ModelRegisterHandler()); FMLJavaModLoadingContext.get().getModEventBus().register(new EntityAttributesRegisterHandler()); MinecraftForge.EVENT_BUS.register(this); } @Override public void initElements() { elements.entities.add(() -> entity); elements.items .add(() -> new SpawnEggItem(entity, -1, -1, new Item.Properties().group(ItemGroup.MISC)).setRegistryName("babytiger_spawn_egg")); } @SubscribeEvent public void addFeatureToBiomes(BiomeLoadingEvent event) { event.getSpawns().getSpawner(EntityClassification.MONSTER).add(new MobSpawnInfo.Spawners(entity, 20, 4, 4)); } @Override public void init(FMLCommonSetupEvent event) { EntitySpawnPlacementRegistry.register(entity, EntitySpawnPlacementRegistry.PlacementType.ON_GROUND, Heightmap.Type.MOTION_BLOCKING_NO_LEAVES, MonsterEntity::canMonsterSpawn); } private static class EntityAttributesRegisterHandler { @SubscribeEvent public void onEntityAttributeCreation(EntityAttributeCreationEvent event) { AttributeModifierMap.MutableAttribute ammma = MobEntity.func_233666_p_(); ammma = ammma.createMutableAttribute(Attributes.MOVEMENT_SPEED, 0.8); ammma = ammma.createMutableAttribute(Attributes.MAX_HEALTH, 10); ammma = ammma.createMutableAttribute(Attributes.ARMOR, 0); ammma = ammma.createMutableAttribute(Attributes.ATTACK_DAMAGE, 3); event.put(entity, ammma.create()); } } public static class CustomEntity extends CreatureEntity { public CustomEntity(FMLPlayMessages.SpawnEntity packet, World world) { this(entity, world); } public CustomEntity(EntityType<CustomEntity> type, World world) { super(type, world); experienceValue = 0; setNoAI(false); } @Override public IPacket<?> createSpawnPacket() { return NetworkHooks.getEntitySpawningPacket(this); } @Override protected void registerGoals() { super.registerGoals(); this.goalSelector.addGoal(1, new MeleeAttackGoal(this, 1.2, false)); this.goalSelector.addGoal(2, new RandomWalkingGoal(this, 1)); this.targetSelector.addGoal(3, new HurtByTargetGoal(this)); this.goalSelector.addGoal(4, new LookRandomlyGoal(this)); this.goalSelector.addGoal(5, new SwimGoal(this)); } @Override public CreatureAttribute getCreatureAttribute() { return CreatureAttribute.UNDEFINED; } @Override public net.minecraft.util.SoundEvent getHurtSound(DamageSource ds) { return (net.minecraft.util.SoundEvent) ForgeRegistries.SOUND_EVENTS.getValue(new ResourceLocation("entity.generic.hurt")); } @Override public net.minecraft.util.SoundEvent getDeathSound() { return (net.minecraft.util.SoundEvent) ForgeRegistries.SOUND_EVENTS.getValue(new ResourceLocation("entity.generic.death")); } @Override public ActionResultType func_230254_b_(PlayerEntity sourceentity, Hand hand) { ItemStack itemstack = sourceentity.getHeldItem(hand); ActionResultType retval = ActionResultType.func_233537_a_(this.world.isRemote()); super.func_230254_b_(sourceentity, hand); sourceentity.startRiding(this); return retval; } @Override public void travel(Vector3d dir) { Entity entity = this.getPassengers().isEmpty() ? null : (Entity) this.getPassengers().get(0); if (this.isBeingRidden()) { this.rotationYaw = entity.rotationYaw; this.prevRotationYaw = this.rotationYaw; this.rotationPitch = entity.rotationPitch * 0.5F; this.setRotation(this.rotationYaw, this.rotationPitch); this.jumpMovementFactor = this.getAIMoveSpeed() * 0.15F; this.renderYawOffset = entity.rotationYaw; this.rotationYawHead = entity.rotationYaw; this.stepHeight = 1.0F; if (entity instanceof LivingEntity) { this.setAIMoveSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED)); float forward = ((LivingEntity) entity).moveForward; float strafe = ((LivingEntity) entity).moveStrafing; super.travel(new Vector3d(strafe, 0, forward)); } this.prevLimbSwingAmount = this.limbSwingAmount; double d1 = this.getPosX() - this.prevPosX; double d0 = this.getPosZ() - this.prevPosZ; float f1 = MathHelper.sqrt(d1 * d1 + d0 * d0) * 4.0F; if (f1 > 1.0F) f1 = 1.0F; this.limbSwingAmount += (f1 - this.limbSwingAmount) * 0.4F; this.limbSwing += this.limbSwingAmount; return; } this.stepHeight = 0.5F; this.jumpMovementFactor = 0.02F; super.travel(dir); } } } ok thanks and for the people that want to copy paste here is the code
    • I did download the latest forge-1.18-38.0.6-installer and installed it correctly into the right place. Also downloaded  38.0.5 to test (didn't work) and downloaded 38.0.0 None of those worked.
    • Unknown module securejarhandler implies that some libraries were missed during the installation. I suggest you redownload the latest installer and run it again.
    • Forge Version: 38.0.6 Minecraft Version: 1.18 Downloads: Changelog: (Direct) Installer: (AdFocus) (Direct) MDK: (AdFocus) (Direct) However, as this is the start of a new version, it is recommended that you check the Downloads Page and use the latest version to receive any bug fixes. Intro: 1.17 was a stepping stone, and 1.18 is the real target. The culmination of the Caves & Cliffs update, with few real code changes from 1.17 except those required to plug in the new biome system. This is our new Latest version. As we had some time before the release, we handled some refactors beforehand. Those will be listed here. Changelog: Refactors (not comprehensive): 99% of the fmllegacy package. Most classes were simply moved from x.y.fmllegacy.z to x.y.z. All instances of Gui -> Screen (GuiOpenEvent -> ScreenOpenEvent, for example) GuiScreenEvent -> ScreenEvent, GuiOverlayDebugForge -> ForgeDebugScreenOverlay All instances of GameMode -> GameType (ClientPlayerChangeGameModeEvent -> ClientPlayerChangedGameTypeEvent, for example) All instances of MatrixStack -> PoseStack (DrawSelectionEvent.matrix -> DrawSelectionEvent.poseStack, for example All instances of KeyBinding -> KeyMapping (ClickInputEvent.keyBinding -> ClickInputEvent.keyMapping, for example All instances of World -> Level All instances of WorldType -> WorldPreset (ForgeHooksClient.getDefaultWorldType -> ForgeHooksClient.getDefaultWorldPreset, for example All instances of NBT -> Tag (BlockSnapshot.getNbt -> BlockSnapshot.getTag, for example) All instances of Container -> Menu (IForgeContainerType -> IForgeMenuType, for example) PlaySoundEvent.sound -> PlaySoundEvent.originalSound PlaySoundEvent.result -> PlaySoundEvent.sound SoundEvent.manager -> SoundEvent.engine SoundEvent.SoundSourceEvent.source -> SoundEvent.SoundSourceEvent.channel FOVUpdateEvent -> FOVModifierEvent EntityViewRenderEvent.FOVModiier -> EntityViewRenderEvent.FieldOfView InputUpdateEvent -> MovementInputUpdateEvent InitScreenEvent.{...Widget...} -> {...Listener...} ForgeItemTagsProvider.func_240521_a_Colored -> copyColored MobSpawnInfoBuilder -> MobSpawnSettingBuilder BasicTrade -> BasicItemListing ModelLoader -> ForgeModelBakery ForgeWorldTypeScreens -> ForgeWorldPresetEditors StackList -> MultItemValue Removals: Entire Animation API IForgeTextureAtlasSprite IForgeItem.{showDurabiityBar, getDurabilityForDisplay, getRGBDurabilityForDisplay} ForgeHooksClient.refreshResources ModelBuilder.gui3d BlockInfo.{updateShift, getShx, getShy, getShz} CapabilityInject CapabilityManager.register ConditionalAdvancement.processConditions IForgeItem.isShield IForgeStructureFeature.{getDefaultSpawnList, getDefaultCreatureSpawnList} Forge's Constants class VanillaResourceType ForgeHooksClient.worldRenderPass (+ accessor) ForgeHooksClient.{preDraw, postDraw, getColorIndex} ScrollPanel.drawBackground Screen.{RenderToolTip, RenderComponentToolTip} ResourceManager.getResourceType LootPool.bonusRolls ForgeConfig - selectiveResourceReload PotionEvent.PotionAddedEvent ClientHooks ModFileResourcePack ResourcePackLoader.getResourcePackFor ResourcePackLoader.IPackInfoFinder ServerLifecycleHooks.buildPackFinder IResourceType ReloadRequirements CommandSetDimension
    • This is the error that I'm getting. WARNING: Unknown module: cpw.mods.securejarhandler specified to --add-exports WARNING: Unknown module: cpw.mods.securejarhandler specified to --add-opens Exception in thread "main" java.lang.module.FindException: Module org.objectweb.asm.util not found, required by org.openjdk.nashorn at java.base/java.lang.module.Resolver.findFail(Resolver.java:893) at java.base/java.lang.module.Resolver.resolve(Resolver.java:192) at java.base/java.lang.module.Resolver.resolve(Resolver.java:141) at java.base/java.lang.module.Configuration.resolveAndBind(Configuration.java:492) at java.base/java.lang.module.Configuration.resolveAndBind(Configuration.java:298) at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:83)   Tried various java versions,   8 and 16 to no avail. even tried bellsoft liberica full jre  and openjre   No clue what is going on and why there are such problems with Java now, seems like Oracle took their ball and wants to go home with the Java project. So many issues with various versions of it.  Any advice? Thanks,.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.