Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

Armor damage with random


Cris16228
 Share

Recommended Posts

Hello guys,

I was trying to create a "Revival" status effect with a debuff on it, basically, if you wear the armor it set your health to 0.5 (Half hearth), it adds a regen effect and it damages the armor

this is my revival class:

Spoiler

@EventBusSubscriber
public class EventHandler {

	private static Random random = new Random();

	@SubscribeEvent
	public static void onDeath(LivingDeathEvent event) {
		if (event.getEntityLiving() instanceof EntityPlayer) {
			EntityPlayer player = (EntityPlayer) event.getEntityLiving();
			boolean isActive = false;
			boolean damageArmor = false;
			int min = Config.revivaldamagemin;
			int max = Config.revivaldamagemax;
			int randomDamage = random.nextInt(max - min + 1) + min;
			if (player.isPotionActive(InitPotions.REVIVAL_EFFECT))
				isActive = true;
			if (Config.revivaldamagearmor == true)
				damageArmor = true;

			if (isActive) {
				event.setCanceled(true);
				player.setHealth(0.5F);
				player.addPotionEffect(new PotionEffect(Potion.getPotionById(10),
						10 * 20, 3));

				if (damageArmor) {
					if (player.inventory.armorItemInSlot(0) != null && player.inventory.armorItemInSlot(1) != null
							&& player.inventory.armorItemInSlot(2) != null
							&& player.inventory.armorItemInSlot(3) != null) {
						player.inventory.damageArmor(randomDamage);
						player.sendMessage(new TextComponentString("Danno: " + String.valueOf(randomDamage)));
					}
				}
			}
		}
	}
}

 

 

I tried to debug it with a send message with the random number (Sorry for the String "Danno:  " but I'm Italian) and in chat it gives me random damage from 5 (min in config) to 13 (max in config) but the armor takes only a bit of damage and not full.

Does

player.inventory.damageArmor(randomDamage);

make an addition of the random and does it as damage to armor pieces?

Do I have to use something else? I want to damage all the armor with the random int given by the random and if I can ask how can I kill ( /kill {player} ) someone if he has the revival effect?

2019-02-17_14.19.52.png

2019-02-17_14.20.21.png

Link to comment
Share on other sites

1. 

47 minutes ago, Cris16228 said:

if (player.inventory.armorItemInSlot(0) != null && player.inventory.armorItemInSlot(1) != null && player.inventory.armorItemInSlot(2) != null && player.inventory.armorItemInSlot(3) != null)

ItemStack does not support null. Use ItemStack#isEmpty instead.

 

2. You are not doing anything to make the armor take randomized damage, so of course it will only take one damage at a time.

 

3. 

47 minutes ago, Cris16228 said:

Does


player.inventory.damageArmor(randomDamage);

make an addition of the random and does it as damage to armor pieces?

No (and I don't see why it should). You have to implement the randomized damage part yourself.

Edited by DavidM

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

2 hours ago, DavidM said:

1. 

ItemStack does not support null. Use ItemStack#isEmpty instead.

That's why if I wear an armor with a custom effect Minecraft crashes saying that the error is in the check line?????

(No, keep crash)

 

Thanks, I fixed it

Edited by Cris16228
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.