Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[Solved] ItemStack amount is doubling randomly


onVoid
 Share

Recommended Posts

Alright, so I have an item where when I break a block, the drop is changed based on a recipe system I have going.

The class where the recipes are added is here (yes I know it's ugly, I'll work on it):

	public static HashMap<String, ArrayList<Object>> blocks = new HashMap<String, ArrayList<Object>>();
	
	public static void addRecipe(String block, HashMap<Object, Integer> drops){
		ArrayList<Object> temp = new ArrayList<Object>();
		for (Object i : drops.keySet()){
			int x = drops.get(i);
			for (int y = 0; y < x; y++){
				temp.add(i);
			}
		}
		blocks.put(block, new ArrayList<Object>(temp));
		temp.clear();
		return;
	}
	
	public static void addRecipe(String block, Object drop){
		ArrayList<Object> temp = new ArrayList<Object>();
		temp.add(drop);
		blocks.put(block, new ArrayList<Object>(temp));
		temp.clear();
		return;
	}
	
	public static ArrayList<Object> getDrop(String block, EntityPlayer player){
		return blocks.get(block);
	}
	
	public static void init(){
		//LOG
		HashMap<Object, Integer> LOG = new HashMap<Object, Integer>();{
		LOG.put("block", 39);
		LOG.put(new ItemStack(Items.STICK), 45);
		LOG.put(new ItemStack(ItemsAdjunct.petrifiedWood, 1, 2), 8);
		LOG.put(new ItemStack(ItemsAdjunct.petrifiedWood, 1, 1), 4);
		LOG.put(new ItemStack(ItemsAdjunct.petrifiedWood, 1, 0), 4);
		}
		addRecipe("logWood", LOG);
		
		//LEAVES
		HashMap<Object, Integer> LEAVES = new HashMap<Object, Integer>();{
		LEAVES.put(null, 17);
		LEAVES.put(new ItemStack(ItemsAdjunct.leafDry, 1), 2);
		LEAVES.put(new ItemStack(ItemsAdjunct.leaf, 1), 1);
		}
		addRecipe("treeLeaves", LEAVES);
		
		addRecipe("dirt", new ItemStack(Blocks.GOLD_BLOCK, 1));
	}

The drop is calculated in the tool class, as a method ran from onBlockStartBreak, and that method is here:

	public static void calculateDrop(ItemStack itemstack, BlockPos pos, net.minecraft.entity.player.EntityPlayer player){
        IBlockState bs = player.getEntityWorld().getBlockState(pos);
        Block block = bs.getBlock();
        int[] blockIDs = OreDictionary.getOreIDs(new ItemStack(Item.getItemFromBlock(block), 1, block.damageDropped(bs)));
        ArrayList<String> blockNAMEs = new ArrayList<String>();
        for (int id : blockIDs){
        	blockNAMEs.add(OreDictionary.getOreName(id));
        }
        Random rand = new java.util.Random();
        ItemStack drop = ItemStack.EMPTY;
        	for (String name : blockNAMEs){
	            if (Pruner.blocks.keySet().contains(name)){
	            	player.getEntityWorld().setBlockToAir(pos);
	            	int outOf = Pruner.getDrop(name, player).size();
	            	Object j = Pruner.getDrop(name, player).get(rand.nextInt(outOf));
	            	if (j instanceof ItemStack){
	            		drop = (ItemStack)j;
		            	break;
	            	} else if (j instanceof String){
	            		if (((String)j).equals("block")){
	            			drop = new ItemStack (block.getItemDropped(bs, new Random(), block.damageDropped(bs)), 1, block.damageDropped(bs));
	    	            	break;
	            		}
	            	}
	            }
        	}
            //
            if (!drop.isEmpty()){
		        float f = 0.7F;
		        double d  = (double)(rand.nextFloat() * f) + (double)(1.0F - f) * 0.2D;
		        double d2 = (double)(rand.nextFloat() * f) + (double)(1.0F - f) * 0.2D;
		        net.minecraft.entity.item.EntityItem entityitem = new net.minecraft.entity.item.EntityItem(player.getEntityWorld(), (double)pos.getX() + d, (double)pos.getY(), (double)pos.getZ() + d2, drop);
		        entityitem.setDefaultPickupDelay();
		        player.getEntityWorld().spawnEntity(entityitem);
		        return;
            }
	}

Now, the issue I am having is that when I break the block that I am using to test (dirt block), at first I receive a single gold block like I am supposed to. But, as I keep breaking more, the amount that drops keeps doubling (I've done some bug testing, and it seems that the actual ItemStack inside of my blocks map is being edited. Now, the only time this map is mentioned in my mod (besides in contains, get, or keySet) is in the class I gave.

Also, init(), in the recipe class, is ran from my main class' FMLInitializationEvent only.

 

Help would be much appreciated, thanks.

Edited by onVoid
Solved
Link to comment
Share on other sites

In java everything that is an instance of Object is a reference-type. So, for example if you have this code

class Foo
{
	public int i = 0;
}

class Main
{
	static void main(string[] args)
	{
		Foo foo = new Foo();
		foo.i = 1;
		doStuff(foo);
		System.out.println(foo.i);
	}

	static void doStuff(Foo foo)
	{
		++foo.i;
	}
}

then the statement being printed into console will be 2. This is basic java.

So you have a Map<String, ItemStack[]>(your map is slightly different but effectively it's the same). Then in your drop class you get an ItemStack from said map and drop it to the player. Now the player has that ItemStack, but it is also still in your map. Thus every modification the player's inventory now does to that ItemStack is also applied to the one inside the map(because they are the same object). So if the player increases the stacksize of your itemstack by 1(say by picking it up) your map now contains the itemstack with the size of 2 and when it is dropped it will have a quantity of 2. Which when the player picks it up will become 4 and so on.

Basically use ItemStack#copy(or it may be called clone, don't remember and can't look it up rn) to create a copy of the itemstack in your map.

 

Unrelated issues:

Don't construct a new Random instance every time, there is no reason to do that.

Link to comment
Share on other sites

30 minutes ago, V0idWa1k3r said:

In java everything that is an instance of Object is a reference-type. So, for example if you have this code


class Foo
{
	public int i = 0;
}

class Main
{
	static void main(string[] args)
	{
		Foo foo = new Foo();
		foo.i = 1;
		doStuff(foo);
		System.out.println(foo.i);
	}

	static void doStuff(Foo foo)
	{
		++foo.i;
	}
}

then the statement being printed into console will be 2. This is basic java.

So you have a Map<String, ItemStack[]>(your map is slightly different but effectively it's the same). Then in your drop class you get an ItemStack from said map and drop it to the player. Now the player has that ItemStack, but it is also still in your map. Thus every modification the player's inventory now does to that ItemStack is also applied to the one inside the map(because they are the same object). So if the player increases the stacksize of your itemstack by 1(say by picking it up) your map now contains the itemstack with the size of 2 and when it is dropped it will have a quantity of 2. Which when the player picks it up will become 4 and so on.

Basically use ItemStack#copy(or it may be called clone, don't remember and can't look it up rn) to create a copy of the itemstack in your map.

 

Unrelated issues:

Don't construct a new Random instance every time, there is no reason to do that.

Thanks for the help, realizing that objects are universal is something that has tripped me up a few times in Java.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • show the complete RegistryObject, you tried to create
    • Luis_ST Can you please show me an example I am trying to create a ForgeSpawnEggItem in my ModSpawnEgg class, but it keeps on saying the same error as shown above 
    • Time: 12/3/21 11:33 PM Description: Ticking entity java.lang.BootstrapMethodError: java.lang.LinkageError: loader constraint violation: loader (instance of sun/misc/Launcher$AppClassLoader) previously initiated loading for a different type with name "org/apache/logging/log4j/util/MessageSupplier"     at net.minecraftforge.eventbus.EventBus.handleException(EventBus.java:316) ~[eventbus-4.0.0.jar:?] {}     at net.minecraftforge.eventbus.EventBus.post(EventBus.java:307) ~[eventbus-4.0.0.jar:?] {}     at net.minecraftforge.eventbus.EventBus.post(EventBus.java:283) ~[eventbus-4.0.0.jar:?] {}     at net.minecraftforge.event.ForgeEventFactory.gatherCapabilities(ForgeEventFactory.java:597) ~[?:?] {re:mixin,re:classloading}     at net.minecraftforge.event.ForgeEventFactory.gatherCapabilities(ForgeEventFactory.java:591) ~[?:?] {re:mixin,re:classloading}     at net.minecraftforge.common.capabilities.CapabilityProvider.doGatherCapabilities(CapabilityProvider.java:83) ~[?:?] {re:computing_frames,re:mixin,re:classloading}     at net.minecraftforge.common.capabilities.CapabilityProvider.getCapabilities(CapabilityProvider.java:91) ~[?:?] {re:computing_frames,re:mixin,re:classloading}     at net.minecraftforge.common.capabilities.CapabilityProvider.areCapsCompatible(CapabilityProvider.java:103) ~[?:?] {re:computing_frames,re:mixin,re:classloading}     at net.minecraft.item.ItemStack.func_77959_d(ItemStack.java:387) ~[?:?] {re:mixin,xf:fml:forge:filled_map.4,xf:fml:forge:itemstack,re:classloading,xf:fml:forge:filled_map.4,xf:fml:forge:itemstack,pl:mixin:APP:performant.mixins.json:item.ItemStackMixin,pl:mixin:APP:itemfilters-common.mixins.json:ItemStackMixin,pl:mixin:APP:epicfight.mixins.json:MixinItemStack,pl:mixin:A}     at net.minecraft.item.ItemStack.func_77989_b(ItemStack.java:375) ~[?:?] {re:mixin,xf:fml:forge:filled_map.4,xf:fml:forge:itemstack,re:classloading,xf:fml:forge:filled_map.4,xf:fml:forge:itemstack,pl:mixin:APP:performant.mixins.json:item.ItemStackMixin,pl:mixin:APP:itemfilters-common.mixins.json:ItemStackMixin,pl:mixin:APP:epicfight.mixins.json:MixinItemStack,pl:mixin:A}     at net.minecraft.entity.LivingEntity.func_241354_r_(LivingEntity.java:2267) ~[?:?] {re:mixin,pl:accesstransformer:B,re:computing_frames,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:performant.mixins.json:entity.LivingEntityMixin,pl:mixin:APP:citadel.mixins.json:LivingEntityMixin,pl:mixin:APP:environmental.mixins.json:LivingEntityMixin,pl:mixin:APP:allurement.mixins.json:LivingEntityAccessor,pl:mixin:APP:allurement.mixins.json:LivingEntityMixin,pl:mixin:APP:ars_nouveau.mixins.json:ExpInvokerMixin,pl:mixin:APP:ars_nouveau.mixins.json:MixinLivingEntity,pl:mixin:APP:personality.mixins.json:LivingEntityMixin,pl:mixin:APP:assets/botania/botania.mixins.json:AccessorLivingEntity,pl:mixin:A}     at net.minecraft.entity.LivingEntity.func_241353_q_(LivingEntity.java:2239) ~[?:?] {re:mixin,pl:accesstransformer:B,re:computing_frames,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:performant.mixins.json:entity.LivingEntityMixin,pl:mixin:APP:citadel.mixins.json:LivingEntityMixin,pl:mixin:APP:environmental.mixins.json:LivingEntityMixin,pl:mixin:APP:allurement.mixins.json:LivingEntityAccessor,pl:mixin:APP:allurement.mixins.json:LivingEntityMixin,pl:mixin:APP:ars_nouveau.mixins.json:ExpInvokerMixin,pl:mixin:APP:ars_nouveau.mixins.json:MixinLivingEntity,pl:mixin:APP:personality.mixins.json:LivingEntityMixin,pl:mixin:APP:assets/botania/botania.mixins.json:AccessorLivingEntity,pl:mixin:A}     at net.minecraft.entity.LivingEntity.func_70071_h_(LivingEntity.java:2141) ~[?:?] {re:mixin,pl:accesstransformer:B,re:computing_frames,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:performant.mixins.json:entity.LivingEntityMixin,pl:mixin:APP:citadel.mixins.json:LivingEntityMixin,pl:mixin:APP:environmental.mixins.json:LivingEntityMixin,pl:mixin:APP:allurement.mixins.json:LivingEntityAccessor,pl:mixin:APP:allurement.mixins.json:LivingEntityMixin,pl:mixin:APP:ars_nouveau.mixins.json:ExpInvokerMixin,pl:mixin:APP:ars_nouveau.mixins.json:MixinLivingEntity,pl:mixin:APP:personality.mixins.json:LivingEntityMixin,pl:mixin:APP:assets/botania/botania.mixins.json:AccessorLivingEntity,pl:mixin:A}     at net.minecraft.entity.MobEntity.func_70071_h_(MobEntity.java:431) ~[?:?] {re:mixin,pl:accesstransformer:B,xf:OptiFine:default,re:classloading,pl:accesstransformer:B,xf:OptiFine:default,pl:mixin:APP:environmental.mixins.json:MobEntityMixin,pl:mixin:APP:assets/botania/botania.mixins.json:AccessorMobEntity,pl:mixin:APP:performant.mixins.json:entity.MobEntityDespawnMixin,pl:mixin:APP:performant.mixins.json:entity.MobEntityMixin,pl:mixin:A}     at net.minecraft.world.server.ServerWorld.func_217479_a(ServerWorld.java:611) ~[?:?] {re:mixin,pl:accesstransformer:B,re:computing_frames,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:performant.mixins.json:world.ServerWorldBlockUpdateMixin,pl:mixin:APP:abnormals_core.mixins.json:ServerWorldMixin,pl:mixin:APP:performant.mixins.json:world.ServerWorldMixin,pl:mixin:APP:performant.mixins.json:entity.MobServerWorldMixin,pl:mixin:A}     at net.minecraft.world.server.ServerWorld$$Lambda$16565/514282080.accept(Unknown Source) ~[?:?] {}     at net.minecraft.world.World.func_217390_a(World.java:554) ~[?:?] {re:computing_frames,pl:accesstransformer:B,xf:fml:observerlib:coremodmethod,re:mixin,pl:accesstransformer:B,xf:fml:observerlib:coremodmethod,re:classloading,pl:accesstransformer:B,xf:fml:observerlib:coremodmethod,pl:mixin:APP:sereneseasons.mixins.json:MixinWorld,pl:mixin:APP:flywheel.mixins.json:TileWorldHookMixin,pl:mixin:A}     at net.minecraft.world.server.ServerWorld.func_72835_b(ServerWorld.java:404) ~[?:?] {re:mixin,pl:accesstransformer:B,re:computing_frames,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:performant.mixins.json:world.ServerWorldBlockUpdateMixin,pl:mixin:APP:abnormals_core.mixins.json:ServerWorldMixin,pl:mixin:APP:performant.mixins.json:world.ServerWorldMixin,pl:mixin:APP:performant.mixins.json:entity.MobServerWorldMixin,pl:mixin:A}     at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:851) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:structure_gel.mixins.json:MinecraftServerMixin,pl:mixin:APP:byg.mixins.json:server.MixinMinecraftServer,pl:mixin:APP:marg.mixins.json:MinecraftServerMixin,pl:mixin:A}     at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:787) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:structure_gel.mixins.json:MinecraftServerMixin,pl:mixin:APP:byg.mixins.json:server.MixinMinecraftServer,pl:mixin:APP:marg.mixins.json:MinecraftServerMixin,pl:mixin:A}     at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:118) ~[?:?] {re:mixin,xf:OptiFine:default,re:classloading,xf:OptiFine:default,pl:mixin:APP:smoothboot.mixins.json:client.IntegratedServerMixin,pl:mixin:A}     at net.minecraft.server.MinecraftServer.func_240802_v_(MinecraftServer.java:642) [?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:structure_gel.mixins.json:MinecraftServerMixin,pl:mixin:APP:byg.mixins.json:server.MixinMinecraftServer,pl:mixin:APP:marg.mixins.json:MinecraftServerMixin,pl:mixin:A}     at net.minecraft.server.MinecraftServer.func_240783_a_(MinecraftServer.java:232) [?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:structure_gel.mixins.json:MinecraftServerMixin,pl:mixin:APP:byg.mixins.json:server.MixinMinecraftServer,pl:mixin:APP:marg.mixins.json:MinecraftServerMixin,pl:mixin:A}     at net.minecraft.server.MinecraftServer$$Lambda$15673/85323444.run(Unknown Source) [?:?] {}     at java.lang.Thread.run(Thread.java:745) [?:1.8.0_51] {} Caused by: java.lang.LinkageError: loader constraint violation: loader (instance of sun/misc/Launcher$AppClassLoader) previously initiated loading for a different type with name "org/apache/logging/log4j/util/MessageSupplier"     at java.lang.ClassLoader.defineClass1(Native Method) ~[?:1.8.0_51] {}     at java.lang.ClassLoader.defineClass(ClassLoader.java:760) ~[?:1.8.0_51] {}     at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142) ~[?:1.8.0_51] {}     at java.net.URLClassLoader.defineClass(URLClassLoader.java:467) ~[?:1.8.0_51] {}     at java.net.URLClassLoader.access$100(URLClassLoader.java:73) ~[?:1.8.0_51] {}     at java.net.URLClassLoader$1.run(URLClassLoader.java:368) ~[?:1.8.0_51] {}     at java.net.URLClassLoader$1.run(URLClassLoader.java:362) ~[?:1.8.0_51] {}     at java.security.AccessController.doPrivileged(Native Method) ~[?:1.8.0_51] {}     at java.net.URLClassLoader.findClass(URLClassLoader.java:361) ~[?:1.8.0_51] {}     at java.lang.ClassLoader.loadClass(ClassLoader.java:424) ~[?:1.8.0_51] {}     at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331) ~[?:1.8.0_51] {}     at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ~[?:1.8.0_51] {}     ... 25 more for full report https://pastebin.com/Did3vHvR    
    • you need to create a new ForgeSpawnEggItem and not a SpawnEggItem!
    • this is at the moment not implemented, since vanilla changed the Biome generation, and the old Forge patch doesn't work anymore you need to wait till it's will be added back
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.