Jump to content

OnBlockActivated is not working


Xaaf

Recommended Posts

Hello,

 

I'd like to output a message to the console when clicking on a block. To do this I have the following code

public boolean onBlockActivated(World world, BlockPos pos, IBlockState state, EntityPlayer player, EnumHand hand, @Nullable ItemStack heldItem, EnumFacing side, float hitX, float hitY, float hitZ) {
	ForgeOfIndustries.logger.info("Clicked the HeatCoil!");
        
	return true;
}

The problem is that nothing is being output in the console. I've already tried adding an Override annotation, but Eclipse wants me to remove it immediately.

 

What's the issue here? I've been struggling with this problem for a couple of hours now. Might be obvious, but I'm just not seeing it.

Link to comment
Share on other sites

6 hours ago, Xaaf said:

I've already tried adding an Override annotation, but Eclipse wants me to remove it immediately.

That is what the @Override annotation is supposed to do: throwing an error when the signature of your method does not match methods in the parent method.

Your problem is caused by the method signature being incorrect.

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

 
 
 
22 hours ago, diesieben07 said:

This clearly shows you do not understand what @Override does and how overriding works in general.

Please learn basic Java before writing a mod.

I do know what `@Override` does. I know basic Java, as I've been using it for a while. The point of me trying it is that I didn't know whether the method was overridable.

 
 
 
23 hours ago, DoctorLOGiQ said:

Hello, what is the value of 


ForgeOfIndustries.logger

? And which version of Forge are you working with?

The logger is a proper value. I know because I'm using it to call out the different initialization phases. These logs are all findable in the console.

 

I'm quite sure that the issue is related to how I use the method `onBlockActivated`. Do I need to subscribe it to te event bus?

Link to comment
Share on other sites

1. All methods, except final ones, are overridable.

2.

Quote

The point of me trying it is that I didn't know whether the method was overridable.

This does not mean you should try overriding without the @Override annotation.

 

3. No, you don't need to subscribe to everything; you just have to override Block#onBlockActivated.

Edited by DavidM

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

4 hours ago, DavidM said:

3. No, you don't need to subscribe to everything; you just have to override Block#onBlockActivated.

With the correct Block#onBlockActivated method signature.*

  • Like 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

17 hours ago, Draco18s said:

With the correct Block#onBlockActivated method signature.*

What do you mean with the correct signature? Aren't the parameters I provided correct? I'm assuming that the naming of these variables doesn't matter to Forge.

Link to comment
Share on other sites

3 hours ago, Xaaf said:

What do you mean with the correct signature? Aren't the parameters I provided correct? I'm assuming that the naming of these variables doesn't matter to Forge.

This indicates that you are not so familiar with how methods and methods signatures work in Java.

I would recommend to look up tutorials or explanations on method signatures and overriding in Java.

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.