Jump to content

[1.12.2] Item breaks when has durability 0 event


nov4e

Recommended Posts

20 hours ago, nov4e said:

yes

Then override Item#setDamage(ItemStack, int) for your item. In your overridden method, just make sure that the stack's item damage never exceeds its max damage, and the item won't break.

Link to comment
Share on other sites

20 minutes ago, nov4e said:

   @Override
	public void setDamage(ItemStack stack, int damage) {
		if(damage > 1) {
			stack.setItemDamage(damage);
		}
	}

 

No, you want to check that damage <= item.getMaxDamage() before you update the item's damage.  Remember that the item damage increases as it becomes more damaged.

Link to comment
Share on other sites

I changed it a little bit:

@Override
	public void setDamage(ItemStack stack, int damage) {
		if(stack == new ItemStack(this)) {
			if(damage < stack.getItem().getMaxDamage()) {
				if(damage > 1) {
					super.setDamage(stack, damage);
				}
			}
		}
	}

 

Link to comment
Share on other sites

What on earth is this for? 

if(stack == new ItemStack(this))

 

And why do you keep trying to compare damage > 1 ?  What do you think that's achieving?

 

All you need to do is clamp the item's damage value between 0 (undamaged) and item.maxDamage() (fully damaged, just before breaking) inclusive.

 

By the way, you should be testing your code (and ideally running it through your IDE's debugger when it fails) rather than just inventing snippets to post here.

Edited by desht
  • Thanks 1
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.