Jump to content

[1.12.2] Fog Color/Fog Density


DiamondMiner88

Recommended Posts

I cannot get the Fog color to work; along with the density. I looked at other posts, tutorials, and GitHub Repository-s but still have no idea why this won't work.

@SubscribeEvent(priority = EventPriority.NORMAL, receiveCanceled = true)
public void onFogDensityEvent(EntityViewRenderEvent.FogDensity event) {
    event.setDensity(0.0001F);
    if (event.getEntity().isInsideOfMaterial(ModMaterials.MOLTEN_GLASS)) event.setDensity(1F);
}

@SubscribeEvent(priority = EventPriority.NORMAL, receiveCanceled = true)
public void onFogColorsEvent(EntityViewRenderEvent.FogColors event) {
    if (event.getEntity().isInsideOfMaterial(ModMaterials.MOLTEN_GLASS)) {
        event.setRed(COLOR_MOLTEN_GLASS.getRed());
        event.setGreen(COLOR_MOLTEN_GLASS.getGreen());
        event.setBlue(COLOR_MOLTEN_GLASS.getBlue());
    }
}
private static final Color COLOR_MOLTEN_GLASS = new Color(251, 143, 70);
Link to comment
Share on other sites

41 minutes ago, DiamondMiner88 said:

I cannot get the Fog color to work; along with the density. I looked at other posts, tutorials, and GitHub Repository-s but still have no idea why this won't work.


@SubscribeEvent(priority = EventPriority.NORMAL, receiveCanceled = true)
public void onFogDensityEvent(EntityViewRenderEvent.FogDensity event) {
    event.setDensity(0.0001F);
    if (event.getEntity().isInsideOfMaterial(ModMaterials.MOLTEN_GLASS)) event.setDensity(1F);
}

@SubscribeEvent(priority = EventPriority.NORMAL, receiveCanceled = true)
public void onFogColorsEvent(EntityViewRenderEvent.FogColors event) {
    if (event.getEntity().isInsideOfMaterial(ModMaterials.MOLTEN_GLASS)) {
        event.setRed(COLOR_MOLTEN_GLASS.getRed());
        event.setGreen(COLOR_MOLTEN_GLASS.getGreen());
        event.setBlue(COLOR_MOLTEN_GLASS.getBlue());
    }
}

private static final Color COLOR_MOLTEN_GLASS = new Color(251, 143, 70);

Did you check if events are being called?

Link to comment
Share on other sites

No, how do i do that?

I placed them in my ClientEventSubscriber

Spoiler

package tk.diamondbuildz.mod.character.client;

import com.google.common.base.Preconditions;
import net.minecraft.block.Block;
import net.minecraft.block.state.IBlockState;
import net.minecraft.client.renderer.block.model.ModelBakery;
import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.client.renderer.block.statemap.StateMapperBase;
import net.minecraft.item.Item;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.client.event.EntityViewRenderEvent;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.fluids.IFluidBlock;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;
import net.minecraftforge.fml.common.eventhandler.EventPriority;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.common.registry.ForgeRegistries;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import tk.diamondbuildz.mod.character.reference.ModMaterials;

import javax.annotation.Nonnull;
import java.awt.*;

import static net.minecraftforge.fml.relauncher.Side.CLIENT;
import static tk.diamondbuildz.mod.character.reference.Reference.FLUID_MODEL_PATH;
import static tk.diamondbuildz.mod.character.reference.Reference.MOD_ID;

/**
 * Subscribe to events that should be handled on the PHYSICAL CLIENT in this class
 *
 * @author Diamond
 */
@EventBusSubscriber(modid = MOD_ID, value = CLIENT)
public final class ClientEventSubscriber {

    private static final Logger LOGGER = LogManager.getLogger();
    private static final String DEFAULT_VARIANT = "normal";

    private static final Color COLOR_MOLTEN_GLASS = new Color(251, 143, 70);

    /**
     * Cycle through all block and items already registered, if ModId of the entry matches to my ModId, calls
     * {@link ClientEventSubscriber#registerItemBlockModel(Block)}
     * or
     * {@link ClientEventSubscriber#registerItemModel(Item)}
     */
    @SubscribeEvent
    public static void onRegisterModelsEvent(@Nonnull final ModelRegistryEvent event) {
        ForgeRegistries.BLOCKS.getValuesCollection().stream()
                .filter(block -> block.getRegistryName().getNamespace().equals(MOD_ID))
                .forEach(ClientEventSubscriber::registerItemBlockModel);

        ForgeRegistries.ITEMS.getValuesCollection().stream()
                .filter(block -> block.getRegistryName().getNamespace().equals(MOD_ID))
                .forEach(ClientEventSubscriber::registerItemModel);

        LOGGER.debug("Registered models");
    }

    private static void registerItemModel(final Item item) {
        Preconditions.checkNotNull(item, "Item cannot be null!");
        final ResourceLocation registryName = item.getRegistryName();
        Preconditions.checkNotNull(registryName, "Item Registry Name cannot be null!");
        ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(registryName, DEFAULT_VARIANT));
    }

    private static void registerItemBlockModel(final Block block) {
        Preconditions.checkNotNull(block, "Block cannot be null!");
        final ResourceLocation registryName = block.getRegistryName();
        Preconditions.checkNotNull(registryName, "Block Registry Name cannot be null!");
        if (block instanceof IFluidBlock) registerFluidModel((IFluidBlock) block);
        else
            ModelLoader.setCustomModelResourceLocation(Item.getItemFromBlock(block), 0, new ModelResourceLocation(registryName, DEFAULT_VARIANT));
    }

    private static void registerFluidModel(IFluidBlock fluidBlock) {
        Item item = Item.getItemFromBlock((Block) fluidBlock);
        ModelBakery.registerItemVariants(item);
        ModelResourceLocation modelResourceLocation = new ModelResourceLocation(FLUID_MODEL_PATH, fluidBlock.getFluid().getName());
        ModelLoader.setCustomMeshDefinition(item, stack -> modelResourceLocation);
        ModelLoader.setCustomStateMapper((Block) fluidBlock, new StateMapperBase() {
            @Override
            protected ModelResourceLocation getModelResourceLocation(@Nonnull IBlockState p_178132_1_) {
                return modelResourceLocation;
            }
        });
    }

    @SubscribeEvent(priority = EventPriority.NORMAL, receiveCanceled = true)
    public void onFogDensityEvent(EntityViewRenderEvent.FogDensity event) {
        event.setDensity(0.0001F);
        if (event.getEntity().isInsideOfMaterial(ModMaterials.MOLTEN_GLASS)) event.setDensity(1F);
    }

    @SubscribeEvent(priority = EventPriority.NORMAL, receiveCanceled = true)
    public void onFogColorsEvent(EntityViewRenderEvent.FogColors event) {
        if (event.getEntity().isInsideOfMaterial(ModMaterials.MOLTEN_GLASS)) {
            event.setRed(COLOR_MOLTEN_GLASS.getRed());
            event.setGreen(COLOR_MOLTEN_GLASS.getGreen());
            event.setBlue(COLOR_MOLTEN_GLASS.getBlue());
        }
    }
}

 

Link to comment
Share on other sites

22 minutes ago, DiamondMiner88 said:

No, how do i do that?

I placed them in my ClientEventSubscriber

  Reveal hidden contents


package tk.diamondbuildz.mod.character.client;

import com.google.common.base.Preconditions;
import net.minecraft.block.Block;
import net.minecraft.block.state.IBlockState;
import net.minecraft.client.renderer.block.model.ModelBakery;
import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.client.renderer.block.statemap.StateMapperBase;
import net.minecraft.item.Item;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.client.event.EntityViewRenderEvent;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.fluids.IFluidBlock;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;
import net.minecraftforge.fml.common.eventhandler.EventPriority;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.common.registry.ForgeRegistries;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import tk.diamondbuildz.mod.character.reference.ModMaterials;

import javax.annotation.Nonnull;
import java.awt.*;

import static net.minecraftforge.fml.relauncher.Side.CLIENT;
import static tk.diamondbuildz.mod.character.reference.Reference.FLUID_MODEL_PATH;
import static tk.diamondbuildz.mod.character.reference.Reference.MOD_ID;

/**
 * Subscribe to events that should be handled on the PHYSICAL CLIENT in this class
 *
 * @author Diamond
 */
@EventBusSubscriber(modid = MOD_ID, value = CLIENT)
public final class ClientEventSubscriber {

    private static final Logger LOGGER = LogManager.getLogger();
    private static final String DEFAULT_VARIANT = "normal";

    private static final Color COLOR_MOLTEN_GLASS = new Color(251, 143, 70);

    /**
     * Cycle through all block and items already registered, if ModId of the entry matches to my ModId, calls
     * {@link ClientEventSubscriber#registerItemBlockModel(Block)}
     * or
     * {@link ClientEventSubscriber#registerItemModel(Item)}
     */
    @SubscribeEvent
    public static void onRegisterModelsEvent(@Nonnull final ModelRegistryEvent event) {
        ForgeRegistries.BLOCKS.getValuesCollection().stream()
                .filter(block -> block.getRegistryName().getNamespace().equals(MOD_ID))
                .forEach(ClientEventSubscriber::registerItemBlockModel);

        ForgeRegistries.ITEMS.getValuesCollection().stream()
                .filter(block -> block.getRegistryName().getNamespace().equals(MOD_ID))
                .forEach(ClientEventSubscriber::registerItemModel);

        LOGGER.debug("Registered models");
    }

    private static void registerItemModel(final Item item) {
        Preconditions.checkNotNull(item, "Item cannot be null!");
        final ResourceLocation registryName = item.getRegistryName();
        Preconditions.checkNotNull(registryName, "Item Registry Name cannot be null!");
        ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(registryName, DEFAULT_VARIANT));
    }

    private static void registerItemBlockModel(final Block block) {
        Preconditions.checkNotNull(block, "Block cannot be null!");
        final ResourceLocation registryName = block.getRegistryName();
        Preconditions.checkNotNull(registryName, "Block Registry Name cannot be null!");
        if (block instanceof IFluidBlock) registerFluidModel((IFluidBlock) block);
        else
            ModelLoader.setCustomModelResourceLocation(Item.getItemFromBlock(block), 0, new ModelResourceLocation(registryName, DEFAULT_VARIANT));
    }

    private static void registerFluidModel(IFluidBlock fluidBlock) {
        Item item = Item.getItemFromBlock((Block) fluidBlock);
        ModelBakery.registerItemVariants(item);
        ModelResourceLocation modelResourceLocation = new ModelResourceLocation(FLUID_MODEL_PATH, fluidBlock.getFluid().getName());
        ModelLoader.setCustomMeshDefinition(item, stack -> modelResourceLocation);
        ModelLoader.setCustomStateMapper((Block) fluidBlock, new StateMapperBase() {
            @Override
            protected ModelResourceLocation getModelResourceLocation(@Nonnull IBlockState p_178132_1_) {
                return modelResourceLocation;
            }
        });
    }

    @SubscribeEvent(priority = EventPriority.NORMAL, receiveCanceled = true)
    public void onFogDensityEvent(EntityViewRenderEvent.FogDensity event) {
        event.setDensity(0.0001F);
        if (event.getEntity().isInsideOfMaterial(ModMaterials.MOLTEN_GLASS)) event.setDensity(1F);
    }

    @SubscribeEvent(priority = EventPriority.NORMAL, receiveCanceled = true)
    public void onFogColorsEvent(EntityViewRenderEvent.FogColors event) {
        if (event.getEntity().isInsideOfMaterial(ModMaterials.MOLTEN_GLASS)) {
            event.setRed(COLOR_MOLTEN_GLASS.getRed());
            event.setGreen(COLOR_MOLTEN_GLASS.getGreen());
            event.setBlue(COLOR_MOLTEN_GLASS.getBlue());
        }
    }
}

 

Well I am not an expert, but you can do that using debugger, orrr I always do that by simply putting

System.out.println("YAY It was called, so it's working!");

inside the method I wanna check.
I would suggest putting two checks - before if and after if - so you will get double result - check if your event is actually working (is it being called) and check if entity actually is inside that material, so you will be sure that your if works correctly.

Link to comment
Share on other sites

33 minutes ago, DiamondMiner88 said:

Tried that in both Events returned nothing in console, Im going to try LOGGER.debug instead.

 

so your events are not being called actually. Maybe try changing event methods to static?

Link to comment
Share on other sites

Ok That fixed it. My other event subscriptions are static, didn't notice that. Now the problem is that the color is not working.

How it looks when I'm not in the fluid:

Spoiler

2019-05-07_12_58_29.png.04d8923d207e87330e0f9e8766775a81.png

When i am in the fluid:

Spoiler

2019-05-07_12_58_51.png.37b14ff2399f58b97670dde76e6a00b2.png2019-05-07_12_58_48.png.eb246394c0febd9274f08530efdac4ad.png

What i have done now:

Spoiler

@SubscribeEvent(priority = EventPriority.NORMAL, receiveCanceled = true)
public static void onFogDensityEvent(EntityViewRenderEvent.FogDensity event) {
    event.setDensity(0.0000000000000000000001F);
    if (event.getEntity().isInsideOfMaterial(ModMaterials.MOLTEN_GLASS)) {
        event.setDensity(1F);
    }
}

@SubscribeEvent(priority = EventPriority.NORMAL, receiveCanceled = true)
public static void onFogColorsEvent(EntityViewRenderEvent.FogColors event) {
    if (event.getEntity().isInsideOfMaterial(ModMaterials.MOLTEN_GLASS)) {
        event.setRed(COLOR_MOLTEN_GLASS.getRed() / 255);
        event.setGreen(COLOR_MOLTEN_GLASS.getGreen() / 255);
        event.setBlue(COLOR_MOLTEN_GLASS.getBlue() / 255);
    }
}

private static final Color COLOR_MOLTEN_GLASS = new Color(251, 143, 70);

 

 

Edited by DiamondMiner88
Link to comment
Share on other sites

7 minutes ago, DiamondMiner88 said:

Density Hook? Whats that?

 

2 hours ago, DiamondMiner88 said:

public static void onFogDensityEvent(EntityViewRenderEvent.FogDensity event) {

 

7 minutes ago, DiamondMiner88 said:

How do i do that?

 

1 hour ago, V0idWa1k3r said:

using GlStateManager

To be more specifically GlStateManager.fogMode

Link to comment
Share on other sites

6 hours ago, DiamondMiner88 said:

I have done this in my density hook but it appears to have done nothing


GlStateManager.setFog(GlStateManager.FogMode.EXP);

I haven't finished the flow texture so i just set it to be white, here's how it looks:

  Hide contents

2019-05-07_16_42_31.png.6f3e6467d3bfa64a676ffaf6041cadac.png

 

Hmmm maybe you need to experiment with fogStart and fogEnd parameters? 

            GlStateManager.fogStart(fogStartFloat-for e.g. 4f);
            GlStateManager.fogEnd(fogEndFloat for e.g. 40f);

 

Link to comment
Share on other sites

Try doing 

GlStateManager.setFogDensity(float);

Look at what Minecraft uses for water (in net.minecraft.client.renderer.EntityRenderer):

Spoiler

private void setupFog(int startCoords, float partialTicks)
    {
        Entity entity = this.mc.getRenderViewEntity();
        this.setupFogColor(false);
        GlStateManager.glNormal3f(0.0F, -1.0F, 0.0F);
        GlStateManager.color(1.0F, 1.0F, 1.0F, 1.0F);
        IBlockState iblockstate = ActiveRenderInfo.getBlockStateAtEntityViewpoint(this.mc.world, entity, partialTicks);
        float hook = net.minecraftforge.client.ForgeHooksClient.getFogDensity(this, entity, iblockstate, partialTicks, 0.1F);
        if (hook >= 0) GlStateManager.setFogDensity(hook);
        else
        if (entity instanceof EntityLivingBase && ((EntityLivingBase)entity).isPotionActive(MobEffects.BLINDNESS))
        {
            float f1 = 5.0F;
            int i = ((EntityLivingBase)entity).getActivePotionEffect(MobEffects.BLINDNESS).getDuration();

            if (i < 20)
            {
                f1 = 5.0F + (this.farPlaneDistance - 5.0F) * (1.0F - (float)i / 20.0F);
            }

            GlStateManager.setFog(GlStateManager.FogMode.LINEAR);

            if (startCoords == -1)
            {
                GlStateManager.setFogStart(0.0F);
                GlStateManager.setFogEnd(f1 * 0.8F);
            }
            else
            {
                GlStateManager.setFogStart(f1 * 0.25F);
                GlStateManager.setFogEnd(f1);
            }

            if (GLContext.getCapabilities().GL_NV_fog_distance)
            {
                GlStateManager.glFogi(34138, 34139);
            }
        }
        else if (this.cloudFog)
        {
            GlStateManager.setFog(GlStateManager.FogMode.EXP);
            GlStateManager.setFogDensity(0.1F);
        }
  		// Water starts here
        else if (iblockstate.getMaterial() == Material.WATER)
        {
            GlStateManager.setFog(GlStateManager.FogMode.EXP);

            if (entity instanceof EntityLivingBase)
            {
                if (((EntityLivingBase)entity).isPotionActive(MobEffects.WATER_BREATHING))
                {
                    GlStateManager.setFogDensity(0.01F);
                }
                else
                {
                    GlStateManager.setFogDensity(0.1F - (float)EnchantmentHelper.getRespirationModifier((EntityLivingBase)entity) * 0.03F);
                }
            }
            else
            {
                GlStateManager.setFogDensity(0.1F);
            }
        }
  		// and ends here
        else if (iblockstate.getMaterial() == Material.LAVA)
        {
            GlStateManager.setFog(GlStateManager.FogMode.EXP);
            GlStateManager.setFogDensity(2.0F);
        }
        else
        {
            float f = this.farPlaneDistance;
            GlStateManager.setFog(GlStateManager.FogMode.LINEAR);

            if (startCoords == -1)
            {
                GlStateManager.setFogStart(0.0F);
                GlStateManager.setFogEnd(f);
            }
            else
            {
                GlStateManager.setFogStart(f * 0.75F);
                GlStateManager.setFogEnd(f);
            }

            if (GLContext.getCapabilities().GL_NV_fog_distance)
            {
                GlStateManager.glFogi(34138, 34139);
            }

            if (this.mc.world.provider.doesXZShowFog((int)entity.posX, (int)entity.posZ) || this.mc.ingameGUI.getBossOverlay().shouldCreateFog())
            {
                GlStateManager.setFogStart(f * 0.05F);
                GlStateManager.setFogEnd(Math.min(f, 192.0F) * 0.5F);
            }
            net.minecraftforge.client.ForgeHooksClient.onFogRender(this, entity, iblockstate, partialTicks, startCoords, f);
        }

        GlStateManager.enableColorMaterial();
        GlStateManager.enableFog();
        GlStateManager.colorMaterial(1028, 4608);
    }

 

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.