Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

1.12.2 need help for my datafixer


TheRPGAdventurer
 Share

Recommended Posts

So i needed data fixer because an amulet item that stores the dragons and respawn them saving the nbt data like health breed stuff like has been compressed from 13 registered names corresponding to dragon breeds to one amulet itself. so i need to data fix them. Now it doesnt work so it seems like im doing something wrong here. Also the breed was saved in the amulets inititialize instead of the nbt (now it is) how do i add that breed in?

 

this was derived especially from ItemTotemRename.class, it doesnt have an initizlization and im not sure how

DataFixer: https://pastebin.com/41vi5n4J

Registry: 

package com.TheRPGAdventurer.ROTD.datafix;

import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.datafix.IFixableData;

public class DragonMountsItemDataFixes implements IFixableData {

    @Override
    public int getFixVersion() {
        return 2;
    }

    // is the fixTag proper (I think this is the cause tho) derived from PotionItem.class
    public NBTTagCompound fixTagCompound(NBTTagCompound compound) {
        if ("dragonmounts:end_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:nether_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:skeleton_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:wither_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:forest_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:fire_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:water_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:sunlight_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:enchant_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:terra_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:moonlight_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }

        return compound;
    }
}

 

Link to comment
Share on other sites

Irrelevant: You might want to use something like regex to clean up that bunch of if elses.

Using sub-string to check if the last few characters equal to "dragon_amulet" would also work. Just don't use a bunch of if elses.

Edited by DavidM

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

1 hour ago, DavidM said:

Irrelevant: You might want to use something like regex to clean up that bunch of if elses.

Using sub-string to check if the last few characters equal to "dragon_amulet" would also work. Just don't use a bunch of if elses.

i removed the else and left with only if statemets whats left to do it still doesnt fire up

Link to comment
Share on other sites

12 hours ago, DavidM said:

public class DragonMountsItemDataFixes implements IFixableData {

    @Override
    public int getFixVersion() {
        return 1;
    }

    // is the fixTag proper (I think this is the cause tho) derived from PotionItem.class
    public NBTTagCompound fixTagCompound(NBTTagCompound compound) {
        if ("dragonmounts:end_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:nether_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:skeleton_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:wither_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:forest_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:fire_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:water_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:sunlight_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:enchant_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:terra_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:moonlight_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }

        if ("dragonmounts:storm_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }

        return compound;
    }
}
Link to comment
Share on other sites

setRegistryName sets the registry name of the Item

setTranslationKey sets the translation key of the Item

 

none of them set the ItemStack’s NBT or the “id” in the ItemStack’s NBT

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • These are my particle effect classes, they are all copied from a tutorial.   public class Juan1ParticalType extends ParticleType { public Juan1ParticalType() { super(false, Juan1ParticalData.DESERIALIZER); } @Override public Codec<Juan1ParticalData> func_230522_e_() { return Codec.unit(new Juan1ParticalData(new Vector3d(0, 0, 0), new Color(0xF63900), 0)); } }   public class Juan1ParticalData implements IParticleData { private final Vector3d speed; private final Color color; private final float diameter; public static final IDeserializer<Juan1ParticalData> DESERIALIZER = new IDeserializer<Juan1ParticalData>() { @Override public Juan1ParticalData deserialize(ParticleType<Juan1ParticalData> particleTypeIn, StringReader reader) throws CommandSyntaxException { final int MIN_COLOUR = 0; final int MAX_COLOUR = 255;reader.expect(' '); double speedX = reader.readDouble(); reader.expect(' '); double speedY = reader.readDouble(); reader.expect(' '); double speedZ = reader.readDouble(); reader.expect(' '); int red = MathHelper.clamp(reader.readInt(), MIN_COLOUR, MAX_COLOUR); reader.expect(' '); int green = MathHelper.clamp(reader.readInt(), MIN_COLOUR, MAX_COLOUR); reader.expect(' '); int blue = MathHelper.clamp(reader.readInt(), MIN_COLOUR, MAX_COLOUR);reader.expect(' ');  int alpha = MathHelper.clamp(reader.readInt(), 1, MAX_COLOUR);reader.expect(' '); float diameter = reader.readFloat();  return new Juan1ParticalData(new Vector3d(speedX, speedY, speedZ), new Color(red, green, blue, alpha), diameter); } @Override public Juan1ParticalData read(ParticleType<Juan1ParticalData> particleTypeIn, PacketBuffer buffer) { final int MIN_COLOUR = 0; final int MAX_COLOUR = 255; double speedX = buffer.readDouble(); double speedY = buffer.readDouble(); double speedZ = buffer.readDouble(); int red = MathHelper.clamp(buffer.readInt(), MIN_COLOUR, MAX_COLOUR); int green = MathHelper.clamp(buffer.readInt(), MIN_COLOUR, MAX_COLOUR); int blue = MathHelper.clamp(buffer.readInt(), MIN_COLOUR, MAX_COLOUR); int alpha = MathHelper.clamp(buffer.readInt(), 1, MAX_COLOUR); float diameter = buffer.readFloat(); return new Juan1ParticalData(new Vector3d(speedX, speedY, speedZ), new Color(red, green, blue, alpha), diameter); } }; public Juan1ParticalData(Vector3d speed, Color color, float diameter) { this.speed = speed; this.color = color; this.diameter = diameter; } @Override public ParticleType<?> getType() { return Utils.ParticleRegistry.JUAN_1_PARTICLE.get(); } @Override public void write(PacketBuffer buffer) { buffer.writeDouble(this.speed.x); buffer.writeDouble(this.speed.y); buffer.writeDouble(this.speed.z); buffer.writeInt(this.color.getRed()); buffer.writeInt(this.color.getGreen()); buffer.writeInt(this.color.getBlue()); buffer.writeInt(this.color.getAlpha()); buffer.writeFloat(this.diameter); } @Override public String getParameters() { return String.format(Locale.ROOT, "%s %.2f %i %i %i %i %.2d %.2d %.2d", this.getType().getRegistryName(), diameter, color.getRed(), color.getGreen(), color.getBlue(), color.getAlpha(), speed.getX(), speed.getY(), speed.getZ()); } public Vector3d getSpeed() { return speed; } public Color getColor() { return color; } public float getDiameter() { return diameter; } }   public class Juan1Particle extends SpriteTexturedParticle { public Juan1Particle(ClientWorld world, double x, double y, double z, Vector3d speed, Color color, float diameter) { super(world, x, y, z, speed.x, speed.y, speed.z); maxAge = 100; setColor(color.getRed() / 255F,color.getGreen() / 255F,color.getBlue() / 255); this.setAlphaF(color.getAlpha()); final float PARTICLE_SCALE_FOR_ONE_METER = 0.1F; particleScale = PARTICLE_SCALE_FOR_ONE_METER * diameter; this.canCollide = true; } @Override public IParticleRenderType getRenderType(){ return IParticleRenderType.PARTICLE_SHEET_TRANSLUCENT; } }   public class Juan1ParticleFactory implements IParticleFactory<Juan1ParticalData> { private final IAnimatedSprite sprites; public Juan1ParticleFactory(IAnimatedSprite sprite) { this.sprites = sprite; } @Override public Particle makeParticle(Juan1ParticalData typeIn, ClientWorld worldIn, double x, double y, double z, double xSpeed, double ySpeed, double zSpeed) { Juan1Particle particle = new Juan1Particle(worldIn, x, y, z, typeIn.getSpeed(), typeIn.getColor(), typeIn.getDiameter()); particle.selectSpriteWithAge(sprites); return particle; } }
    • This is where I want to call the addParticle() method, it is in the livingTick() in an entity. But it shows no particle effect. @Override public void livingTick() { double x = rand.nextGaussian() * 0.02D; double y = rand.nextGaussian() * 0.02D; double z = rand.nextGaussian() * 0.02D; double px = this.getPosX() + 4.0D * rand.nextDouble() - 2.0D; double py = this.getPosY() + rand.nextDouble() - 0.5D; double pz = this.getPosZ() + 4.0D * rand.nextDouble() - 2.0D; world.addParticle(new Juan1ParticalData(new Vector3d(x, y, z), new Color(0xae6be2), 0), px, py, pz, x, y, z);  } When I change "new Juan1ParticalData(new Vector3d(x, y, z), new Color(0xae6be2), 0)" to "ParticleTypes.DRAGON_BREATH" , the particle effects appeared.
    • can you get any useful info from your crash reports?
    • I made a particle effect of my own, and I can only display the particle effect in the game through the command : /particle mymod:juan1particle 0 0 0 0 0 255 100 3.   When I want add the particle through World.addParticle(IParticleData particleData, double x, double y, double z, double xSpeed, double ySpeed, double zSpeed), it does not show at all.   But when I change the particleData Parameter from my particledata's instance to those in the ParticleTypes in the vanilla, It works without problem. So it seems that only my particle effect can't be added into the game, but those in the vanilla can be added.
    • Ok, so, that's really helpful. I guess i need to learn how to make a custom sound instance for my sound.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.