Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.12.2] armortick and playerdeath event on server


Cris16228
 Share

Recommended Posts

 

Hello, a couple of days ago I've tried to upload my mod on my server to play with friends but after some seconds using it I saw a lot of spam in console.

 

I don't know why but only with this armor I have problems, for example, the glowstone ones has the same check (and potion giver but checks glowstone armor) and it works without crash or console spam.

 

P.s. Help me with code inside spoilers because it adds these white lines random

 

Spoiler
 
 
 
Spoiler

@Override
	public void onArmorTick(World world, EntityPlayer player, ItemStack itemStack) {
		if (player.inventory.armorItemInSlot(0).isEmpty() && player.inventory.armorItemInSlot(1).isEmpty()
				&& player.inventory.armorItemInSlot(2).isEmpty() && player.inventory.armorItemInSlot(3).isEmpty()) {
			return;
		}
		if (player.inventory.armorItemInSlot(0).getItem() == InitItems.REDSTONE_BOOTS
				&& player.inventory.armorItemInSlot(1).getItem() == InitItems.REDSTONE_LEGGINGS
				&& player.inventory.armorItemInSlot(2).getItem() == InitItems.REDSTONE_CHESTPLATE
				&& player.inventory.armorItemInSlot(3).getItem() == InitItems.REDSTONE_HELMET) {
			if (!player.isPotionActive(Potion.getPotionById(1))) {
				player.addPotionEffect(new PotionEffect(Potion.getPotionById(1), Config.redstonearmorduration * 20,
						Config.redstonearmorlevel, false, false));
			}
		}
	}

 

Log:

Spoiler
 
 
 
Spoiler

[20:19:41] [Server thread/WARN] [net.minecraft.network.NetworkSystem]: Failed to handle packet for /**.**.**.**:*****
net.minecraft.util.ReportedException: Ticking player
	at net.minecraft.entity.player.EntityPlayerMP.func_71127_g(EntityPlayerMP.java:459) ~[oq.class:?]
	at net.minecraft.network.NetHandlerPlayServer.func_73660_a(NetHandlerPlayServer.java:173) ~[pa.class:?]
	at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher$1.func_73660_a(NetworkDispatcher.java:209) ~[NetworkDispatcher$1.class:?]
	at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:285) ~[gw.class:?]
	at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:180) [oz.class:?]
	at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:790) [MinecraftServer.class:?]
	at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:397) [nz.class:?]
	at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:668) [MinecraftServer.class:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526) [MinecraftServer.class:?]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_212]
Caused by: java.lang.NoSuchMethodError: net.minecraft.entity.player.InventoryPlayer.func_70440_f(I)Lnet/minecraft/item/ItemStack;
	at com.capitancold.myarmorplus.items.armor.redstone_armor.RedstoneHelmet.onArmorTick(RedstoneHelmet.java:55) ~[RedstoneHelmet.class:?]
	at net.minecraft.entity.player.InventoryPlayer.func_70429_k(InventoryPlayer.java:371) ~[aec.class:?]
	at net.minecraft.entity.player.EntityPlayer.func_70636_d(EntityPlayer.java:511) ~[aed.class:?]
	at net.minecraft.entity.EntityLivingBase.func_70071_h_(EntityLivingBase.java:2179) ~[vp.class:?]
	at net.minecraft.entity.player.EntityPlayer.func_70071_h_(EntityPlayer.java:234) ~[aed.class:?]
	at net.minecraft.entity.player.EntityPlayerMP.func_71127_g(EntityPlayerMP.java:382) ~[oq.class:?]
	... 9 more
[20:19:41] [Server thread/INFO] [net.minecraft.network.NetHandlerPlayServer]: ************ lost connection: Internal server error

 

The second one is when I use the revival potion (added by me).

 

Spoiler
 
 
 
Spoiler

@SubscribeEvent
	public static void onDeath(LivingDeathEvent event) {
		if (event.getEntityLiving() instanceof EntityPlayer) {
			EntityPlayer player = (EntityPlayer) event.getEntity();
			boolean isActive = false;
			boolean damageArmor = false;
			int min = Config.revivaldamagemin;
			int max = Config.revivaldamagemax;
			int randomDamage = random.nextInt(max - min + 1) + min;
			if (player.isPotionActive(InitPotions.REVIVAL_EFFECT))
				isActive = true;
			if (Config.revivaldamagearmor == true)
				damageArmor = true;

			if (isActive) {
				event.setCanceled(true);
				player.setHealth(0.5F);
				player.addPotionEffect(
						new PotionEffect(Potion.getPotionById(10), Config.potionduration * 20, Config.potionlevel));
			}
			if (damageArmor) { //From here the error.
				if (player.inventory.armorItemInSlot(0).getItem() == InitItems.ULTIMATE_BOOTS
						&& player.inventory.armorItemInSlot(1).getItem() == InitItems.ULTIMATE_LEGGINGS
						&& player.inventory.armorItemInSlot(2).getItem() == InitItems.ULTIMATE_CHESTPLATE
						&& player.inventory.armorItemInSlot(3).getItem() == InitItems.ULTIMATE_HELMET) {
					player.inventory.armorItemInSlot(0).damageItem(randomDamage, player);
					player.inventory.armorItemInSlot(1).damageItem(randomDamage, player);
					player.inventory.armorItemInSlot(2).damageItem(randomDamage, player);
					player.inventory.armorItemInSlot(3).damageItem(randomDamage, player);
				}
			}
		}
	}

 

Spoiler
 
 
 
Spoiler

@SubscribeEvent
	@Mod.EventHandler
	public void onPlayerDie(LivingDeathEvent event) {
		if (event.getEntityLiving() instanceof EntityPlayer) {
			EntityPlayer player = (EntityPlayer) event.getEntityLiving();
			ItemStack ring = BaublesApi.getBaublesHandler(player).getStackInSlot(RING);
			ItemStack ring2 = BaublesApi.getBaublesHandler(player).getStackInSlot(RING_DOWN);
			Random r = new Random();
			if (!ring.isEmpty() && ring.getItem() instanceof RingOfUndying) {
				event.setCanceled(true);
				player.setHealth(0.5F);
				player.addPotionEffect(new PotionEffect(Potion.getPotionById(10), 20 * 10, 1));
				if (r.nextInt(100) >= 5) {
					ring.damageItem(1, player);
				}
			}
			if (!ring2.isEmpty() && ring2.getItem() instanceof RingOfUndying) {
				event.setCanceled(true);
				player.setHealth(0.5F);
				player.addPotionEffect(new PotionEffect(Potion.getPotionById(10), 20 * 10, 1));
				if (r.nextInt(100) >= 5) {
					ring2.damageItem(1, player);
				}
			}
		}
	}

 

 
 
 
Spoiler
 
 
 
Spoiler

20:39:11] [Server thread/ERROR] [FML]: Exception caught during firing event net.minecraftforge.event.entity.living.LivingDeathEvent@3eddbdf0:
java.lang.NoSuchMethodError: net.minecraft.entity.player.InventoryPlayer.func_70440_f(I)Lnet/minecraft/item/ItemStack;
	at com.capitancold.myarmorplus.potions.revival.EventHandler.onDeath(EventHandler.java:41) ~[EventHandler.class:?]
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_10_EventHandler_onDeath_LivingDeathEvent.invoke(.dynamic) ~[?:?]
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) ~[ASMEventHandler.class:?]
	at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:182) [EventBus.class:?]
	at net.minecraftforge.common.ForgeHooks.onLivingDeath(ForgeHooks.java:609) [ForgeHooks.class:?]
	at net.minecraft.entity.player.EntityPlayerMP.func_70645_a(EntityPlayerMP.java:474) [oq.class:?]
	at net.minecraft.entity.EntityLivingBase.func_70097_a(EntityLivingBase.java:1023) [vp.class:?]
	at net.minecraft.entity.player.EntityPlayer.func_70097_a(EntityPlayer.java:1038) [aed.class:?]
	at net.minecraft.entity.player.EntityPlayerMP.func_70097_a(EntityPlayerMP.java:645) [oq.class:?]
	at net.minecraft.entity.EntityLivingBase.func_174812_G(EntityLivingBase.java:159) [vp.class:?]
	at net.minecraft.command.CommandKill.func_184881_a(SourceFile:35) [cp.class:?]
	at net.minecraft.command.CommandHandler.func_175786_a(CommandHandler.java:119) [bj.class:?]
	at net.minecraft.command.CommandHandler.func_71556_a(CommandHandler.java:91) [bj.class:?]
	at net.minecraft.network.NetHandlerPlayServer.func_147361_d(NetHandlerPlayServer.java:960) [pa.class:?]
	at net.minecraft.network.NetHandlerPlayServer.func_147354_a(NetHandlerPlayServer.java:939) [pa.class:?]
	at net.minecraft.network.play.client.CPacketChatMessage.func_148833_a(SourceFile:37) [la.class:?]
	at net.minecraft.network.play.client.CPacketChatMessage.func_148833_a(SourceFile:9) [la.class:?]
	at net.minecraft.network.PacketThreadUtil$1.run(SourceFile:13) [hv$1.class:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_212]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_212]
	at net.minecraft.util.Util.func_181617_a(SourceFile:46) [h.class:?]
	at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:723) [MinecraftServer.class:?]
	at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:397) [nz.class:?]
	at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:668) [MinecraftServer.class:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526) [MinecraftServer.class:?]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_212]
[20:39:11] [Server thread/ERROR] [FML]: Index: 1 Listeners:
[20:39:11] [Server thread/ERROR] [FML]: 0: NORMAL
[20:39:11] [Server thread/ERROR] [FML]: 1: ASM: class com.capitancold.myarmorplus.potions.revival.EventHandler onDeath(Lnet/minecraftforge/event/entity/living/LivingDeathEvent;)V
[20:39:11] [Server thread/ERROR] [FML]: 2: ASM: com.capitancold.myarmorplus.items.items.rings.events.Events@6e48361b onPlayerDie(Lnet/minecraftforge/event/entity/living/LivingDeathEvent;)V
[20:39:11] [Server thread/WARN] [net.minecraft.command.CommandHandler]: Couldn't process command: kill
java.lang.NoSuchMethodError: net.minecraft.entity.player.InventoryPlayer.func_70440_f(I)Lnet/minecraft/item/ItemStack;
	at com.capitancold.myarmorplus.potions.revival.EventHandler.onDeath(EventHandler.java:41) ~[EventHandler.class:?]
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_10_EventHandler_onDeath_LivingDeathEvent.invoke(.dynamic) ~[?:?]
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) ~[ASMEventHandler.class:?]
	at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:182) ~[EventBus.class:?]
	at net.minecraftforge.common.ForgeHooks.onLivingDeath(ForgeHooks.java:609) ~[ForgeHooks.class:?]
	at net.minecraft.entity.player.EntityPlayerMP.func_70645_a(EntityPlayerMP.java:474) ~[oq.class:?]
	at net.minecraft.entity.EntityLivingBase.func_70097_a(EntityLivingBase.java:1023) ~[vp.class:?]
	at net.minecraft.entity.player.EntityPlayer.func_70097_a(EntityPlayer.java:1038) ~[aed.class:?]
	at net.minecraft.entity.player.EntityPlayerMP.func_70097_a(EntityPlayerMP.java:645) ~[oq.class:?]
	at net.minecraft.entity.EntityLivingBase.func_174812_G(EntityLivingBase.java:159) ~[vp.class:?]
	at net.minecraft.command.CommandKill.func_184881_a(SourceFile:35) ~[cp.class:?]
	at net.minecraft.command.CommandHandler.func_175786_a(CommandHandler.java:119) [bj.class:?]
	at net.minecraft.command.CommandHandler.func_71556_a(CommandHandler.java:91) [bj.class:?]
	at net.minecraft.network.NetHandlerPlayServer.func_147361_d(NetHandlerPlayServer.java:960) [pa.class:?]
	at net.minecraft.network.NetHandlerPlayServer.func_147354_a(NetHandlerPlayServer.java:939) [pa.class:?]
	at net.minecraft.network.play.client.CPacketChatMessage.func_148833_a(SourceFile:37) [la.class:?]
	at net.minecraft.network.play.client.CPacketChatMessage.func_148833_a(SourceFile:9) [la.class:?]
	at net.minecraft.network.PacketThreadUtil$1.run(SourceFile:13) [hv$1.class:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_212]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_212]
	at net.minecraft.util.Util.func_181617_a(SourceFile:46) [h.class:?]
	at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:723) [MinecraftServer.class:?]
	at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:397) [nz.class:?]
	at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:668) [MinecraftServer.class:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526) [MinecraftServer.class:?]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_212]

 

 

The last one (optional because probably I remove the armor) is this:

This is my InitItems

if (Config.enablelapisarmor) {
			LAPIS_HELMET = new LapisHelmet("lapis_helmet", LAPIS_ARMOR, 1, EntityEquipmentSlot.HEAD);
			LAPIS_CHESTPLATE = new LapisChestplate("lapis_chestplate", LAPIS_ARMOR, 1, EntityEquipmentSlot.CHEST);
			LAPIS_LEGGINGS = new LapisLeggings("lapis_leggings", LAPIS_ARMOR, 2, EntityEquipmentSlot.LEGS);
			LAPIS_BOOTS = new LapisBoots("lapis_boots", LAPIS_ARMOR, 1, EntityEquipmentSlot.FEET);
		}

This is the log (I use json recipes)

[20:14:13] [Server thread/ERROR] [FML]: Parsing error loading recipe myarmorplus:lapis_leggings
com.google.gson.JsonSyntaxException: Unknown item 'myarmorplus:lapis_leggings'
	at net.minecraftforge.common.crafting.CraftingHelper.getItemStack(CraftingHelper.java:213) ~[CraftingHelper.class:?]
	at net.minecraftforge.common.crafting.CraftingHelper.lambda$init$14(CraftingHelper.java:517) ~[CraftingHelper.class:?]
	at net.minecraftforge.common.crafting.CraftingHelper.getRecipe(CraftingHelper.java:410) ~[CraftingHelper.class:?]
	at net.minecraftforge.common.crafting.CraftingHelper.lambda$loadRecipes$22(CraftingHelper.java:706) ~[CraftingHelper.class:?]
	at net.minecraftforge.common.crafting.CraftingHelper.findFiles(CraftingHelper.java:816) ~[CraftingHelper.class:?]
	at net.minecraftforge.common.crafting.CraftingHelper.loadRecipes(CraftingHelper.java:671) ~[CraftingHelper.class:?]
	at java.util.ArrayList.forEach(ArrayList.java:1257) [?:1.8.0_212]
	at net.minecraftforge.common.crafting.CraftingHelper.loadRecipes(CraftingHelper.java:621) [CraftingHelper.class:?]
	at net.minecraftforge.fml.common.Loader.initializeMods(Loader.java:742) [Loader.class:?]
	at net.minecraftforge.fml.server.FMLServerHandler.finishServerLoading(FMLServerHandler.java:108) [FMLServerHandler.class:?]
	at net.minecraftforge.fml.common.FMLCommonHandler.onServerStarted(FMLCommonHandler.java:338) [FMLCommonHandler.class:?]
	at net.minecraft.server.dedicated.DedicatedServer.func_71197_b(DedicatedServer.java:219) [nz.class:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:486) [MinecraftServer.class:?]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_212]

 

Edited by Cris16228
mess with spoilers
Link to comment
Share on other sites

  • InventoryPlayer#armorItemInSlot is annotated with @SideOnly(Side.CLIENT). This means it only exists on the physical client and cannot be used on a server (see the documentation for Sides for more information). Use EntityLivingBase#getItemStackFromSlot instead.
  • Do not register items conditionally. All items (and blocks and other registry entries) must always be registered.
Link to comment
Share on other sites

 
 
 
2 minutes ago, diesieben07 said:
  • InventoryPlayer#armorItemInSlot is annotated with @SideOnly(Side.CLIENT). This means it only exists on the physical client and cannot be used on a server (see the documentation for Sides for more information). Use EntityLivingBase#getItemStackFromSlot instead.

But why only this armor has problems? I'll add the client side. Thanks

 
 
 
2 minutes ago, diesieben07 said:
  • Do not register items conditionally. All items (and blocks and other registry entries) must always be registered.

How to disable them with a boolean like I did then?

Link to comment
Share on other sites

3 minutes ago, Cris16228 said:

I can't edit the post... I dont know why...

I don't know what you did, but there are some hidden very big elements in your post that somehow cover up the site... 

 

6 minutes ago, Cris16228 said:

How to disable them with a boolean like I did then?

You don't. You can hide items from creative tabs and disable their recipes. Do not remove items.

 

4 minutes ago, Cris16228 said:

I saw now that only this armor doesn't have the "@SideOnly(Side.CLIENT)"

I don't know what you mean by this. The method you are using is always client-only. It is not dependent on the type of armor.

Link to comment
Share on other sites

 
 
 
1 minute ago, diesieben07 said:

I don't know what you did, but there are some hidden very big elements in your post that somehow cover up the site... 

Nice question... I just do: Insert spoiler > Insert code > I add the code and Its all okay, I submit the reply I see blank elements

 

 
 
 
2 minutes ago, diesieben07 said:

You don't. You can hide items from creative tabs and disable their recipes. Do not remove items.

Nice, I need to find a way to disable recipes.

 

 
 
 
2 minutes ago, diesieben07 said:

I don't know what you mean by this. The method you are using is always client-only. It is not dependent on the type of armor.

I saw that my "onArmorTick" for redstone armor had only the override without the ClientSide.

 

Link to comment
Share on other sites

8 minutes ago, Cris16228 said:

Nice, I need to find a way to disable recipes.

You can use Forge's conditions feature.

 

9 minutes ago, Cris16228 said:

I saw that my "onArmorTick" for redstone armor had only the override without the ClientSide.

I have no idea how this is relevant to this question at all.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Hi So Im trying to set up a Server for 1.16.4 now but when I go to launch it doesn't work, Im using the Life in the Village 2 server pack thats already pre-made but it still wont launch no matter what I try. If I can get some help that would be great thanks. D:\Modded Mc\LITV2-Serverpack-1.28a\LITV2-Serverpack-1.28a>java -Xmx4G -jar forge-1.16.5-36.2.4.jar nogui 2021-11-29 13:43:08,050 main WARN Advanced terminal features are not available in this environment [13:43:08] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher running: args [--gameDir, ., --launchTarget, fmlserver, --fml.forgeVersion, 36.2.4, --fml.mcpVersion, 20210115.111550, --fml.mcVersion, 1.16.5, --fml.forgeGroup, net.minecraftforge, nogui] [13:43:08] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher 8.0.9+86+master.3cf110c starting: java version 16.0.2 by Oracle Corporation Exception in thread "main" java.lang.IllegalAccessError: class cpw.mods.modlauncher.SecureJarHandler (in unnamed module @0x4de5031f) cannot access class sun.security.util.ManifestEntryVerifier (in module java.base) because module java.base does not export sun.security.util to unnamed module @0x4de5031f at cpw.mods.modlauncher.SecureJarHandler.lambda$static$1(SecureJarHandler.java:41) at cpw.mods.modlauncher.api.LamdbaExceptionUtils.uncheck(LamdbaExceptionUtils.java:95) at cpw.mods.modlauncher.SecureJarHandler.<clinit>(SecureJarHandler.java:41) at cpw.mods.modlauncher.Launcher.lambda$new$6(Launcher.java:55) at java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1708) at cpw.mods.modlauncher.api.TypesafeMap.computeIfAbsent(TypesafeMap.java:52) at cpw.mods.modlauncher.api.TypesafeMap.computeIfAbsent(TypesafeMap.java:47) at cpw.mods.modlauncher.Environment.computePropertyIfAbsent(Environment.java:62) at cpw.mods.modlauncher.Launcher.<init>(Launcher.java:55) at cpw.mods.modlauncher.Launcher.main(Launcher.java:66) at net.minecraftforge.server.ServerMain$Runner.runLauncher(ServerMain.java:63) at net.minecraftforge.server.ServerMain$Runner.access$100(ServerMain.java:60) at net.minecraftforge.server.ServerMain.main(ServerMain.java:57) D:\Modded Mc\LITV2-Serverpack-1.28a\LITV2-Serverpack-1.28a>pause Press any key to continue . . .  
    • Still waiting on the issue.
    • Registering in static fields isn't ideal. You have a method that registers your deferred register to the event bus, right? leave your RegistryObject fields as non-final and empty, and set their reference in that method, right after registering the deferred register on the bus.
    • This is my event: p.s i tried the subclasses.   Above this line, I am also registering my GUI event listener with RenderGameOverlay, which works fine.  
    • Thanks. But I thought they would help me decide on the code. (((    As a result, I figured it out myself.   private static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, MODID); public static final RegistryObject<BlockItem> MyBlockItem = ITEMS.register("mysuperblockreg", () -> new BlockItem(testBlock, new Item.Properties().tab(CreativeModeTab.TAB_BUILDING_BLOCKS)));  
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.