Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[Solved] [1.13.2] Why is this code not working?


Recommended Posts

I wrote this code, but test_item don't drops when i break a gravel with a stick in mainhand. What's wrong?

		if ((event.getState().getBlock() instanceof BlockGravel)) {
			if (event.getHarvester() != null) {
				ItemStack tool = event.getHarvester().getHeldItemMainhand();
				ItemStack item = new ItemStack(Items.STICK);
				if (tool == item) {
					event.getDrops().add(new ItemStack(ItemList.test_item, 1));
					event.setDropChance((float) 0.8);
				}
			}
		}

 

Edited by Tameet
Link to post
Share on other sites

You've created two different instance of ItemStack. They don't double equal "==".

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to post
Share on other sites

Try this:

if ((event.getState().getBlock() instanceof BlockGravel)) {
	if (event.getHarvester() != null) {
		Item tool = event.getHarvester().getHeldItemMainhand().getItem();
		if (tool == Items.STICK) {
			event.getDrops().add(new ItemStack(ItemList.test_item, 1));
			event.setDropChance((float) 0.8);
		}
	}
}

 

Link to post
Share on other sites
13 minutes ago, TheOnlyTrueEnte said:

Try this:


if ((event.getState().getBlock() instanceof BlockGravel)) {
	if (event.getHarvester() != null) {
		Item tool = event.getHarvester().getHeldItemMainhand().getItem();
		if (tool == Items.STICK) {
			event.getDrops().add(new ItemStack(ItemList.test_item, 1));
			event.setDropChance((float) 0.8);
		}
	}
}

 

Many thanks

Link to post
Share on other sites

In java "==" does mean something different than in other languages, "==" compares if both references reference the same instance, if you wanna compare if 2 objects are equal, you can use .equals() method or as provided by Forge a reference to the registered Item/Block in Items.<name of block>, Blocks.<name of block> ( note that as pointed out by @TheOnlyTrueEnte you can use == here because the getItem() method you're using returns a reference to some item in Items or your custom item list not a new instance of that item)

Link to post
Share on other sites
3 hours ago, TheOnlyTrueEnte said:

Try this:


if ((event.getState().getBlock() instanceof BlockGravel)) {
	if (event.getHarvester() != null) {
		Item tool = event.getHarvester().getHeldItemMainhand().getItem();
		if (tool == Items.STICK) {
			event.getDrops().add(new ItemStack(ItemList.test_item, 1));
			event.setDropChance((float) 0.8);
		}
	}
}

 

Please do not post copy-pastable code like this. Others might copy it without learning anything.

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.