[1.14.2] Registering TileEntites

[TehStoneMan]

How are TIleEntites registered in 1.14.2? I have tried whatever examples I could find, but I am still getting "missing mapping" errors.

[Dipo]

Can u show full error log ?

[Cadiboo]

Also post your code.

Heres an example of registration that works perfectly https://github.com/Cadiboo/Example-Mod/blob/d828cd29685f7732cac6a2a8cd0f5cbfee5d6e88/src/main/java/io/github/cadiboo/examplemod/ModEventSubscriber.java#L106-L118 

Edited June 25, 2019 by Cadiboo

[TehStoneMan]

TileEntity

public class TileEntityLocker extends TileEntityLockable
{
	public TileEntityLocker()
	{
		super( BetterStorageTileEntityTypes.LOCKER );
	}
}

Registering

@Mod.EventBusSubscriber( bus = Mod.EventBusSubscriber.Bus.MOD )
public class RegistryEventHandler
{
	....
	@SubscribeEvent
	public static void onTileEntityRegistry( final RegistryEvent.Register< TileEntityType< ? > > event )
	{
		final IForgeRegistry< TileEntityType< ? > > registry = event.getRegistry();
		
		registry.register( TileEntityType.Builder.create( TileEntityLocker::new ).build( null ).setRegistryName( ModInfo.MOD_ID, "locker" ) );
	}
}

Error

[20:09:38.492] [Server thread/ERROR] [minecraft/Chunk]: A TileEntity type io.github.tehstoneman.betterstorage.common.tileentity.TileEntityLocker has thrown an exception trying to write state. It will not persist, Report this to the mod author
java.lang.RuntimeException: class io.github.tehstoneman.betterstorage.common.tileentity.TileEntityLocker is missing a mapping! This is a bug!
	at net.minecraft.tileentity.TileEntity.writeInternal(TileEntity.java:63) ~[?:?] {pl:accesstransformer:B}
	at net.minecraft.tileentity.TileEntity.write(TileEntity.java:57) ~[?:?] {pl:accesstransformer:B}
	at net.minecraft.world.chunk.Chunk.func_223134_j(Chunk.java:431) ~[?:?] {}
	at net.minecraft.world.chunk.storage.ChunkSerializer.write(ChunkSerializer.java:302) ~[?:?] {}
	at net.minecraft.world.chunk.ChunkManager.func_219229_a(ChunkManager.java:660) ~[?:?] {}
	at java.util.stream.ReferencePipeline$2$1.accept(Unknown Source) [?:1.8.0_211] {}
	at java.util.stream.ReferencePipeline$2$1.accept(Unknown Source) [?:1.8.0_211] {}
	at java.util.stream.ReferencePipeline$3$1.accept(Unknown Source) [?:1.8.0_211] {}
	at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(Unknown Source) [?:1.8.0_211] {}
	at java.util.stream.AbstractPipeline.copyInto(Unknown Source) [?:1.8.0_211] {}
	at java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source) [?:1.8.0_211] {}
	at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(Unknown Source) [?:1.8.0_211] {}
	at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(Unknown Source) [?:1.8.0_211] {}
	at java.util.stream.AbstractPipeline.evaluate(Unknown Source) [?:1.8.0_211] {}
	at java.util.stream.ReferencePipeline.forEach(Unknown Source) [?:1.8.0_211] {}
	at net.minecraft.world.chunk.ChunkManager.save(ChunkManager.java:319) [?:?] {}
	at net.minecraft.world.chunk.ServerChunkProvider.save(SourceFile:277) [?:?] {pl:accesstransformer:B}
	at net.minecraft.world.ServerWorld.save(ServerWorld.java:733) [?:?] {pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.save(MinecraftServer.java:501) [?:?] {pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.stopServer(MinecraftServer.java:541) [?:?] {pl:accesstransformer:B}
	at net.minecraft.server.integrated.IntegratedServer.stopServer(IntegratedServer.java:210) [?:?] {pl:runtimedistcleaner:A}
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:646) [?:?] {pl:accesstransformer:B}
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_211] {}

 

[Cadiboo]

Place a breakpoint in the writeInternal method and check variables. Also make sure that  BetterStorageTileEntityTypes.LOCKER is getting properly filled with @ObjectHolder

[TehStoneMan]

What is @ObjectHolder?

[Cadiboo]

The thing that I’m assuming you’re using to fill BetterStorageTileEntityTypes.LOCKER. Please post the entire BetterStorageTileEntityTypes class. 

 

Info on @ObjectHolder: https://mcforge.readthedocs.io/en/latest/concepts/registries/#injecting-registry-values-into-fields

[TehStoneMan]

Here:

package io.github.tehstoneman.betterstorage.common.tileentity;

import net.minecraft.tileentity.TileEntityType;

public final class BetterStorageTileEntityTypes
{
	public static TileEntityType< TileEntityCrate >				CRATE;
	public static TileEntityType< TileEntityReinforcedChest >	REINFORCED_CHEST;
	public static TileEntityType< TileEntityLocker >			LOCKER;
	public static TileEntityType< TileEntityReinforcedLocker >	REINFORCED_LOCKER;
}

I guess @ObjectHolder is something new to me - I have not seen it before.

[desht]

56 minutes ago, TehStoneMan said:

Here:

package io.github.tehstoneman.betterstorage.common.tileentity;

import net.minecraft.tileentity.TileEntityType;

public final class BetterStorageTileEntityTypes
{
	public static TileEntityType< TileEntityCrate >				CRATE;
	public static TileEntityType< TileEntityReinforcedChest >	REINFORCED_CHEST;
	public static TileEntityType< TileEntityLocker >			LOCKER;
	public static TileEntityType< TileEntityReinforcedLocker >	REINFORCED_LOCKER;
}

I guess @ObjectHolder is something new to me - I have not seen it before.

Nope, @ObjectHolder is not new - it's been around since 1.10.  Read https://mcforge.readthedocs.io/en/latest/concepts/registries/ (although it's written for 1.12.2, the concepts still apply in 1.14+).

 

Learn it, use it - it's the Right Way to do things with Forge, especially in 1.14 where so many more things are in registries.

[TehStoneMan]

First off, I said that it is new to -->ME<--, and how would I learn to use something that I did not know even exists when everything I have done up to now has worked without any reference to things that I may be missing?

[Cadiboo]

10 hours ago, TehStoneMan said:

Here:

package io.github.tehstoneman.betterstorage.common.tileentity;

import net.minecraft.tileentity.TileEntityType;

public final class BetterStorageTileEntityTypes
{
	public static TileEntityType< TileEntityCrate >				CRATE;
	public static TileEntityType< TileEntityReinforcedChest >	REINFORCED_CHEST;
	public static TileEntityType< TileEntityLocker >			LOCKER;
	public static TileEntityType< TileEntityReinforcedLocker >	REINFORCED_LOCKER;
}

I guess @ObjectHolder is something new to me - I have not seen it before.

These fields are never set to anything, so they are always null when used. @ObjectHolder would fill these values for you if you used it https://github.com/Cadiboo/Example-Mod/blob/1.14.2/src/main/java/io/github/cadiboo/examplemod/init/ModTileEntityTypes.java

[TehStoneMan]

Thank you. I was wondering about that since the method I used to set them up in 1.13 seems to be no longer available.