[1.12.2] onBlockActivated Not Working?

[ssbbpeople]

Hi,

 

I've recently finished the classes for my BlockGrinder, but onBlockActivated seems to not be firing when I right-click the block. When I right-click it, absolutely nothing happens.

Here's the code:
 

	//When right-clicked
	   @Override
	    public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn, EnumHand hand, EnumFacing facing, float hitX, float hitY, float hitZ)
	    {
		   if(worldIn.isRemote) {
			   return true;
		   }
	            final TileEntity tileentity = worldIn.getTileEntity(pos);

	            if (tileentity instanceof TileGrinder)
	            {
	            	playerIn.openGui(Main.instance, ModGuiHandler.MOD_GRINDER, worldIn, pos.getX(), pos.getY(), pos.getZ());
	                playerIn.addStat(StatList.FURNACE_INTERACTION);
	            }

	            return true;
	    }

 

I used the BlockFurnace class as reference for this method, but it doesn't open the GUI nor make the player right-click animation for the block

[sunsigne]

This should probably be helping you : https://github.com/sunsigne/Sunsigne

 

It's a mod i created 6 months ago in 1.12.2 and there is a fully fonctionnal "centrifuge", whose the fonction might be similar to your grinder

[ssbbpeople]

Thank you! I got the onBlockActivated method functioning correctly. Now I just have two smelting bugs... it instantly smelts items, even when there's no fuel

[Animefan8888]

45 minutes ago, ssbbpeople said:

Thank you! I got the onBlockActivated method functioning correctly. Now I just have two smelting bugs... it instantly smelts items, even when there's no fuel

Not sure if you are asking for help or not...but if you want help we need to see the code for your TE.

[ssbbpeople]

Yes, sorry I forgot to link my GitHub. Here's the link:
https://github.com/SpookyBarca/Metallurgy

All my Grinder files are in the same package.

[Animefan8888]

21 minutes ago, ssbbpeople said:

Yes, sorry I forgot to link my GitHub. Here's the link:
https://github.com/SpookyBarca/Metallurgy

All my Grinder files are in the same package.

You never ever check if the time passed smelting is high enough and you also never check if the furnace has fuel in your trySmeltItem method.

[ssbbpeople]

How can I check that in the trySmeltItem if there's no boolean? I thought I already checked that with boolean isItemValid method

[Animefan8888]

56 minutes ago, ssbbpeople said:

How can I check that in the trySmeltItem if there's no boolean? I thought I already checked that with boolean isItemValid method

if (this.smeltTime >= this.maxSmeltTime)

 

Edited July 24, 2019 by Animefan8888
Using the code block.

[ssbbpeople]

Okay, I inserted the code:

	private void trySmeltItem(){
		
		if (this.smeltTime >= this.maxSmeltTime) {
			return;
		}
...

And the bug still remains :-/

[Animefan8888]

12 minutes ago, ssbbpeople said:

Okay, I inserted the code:

	private void trySmeltItem(){
		
		if (this.smeltTime >= this.maxSmeltTime) {
			return;
		}
...

And the bug still remains ?

No that is not what I said. You need to actually smelt the item when that condition is true.

[ssbbpeople]

Oh okay. So I rearranged it like this:

        if (this.canSmeltItem())
        {
        	
    		if (this.smeltTime >= this.maxSmeltTime) {
    			return;
    		}

 

The bug occurs, but its under the if statement canSmeltItem

[Animefan8888]

Just now, ssbbpeople said:

Oh okay. So I rearranged it like this:

        if (this.canSmeltItem())
        {
        	
    		if (this.smeltTime >= this.maxSmeltTime) {
    			return;
    		}

 

The bug occurs, but its under the if statement canSmeltItem

Do you know the Java language or is Minecraft Modding your first venture?

[ssbbpeople]

I'm starting to learn Java, I made the mistake of going to modding tutorials first

[Draco18s]

Look at the if-statement.

Consider likely values.

Compute the outcome in your head.

 

If that fails, use the debugger.

[Animefan8888]

2 minutes ago, ssbbpeople said:

I'm starting to learn Java, I made the mistake of going to modding tutorials first

Yes, yes you have. You should probably get some programming experience first. Or if you are dead set on doing this you won't really get help here because we don't like to have to teach Java to people.

[ssbbpeople]

I understand that. I'm sort of in a time crunch, so I figured going for tutorials would be the fastest way, for now. In the future/now I'll study more on java