Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

HarvestDropsEvent not working as expected.


Andrew Murdza
 Share

Recommended Posts

I'm making a mod for 1.14.4 which affects the drops of blocks depending on the biome at the location where they were harvested. I think that the best way to do this is with the HarvestDropsEvent. The problem is that my HarvestDropEvent method does not get called when I mine a sand block with a diamond shovel in survival on a test world. I could use the OnBlockBreakEvent method (which does get called under the same situation) but I only want the additional drops to be added if the conditions of the harvest drops event are satisfied and the tool is not a silk-touch tool. Note that I have strange code inside of both methods because I first want to make sure I get the onEvent method to fire and then I will replace the inside code with things relevant to my mod.

 

Please tell if there is a way to get the onEvent method to be called when I harvest blocks like wheat, melons, ores, etc.

 

My code is below:

 

 
 
 
 
Spoiler

package com.amurdza.aoemod.blocks;

import java.util.List;
import java.util.logging.*;

import com.amurdza.aoemod.LoggerClass;

import net.minecraft.block.Block;
import net.minecraft.block.Blocks;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.item.Items;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraftforge.event.world.BlockEvent;
import net.minecraftforge.event.world.BlockEvent.HarvestDropsEvent;
import net.minecraftforge.eventbus.api.EventPriority;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;

@EventBusSubscriber
public class BlockEventHandler {

    private static final Logger logger=LoggerClass.logSetup();
    @SubscribeEvent
    public static void OnBlockBreakEvent(BlockEvent.BreakEvent event) {
        Block block=event.getState().getBlock();
        logger.info("this ran");
        World worldIn=event.getWorld().getWorld();
        BlockPos pos=event.getPos();
        PlayerEntity player=event.getPlayer();
        
        Item activeItem=player.getHeldItemMainhand().getItem();
        //if(activeItem.canHarvestBlock(event.getState())) {
            logger.info("this ran 1");
            if(!activeItem.equals(Items.SHEARS)) {
                logger.info("this ran 2");
                if(!player.isCreative()) {
                    logger.info("this ran 3");
                    
                }
            }
        //}
        
        Block.spawnAsEntity(worldIn, pos, new ItemStack(Items.GOLD_INGOT,4));        
        if(block.equals(Blocks.JUNGLE_LEAVES)) {
            logger.info("this ran 2");
            World worldIn1=event.getWorld().getWorld();
            BlockPos pos1=event.getPos();
            Block.spawnAsEntity(worldIn1, pos1, new ItemStack(Items.JUNGLE_SAPLING,4));
        }
    }
    
    
    @SubscribeEvent(priority=EventPriority.NORMAL, receiveCanceled=true)
    public static void onEvent(HarvestDropsEvent event) {
        List<ItemStack> drops=event.getDrops();
        logger.info("this ran");
        if(drops.contains(new ItemStack(Items.SAND,1))) {
            logger.info("this ran 2");
            World worldIn=event.getWorld().getWorld();
            BlockPos pos=event.getPos();
            Block.spawnAsEntity(worldIn, pos, new ItemStack(Items.GOLD_INGOT,4));        
        }
    }
}

 

Thanks, Andrew Murdza

Link to comment
Share on other sites

5 hours ago, Andrew Murdza said:

@EventBusSubscriber

You need to provide the bus in the annotation. It needs to be Bus.FORGE I believe.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

2 hours ago, Animefan8888 said:

You need to provide the bus in the annotation. It needs to be Bus.FORGE I believe.

Bus.FORGE is the default, so it doesn't need to be specified manually.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

10 minutes ago, Choonster said:

Bus.FORGE is the default, so it doesn't need to be specified manually.

Right.

 

8 hours ago, Andrew Murdza said:

logger.info("this ran");

Does this log statement run?

 

8 hours ago, Andrew Murdza said:

 if(drops.contains(new ItemStack(Items.SAND,1))) {

This is probably your problem. Your asking if a new instance of ItemStack is in the drops list. That doesn't work.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

The log statements in OnBlockBreak all run, while the log statement in the HarvestDropsEvent does not. This means that the if statement is not reached.

 

How could I change the if statement so that it would work? (This is something I would have to deal with after I get the HarvestDropsEvent to fire)

 

Thanks, Andrew Murdza

 

Link to comment
Share on other sites

  • 5 months later...

I'm using the latest Forge MDK for 1.15.2 and the HarvestDropsEvent event sill isn't being fired. Other types of BlockEvent are fired. I used Eclipse to search for references, and found that while there IS a method that posts the HarvestDropsEvent, that method is never called. Basically the event is never fired unless fired by a mod. I think this is a bug.

Link to comment
Share on other sites

And modifications to such are still being worked on.

https://github.com/MinecraftForge/MinecraftForge/pull/6401

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

  • 1 month later...

I am now making a mod for 1.15 I would like to know when the event comes to forge 1.15. I went to the link Draco18s provided and it seems that there is no project or milestone. I subscribed to that github thread, but I was wondering if anyone has a time estimate for the number of months before it gets added.

Link to comment
Share on other sites

image.png.5054d07afbb8a71a013f93df8d300062.png

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Register your own IRecipeSerializer. It is registered like any other registry entry. However note that you should have as much as possible in the JSON. Don't just have a placeholder JSON file and then hardcode all the logic in code. That defeats the point of datapacks. You'll have to have your own repair recipe then (see above for how to make your own serializer) and override getRemainingItems. If the knife is your item, override hasContainerItem and getContainerItem in your Item class. If the knife is not your item, refer to the section about repairing. Use a GlobalLootModifier.
    • So, im kinda new to modding. Trying to make relatively complicated mod(as I see now, it breaks the api a little bit...), and faced into some problems, especially with crafting. I think I should tell a little bit about my mod, you actually can skip this part, but if you don't get something, i strongly suggest to read this part. The goal i'm chasing is to implement similar food mechanics to TFC classic(1.7.10) mechanics. In a nutshell, it's food with durrability, and when you eat, you consume as much as you need(like if you have a steak and 1 hunger, if you eat it, stake's potential wastes, in case of my mod, it shouldn't). That's it, that's already done(with little bugs thou, but done). Now I have to do crafting somehow, using that items and modify durability while crafting. And it doesn't seems to be easy.     And.. question 1 will be: is it possible to hardcode crafts in 1.16.5? I know.. it's kinda not beautifull, but I really hate the json system. I've made as much crafts as possible by using it, but now, when I need to implement some logic, it's such a headache.   2. This question is about repearing. I mean, placing two damaged items in recipe grid. If you add 2 8/10 items, you'll get just one 10/10 item, and nothing more. I'd like 6/10 item to apear in grid after crafting. 3. Also there should be a recipe for extracting seeds with knife(i don't like to loose knife and whole peace of crop after craft). 4. And the last one. Well, I should change drop of crops if it's broken by special tool. I know, it's possible to do it by adding harvest tools, but I can't modify vanilla crops(maybe only by reflection..). Seems like it's reasonable to use onBlockBroken event, or something like that, but I keep finding deprecated code examples in google, and it doesn't work for me. Maybe there is a better solution.   About crafts.. I tried to figure out how CraftSerializers works, and i think it might be a good solution for that crafting stuff. But don't understand how to bind the serializer to regular minecraft crafting. Tried to read ShapelessRecipe class, but don't understand what happens in mathes, so cant do any assumptions how should I modify it. 
    • IP: Play.EpicLandCraft.Com Version: Cualquiera
    • What Im trying to do is to implement a "dash" mechanic on a Shift button.   @SubscribeEvent public static void onEvent(InputEvent.KeyInputEvent event){ KeyBinding runBinding = Minecraft.getInstance().gameSettings.keyBindSprint; int key = event.getKey(); int runKey = runBinding.getKey().getKeyCode(); ClientPlayerEntity player = Minecraft.getInstance().player; if (key == runKey){ //some checks, and then: float yaw = player.rotationYaw; float x = -MathHelper.sin(yaw * 0.017453292F); float z = MathHelper.cos(yaw * 0.017453292F); double groundMotion = 5, airMotion = 2; if (player.isOnGround()) player.setMotion(new Vector3d(x * groundMotion, 0, z * groundMotion)); else player.setMotion(new Vector3d(x * airMotion, 0, z * airMotion)); } } And this code works. The problem is, it causes a lot of lag when the setMotion() is called - my fps drops from 60 to 50-40 and the dash movement looks discrete. I wonder why is it so and how it can be improved...
  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.