Jump to content

Simple Summon Lightning on Right Click with Sword 1.12.2


sarxworks

Recommended Posts

Hello All :), I am relatively new to minecraft modding so I might be a bit unsure about certain things. I have a basic grasp on Java programming so I would say I somewhat understand how the code works and I'm constantly trying to learn but I've hit a snag. Basically I'm trying to make a basic sword that fires lightning bolts on right click however I can't seem to get the code to work. This is currently what I'm using:

public BoltSword(String unlocalizedName, ToolMaterial material) {
        super(unlocalizedName, material);
    }
    public ActionResult<ItemStack> onItemRightClick(ItemStack itemStackIn, World worldIn, EntityPlayer playerIn, EnumHand hand) {
        if (worldIn.isRemote) {
            RayTraceResult result = playerIn.rayTrace(100, 1F);
            int x = result.getBlockPos().getX();
            int y = result.getBlockPos().getY();
            int z = result.getBlockPos().getZ();
            EntityLightningBolt lightning = new EntityLightningBolt(worldIn, x, y, z, false);
            worldIn.addWeatherEffect(lightning);
            
        }
        return new ActionResult(EnumActionResult.SUCCESS, itemStackIn);

I've tried searching endless posts and this was the furthest I've gotten however it still won't work. I will appreciate any help given and I'm open to any suggestions you guys may recommend me. Thanks!

Link to comment
Share on other sites

Entity summoning are controlled on the server side, thus summoning lightning bolts on the client will not work.

Send a packet to the server when the sword is right clicked with; write a handler for that packet that summons the lightning.

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

6 minutes ago, diesieben07 said:

Not needed, onItemRightClick is called on the server, too.

I thought OP needed RayTracing. If I recall correctly RayTracing is client only?

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

4 hours ago, sarxworks said:

Hello All :), I am relatively new to minecraft modding so I might be a bit unsure about certain things. I have a basic grasp on Java programming so I would say I somewhat understand how the code works and I'm constantly trying to learn but I've hit a snag. Basically I'm trying to make a basic sword that fires lightning bolts on right click however I can't seem to get the code to work. This is currently what I'm using:

public BoltSword(String unlocalizedName, ToolMaterial material) {
        super(unlocalizedName, material);
    }
    public ActionResult<ItemStack> onItemRightClick(ItemStack itemStackIn, World worldIn, EntityPlayer playerIn, EnumHand hand) {
        if (worldIn.isRemote) {
            RayTraceResult result = playerIn.rayTrace(100, 1F);
            int x = result.getBlockPos().getX();
            int y = result.getBlockPos().getY();
            int z = result.getBlockPos().getZ();
            EntityLightningBolt lightning = new EntityLightningBolt(worldIn, x, y, z, false);
            worldIn.addWeatherEffect(lightning);
            
        }
        return new ActionResult(EnumActionResult.SUCCESS, itemStackIn);

I've tried searching endless posts and this was the furthest I've gotten however it still won't work. I will appreciate any help given and I'm open to any suggestions you guys may recommend me. Thanks!

Check for !World::isRemote. Also, EntityPlayer::rayTrace(double blockReachDistance, float partialTicks) has @SideOnly(Side.CLIENT) annotation, so you can't run it on server thread or you'll crash. Use World::rayTraceBlocks(Vec3d start, Vec3d end) instead.

One more thing, make an instance of BlockPos instead of calling the same method three times.

Edited by Differentiation
  • Thanks 1
Link to comment
Share on other sites

Alright so I first realized that one of the value "worldIn" was a mistake by me. I meant to use "world". I have changed the code around and used world.isRemote however I'm still not getting a response from right clicking. I'm not worrying too much about cleaning up the code as of right now, just trying to test things out. This is what I have: 

Quote

public class LightningBoltEvent{
        @SubscribeEvent
        public ActionResult<ItemStack> onItemRightClick(ItemStack itemStackIn, World world, EntityPlayer playerIn, EnumHand hand){
            if(!world.isRemote) {
                  RayTraceResult result = playerIn.rayTrace(100, 1F);
                  int x = result.getBlockPos().getX();
                  int y = result.getBlockPos().getY();
                  int z = result.getBlockPos().getZ();
                  EntityLightningBolt lightning = new EntityLightningBolt(world, x, y, z, false);
                  world.addWeatherEffect(lightning);
            }
                return new ActionResult<ItemStack>(EnumActionResult.SUCCESS, itemStackIn);

I even tried referencing the class in the main class to see if the event was not initializing but no change. Is it that I did not use the @Override annotation or no?

Link to comment
Share on other sites

3 minutes ago, sarxworks said:

I even tried referencing the class in the main class to see if the event was not initializing but no change

What you have there is not an event.

How much do you know Java? If not much I don't recommend starting with creating a Minecraft Modding.

If you know Java you don't have the right method signature It's Item#onItemRightClick(World, EntityPlayer, EnumHand) You don't get the ItemStack but you can get it via EntityPlayer#getHeldItem()

  • Thanks 1

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

I've taken a MOOC class over the summer so I understand the basics of the Java like OOP, Basic methods, modifiers, flow statements and the other fundamentals. If I need to know more I'm more than willing to learn. I figured that after a while because I was wondering what purpose the ItemStack had in the method. Alright I will try that.

Edited by sarxworks
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.