Jump to content

[1.14.2] [SOLVED] Button.IPressable not called


Big_Bad_E

Recommended Posts

I have a pretty simple GUI, where I add two buttons. Both are added but neither button's IPressable is called when I click the button. The button highlights on hover.

 

Button initialization:

buttons.clear();
buttons.add(new Button(guiLeft + 8, guiTop + 39, 48, 20, new TranslationTextComponent("gui.battlepets.pet.skills").getFormattedText(),	(button) -> {
    mc.player.closeScreen();
}));

 

Screen class:

https://github.com/BigBadE/BattlePets/blob/master/src/main/java/bigbade/battlepets/client/gui/PetScreen.java

Spoiler

public class PetScreen extends ContainerScreen<PetContainer> {
    private static final ResourceLocation GUITEXTURE = new ResourceLocation("battlepets:textures/gui/pet.png");
    private PetEntity pet;
    private int currTexIndex = 0;
    private Widget texButton;

    public PetScreen(PetContainer container, PlayerInventory playerInventory, ITextComponent name) {
        super(container, playerInventory, container.getName());
        pet = container.getPet();
    }

    @Override
    public void init() {
        super.init();

        Minecraft mc = Minecraft.getInstance();

        buttons.clear();
        buttons.add(new Button(guiLeft + 8, guiTop + 39, 48, 20, new TranslationTextComponent("gui.battlepets.pet.skills").getFormattedText(), (button) -> {
            mc.player.closeScreen();
            //TODO skill inv
            //NetworkHooks.openGui(mc.player, new CulinaryWorkbenchContainerProvider(pos));
        }));

        buttons.add(texButton = new Button(guiLeft + 8, guiTop - 28, xSize - 16, 20, "<...>", (button) -> {
            PetType type = pet.getPetType();
            if (++currTexIndex >= type.textures.length) {
                currTexIndex = 0;
            }

            String tex = type.textures[currTexIndex];
            pet.setTexture(tex);

            updateTextureButton(false);
        }));

        updateTextureButton(true);
    }


    @Override
    protected void drawGuiContainerForegroundLayer(int par1, int par2) {
        FontRenderer fontRenderer = Minecraft.getInstance().fontRenderer;
        fontRenderer.drawString(container.getName().getFormattedText(), 8, 6, 4210752);
        fontRenderer.drawString(playerInventory.hasCustomName() ? playerInventory.getCustomName().getFormattedText() : playerInventory.getName().getFormattedText(), 8, this.ySize - 96 + 2, 4210752);
    }

    @Override
    protected void drawGuiContainerBackgroundLayer(float partialTicks, int mouseX, int mouseY) {
        GL11.glColor4f(1.0F, 1.0F, 1.0F, 1.0F);
        texButton.render(mouseX, mouseY, partialTicks);
        Minecraft.getInstance().getTextureManager().bindTexture(GUITEXTURE);
        int k = (this.width - this.xSize) / 2;
        int l = (this.height - this.ySize) / 2;
        blit(k, l, 0, 0, this.xSize, this.ySize);

        if (pet.hasSkill(Skill.INVENTORY_ARMOR.id)) {
            blit(k + 7 + 18, l + 17, 0, 220, 18, 18);
        }
        if (pet.hasSkill(Skill.TRAVEL_MOUNTABLE.id)) {
            blit(k + 7, l + 17, 18, 220, 18, 18);
        }
        if (pet.hasSkill(Skill.INVENTORY_WEAPON.id)) {
            blit(k + 7 + 36, l + 17, 36, 220, 18, 18);
        }

        if (pet.hasSkill(Skill.INVENTORY.id)) {
            int count = (pet.getPetInventory().getSizeInventory() - 3) / 3;

            int rows = Math.min(count, 3);
            blit(k + 115, l + 17, 0, 166, 54, 18 * rows);

            int cols = Math.max(count - 3, 0);
            blit(k + 115 + 18 * 3, l + 17, 18 * 3, 166, 18 * cols, 54);
        }

        InventoryScreen.drawEntityOnScreen(k + 88, l + 60, 17, (float)(k+88) - mouseX, (float)(l+45) - mouseY, this.pet);
    }

    @Override
    public void render(int mx, int my, float par3) {
        super.render(mx, my, par3);
    }

    private void updateTextureButton(boolean initial) {
        if (initial) {
            int tex = 0;
            for(int i = 0; i < pet.getPetType().textures.length; i++)
                if(pet.getPetType().textures[i].equals(pet.getTexture()))
                    tex = i;
            currTexIndex = tex;
        }
        texButton.setMessage(new TranslationTextComponent("pet.battlepets.texture").getFormattedText().replace("%s", new TranslationTextComponent("pet.battlepets.texture." + pet.getPetType().name().toLowerCase() + "." + pet.getTexture()).getFormattedText()));
    }
}

 

 

I put a print on top of the button press callback, yet nothing is printed.

Edited by Big_Bad_E
Link to comment
Share on other sites

2 minutes ago, Big_Bad_E said:

I have a pretty simple GUI, where I add two buttons. Both are added but neither button's IPressable is called when I click the button. The button highlights on hover.

 

Button initialization:


buttons.clear();
buttons.add(new Button(guiLeft + 8, guiTop + 39, 48, 20, new TranslationTextComponent("gui.battlepets.pet.skills").getFormattedText(),	(button) -> {
    mc.player.closeScreen();
}));

 

Screen class:

https://github.com/BigBadE/BattlePets/blob/master/src/main/java/bigbade/battlepets/client/gui/PetScreen.java

  Hide contents


public class PetScreen extends ContainerScreen<PetContainer> {
    private static final ResourceLocation GUITEXTURE = new ResourceLocation("battlepets:textures/gui/pet.png");
    private PetEntity pet;
    private int currTexIndex = 0;
    private Widget texButton;

    public PetScreen(PetContainer container, PlayerInventory playerInventory, ITextComponent name) {
        super(container, playerInventory, container.getName());
        pet = container.getPet();
    }

    @Override
    public void init() {
        super.init();

        Minecraft mc = Minecraft.getInstance();

        buttons.clear();
        buttons.add(new Button(guiLeft + 8, guiTop + 39, 48, 20, new TranslationTextComponent("gui.battlepets.pet.skills").getFormattedText(), (button) -> {
            mc.player.closeScreen();
            //TODO skill inv
            //NetworkHooks.openGui(mc.player, new CulinaryWorkbenchContainerProvider(pos));
        }));

        buttons.add(texButton = new Button(guiLeft + 8, guiTop - 28, xSize - 16, 20, "<...>", (button) -> {
            PetType type = pet.getPetType();
            if (++currTexIndex >= type.textures.length) {
                currTexIndex = 0;
            }

            String tex = type.textures[currTexIndex];
            pet.setTexture(tex);

            updateTextureButton(false);
        }));

        updateTextureButton(true);
    }


    @Override
    protected void drawGuiContainerForegroundLayer(int par1, int par2) {
        FontRenderer fontRenderer = Minecraft.getInstance().fontRenderer;
        fontRenderer.drawString(container.getName().getFormattedText(), 8, 6, 4210752);
        fontRenderer.drawString(playerInventory.hasCustomName() ? playerInventory.getCustomName().getFormattedText() : playerInventory.getName().getFormattedText(), 8, this.ySize - 96 + 2, 4210752);
    }

    @Override
    protected void drawGuiContainerBackgroundLayer(float partialTicks, int mouseX, int mouseY) {
        GL11.glColor4f(1.0F, 1.0F, 1.0F, 1.0F);
        texButton.render(mouseX, mouseY, partialTicks);
        Minecraft.getInstance().getTextureManager().bindTexture(GUITEXTURE);
        int k = (this.width - this.xSize) / 2;
        int l = (this.height - this.ySize) / 2;
        blit(k, l, 0, 0, this.xSize, this.ySize);

        if (pet.hasSkill(Skill.INVENTORY_ARMOR.id)) {
            blit(k + 7 + 18, l + 17, 0, 220, 18, 18);
        }
        if (pet.hasSkill(Skill.TRAVEL_MOUNTABLE.id)) {
            blit(k + 7, l + 17, 18, 220, 18, 18);
        }
        if (pet.hasSkill(Skill.INVENTORY_WEAPON.id)) {
            blit(k + 7 + 36, l + 17, 36, 220, 18, 18);
        }

        if (pet.hasSkill(Skill.INVENTORY.id)) {
            int count = (pet.getPetInventory().getSizeInventory() - 3) / 3;

            int rows = Math.min(count, 3);
            blit(k + 115, l + 17, 0, 166, 54, 18 * rows);

            int cols = Math.max(count - 3, 0);
            blit(k + 115 + 18 * 3, l + 17, 18 * 3, 166, 18 * cols, 54);
        }

        InventoryScreen.drawEntityOnScreen(k + 88, l + 60, 17, (float)(k+88) - mouseX, (float)(l+45) - mouseY, this.pet);
    }

    @Override
    public void render(int mx, int my, float par3) {
        super.render(mx, my, par3);
    }

    private void updateTextureButton(boolean initial) {
        if (initial) {
            int tex = 0;
            for(int i = 0; i < pet.getPetType().textures.length; i++)
                if(pet.getPetType().textures[i].equals(pet.getTexture()))
                    tex = i;
            currTexIndex = tex;
        }
        texButton.setMessage(new TranslationTextComponent("pet.battlepets.texture").getFormattedText().replace("%s", new TranslationTextComponent("pet.battlepets.texture." + pet.getPetType().name().toLowerCase() + "." + pet.getTexture()).getFormattedText()));
    }
}

 

 

I put a print on top of the button press callback, yet nothing is printed.

I don't see a print...

Link to comment
Share on other sites

14 hours ago, ProPane865 said:

Ok... and? This thread should be marked as "solved" if you removed the print statement.

No... that’s not how it works. removing a print statement didn’t fix my problem.

 

9 hours ago, diesieben07 said:

You need to use Screen#addButton to add buttons.

I will change the method, I’ve been looking at old code that worked without thinking of changes like this.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.