Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[Solved] [1.12.2] override methods (ex. onItemUse) not called when extending ItemTool. Does anybody have a solution?


Mr. Tinkerman
 Share

Recommended Posts

I have been trying to create a chisel tool that can be used to break chunks off of bedrock.  The problem is that whenever I try to override the onItemUse or onItemRightClick the methods do not get called.  I have confirmed this by replacing my code with a simple message to tell me when the method has been called but receive no messages.  Is anyone willing to help me fix the issue.  I'll put the code below.  Thanks in advanced.

 

This is the base class I made for the chisels.

package com.mrtinkerman.modularmachines.items;

import java.util.Set;

import com.mrtinkerman.modularmachines.ModularMachines;
import com.mrtinkerman.modularmachines.creativetabs.CustomTabs;
import com.mrtinkerman.modularmachines.init.ModItems;
import com.mrtinkerman.modularmachines.util.IHasModel;

import net.minecraft.block.Block;
import net.minecraft.item.Item;
import net.minecraft.item.ItemTool;

public class ChiselBase extends ItemTool implements IHasModel
{
	public ChiselBase(String name, ToolMaterial materialIn, Set<Block> effectiveBlocks)
	{	
		super(materialIn, effectiveBlocks);
		
		setUnlocalizedName(name);
		setRegistryName(name);
		
		setMaxStackSize(1);
		
		ModItems.ITEMS.add(this);
	}

	@Override
	public void registerModels() 
	{
		ModularMachines.proxy.registerItemRenderer(this, 0, "inventory");
	}
}

 

This is the actual chisel class

package com.mrtinkerman.modularmachines.items.tools;

import java.util.Set;

import com.mrtinkerman.modularmachines.items.ChiselBase;

import net.minecraft.block.Block;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.ActionResult;
import net.minecraft.util.EnumActionResult;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumHand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.Vec3d;
import net.minecraft.util.text.TextComponentString;
import net.minecraft.world.World;
import net.minecraftforge.fml.client.FMLClientHandler;

public class HandChiselIron extends ChiselBase
{
	public HandChiselIron(String name, ToolMaterial materialIn, Set<Block> effectiveBlocks)
	{
		super(name, materialIn, effectiveBlocks);
	}

	@Override
	public EnumActionResult onItemUse(EntityPlayer playerIn, World worldIn, BlockPos pos, EnumHand hand, EnumFacing facing, float hitX, float hitY, float hitZ)
	{
		playerIn.sendMessage(new TextComponentString("Block Right Clicked"));
		System.out.println("OnItemUse Called");
//		if(true)
//		{
//			//System.out.println("OnItemUse Called inside if loop");
//			playerIn.sendMessage(new TextComponentString("Block Right Clicked IF"));
//		}
		
		return super.onItemUse(playerIn, worldIn, pos, hand, facing, hitX, hitY, hitZ);
	}
	
	@Override
	public ActionResult<ItemStack> onItemRightClick(World worldIn, EntityPlayer playerIn, EnumHand handIn)
	{
		playerIn.sendMessage(new TextComponentString("Right Clicked!"));
		// TODO Auto-generated method stub
		return super.onItemRightClick(worldIn, playerIn, handIn);
	}
	
	@Override
	public double getDurabilityForDisplay(ItemStack stack)
	{
		return super.getDurabilityForDisplay(stack);
	}
	
	@Override
	public boolean hasContainerItem()
	{
		return true;
	}
	
	@Override
	public Item getContainerItem()
	{
		return super.getContainerItem();
	}
}

 

This is the ModItems class

package com.mrtinkerman.modularmachines.init;

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.init.Blocks;
import net.minecraft.item.Item;
import net.minecraft.item.Item.ToolMaterial;

import java.util.ArrayList;
import java.util.HashSet;
import java.util.List;
import java.util.Set;

import com.mrtinkerman.modularmachines.items.ChiselBase;
import com.mrtinkerman.modularmachines.items.ItemBase;
import com.mrtinkerman.modularmachines.items.tools.TinkerWrench;
import com.google.common.collect.Sets;
import com.mrtinkerman.modularmachines.init.ModMaterials;

public class ModItems
{

	public static final List<Item> ITEMS = new ArrayList<Item>();

	//Block Sets
	public static final Set<Block> CHISEL_EFFECTIVE = Sets.newHashSet(new Block[]{ Blocks.BEDROCK });
	
	//Tools
	public static final Item HAND_CHISEL_IRON = new ChiselBase("hand_chisel_iron", ModMaterials.IRON_CHISEL, CHISEL_EFFECTIVE);
      
}

 

Registry class


package com.mrtinkerman.modularmachines.util.handlers;

import com.mrtinkerman.modularmachines.blocks.BlockTileEntityBase;
import com.mrtinkerman.modularmachines.blocks.functional.Machine_Frame_Block;
import com.mrtinkerman.modularmachines.entity.tile.Machine_Frame_Data;
import com.mrtinkerman.modularmachines.init.ModBlocks;
import com.mrtinkerman.modularmachines.init.ModItems;
import com.mrtinkerman.modularmachines.init.ModTileEntities;
import com.mrtinkerman.modularmachines.util.IHasModel;

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.item.Item;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.common.registry.GameRegistry;

@EventBusSubscriber
public class RegistryHandler
{
	@SubscribeEvent
	public static void onItemRegister(RegistryEvent.Register<Item> event)
	{
		event.getRegistry().registerAll(ModItems.ITEMS.toArray(new Item[0]));
	}

	@SubscribeEvent
	public static void onBlockRegister(RegistryEvent.Register<Block> event)
	{
		event.getRegistry().registerAll(ModBlocks.BLOCKS.toArray(new Block[0]));
		event.getRegistry().registerAll(ModTileEntities.TILE_ENTITIES.toArray(new Block[0]));

		for (BlockTileEntityBase blockTileEntity : ModTileEntities.TILE_ENTITIES)
		{
			GameRegistry.registerTileEntity(blockTileEntity.getTileEntityClass(), blockTileEntity.getRegistryName());
		}
	}

	@SubscribeEvent
	public static void onModelRegister(ModelRegistryEvent event)
	{
		for (Item item : ModItems.ITEMS)
		{
			if (item instanceof IHasModel)
			{
				((IHasModel) item).registerModels();
			}
		}

		for (Block block : ModBlocks.BLOCKS)
		{
			if (block instanceof IHasModel)
			{
				((IHasModel) block).registerModels();
			}
		}
		
		for (BlockTileEntityBase tileEntity : ModTileEntities.TILE_ENTITIES)
		{
			if (tileEntity instanceof IHasModel)
			{
				((IHasModel) tileEntity).registerModels();
			}
		}
	}
}

 

I think that is all you'll need but please let me know otherwise.  Thanks again.

Link to comment
Share on other sites

  • Mr. Tinkerman changed the title to [1.12.2] override methods (ex. onItemUse) not called when extending ItemTool. Does anybody have a solution?

I'm feeling pretty dumb right now...

 

I needed to create a new item from HandChiselIron instead of ChiselBase

	//From
	public static final Item HAND_CHISEL_IRON = new ChiselBase("hand_chisel_iron", ModMaterials.IRON_CHISEL, CHISEL_EFFECTIVE);

	//To
	public static final Item HAND_CHISEL_IRON = new HandChiselIron("hand_chisel_iron", ModMaterials.IRON_CHISEL, CHISEL_EFFECTIVE);

 

Sorry 'bout that.

 

EDIT: I'll leave the thread open for a little while in case anyone has any comments.

Edited by Mr. Tinkerman
Link to comment
Share on other sites

1 hour ago, Mr. Tinkerman said:

public static final Item HAND_CHISEL_IRON = new ChiselBase

Problematic code #14

 

2 hours ago, Mr. Tinkerman said:

IHasModel

Code style #3

 

2 hours ago, Mr. Tinkerman said:

@Override
	public Item getContainerItem()
	{
		return super.getContainerItem();
	}

Pointless code. Just don't override it if you're going to do nothing.

 

2 hours ago, Mr. Tinkerman said:

public class ChiselBase

Code Style #4

  • Thanks 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

14 hours ago, Draco18s said:

Problematic code #14

 

Code style #3

 

Pointless code. Just don't override it if you're going to do nothing.

 

Code Style #4

Thank you for the advice and showing the problematic code!  I'll update my code based on your comment.  I'm just learning so I wasn't aware about Code Styles 3 and 4 although I guess I should have known that getContainerItem() wasn't needed.

Edited by Mr. Tinkerman
nuthin' much
Link to comment
Share on other sites

  • Mr. Tinkerman changed the title to [Solved] [1.12.2] override methods (ex. onItemUse) not called when extending ItemTool. Does anybody have a solution?
14 hours ago, Draco18s said:

Problematic code #14

 

Code style #3

 

Pointless code. Just don't override it if you're going to do nothing.

 

Code Style #4

I understand Code style #4 but I have a question about Code style #3.  Does this mean I should completely remove IHasModel and I register the model for all items in the registry?

 

I clicked the link but I'm not sure if I'm fully understanding what Code style #3 is suggesting I actually do.  Do I leave it in ItemBase or remove it entirely?  Sorry about all these questions.

Edited by Mr. Tinkerman
forgot a thing (again)
Link to comment
Share on other sites

1 hour ago, Mr. Tinkerman said:

Does this mean I should completely remove IHasModel

Yes

 

Quote

and I register the model for all items in the registry?

No. You should only register models for all of YOUR items. You're already looping over all of your items, so don't change that.

 

Note that you do not need to loop over your block list or your tile entity list, they don't need models registered, only items do, and if your blocks have items, those items should already be in the list.

Edited by Draco18s
  • Thanks 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

2 hours ago, Draco18s said:

Yes

 

No. You should only register models for all of YOUR items. You're already looping over all of your items, so don't change that.

 

Note that you do not need to loop over your block list or your tile entity list, they don't need models registered, only items do, and if your blocks have items, those items should already be in the list.

OK, I think I understand now.  I meant to only register my items instead of all of them in general but I didn't know that I should remove the registry loops for the blocks and tile entities.  Thanks again for helping me.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Hello everyone, like the title suggest, I've a problem running dedicated server for my mod "emomod, Emotion's Mod", I understand that the problem is caused by my containers because of invalid dist and I understand the concept of side but I really struggle to fix it, for the lore I'm developing this mod since 5 or 6 years from now so it's a huge one, I have like 281 block textures, 167 item textures, biomes, game mechanics, dimensions, entities etc.. I love it but I kept it private for the moment (I may send it public soon) and I use to get back on it sometimes when I want to update the version (I also rewrite everything once because I suck to do so for the version 1.8 to 1.12 / 1.14) or add stuff for example, here is the log of the server :   I'm registering Biome, Block, ContainerType, TileEntityType etc.. In differents class that I'm calling in my main one called "MainRegistry" with the method init().   Firstly, the classe where I'm registering ContainerType is modestly named "ContainerTypeRegistry" (this is my convention), I've currently three type of container, "CRAFTER" wich is a complex automatic crafting machine, "BAG" is a bag item storing stuff using "ItemStackHandler" and finally Nightstand is a basic chest with less slots (4) using different color GUIs based on the wood used to craft, here is the code :   @Mod.EventBusSubscriber(modid = MainRegistry.MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD) public class ContainerTypeRegistry { private static final List<ContainerType<?>> containerTypeList = new ArrayList<ContainerType<?>>(); public static final ContainerType<CrafterContainer> CRAFTER = IForgeContainerType.create((windowId, inv, data) -> { BlockPos pos = data.readBlockPos(); return new CrafterContainer(windowId, MainRegistry.proxy.getClientWorld(), pos, MainRegistry.proxy.getClientPlayer()); }); public static final ContainerType<BagContainer> BAG = IForgeContainerType.create((windowId, inv, data) -> { return new BagContainer(windowId, inv); }); public static final ContainerType<NightstandContainer> NIGHTSTAND = IForgeContainerType.create((windowId, inv, data) -> { BlockPos pos = data.readBlockPos(); return new NightstandContainer(windowId, inv.player.getEntityWorld(), pos, inv); }); public static void init() { addContainerType(CRAFTER, "crafter"); addContainerType(BAG, "bag"); addContainerType(NIGHTSTAND, "nightstand"); } public static void addContainerType(ContainerType<?> tet, String name) { containerTypeList.add(tet.setRegistryName(name)); } @SubscribeEvent public static void registerContainerType(final RegistryEvent.Register<ContainerType<?>> e) { for (ContainerType<?> tet : containerTypeList) { e.getRegistry().register(tet); } } } Secondly, I'm using the same technique to register TileEntityType and I'm calling all those init methods but also ScreenManager.registerFactory() like I said in the main class just here :   @Mod(MainRegistry.MOD_ID) public class MainRegistry { public static final String MOD_ID = "emomod"; public static final Logger LOGGER = LogManager.getLogger(MOD_ID); public static IProxy proxy = DistExecutor.runForDist(() -> () -> new ClientProxy(), () -> () -> new ServerProxy()); public static MainRegistry instance; public static WorldType PARCEL_TYPE = new ParcelWorldType(); public static WorldType DREAM_TYPE = new DreamWorldType(); public MainRegistry() { ItemRegistry.init(); BlockRegistry.init(); TileEntityTypeRegistry.init(); EntityTypeRegistry.init(); SurfaceBuilderRegistry.init(); PlacementRegistry.init(); FeatureRegistry.init(); FluidRegistry.init(); ContainerTypeRegistry.init(); DispenserBlock.registerDispenseBehavior(PotionUtils.addPotionToItemStack(new ItemStack(Items.POTION), Potions.WATER).getItem(), new IInteractBehavior()); DispenserBlock.registerDispenseBehavior(Items.WHEAT_SEEDS, new IPlaceBehavior(Blocks.WHEAT, Blocks.FARMLAND)); DispenserBlock.registerDispenseBehavior(Items.PUMPKIN_SEEDS, new IPlaceBehavior(Blocks.PUMPKIN_STEM, Blocks.FARMLAND)); DispenserBlock.registerDispenseBehavior(Items.MELON_SEEDS, new IPlaceBehavior(Blocks.MELON_STEM, Blocks.FARMLAND)); DispenserBlock.registerDispenseBehavior(Items.BEETROOT_SEEDS, new IPlaceBehavior(Blocks.BEETROOTS, Blocks.FARMLAND)); DispenserBlock.registerDispenseBehavior(Items.CARROT, new IPlaceBehavior(Blocks.CARROTS, Blocks.FARMLAND)); DispenserBlock.registerDispenseBehavior(Items.POTATO, new IPlaceBehavior(Blocks.POTATOES, Blocks.FARMLAND)); DispenserBlock.registerDispenseBehavior(Items.OAK_SAPLING, new IPlaceBehavior(Blocks.OAK_SAPLING, Blocks.GRASS_BLOCK, Blocks.DIRT, Blocks.COARSE_DIRT, Blocks.PODZOL)); DispenserBlock.registerDispenseBehavior(Items.ACACIA_SAPLING, new IPlaceBehavior(Blocks.ACACIA_SAPLING, Blocks.GRASS_BLOCK, Blocks.DIRT, Blocks.COARSE_DIRT, Blocks.PODZOL)); DispenserBlock.registerDispenseBehavior(Items.BIRCH_SAPLING, new IPlaceBehavior(Blocks.BIRCH_SAPLING, Blocks.GRASS_BLOCK, Blocks.DIRT, Blocks.COARSE_DIRT, Blocks.PODZOL)); DispenserBlock.registerDispenseBehavior(Items.DARK_OAK_SAPLING, new IPlaceBehavior(Blocks.DARK_OAK_SAPLING, Blocks.GRASS_BLOCK, Blocks.DIRT, Blocks.COARSE_DIRT, Blocks.PODZOL)); DispenserBlock.registerDispenseBehavior(Items.JUNGLE_SAPLING, new IPlaceBehavior(Blocks.JUNGLE_SAPLING, Blocks.GRASS_BLOCK, Blocks.DIRT, Blocks.COARSE_DIRT, Blocks.PODZOL)); DispenserBlock.registerDispenseBehavior(Items.SPRUCE_SAPLING, new IPlaceBehavior(Blocks.SPRUCE_SAPLING, Blocks.GRASS_BLOCK, Blocks.DIRT, Blocks.COARSE_DIRT, Blocks.PODZOL)); DispenserBlock.registerDispenseBehavior(Items.BAMBOO, new IPlaceBehavior(Blocks.BAMBOO_SAPLING, Blocks.GRASS_BLOCK, Blocks.DIRT, Blocks.COARSE_DIRT, Blocks.PODZOL)); DispenserBlock.registerDispenseBehavior(Items.NETHER_WART, new IPlaceBehavior(Blocks.NETHER_WART, Blocks.SOUL_SAND, Blocks.DIRT, Blocks.COARSE_DIRT, Blocks.PODZOL)); FMLJavaModLoadingContext.get().getModEventBus().addListener(this::setup); FMLJavaModLoadingContext.get().getModEventBus().addListener(this::clientSetup); FMLJavaModLoadingContext.get().getModEventBus().addListener(this::serverSetup); MinecraftForge.EVENT_BUS.register(new EmotionOverlayEvent()); MinecraftForge.EVENT_BUS.register(new EmotionLivingEvent()); ClientRegistry.bindTileEntitySpecialRenderer(TileEntitySign.class, new TileEntitySignRenderer()); ClientRegistry.bindTileEntitySpecialRenderer(TileEntityCrafter.class, new TileEntityCrafterRenderer()); ClientRegistry.bindTileEntitySpecialRenderer(TileEntityPot.class, new TileEntityPotRenderer()); LootConditionManager.registerCondition(new HarvestLevelCondition.Serializer()); EmomodPacketHandler.registerMessages(); } private void setup(final FMLCommonSetupEvent e) { proxy.init(); RenderingRegistry.registerEntityRenderingHandler(OrbSpellEntity.class, render -> new SpriteRenderer<OrbSpellEntity>(render, Minecraft.getInstance().getItemRenderer())); RenderingRegistry.registerEntityRenderingHandler(EntityButterfly.class, render -> new RendererButterfly(render)); RenderingRegistry.registerEntityRenderingHandler(EntityBeetle.class, render -> new RendererBasic<EntityBeetle, ModelBeetle>(render, new ModelBeetle(), 0.175f, new ResourceLocation(MainRegistry.MOD_ID, "textures/entity/beetle.png"))); RenderingRegistry.registerEntityRenderingHandler(EntityLightningBug.class, render -> new RendererBasic<EntityLightningBug, ModelLightningBug>(render, new ModelLightningBug(), 0.0f, new ResourceLocation(MainRegistry.MOD_ID, "textures/entity/lightning_bug.png"))); RenderingRegistry.registerEntityRenderingHandler(EntityBoat.class, RendererBoat::new); RenderingRegistry.registerEntityRenderingHandler(EntityChubby.class, render -> new RendererBasic<EntityChubby, ModelChubby>(render, new ModelChubby(), .2f, new ResourceLocation(MainRegistry.MOD_ID, "textures/entity/chubby.png"))); RenderingRegistry.registerEntityRenderingHandler(EntityMouse.class, render -> new RendererMouse(render, new ModelMouse(), 0.1f)); RenderingRegistry.registerEntityRenderingHandler(EntityOrchardSpider.class, render -> new RendererOrchardSpider<EntityOrchardSpider>(render)); EmoOreGeneration.setupOreGeneration(); // RecipeRegistry.init(); } private void clientSetup(final FMLClientSetupEvent e) { EmoStaff staff = (EmoStaff) ItemRegistry.PURPURA_STAFF; Minecraft.getInstance().getItemColors().register((item, tintIndex) -> { return staff.getColor(new ItemStack(staff), tintIndex); }, staff); Minecraft.getInstance().getItemColors().register((item, tintIndex) -> { return GrassColors.get(0.5D, 1.0D); }, BlockRegistry.FLOWER_TALLGRASS); Minecraft.getInstance().getItemColors().register((item, tintIndex) -> { BlockState blockstate = ((BlockItem) item.getItem()).getBlock().getDefaultState(); return Minecraft.getInstance().getBlockColors().getColor(blockstate, (IEnviromentBlockReader) null, (BlockPos) null, tintIndex); }, BlockRegistry.LEAVES_CHERRY, BlockRegistry.LEAVES_PEAR, BlockRegistry.LEAVES_ORANGE, BlockRegistry.LEAVES_ATLAS, BlockRegistry.LEAVES_PINE, BlockRegistry.LEAVES_COCO, BlockRegistry.LEAVES_DREAM); Minecraft.getInstance().getBlockColors().register((state, reader, pos, color) -> { return reader != null && pos != null ? BiomeColors.getGrassColor(reader, pos) : GrassColors.get(0.5D, 1.0D); }, BlockRegistry.FLOWER_TALLGRASS); Minecraft.getInstance().getBlockColors().register((state, reader, pos, color) -> { return reader != null && pos != null ? BiomeColors.getFoliageColor(reader, pos) : FoliageColors.getDefault(); }, BlockRegistry.LEAVES_PINE, BlockRegistry.LEAVES_COCO, BlockRegistry.LEAVES_DREAM); Minecraft.getInstance().getBlockColors().register((state, reader, pos, color) -> { return 0xac73af; }, BlockRegistry.LEAVES_CHERRY); Minecraft.getInstance().getBlockColors().register((state, reader, pos, color) -> { return 0x487748; }, BlockRegistry.LEAVES_PEAR); Minecraft.getInstance().getBlockColors().register((state, reader, pos, color) -> { return 0x45a14a; }, BlockRegistry.LEAVES_ORANGE); Minecraft.getInstance().getBlockColors().register((state, reader, pos, color) -> { return 0x4496c4; }, BlockRegistry.LEAVES_ATLAS); ScreenManager.<CrafterContainer, CrafterScreen>registerFactory(ContainerTypeRegistry.CRAFTER, (container, playerInventory, title) -> { return new CrafterScreen(container, playerInventory, title); }); ScreenManager.<BagContainer, BagScreen>registerFactory(ContainerTypeRegistry.BAG, (container, playerInventory, title) -> { return new BagScreen(container, playerInventory, title); }); ScreenManager.<NightstandContainer, NightstandScreen>registerFactory(ContainerTypeRegistry.NIGHTSTAND, (container, playerInventory, title) -> { return new NightstandScreen(container, playerInventory, title, container.getTileEntity().getColor()); }); } private void serverSetup(final FMLDedicatedServerSetupEvent e) { } } Finally for the specific class I'm only gonna send the Nightstand one in random way :   - Block class :   public class EmoNightstand extends Block { private static final DirectionProperty FACING = HorizontalBlock.HORIZONTAL_FACING; private static final VoxelShape NIGHTSTAND_SHAPE = Block.makeCuboidShape(1.0D, 0.0D, 1.0D, 15.0D, 15.0D, 15.0D); private float[] color; public EmoNightstand(Properties properties, float[] color) { super(properties); this.getDefaultState().with(FACING, Direction.NORTH); this.color = color; } @Override public VoxelShape getCollisionShape(BlockState state, IBlockReader worldIn, BlockPos pos, ISelectionContext context) { return NIGHTSTAND_SHAPE; } @Override public VoxelShape getShape(BlockState state, IBlockReader worldIn, BlockPos pos, ISelectionContext context) { return NIGHTSTAND_SHAPE; } @Override public boolean onBlockActivated(BlockState state, World worldIn, BlockPos pos, PlayerEntity player, Hand handIn, BlockRayTraceResult hit) { if (!worldIn.isRemote) { TileEntity tileEntity = worldIn.getTileEntity(pos); if (tileEntity instanceof INamedContainerProvider) { NetworkHooks.openGui((ServerPlayerEntity) player, (INamedContainerProvider) tileEntity, tileEntity.getPos()); } } return true; } public BlockState getStateForPlacement(BlockItemUseContext context) { return this.getDefaultState().with(FACING, context.getPlacementHorizontalFacing().getOpposite()); } protected void fillStateContainer(StateContainer.Builder<Block, BlockState> builder) { builder.add(FACING); } @Override public boolean hasTileEntity(BlockState state) { return true; } @Override public TileEntity createTileEntity(BlockState state, IBlockReader world) { return new TileEntityNightstand(this.color); } } - The ContainerScreen class :   public class NightstandScreen extends ContainerScreen<NightstandContainer> { private static final ResourceLocation NIGHTSTAND_GUI_SCREEN = new ResourceLocation(MainRegistry.MOD_ID, "textures/gui/container/nightstand.png"); private float[] color; public NightstandScreen(NightstandContainer screenContainer, PlayerInventory playerInventory, ITextComponent titleIn, float[] color) { super(screenContainer, playerInventory, titleIn); this.xSize = 176; this.ySize = 127; this.color = color; } protected void drawGuiContainerForegroundLayer(int mouseX, int mouseY) { this.font.drawString(this.getTitle().getFormattedText(), 8, 4, 0); this.font.drawString(this.playerInventory.getDisplayName().getFormattedText(), 8.0F, (float) (this.ySize - 96 + 2), 0); } @Override protected void drawGuiContainerBackgroundLayer(float partialTicks, int mouseX, int mouseY) { int xPos = (this.width - this.xSize) / 2; int yPos = (this.height - this.ySize) / 2; GlStateManager.color4f(1.0f, 1.0f, 1.0f, 1.0f); this.minecraft.getTextureManager().bindTexture(NIGHTSTAND_GUI_SCREEN); this.blit(xPos, yPos, 0, 0, this.xSize, this.ySize); GlStateManager.color4f(color[0] / 255, color[1] / 255, color[2] / 255, 1.0f); this.blit(xPos, yPos, 0, 0, this.xSize, this.ySize); GlStateManager.disableTexture(); GlStateManager.enableBlend(); GlStateManager.disableAlphaTest(); GlStateManager.blendFuncSeparate(GlStateManager.SourceFactor.SRC_ALPHA, GlStateManager.DestFactor.ONE_MINUS_SRC_ALPHA, GlStateManager.SourceFactor.ONE, GlStateManager.DestFactor.ZERO); GlStateManager.shadeModel(7425); Tessellator tessellator = Tessellator.getInstance(); BufferBuilder bufferbuilder = tessellator.getBuffer(); bufferbuilder.begin(7, DefaultVertexFormats.POSITION_COLOR); bufferbuilder.pos((double) xPos + this.xSize, (double) yPos, (double) this.blitOffset).color(0, 0, 0, 0).endVertex(); bufferbuilder.pos((double) xPos, (double) yPos, (double) this.blitOffset).color(0, 0, 0, 0).endVertex(); bufferbuilder.pos((double) xPos, (double) yPos + this.ySize, (double) this.blitOffset).color(0, 0, 0, 255 / 2).endVertex(); bufferbuilder.pos((double) xPos + this.xSize, (double) yPos + this.ySize, (double) this.blitOffset).color(0, 0, 0, 255 / 2).endVertex(); tessellator.draw(); GlStateManager.shadeModel(7424); GlStateManager.disableBlend(); GlStateManager.enableAlphaTest(); GlStateManager.enableTexture(); } } The Container class :   public class NightstandContainer extends Container { private TileEntity tileEntity; private int containerSlots = 0; public NightstandContainer(int id, World world, BlockPos pos, PlayerInventory playerInventory) { super(ContainerTypeRegistry.NIGHTSTAND, id); this.tileEntity = world.getTileEntity(pos); tileEntity.getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY).ifPresent(h -> { containerSlots = h.getSlots(); for (int i = 0; i < h.getSlots(); i++) { addSlot(new SlotItemHandler(h, i, 44 + (i * 18) + (i > 1 ? 18 : 0), 14)); } }); for (int y = 0; y < 3; ++y) { for (int x = 0; x < 9; ++x) { this.addSlot(new Slot(playerInventory, x + y * 9 + 9, 8 + (x * 18), 45 + (y * 18))); } } for (int k = 0; k < 9; ++k) { this.addSlot(new Slot(playerInventory, k, 8 + k * 18, 103)); } } @Override public ItemStack transferStackInSlot(PlayerEntity playerIn, int index) { Slot slot = this.getSlot(index); if (!slot.canTakeStack(playerIn)) return slot.getStack(); if (!slot.getHasStack()) return ItemStack.EMPTY; ItemStack stack = slot.getStack(); ItemStack newStack = stack.copy(); if (index < containerSlots) { if (!this.mergeItemStack(stack, containerSlots, this.inventorySlots.size(), true)) return ItemStack.EMPTY; slot.onSlotChanged(); } else if (!this.mergeItemStack(stack, 0, containerSlots, false)) return ItemStack.EMPTY; if (stack.isEmpty()) slot.putStack(ItemStack.EMPTY); else slot.onSlotChanged(); return slot.onTake(playerIn, newStack); } @Override public boolean canInteractWith(PlayerEntity playerIn) { return this.isUsable(playerIn); } protected boolean isUsable(PlayerEntity playerIn) { return IWorldPosCallable.of(tileEntity.getWorld(), tileEntity.getPos()).applyOrElse((block, pos) -> { return !(block.getBlockState(pos).getBlock() instanceof EmoNightstand) ? false : playerIn.getDistanceSq((double) pos.getX() + 0.5D, (double) pos.getY() + 0.5D, (double) pos.getZ() + 0.5D) <= 64.0D; }, true); } @Nullable public TileEntityNightstand getTileEntity() { if (this.tileEntity instanceof TileEntityNightstand) return (TileEntityNightstand) this.tileEntity; else return null; } } The TileEntity class :   public class TileEntityNightstand extends TileEntity implements INamedContainerProvider { private LazyOptional<IItemHandler> handler = LazyOptional.of(this::createHandler); private float[] color = new float[] { 0.0f, 255.0f, 0.0f}; public TileEntityNightstand(float[] color) { this(); this.color = color; } public TileEntityNightstand() { super(TileEntityTypeRegistry.NIGHTSTAND); } @SuppressWarnings("unchecked") @Override public void read(CompoundNBT compound) { CompoundNBT inventory = compound.getCompound("Inventory"); handler.ifPresent(h -> ((INBTSerializable<CompoundNBT>) h).deserializeNBT(inventory)); super.read(compound); } @SuppressWarnings("unchecked") @Override public CompoundNBT write(CompoundNBT compound) { handler.ifPresent(h -> { CompoundNBT nbt = ((INBTSerializable<CompoundNBT>) h).serializeNBT(); compound.put("Inventory", nbt); }); return super.write(compound); } private IItemHandler createHandler() { return new ItemStackHandler(4) { @Override protected void onContentsChanged(int slot) { markDirty(); } }; } @Override public <T> LazyOptional<T> getCapability(Capability<T> cap, Direction side) { if (cap == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY) return handler.cast(); return super.getCapability(cap, side); } @Override public ITextComponent getDisplayName() { return new TranslationTextComponent("container.emomod.nightstand"); } @Override public Container createMenu(int windowId, PlayerInventory playerInventory, PlayerEntity player) { return new NightstandContainer(windowId, this.getWorld(), this.getPos(), playerInventory); } public float[] getColor() { return this.color; } } And voilà, I think that everything is here and I will really appreciate some help, this mod is very important for me and I've put so many efforts in it, I've to update it soon to the latest version (I may also want some paid help for that if I can apply some sort of dev recrutment on this forum) and I will stop adding stuff but polish everything up to finally set it public. Thanks again for giving me some of your time, I can send the WIP version of the mod jar as demo when this will be fixed if some of you want it, and also if I find a way to protect my textures from being copied / reused or modified.
    • https://mcforge.readthedocs.io/en/latest/concepts/sides/#writing-one-sided-mods
    • What?! Just use RegisterCommandsEvent. FMLServerStartingEvent is not involved with registering commands at all.
    • Only ModelRegistryEvent is necessary. Call ModelLoader.addSpecialModel in there and the model will be baked as normal.
    • Really old Minecraft versions are no longer supported on this forum. Please update to a modern version of Minecraft to receive support.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.