Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

Request for hooks - Sky control


Benimatic
 Share

Recommended Posts

Hi, I'm the developer of the Twilight Forest mod.  I ported my mod over to Forge a few months ago and it's been great.  Things have been so much easier, and I'm really grateful for everyone's hard work.  Recently I was looking through my code for stupid hacks to eliminate, and I found some!

 

In my code, I override the World class, and use some dumb hack methods to replace it in the client with my custom World, when the player is in my dimension.

 

The methods I could use hooks for are:

 

World.calculateSkylightSubtracted()

World.func_35464_b() which has something to do with sky lighting.

World.getSkyColor()

World.getStarBrightness()

World.getSealevel(), since that's only used for horizon rendering.

 

I could ask what some of these functions are even doing in the World class.  Could we make a hook that lets maybe the WorldProvider for that world override them?

 

What would take that one step further would be if I could get a hook for RenderGlobal.renderSky(), the way the End dimension has a custom sky.

 

Finally, although it's unrelated to sky rendering, I'm also overriding World.setSpawnLocation() and World.getSpawnPoint().  I have less of an idea as to how you'd handle the hook for those, but I'd still like one.

 

Also, a pony. ;)

 

 

 

Link to comment
Share on other sites

Take this with a grain of salt as I have not done this myself, this is just from perusing over the code:  If you use the DimensionManager API in Forge, you should be able to use your 'own' World and WorldProvider, no hacks needed.  The functions registerDimension and setWorld?  Unsure what calls setWorld in the code, did not see what calls it on a quick look.

 

EDIT:  May need to wait for Lex, but from what I am reading, you should be able to registerDimension, then new a new WorldMyType that is derived from WorldServer (WorldServer calls DimensionManager.setWorld from inside its constructor) and everything 'should' work, at least on multiplayer?  No clue about singleplayer, ask Lex?  I have not yet used the DimensionManager, but I know others have.

Link to comment
Share on other sites

If I'm following the code correctly (I'm not really a coder) you write you own custom WorldProvider that extends the main one and it should register it. Looking at WorldProviderHell and WordProviderEnd, some of what Benimatic is looking to do is already available. 

 

I really hope that made sense! :)

Link to comment
Share on other sites

The way the code currently works, you write your own WorldProvider, and register it with e.g. DimensionManager.registerDimension(7, new WorldProviderTwilightForest(), true);.  There are some functions that have to do with the sky or spawn points, that I'm already using, in that WorldProvider class.  Others, which I am requesting, are locked away in the World class. 

 

As for using DimensionManager.setWorld, that seems to be something used internally on the server.  I might be able to use it to inject a custom class which could control respawning coordinates, but that wouldn't work in singleplayer.  Further all the sky stuff is clientside-only.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • I'm running a Minecraft Forge 1.17 server but I can't add more RAM to it. I can change the amount of RAM to 4G and it launches without problems, but the the Java GUI tells me it's still running on 2G. Before you comment, yes I have entered the -Xmx4G into the new "user_jvm_args.txt" document. The computer I run the server on has 6GB of memory (I know, rare sight) so it should run just fine. If you need any more information, I'm happy to oblige. Thanks in advance!
    • Never mind, I fixed the problem, it wasn't anything to do with the forge_gradle folder. Thanks for helping anyway
    • What are you talking about? Post actual logs if you have errors.
    • Based on this Minecraft rarity, I'm going to create my own rarity.   Rarity.java package net.minecraft.world.item; import net.minecraft.ChatFormatting; public enum Rarity implements net.minecraftforge.common.IExtensibleEnum { COMMON(ChatFormatting.WHITE), UNCOMMON(ChatFormatting.YELLOW), RARE(ChatFormatting.AQUA), EPIC(ChatFormatting.LIGHT_PURPLE); public final ChatFormatting color; private Rarity(ChatFormatting p_43028_) { this.color = p_43028_; } public static Rarity create(String name, ChatFormatting p_43028_) { throw new IllegalStateException("Enum not extended"); } }   However, after creating it, when I tried to give it to the item, it came up with a problem NijiRarity.java package com.ocome.nijisanjiworld.item.tool; import net.minecraft.ChatFormatting; import net.minecraftforge.common.IExtensibleEnum; public enum NijiRarity implements IExtensibleEnum { COMMON(ChatFormatting.AQUA), UNCOMMON(ChatFormatting.YELLOW), RARE(ChatFormatting.AQUA), EPIC(ChatFormatting.LIGHT_PURPLE); public final ChatFormatting color; private NijiRarity(ChatFormatting p_43028_) { this.color = p_43028_; } public static NijiRarity create(String name, ChatFormatting p_43028_) { throw new IllegalStateException("Enum not extended"); } }   The problem is. Error: Incompatible type: Cannot convert NijiRarity to Rarity: This is it. Why is it not applicable?   public class Item_Custom_Pickaxe extends PickaxeItem { public Item_Custom_Pickaxe() { super(NijiTiers.OCOME, 1, -2.4F, new Properties().tab(OcomeNiji.OCOMEMOD_TAB).rarity(NijiRarity.EPIC));   =======Error====== } } I added it this way with a pickaxe. please help me  
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.