crops 1.14

[Draco18s]

Post your project as a git repository, because that's the easiest way for me to look at everything.

[Guest]

1 hour ago, Draco18s said:

Post your project as a git repository, because that's the easiest way for me to look at everything.

https://github.com/drmdgg/mcraft/tree/master/java/drmdgg/marijuanacraft

[Draco18s]

Change this to final or the annotation doesn't work.

https://github.com/drmdgg/mcraft/blob/master/java/drmdgg/marijuanacraft/init/blocks/BlockInit.java#L15

 

Also, you don't need to implement IGrowable, CropsBlock already does.

https://github.com/drmdgg/mcraft/blob/master/java/drmdgg/marijuanacraft/init/blocks/plants/MPlant.java#L29

 

What is this? Why is this here? You aren't even using it anyway.

https://github.com/drmdgg/mcraft/blob/master/java/drmdgg/marijuanacraft/init/blocks/plants/MPlant.java#L40-L49

 

You are still assigning to fields directly:

https://github.com/drmdgg/mcraft/blob/master/java/drmdgg/marijuanacraft/MarijuanaCraft.java#L165

 

Why do you have both a BlockInit and a BlockList? Your BlockList is also not using annotations, also not using final, and also being assigned to directly.

 

As far as I can tell, you haven't changed anything I've asked you to change. Or if you have, you haven't updated your git repo, which makes my searching for problems completely pointless because its not your code (it is outdated).

[Guest]

1 hour ago, Draco18s said:

Change this to final or the annotation doesn't work.

https://github.com/drmdgg/mcraft/blob/master/java/drmdgg/marijuanacraft/init/blocks/BlockInit.java#L15

 

Also, you don't need to implement IGrowable, CropsBlock already does.

https://github.com/drmdgg/mcraft/blob/master/java/drmdgg/marijuanacraft/init/blocks/plants/MPlant.java#L29

 

What is this? Why is this here? You aren't even using it anyway.

https://github.com/drmdgg/mcraft/blob/master/java/drmdgg/marijuanacraft/init/blocks/plants/MPlant.java#L40-L49

 

You are still assigning to fields directly:

https://github.com/drmdgg/mcraft/blob/master/java/drmdgg/marijuanacraft/MarijuanaCraft.java#L165

 

Why do you have both a BlockInit and a BlockList? Your BlockList is also not using annotations, also not using final, and also being assigned to directly.

 

As far as I can tell, you haven't changed anything I've asked you to change. Or if you have, you haven't updated your git repo, which makes my searching for problems completely pointless because its not your code (it is outdated).

I sincerely hope this is better. but its not running now:

https://github.com/drmdgg/mcraft/tree/master/java/drmdgg/marijuanacraft/java/drmdgg/marijuanacraft

and I don't fully understand this log:

https://pastebin.com/nXAFMzkc

[Draco18s]

Your item group is incorrect.

https://github.com/drmdgg/mcraft/blob/master/java/drmdgg/marijuanacraft/java/drmdgg/marijuanacraft/MJItemGroup.java#L7

 

You must use ModItemGroup and pass a Supplier<ItemStack> as at the point that the ItemGroup is constructed your icon item is null and vanilla code is Dumb about it.

 

Here's a working example:

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/industry/ExpandedIndustry.java#L59

 

 

Also, your repo is not correctly set up:

https://github.com/drmdgg/mcraft

That should contain the build.gradle file, and other files at that root directory. The way you've done it has completely fucked up where your resources are.

For example, it should look like this:

https://github.com/Draco18s/ReasonableRealism

[Guest]

2 hours ago, Draco18s said:

Your item group is incorrect.

https://github.com/drmdgg/mcraft/blob/master/java/drmdgg/marijuanacraft/java/drmdgg/marijuanacraft/MJItemGroup.java#L7

 

You must use ModItemGroup and pass a Supplier<ItemStack> as at the point that the ItemGroup is constructed your icon item is null and vanilla code is Dumb about it.

 

Here's a working example:

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/industry/ExpandedIndustry.java#L59

 

 

Also, your repo is not correctly set up:

https://github.com/drmdgg/mcraft

That should contain the build.gradle file, and other files at that root directory. The way you've done it has completely fucked up where your resources are.

For example, it should look like this:

https://github.com/Draco18s/ReasonableRealism

okay, I changed everything you told me to, but I'm still getting this:

https://pastebin.com/tRCKKfee

 

and as for the repo. that's just the repo, not my workstation

 

https://github.com/drmdgg/mcraft/tree/master/java/drmdgg/marijuanacraft

 

Edited October 12, 2019 by Guest

[Guest]

1 hour ago, diesieben07 said:

Thats not how this works. Your repository must be in your project root (where the build.gradle is). The MDK comes with a .gitignore file for a reason. But you're not actually using Git, so all this is pointless. Use Git. Yes, Github != Git.

 

This makes it so nobody can actually just clone your repo and test this locally.

sorry about that. I have to run out for a while...but if it's testing you want, go to this link: 

it's the best I can offer right now.

Edited October 12, 2019 by Guest

[Guest]

3 minutes ago, diesieben07 said:

I am not downloading a random zip file of the internet.

its my onedrive

[Guest]

1 hour ago, diesieben07 said:

Thats not how this works. Your repository must be in your project root (where the build.gradle is). The MDK comes with a .gitignore file for a reason. But you're not actually using Git, so all this is pointless. Use Git. Yes, Github != Git.

 

This makes it so nobody can actually just clone your repo and test this locally.

 

33 minutes ago, diesieben07 said:

I am not downloading a random zip file of the internet.

I wouldn't want to give a virus to anyone, especially those willing to help. here is the git repo the way draco has his set up

https://github.com/drmdgg/marijuanacraft

[Draco18s]

Great. You changed ONE thing in your ItemList to be final.

https://github.com/drmdgg/marijuanacraft/blob/master/src/main/java/drmdgg/marijuanacraft/lists/ItemList.java#L14

How about the rest of them, hmmm?

Ditto your block list:

https://github.com/drmdgg/marijuanacraft/blob/master/src/main/java/drmdgg/marijuanacraft/lists/BlockList.java#L22

 

The reason you're still getting null is because your marijuana_bud is null because @ObjectHolder only works on static final fields.

https://mcforge.readthedocs.io/en/1.13.x/concepts/registries/#injecting-registry-values-into-fields

Edited October 12, 2019 by Draco18s

[Guest]

40 minutes ago, Draco18s said:

Great. You changed ONE thing in your ItemList to be final.

https://github.com/drmdgg/marijuanacraft/blob/master/src/main/java/drmdgg/marijuanacraft/lists/ItemList.java#L14

How about the rest of them, hmmm?

Ditto your block list:

https://github.com/drmdgg/marijuanacraft/blob/master/src/main/java/drmdgg/marijuanacraft/lists/BlockList.java#L22

 

The reason you're still getting null is because your marijuana_bud is null because @ObjectHolder only works on static final fields.

https://mcforge.readthedocs.io/en/1.13.x/concepts/registries/#injecting-registry-values-into-fields

alright. I changed all the stuff to final for the ObjectHolder. https://github.com/drmdgg/marijuanacraft

 

still getting the same error

https://pastebin.com/Fu3bCQKz

[Draco18s]

Set a breakpoint here:

https://github.com/drmdgg/marijuanacraft/blob/master/src/main/java/drmdgg/marijuanacraft/MarijuanaCraft.java#L88

Run in debug mode and inspect the value of BlockList.mplant

[Guest]

24 minutes ago, Draco18s said:

Set a breakpoint here:

https://github.com/drmdgg/marijuanacraft/blob/master/src/main/java/drmdgg/marijuanacraft/MarijuanaCraft.java#L88

Run in debug mode and inspect the value of BlockList.mplant

gradlew runclient --debug?

 

and i'm only getting the same log and crash report (besides. Minecraft won't even get to the loading screen.)

[Animefan8888]

19 minutes ago, DrMDGG said:

gradlew runclient --debug?

No debug mode in your IDE. Which one are you using?

[Guest]

3 minutes ago, Animefan8888 said:

No debug mode in your IDE. Which one are you using?

eclipse

[Animefan8888]

1 minute ago, DrMDGG said:

eclipse

Excellent cause I don't know anything about IntelliJ. First set a breakpoint in your code by right clicking off to the left of the line you want to pause at and click "toggle breakpoint". Then up at the top next to the play button there is one that looks like a bug this is the debug run configuration thingy. Use this to run the runClient configuration.

[Guest]

37 minutes ago, Animefan8888 said:

Excellent cause I don't know anything about IntelliJ. First set a breakpoint in your code by right clicking off to the left of the line you want to pause at and click "toggle breakpoint". Then up at the top next to the play button there is one that looks like a bug this is the debug run configuration thingy. Use this to run the runClient configuration.

glad to hear it!

it said that there were 2 blocks that it was unable to load. one was a mistake on my part, and the other being the block mplant. it hadn't been registered. so I added it to the registry under registerBlocks. now the game boots again. but the texture still isn't there. the block breaks like a normal crop would, but its a square, black and pink. 

now I checked through all the json files and textures and they're all there.

[Animefan8888]

Just now, DrMDGG said:

now I checked through all the json files and textures and they're all there.

Post the console output.

[Guest]

16 minutes ago, Animefan8888 said:

Post the console output.

https://pastebin.com/JEtpbX9n

I stopped it there because what it says at the bottom disappeared when it ran fully.

as I said, I double checked the json files against the ones for wheat, and they all check out it seems.

[Animefan8888]

8 minutes ago, DrMDGG said:

as I said, I double checked the json files against the ones for wheat, and they all check out it seems.

Yes judging by those errors it appears your block doesn't have the AGE property in it. Which doesn't make sense because it extends CropsBlock which adds the property. Try overriding fillStateContainer in your plants Block class and add your age property to the builder.

Also you can remove this. You never use it.

[Draco18s]

2 hours ago, DrMDGG said:

eclipse

Or

Or

F11

Or

https://lmgtfy.com/?q=eclipse+run+debug

[Guest]

9 hours ago, Animefan8888 said:

Yes judging by those errors it appears your block doesn't have the AGE property in it. Which doesn't make sense because it extends CropsBlock which adds the property. Try overriding fillStateContainer in your plants Block class and add your age property to the builder.

Also you can remove this. You never use it.

okay. I removed that section. but I am having trouble finding the fillstatecontainer in my plants block class. 

 

theres one in "Clone" for my tree, but nothing in my MPlant class unless I'm blind

what line should I place the override?

[Animefan8888]

13 minutes ago, DrMDGG said:

okay. I removed that section. but I am having trouble finding the fillstatecontainer in my plants block class. 

fillStateContainer is a method in the Block class. If you are having a hard time overriding the method you can press ctrl+space and type the method name to get suggestions.

[Guest]

5 minutes ago, Animefan8888 said:

fillStateContainer is a method in the Block class. If you are having a hard time overriding the method you can press ctrl+space and type the method name to get suggestions.

my plants block class? or the block class. 

and also, I've tried pressing ctrl + space and typing fillStateContainer but nothing comes up along with "setAge" or "getAge" or "Age"

[Animefan8888]

1 minute ago, DrMDGG said:

or the block class. 

It exists in the Block class. You need to override it in your Block class I believe is called MPlant.