Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.10.2] Object Holder not working


Meldexun
 Share

Recommended Posts

6 minutes ago, Meldexun said:

Does the ObjectHolder annotation only work for classes as of 1.12.2?

No.

 

3 minutes ago, RaphGamingz said:

do you put your mod_id into the object holder? im not sure

You should post your code. And yes your modid needs to be present.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

1 minute ago, Animefan8888 said:

You should post your code.

Sure. Here it is:

@ObjectHolder(BetterDiving.MOD_ID)
public class ModItems {

	public static final Item TITANIUM = null;
	public static final Item COPPER_ORE = null;
	public static final Item SILVER_ORE = null;
	public static final Item LEAD = null;
	public static final Item GOLD = null;

	@EventBusSubscriber
	public static class ItemRegistrationHandler {

		public static final List<Item> ITEMS = new ArrayList<Item>();

		@SubscribeEvent
		public static void registerItems(RegistryEvent.Register<Item> event) {
			final Item[] items = {
					setItemName(new Item(), "titanium"),
					setItemName(new Item(), "copper_ore"),
					setItemName(new Item(), "silver_ore"),
					setItemName(new Item(), "lead"),
					setItemName(new Item(), "gold")
			};

			IForgeRegistry<Item> registry = event.getRegistry();

			for (Item item : items) {
				registry.register(item);
				ITEMS.add(item);
			}
		}

		private static Item setItemName(Item item, String name) {
			return setItemNameAndTab(item, name, BetterDiving.TAB_BETTER_DIVING);
		}

		private static Item setItemNameAndTab(Item item, String name, @Nullable CreativeTabs tab) {
			return item.setUnlocalizedName(name).setRegistryName(BetterDiving.MOD_ID, name).setCreativeTab(tab);
		}
	}

}

 

Link to comment
Share on other sites

25 minutes ago, Meldexun said:

After some testing it seems like i have to annotate every field with @ObjectHolder.

Also looking at Choonster's TestMod3 i saw that he also annotated every field.

Not true. Yes, you can do that, but it is not required.

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/harderores/HarderOres.java#L174

Just that the name-matching has to be exact (only ignoring case).

Edited by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

1 hour ago, Meldexun said:

Probably naming the fields with lowercase letters is the key.

https://mcforge.readthedocs.io/en/latest/concepts/registries/#injecting-registry-values-into-fields

    public static final Item ENDER_PEARL = null;    // Note that the actual name is "minecraft:ender_pearl", not "minecraft:ENDER_PEARL".
                                                    // However, since constructing a ResourceLocation lowerc

 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

On 10/12/2019 at 3:05 AM, Draco18s said:

https://mcforge.readthedocs.io/en/latest/concepts/registries/#injecting-registry-values-into-fields


    public static final Item ENDER_PEARL = null;    // Note that the actual name is "minecraft:ender_pearl", not "minecraft:ENDER_PEARL".
                                                    // However, since constructing a ResourceLocation lowerc

 

Well that's 1.12.2 not 1.10.2. Also when lowercasing the names of the fields it works as well as annotating the fields but leaving them uppercase doesn't work.

Edited by Meldexun
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Delete this server config file if you have not modified it.
    • Yesterday our server crashed with little notice. Below are the crash logs. Anyone able to help out?   ---- Minecraft Crash Report ---- // Shall we play a game? Time: 25/1/22, 6:07 pm Description: Exception in server tick loop net.minecraftforge.fml.config.ConfigFileTypeHandler$ConfigLoadingException: Failed loading config file travelersbackpack-server.toml of type SERVER for modid travelersbackpack at net.minecraftforge.fml.config.ConfigFileTypeHandler.lambda$reader$1(ConfigFileTypeHandler.java:61) ~[fmlcore-1.18.1-39.0.45.jar%2366!/:?] {} at net.minecraftforge.fml.config.ConfigTracker.openConfig(ConfigTracker.java:74) ~[fmlcore-1.18.1-39.0.45.jar%2366!/:?] {} at net.minecraftforge.fml.config.ConfigTracker.lambda$loadConfigs$1(ConfigTracker.java:64) ~[fmlcore-1.18.1-39.0.45.jar%2366!/:?] {} at java.lang.Iterable.forEach(Iterable.java:75) ~[?:?] {} at java.util.Collections$SynchronizedCollection.forEach(Collections.java:2131) ~[?:?] {} at net.minecraftforge.fml.config.ConfigTracker.loadConfigs(ConfigTracker.java:64) ~[fmlcore-1.18.1-39.0.45.jar%2366!/:?] {} at net.minecraftforge.server.ServerLifecycleHooks.handleServerAboutToStart(ServerLifecycleHooks.java:94) ~[forge-1.18.1-39.0.45-universal.jar%2369!/:?] {re:classloading} at net.minecraft.server.dedicated.DedicatedServer.m_7038_(DedicatedServer.java:173) ~[server-1.18.1-20211210.034407-srg.jar%2365!/:?] {re:classloading,pl:accesstransformer:B} at net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:644) ~[server-1.18.1-20211210.034407-srg.jar%2365!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:balm.mixins.json:MinecraftServerAccessor,pl:mixin:APP:balm.mixins.json:MinecraftServerMixin,pl:mixin:A} at net.minecraft.server.MinecraftServer.m_177918_(MinecraftServer.java:258) ~[server-1.18.1-20211210.034407-srg.jar%2365!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:balm.mixins.json:MinecraftServerAccessor,pl:mixin:APP:balm.mixins.json:MinecraftServerMixin,pl:mixin:A} at java.lang.Thread.run(Thread.java:833) [?:?] {} Caused by: com.electronwill.nightconfig.core.io.ParsingException: Not enough data available at com.electronwill.nightconfig.core.io.ParsingException.notEnoughData(ParsingException.java:22) ~[core-3.6.4.jar%237!/:?] {} at com.electronwill.nightconfig.core.io.ReaderInput.directReadChar(ReaderInput.java:36) ~[core-3.6.4.jar%237!/:?] {} at com.electronwill.nightconfig.core.io.AbstractInput.readChar(AbstractInput.java:49) ~[core-3.6.4.jar%237!/:?] {} at com.electronwill.nightconfig.core.io.AbstractInput.readCharsUntil(AbstractInput.java:123) ~[core-3.6.4.jar%237!/:?] {} at com.electronwill.nightconfig.toml.TableParser.parseKey(TableParser.java:166) ~[toml-3.6.4.jar%238!/:?] {} at com.electronwill.nightconfig.toml.TableParser.parseDottedKey(TableParser.java:145) ~[toml-3.6.4.jar%238!/:?] {} at com.electronwill.nightconfig.toml.TableParser.parseNormal(TableParser.java:55) ~[toml-3.6.4.jar%238!/:?] {} at com.electronwill.nightconfig.toml.TomlParser.parse(TomlParser.java:44) ~[toml-3.6.4.jar%238!/:?] {} at com.electronwill.nightconfig.toml.TomlParser.parse(TomlParser.java:37) ~[toml-3.6.4.jar%238!/:?] {} at com.electronwill.nightconfig.core.io.ConfigParser.parse(ConfigParser.java:113) ~[core-3.6.4.jar%237!/:?] {} at com.electronwill.nightconfig.core.io.ConfigParser.parse(ConfigParser.java:219) ~[core-3.6.4.jar%237!/:?] {} at com.electronwill.nightconfig.core.io.ConfigParser.parse(ConfigParser.java:202) ~[core-3.6.4.jar%237!/:?] {} at com.electronwill.nightconfig.core.file.WriteSyncFileConfig.load(WriteSyncFileConfig.java:73) ~[core-3.6.4.jar%237!/:?] {} at com.electronwill.nightconfig.core.file.AutosaveCommentedFileConfig.load(AutosaveCommentedFileConfig.java:85) ~[core-3.6.4.jar%237!/:?] {} at net.minecraftforge.fml.config.ConfigFileTypeHandler.lambda$reader$1(ConfigFileTypeHandler.java:57) ~[fmlcore-1.18.1-39.0.45.jar%2366!/:?] {} ... 10 more A detailed walkthrough of the error, its code path and all known details is as follows: --------------------------------------------------------------------------------------- -- System Details -- Details: Minecraft Version: 1.18.1 Minecraft Version ID: 1.18.1 Operating System: Windows 10 (amd64) version 10.0 Java Version: 17.0.2, Oracle Corporation Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode, sharing), Oracle Corporation Memory: 4789453312 bytes (4567 MiB) / 7662993408 bytes (7308 MiB) up to 8589934592 bytes (8192 MiB) CPUs: 16 Processor Vendor: AuthenticAMD Processor Name: AMD Ryzen 7 2700 Eight-Core Processor Identifier: AuthenticAMD Family 23 Model 8 Stepping 2 Microarchitecture: Zen+ Frequency (GHz): 3.20 Number of physical packages: 1 Number of physical CPUs: 8 Number of logical CPUs: 16 Graphics card #0 name: NVIDIA GeForce GTX 1660 Ti Graphics card #0 vendor: NVIDIA (0x10de) Graphics card #0 VRAM (MB): 4095.00 Graphics card #0 deviceId: 0x2182 Graphics card #0 versionInfo: DriverVersion=30.0.14.7111 Memory slot #0 capacity (MB): 16384.00 Memory slot #0 clockSpeed (GHz): 2.40 Memory slot #0 type: DDR4 Memory slot #1 capacity (MB): 16384.00 Memory slot #1 clockSpeed (GHz): 2.40 Memory slot #1 type: DDR4 Virtual memory max (MB): 34765.36 Virtual memory used (MB): 17914.00 Swap memory total (MB): 2048.00 Swap memory used (MB): 0.00 JVM Flags: 2 total; -Xmx8G -Xms7G Server Running: true Player Count: 0 / 20; [] Data Packs: vanilla, mod:mcwbridges, mod:enchdesc, mod:swingthroughgrass, mod:jei (incompatible), mod:flywheel, mod:patchouli, mod:create, mod:createdeco (incompatible), mod:clumps (incompatible), mod:cookingforblockheads, mod:storagedrawers (incompatible), mod:naturescompass (incompatible), mod:tombstone, mod:naturesaura (incompatible), mod:balm (incompatible), mod:jeresources, mod:forge, mod:aquaculture (incompatible), mod:cosmeticarmorreworked (incompatible), mod:valhelsia_core, mod:forbidden_arcanus, mod:createaddition (incompatible), mod:betteradvancements, mod:starlight, mod:mahoutsukai, mod:travelersbackpack Is Modded: Definitely; Server brand changed to 'forge' Type: Dedicated Server (map_server.txt) ModLauncher: 9.1.0+9.1.0+main.6690ee51 ModLauncher launch target: forgeserver ModLauncher naming: srg ModLauncher services: mixin PLUGINSERVICE eventbus PLUGINSERVICE object_holder_definalize PLUGINSERVICE runtime_enum_extender PLUGINSERVICE capability_token_subclass PLUGINSERVICE accesstransformer PLUGINSERVICE runtimedistcleaner PLUGINSERVICE mixin TRANSFORMATIONSERVICE fml TRANSFORMATIONSERVICE FML Language Providers: minecraft@1.0 javafml@null Mod List: server-1.18.1-20211210.034407-srg.jar |Minecraft |minecraft |1.18.1 |DONE |Manifest: NOSIGNATURE mcw-bridges-2.0.1-mc1.18.1.jar |Macaw's Bridges |mcwbridges |2.0.1 |DONE |Manifest: NOSIGNATURE EnchantmentDescriptions-Forge-1.18.1-9.0.9.jar |EnchantmentDescriptions |enchdesc |9.0.9 |DONE |Manifest: NOSIGNATURE swingthroughgrass-1.18.1-1.8.0.jar |SwingThroughGrass |swingthroughgrass |1.18.1-1.8.0 |DONE |Manifest: NOSIGNATURE jei-1.18.1-9.2.1.69.jar |Just Enough Items |jei |9.2.1.69 |DONE |Manifest: NOSIGNATURE flywheel-forge-1.18-0.5.1.jar |Flywheel |flywheel |1.18-0.5.1 |DONE |Manifest: NOSIGNATURE Patchouli-1.18.1-64.jar |Patchouli |patchouli |1.18.1-64 |DONE |Manifest: NOSIGNATURE create-mc1.18.1_v0.4c.jar |Create |create |0.4c |DONE |Manifest: NOSIGNATURE createdeco-1.2.3-1.18.jar |Create Deco |createdeco |1.2.3-1.18 |DONE |Manifest: NOSIGNATURE Clumps-forge-1.18.1-8.0.4.jar |Clumps |clumps |8.0.4 |DONE |Manifest: NOSIGNATURE cookingforblockheads-forge-1.18.1-11.1.0.jar |CookingForBlockheads |cookingforblockheads |11.1.0 |DONE |Manifest: NOSIGNATURE TravelersBackpack-1.18.1-7.0.1.jar |Traveler's Backpack |travelersbackpack |7.0.1 |DONE |Manifest: NOSIGNATURE StorageDrawers-1.18.1-10.1.1.jar |Storage Drawers |storagedrawers |10.1.1 |DONE |Manifest: NOSIGNATURE NaturesCompass-1.18.1-1.9.4-forge.jar |Nature's Compass |naturescompass |1.18.1-1.9.4-forge |DONE |Manifest: NOSIGNATURE tombstone-7.3.5-1.18.jar |Corail Tombstone |tombstone |7.3.5 |DONE |Manifest: NOSIGNATURE NaturesAura-35.4.jar |Nature's Aura |naturesaura |35.4 |DONE |Manifest: NOSIGNATURE starlight-1.0.0+forge.8f9b922.Aeiou.jar |Starlight |starlight |1.0.0+forge.4fd2e63 |DONE |Manifest: NOSIGNATURE mahoutsukai-1.18.1-v1.34.0.jar |Mahou Tsukai |mahoutsukai |1.18.1-v1.34.0 |DONE |Manifest: NOSIGNATURE balm-2.4.1+0.jar |Balm |balm |2.4.1+0 |DONE |Manifest: NOSIGNATURE JustEnoughResources-1.18.1-0.13.1.141.jar |Just Enough Resources |jeresources |0.13.1.141 |DONE |Manifest: NOSIGNATURE forge-1.18.1-39.0.45-universal.jar |Forge |forge |39.0.45 |DONE |Manifest: 84:ce:76:e8:45:35:e4:0e:63:86:df:47:59:80:0f:67:6c:c1:5f:6e:5f:4d:b3:54:47:1a:9f:7f:ed:5e:f2:90 Aquaculture-1.18.1-2.3.2.jar |Aquaculture 2 |aquaculture |1.18.1-2.3.2 |DONE |Manifest: NOSIGNATURE CosmeticArmorReworked-1.18.1-v1a.jar |CosmeticArmorReworked |cosmeticarmorreworked |1.18.1-v1a |DONE |Manifest: 5e:ed:25:99:e4:44:14:c0:dd:89:c1:a9:4c:10:b5:0d:e4:b1:52:50:45:82:13:d8:d0:32:89:67:56:57:01:53 valhelsia_core-1.18.1-0.3.2.jar |Valhelsia Core |valhelsia_core |1.18.1-0.3.2 |DONE |Manifest: NOSIGNATURE forbidden_arcanus-1.18.1-2.0.2.jar |Forbidden & Arcanus |forbidden_arcanus |1.18.1-2.0.2 |DONE |Manifest: NOSIGNATURE createaddition-1.18.1-20220111b.jar |Create Crafts & Additions |createaddition |1.18.1-20220111b |DONE |Manifest: NOSIGNATURE BetterAdvancements-1.18.1-0.1.2.122.jar |Better Advancements |betteradvancements |0.1.2.122 |DONE |Manifest: NOSIGNATURE Crash Report UUID: 15ab4e22-c0b0-4e5f-8768-6c83dd01c93f FML: 39.0 Forge: net.minecraftforge:39.0.45  
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.