Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[SOLVED] [1.15.1] Confused why entityDropItem fire multiple time


kwpugh
 Share

Recommended Posts

Hi All,

 

Looking for some help here.  I went back to my Udemy Java course and refreshed on the Lists and For each loops to check my thinking, but I am still perplexed.

 

The block does what I want it to do, EXCEPT that the entityDropItem fires any where from 9-12 times each time I spawn a Zombie to test the block.

 

Here is my code:

package com.kwpugh.gobber2.blocks;

import java.util.List;
import java.util.Random;

import javax.annotation.Nullable;

import com.kwpugh.gobber2.Gobber2;

import net.minecraft.block.Block;
import net.minecraft.block.BlockRenderType;
import net.minecraft.block.BlockState;
import net.minecraft.block.Blocks;
import net.minecraft.block.FireBlock;
import net.minecraft.client.util.ITooltipFlag;
import net.minecraft.entity.Entity;
import net.minecraft.entity.LivingEntity;
import net.minecraft.entity.MobEntity;
import net.minecraft.entity.boss.WitherEntity;
import net.minecraft.entity.boss.dragon.EnderDragonEntity;
import net.minecraft.entity.item.ArmorStandEntity;
import net.minecraft.entity.merchant.villager.VillagerEntity;
import net.minecraft.entity.merchant.villager.WanderingTraderEntity;
import net.minecraft.entity.monster.ElderGuardianEntity;
import net.minecraft.entity.monster.GuardianEntity;
import net.minecraft.entity.monster.SkeletonEntity;
import net.minecraft.entity.monster.SpellcastingIllagerEntity;
import net.minecraft.entity.monster.VexEntity;
import net.minecraft.entity.monster.VindicatorEntity;
import net.minecraft.entity.monster.ZombieEntity;
import net.minecraft.entity.monster.ZombiePigmanEntity;
import net.minecraft.entity.monster.ZombieVillagerEntity;
import net.minecraft.entity.passive.AnimalEntity;
import net.minecraft.entity.passive.DolphinEntity;
import net.minecraft.entity.passive.IronGolemEntity;
import net.minecraft.entity.passive.WaterMobEntity;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.item.ItemStack;
import net.minecraft.item.Items;
import net.minecraft.util.ActionResultType;
import net.minecraft.util.Hand;
import net.minecraft.util.math.AxisAlignedBB;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.BlockRayTraceResult;
import net.minecraft.util.text.ITextComponent;
import net.minecraft.util.text.StringTextComponent;
import net.minecraft.util.text.TextFormatting;
import net.minecraft.world.IBlockReader;
import net.minecraft.world.World;
import net.minecraft.world.server.ServerWorld;
import net.minecraftforge.api.distmarker.Dist;
import net.minecraftforge.api.distmarker.OnlyIn;

public class BlockLooter extends Block
{

	public BlockLooter(Properties properties)
	{
		super(properties.func_226896_b_());
	}

	int minTickTime = 5;
	int maxTickTime = 20;

	//Start it up when placed
	@Override
	public void onBlockAdded(BlockState state, World world, BlockPos pos, BlockState oldState, boolean isMoving)
	{
		world.getPendingBlockTicks().scheduleTick(pos, state.getBlock(), world.rand.nextInt(maxTickTime - minTickTime + 1));
	}
	  
	//Start it up if wlaked over
	public void onEntityWalk(World worldIn, BlockPos pos, Entity entityIn)
	{
		BlockState stateIn = worldIn.getBlockState(pos);
		worldIn.getPendingBlockTicks().scheduleTick(pos, stateIn.getBlock(), worldIn.rand.nextInt(maxTickTime - minTickTime + 1));   
	}

	//Start it up if right-clicked on
	@Override
	public ActionResultType func_225533_a_(BlockState state, World worldIn, BlockPos pos, PlayerEntity player, Hand handIn, BlockRayTraceResult hit)
	{
		worldIn.getPendingBlockTicks().scheduleTick(pos, state.getBlock(), worldIn.rand.nextInt(maxTickTime - minTickTime + 1));
		player.sendMessage(new StringTextComponent("The Looter is active in a range of 18 blocks"));
		return ActionResultType.SUCCESS;
	}
    
	@Override
	public BlockRenderType getRenderType(BlockState state)
	{
		return BlockRenderType.MODEL;
	}
    
	@Override
	public void func_225534_a_(BlockState state,ServerWorld world, BlockPos pos,  Random random)
	{
		if(!world.isRemote)
		{			   
			int radius = 18;
		   
			//Scan the radius for LivingEntity and store in list
			List<Entity> mobs = world.getEntitiesWithinAABB(LivingEntity.class, new AxisAlignedBB(pos.getX() - radius, pos.getY() - radius, pos.getZ() - radius, pos.getX() + radius, pos.getY() + radius, pos.getZ() + radius), e -> (e instanceof LivingEntity));
			for(Entity mob : mobs)
			{
				System.out.println(mob + "," + mobs); //debuging in console
				
				//If a player is within the list, kick start the block
				if(mob instanceof PlayerEntity)
				{
					world.getPendingBlockTicks().scheduleTick(pos, state.getBlock(), random.nextInt(minTickTime));
				
					BlockPos posUp = pos.up();		
					BlockState flaming = ((FireBlock)Blocks.FIRE).getStateForPlacement(world, posUp);
					world.setBlockState(posUp, flaming, 11);
				}
			   
				// These types of mobs are excluded 
				if(mob instanceof PlayerEntity ||
						mob instanceof ArmorStandEntity ||
						mob instanceof VillagerEntity || 
						mob instanceof WanderingTraderEntity ||
						mob instanceof AnimalEntity || 
						mob instanceof IronGolemEntity || 
						mob instanceof DolphinEntity ||
						mob instanceof WaterMobEntity ||
						mob instanceof GuardianEntity ||
						mob instanceof ElderGuardianEntity ||
						mob instanceof SpellcastingIllagerEntity ||
						mob instanceof VexEntity ||
						mob instanceof VindicatorEntity ||
						mob instanceof WitherEntity ||
						mob instanceof EnderDragonEntity)
				{
					continue;
				}
				
				if(mob instanceof ZombiePigmanEntity || mob instanceof ZombieEntity || mob instanceof ZombieVillagerEntity)
				{
					((MobEntity) mob).spawnExplosionParticle();
					((LivingEntity) mob).setHealth(0);
					mob.entityDropItem(Items.GOLD_NUGGET,1);
					Gobber2.logger.info("drop executed for " + mob + "," + " values of mobs " + mobs);		
				}
		   }
	   }
   }
    
	@OnlyIn(Dist.CLIENT)
	public void addInformation(ItemStack stack, @Nullable IBlockReader world, List<ITextComponent> tooltip, ITooltipFlag flag)
	{
		super.addInformation(stack, world, tooltip, flag);				
		tooltip.add(new StringTextComponent(TextFormatting.BLUE + "The Looter "));
		tooltip.add(new StringTextComponent(TextFormatting.GREEN + "Range: 18 blocks"));
	}
}

 

I have been going through this for hours, trying different things to no avail.   Help please.

 

Regards.

Link to comment
Share on other sites

1) Your "these mobs are excluded" block is irrelevant. You only care about players and zombies, which you have blocks for. Any entity that is not those things does nothing already, there's no reason to grab everything else (you're not grabbing mod added entities for instance!) and skipping them is pointless.

2) ZombiePigman extends Zombie, so that check is extraneous as well.

3) You're setting mob's health to zero, but the entity is not immediately made dead and removed for at least the next tick, but you aren't checking to make sure that the mob is still alive before doing your thing.

4) TranslationTextComponent (and applyTextStyle(...)) exists. Use it.

Edited by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

13 minutes ago, Draco18s said:

1) Your "these mobs are excluded" block is irrelevant. You only care about players and zombies, which you have blocks for. Any entity that is not those things does nothing already, there's no reason to grab everything else (you're not grabbing mod added entities for instance!) and skipping them is pointless.

2) ZombiePigman extends Zombie, so that check is extraneous as well.

3) You're setting mob's health to zero, but the entity is not immediately made dead and removed for at least the next tick, but you aren't checking to make sure that the mob is still alive before doing your thing.

4) TranslationTextComponent exists. Use it.

1) Good point, that is code that I will delete

2) ditto

3) I did not know it was not immediate.  In 1.12.2 I had used  ((EntityLivingBase) entity).setDead();  which had worked fine, but appears gone in 1.15.1.  Also, see code snippet for how I had tried to check if it was alive before doing the drop.   That did not work.

4.) I'll take a look at the TranslationTextComponent.

 

				if(mob instanceof ZombiePigmanEntity || mob instanceof ZombieEntity || mob instanceof ZombieVillagerEntity)
				{
					((MobEntity) mob).spawnExplosionParticle();
					((LivingEntity) mob).setHealth(0);
					if(!mob.isAlive())
					{
						mob.entityDropItem(Items.GOLD_NUGGET,1);
						Gobber2.logger.info("drop executed for " + mob + "," + " values of mobs " + mobs);	
					}
				
				}

 

Link to comment
Share on other sites

I was going back through the Entity.class to look for other options.   I found remove(boolean).

 

This code does what I need, but is it the intended usage of remove(boolean)?

				if(mob instanceof ZombieEntity || mob instanceof ZombieVillagerEntity)
				{
					((MobEntity) mob).spawnExplosionParticle();
					mob.remove(true);
					mob.entityDropItem(Items.GOLD_NUGGET,1);
				}

 

Link to comment
Share on other sites

36 minutes ago, kwpugh said:

((LivingEntity) mob).setHealth(0);

if(!mob.isAlive()) { ... }

isAlive is going to return false if the mob's health is zero...

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

  • kwpugh changed the title to [SOLVED] [1.15.1] Confused why entityDropItem fire multiple time

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Ok i didnt undertand absolutely anything, even that i learned minecraft modding 1 year ago, can you post a image with code of how can i do that please?
    • check if your event is getting fired, first (and you must be in 3rd person on singleplayer for it to work). second, modifying those values doesn't do anything. It is already rendered (in post) or the values will be overwritten for rendering (in pre). You need to cancel the rendering and do it yourself. I do it with the field model#visible = false in pre, then in post, set it to true, then modify the rotation points and angles, then render it using the render method that takes the buffer, vertex builder, ... it would be much easier to use rightArmPose = ... in PRE. 
    • Have you registered your class as EventBusSubscriber on the correct bus?
    • Nope, 1.16 is going to stay as LTS and 1.17 is getting a 1 month grace period.
    • I downloaded ATM7 on the curseforge launcher and installed it, I can launch it and play it just fine the first time. I can play for as long as I want; when I close the game and exit I can re-launch the game just fine. I turn my PC off and back on again in the morning and try to launch it, that's when it errors out and can't "complete the mod scan". The only way around it I've found is making a new profile for it in curseforge, basically re-downloading it and playing it for "the first time" again. I have a RTX 2080 Ti Strix, an i5 8600K and 32 GB of ram with 8 GB allocated to Minecraft. The crash report as follows:  ---- Minecraft Crash Report ---- // Shall we play a game? Time: 11/30/21, 12:09 PM Description: Initializing game java.lang.IllegalStateException: Failed to complete mod scan     at net.minecraftforge.fml.loading.moddiscovery.BackgroundScanHandler.waitForScanToComplete(BackgroundScanHandler.java:103) ~[fmlloader-1.17.1-37.0.109.jar%2322!:?] {}     at net.minecraftforge.fml.ModLoader.gatherAndInitializeMods(ModLoader.java:153) ~[fmlcore-1.17.1-37.0.109.jar%23218!:?] {}     at net.minecraftforge.fmlclient.ClientModLoader.lambda$begin$1(ClientModLoader.java:108) ~[forge-1.17.1-37.0.109-universal.jar%23221!:?] {re:classloading,pl:runtimedistcleaner:A}     at net.minecraftforge.fmlclient.ClientModLoader.lambda$createRunnableWithCatch$4(ClientModLoader.java:129) ~[forge-1.17.1-37.0.109-universal.jar%23221!:?] {re:classloading,pl:runtimedistcleaner:A}     at net.minecraftforge.fmlclient.ClientModLoader.begin(ClientModLoader.java:108) ~[forge-1.17.1-37.0.109-universal.jar%23221!:?] {re:classloading,pl:runtimedistcleaner:A}     at net.minecraft.client.Minecraft.<init>(Minecraft.java:460) ~[client-1.17.1-20210706.113038-srg.jar%23217!:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A}     at net.minecraft.client.main.Main.main(Main.java:151) ~[client-1.17.1-20210706.113038-srg.jar%23217!:?] {re:classloading,pl:runtimedistcleaner:A}     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] {}     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78) ~[?:?] {}     at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] {}     at java.lang.reflect.Method.invoke(Method.java:567) ~[?:?] {}     at net.minecraftforge.fml.loading.targets.CommonClientLaunchHandler.lambda$launchService$0(CommonClientLaunchHandler.java:45) ~[fmlloader-1.17.1-37.0.109.jar%2322!:?] {}     at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.Launcher.run(Launcher.java:106) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.Launcher.main(Launcher.java:77) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:90) [bootstraplauncher-0.1.17.jar:?] {} A detailed walkthrough of the error, its code path and all known details is as follows: --------------------------------------------------------------------------------------- -- Head -- Thread: Render thread Stacktrace:     at net.minecraftforge.fml.loading.moddiscovery.BackgroundScanHandler.waitForScanToComplete(BackgroundScanHandler.java:103) ~[fmlloader-1.17.1-37.0.109.jar%2322!:?] {}     at net.minecraftforge.fml.ModLoader.gatherAndInitializeMods(ModLoader.java:153) ~[fmlcore-1.17.1-37.0.109.jar%23218!:?] {}     at net.minecraftforge.fmlclient.ClientModLoader.lambda$begin$1(ClientModLoader.java:108) ~[forge-1.17.1-37.0.109-universal.jar%23221!:?] {re:classloading,pl:runtimedistcleaner:A}     at net.minecraftforge.fmlclient.ClientModLoader.lambda$createRunnableWithCatch$4(ClientModLoader.java:129) ~[forge-1.17.1-37.0.109-universal.jar%23221!:?] {re:classloading,pl:runtimedistcleaner:A}     at net.minecraftforge.fmlclient.ClientModLoader.begin(ClientModLoader.java:108) ~[forge-1.17.1-37.0.109-universal.jar%23221!:?] {re:classloading,pl:runtimedistcleaner:A}     at net.minecraft.client.Minecraft.<init>(Minecraft.java:460) ~[client-1.17.1-20210706.113038-srg.jar%23217!:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A} -- Initialization -- Details: Stacktrace:     at net.minecraft.client.main.Main.main(Main.java:151) ~[client-1.17.1-20210706.113038-srg.jar%23217!:?] {re:classloading,pl:runtimedistcleaner:A}     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] {}     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78) ~[?:?] {}     at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] {}     at java.lang.reflect.Method.invoke(Method.java:567) ~[?:?] {}     at net.minecraftforge.fml.loading.targets.CommonClientLaunchHandler.lambda$launchService$0(CommonClientLaunchHandler.java:45) ~[fmlloader-1.17.1-37.0.109.jar%2322!:?] {}     at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.Launcher.run(Launcher.java:106) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.Launcher.main(Launcher.java:77) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:90) [bootstraplauncher-0.1.17.jar:?] {} -- System Details -- Details:     Minecraft Version: 1.17.1     Minecraft Version ID: 1.17.1     Operating System: Windows 10 (amd64) version 10.0     Java Version: 16.0.1, Microsoft     Java VM Version: OpenJDK 64-Bit Server VM (mixed mode), Microsoft     Memory: 1436850640 bytes (1370 MiB) / 2885681152 bytes (2752 MiB) up to 9663676416 bytes (9216 MiB)     CPUs: 6     Processor Vendor: GenuineIntel     Processor Name: Intel(R) Core(TM) i5-8600K CPU @ 3.60GHz     Identifier: Intel64 Family 6 Model 158 Stepping 10     Microarchitecture: Coffee Lake     Frequency (GHz): 3.60     Number of physical packages: 1     Number of physical CPUs: 6     Number of logical CPUs: 6     Graphics card #0 name: NVIDIA GeForce RTX 2080 Ti     Graphics card #0 vendor: NVIDIA (0x10de)     Graphics card #0 VRAM (MB): 4095.00     Graphics card #0 deviceId: 0x1e07     Graphics card #0 versionInfo: DriverVersion=30.0.14.9649     Memory slot #0 capacity (MB): 16384.00     Memory slot #0 clockSpeed (GHz): 2.13     Memory slot #0 type: DDR4     Memory slot #1 capacity (MB): 16384.00     Memory slot #1 clockSpeed (GHz): 2.13     Memory slot #1 type: DDR4     Virtual memory max (MB): 34740.69     Virtual memory used (MB): 18387.16     Swap memory total (MB): 2048.00     Swap memory used (MB): 81.51     JVM Flags: 5 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -Xmx9216m -Xms256m -XX:PermSize=256m     Launched Version: forge-37.0.109     Backend library: LWJGL version 3.2.2 SNAPSHOT     Backend API: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 GL version 3.2.0 NVIDIA 496.49, NVIDIA Corporation     Window size: <not initialized>     GL Caps: Using framebuffer using OpenGL 3.2     GL debug messages:      Using VBOs: Yes     Is Modded: Definitely; Client brand changed to 'forge'     Type: Client (map_client.txt)     CPU: 6x Intel(R) Core(TM) i5-8600K CPU @ 3.60GHz     ModLauncher: 9.0.7+91+master.8569cdf     ModLauncher launch target: forgeclient     ModLauncher naming: srg     ModLauncher services:           mixin PLUGINSERVICE           eventbus PLUGINSERVICE           object_holder_definalize PLUGINSERVICE           runtime_enum_extender PLUGINSERVICE           capability_token_subclass PLUGINSERVICE           capability_inject_definalize PLUGINSERVICE           accesstransformer PLUGINSERVICE           runtimedistcleaner PLUGINSERVICE           mixin TRANSFORMATIONSERVICE           fml TRANSFORMATIONSERVICE      FML Language Providers:          minecraft@1.0         kotori_scala@2.13.6-build-4         javafml@null
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.