Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[Solved] ItemStack Capabilities reset when moved in creative inventory


MrMarnic
 Share

Recommended Posts

I have attached an inventory to an item with the slot size of one (At the beggining the slot is empty).

When you right click with this item a gold ingot will be set in the slot.

If you sneak and right click the Display name of the inserted item will be printed. (At first "Air" because not item is set)

 

The issue was already adressed here, but there was never as solution.

Old issue

public class InventoryTestItem extends Item {
    public InventoryTestItem(Properties properties) {
        super(properties);
        setRegistryName("inv_test");
    }

    @Override
    public ActionResult<ItemStack> onItemRightClick(World worldIn, PlayerEntity playerIn, Hand handIn) {
        if(playerIn.isSneaking()) {
            playerIn.getHeldItem(handIn).getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY,null).ifPresent((h)-> {
                ItemStackHandler handler = (ItemStackHandler) h;
                handler.setStackInSlot(0,new ItemStack(Items.GOLD_INGOT));
            });
        }else {
            playerIn.getHeldItem(handIn).getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY,null).ifPresent((h)-> {
                ItemStackHandler handler = (ItemStackHandler) h;
                System.out.println(handler.getStackInSlot(0).getDisplayName());
            });
        }
        return super.onItemRightClick(worldIn, playerIn, handIn);
    }

    @Nullable
    @Override
    public ICapabilityProvider initCapabilities(ItemStack stack, @Nullable CompoundNBT nbt) {
        return new InventoryTestProvider();
    }

    public class InventoryTestProvider implements ICapabilityProvider, ICapabilitySerializable<CompoundNBT> {

        public ItemStackHandler handler;

        public InventoryTestProvider() {
            this.handler = new ItemStackHandler(1);
        }

        @Nonnull
        @Override
        public <T> LazyOptional<T> getCapability(@Nonnull Capability<T> capability, @Nullable Direction side) {
            if(capability == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY) {
                return LazyOptional.of(()->(T)handler);
            }
            return LazyOptional.empty();
        }

        @Override
        public CompoundNBT serializeNBT() {
            CompoundNBT tag = new CompoundNBT();
            tag.put("itemHandler",handler.serializeNBT());
            return tag;
        }

        @Override
        public void deserializeNBT(CompoundNBT nbt) {
            handler.deserializeNBT(nbt.getCompound("itemHandler"));
        }
    }
}

 

The ItemStack will always keep the Gold Ingot (if set), even when moved in inventories (like chests).

But when I move the Item in the Creative Inventory (for example from slot 1 to 2) the capability is reset and the "Air" is printed as Displayname.

Edited by MrMarnic
Link to comment
Share on other sites

I'm not sure that this can be fixed. The client has authoratative control over their inventory when in creative mode (that's literally how it works, the client says "yeah, this slot is X now"). As such moving an item from one slot to another has the effect of destroying and recreating the stack (pickup: "this slot is now air", place: "this slot is now a backpack"). Unless the client knew about the capability (and its data), then the capability gets reset (and even then, the client would have to know to send that cap data to the server).

Edited by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

3 minutes ago, Draco18s said:

I'm not sure that this can be fixed. The client has authoratative control over their inventory when in creative mode (that's literally how it works, the client says "yeah, this slot is X now"). As such moving an item from one slot to another has the effect of destroying and recreating the stack (pickup: "this slot is now air", place: "this slot is now a backpack"). Unless the client knew about the capability (and its data), then the capability gets reset (and even then, the client would have to know to send that cap data to the server).

Ok I undestand that. But can I maybe send the capability trough getShareTag() ? Or is this not possible at all and I can not create a Backpack item with capabilites?

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Ran again after I got up, had a different error: PS C:\Users\user\Desktop\MinecraftForge> ./gradlew setup To honour the JVM settings for this build a single-use Daemon process will be forked. See https://docs.gradle.org/7.2/userguide/gradle_daemon.html#sec:disabling_the_daemon. Daemon will be stopped at the end of the build > Configure project : Version: 1.17.1-37.0.61 Java: 1.8.0_291 JVM: 25.291-b10(Oracle Corporation) Arch: amd64 > Configure project :clean WARNING: This project is configured to use the official obfuscation mappings provided by Mojang. These mapping fall under their associated license, you should be fully aware of this license. For the latest license text, refer below, or the reference copy here: https://github.com/MinecraftForge/MCPConfig/blob/master/Mojang.md, You can hide this warning by running the `hideOfficialWarningUntilChanged` task WARNING: (c) 2020 Microsoft Corporation. These mappings are provided "as-is" and you bear the risk of using them. You may copy and use the mappings for development purposes, but you may not redistribute the mappings complete and unmodified. Microsoft makes no warranties, express or implied, with respect to the mappings provided here. Use and modification of this document or the source code (in any form) of Minecraft: Java Edition is governed by the Minecraft End User License Agreement available at https://account.mojang.com/documents/minecraft_eula. FAILURE: Build failed with an exception. * Where: Build file 'C:\Users\user\Desktop\MinecraftForge\fmlcore\build.gradle' line: 7 * What went wrong: A problem occurred evaluating project ':fmlcore'. > java.lang.UnsupportedClassVersionError: org/javamodularity/moduleplugin/ModuleSystemPlugin has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0 * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. * Get more help at https://help.gradle.org BUILD FAILED in 21s 2 actionable tasks: 2 up-to-date  
    • Here's a shot of where I'd expect to find it. There's one older forge version that appears at the bottom of the list, so I checked its entire length to be sure.  
    • Hi!, I'm trying to set up a workspace for a 1.17 mod. I want to port a 1.16.5 mod I already have, but first I wanted to try to set up a new empty mod, just to assure it works. The problem is when I run genEclipseRuns, it throws me FAILURE: Build failed with an exception. * What went wrong: Could not resolve all files for configuration ':runtimeClasspathCopy'. > Could not find net.minecraftforge:forge:1.17.1-37.0.61_mapped_official_1.17.1. Searched in the following locations: - file:/C:/Users/migue/.gradle/caches/forge_gradle/bundeled_repo/net/minecraftforge/forge/1.17.1-37.0.61_mapped_official_1.17.1/forge-1.17.1-37.0.61_mapped_official_1.17.1.pom - file:/C:/Users/migue/.gradle/caches/forge_gradle/bundeled_repo/net/minecraftforge/forge/1.17.1-37.0.61_mapped_official_1.17.1/forge-1.17.1-37.0.61_mapped_official_1.17.1.jar Required by: project : * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. * Get more help at https://help.gradle.org Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0. You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins. See https://docs.gradle.org/7.2/userguide/command_line_interface.html#sec:command_line_warnings BUILD FAILED in 24s I have OpenJDK16, and the Path and JAVA_HOME variables correctly set. I'm using the default mdk, so I didn't change anything from build.gradle Any help is appreciated, I've been stucked with this for hours
    • I'm new to Java and modding, so I went to the tutorial on https://mcforge.readthedocs.io/en/1.16.x/gettingstarted/ but I already am facing issues. I followed the guide up until step 6, at which point when I run "gradlew enIntellijRuns" I get an error which reads "Could not find net.minecraftforge:forge:1.16.5-36.2.0_mapped_official_1.16.5.". Do any knowledgable modders know what this means and how to fix it? Log: https://pastebin.com/vt9VgLPz Please let me know if I need to supply any additional information such as further logs or screenshots.
    • I will check out how chests work and see if I can figure a couple things from that, meanwhile ignore the fact I just table flipped on setBlock doing one thing, but not with blockpos.offset wow this change from 1.7 to 1.17 is making me feel dumb Lol Edit: yup nope lack of sleep derp for that Lol Oh well
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.