Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

(SOLVED) [1.14.4] Get Biome of targeted Block


MineModder2000
 Share

Recommended Posts

I am using the event.getWorld().getBiome() method for RightClickItem Event. It takes a position as a parameter. If I use event.getPos() I get the position the player is standing in, but I want the position of the block being targeted, if possible. 

 

- Thanks. 

Edited by MineModder2000
  • Confused 1
Link to comment
Share on other sites

15 hours ago, diesieben07 said:

RightClickItem is specifically for the case where no block is targeted. Use RightClickBlock for the case where a block is right-clicked.

I should've specified, I want this check to happen when the player is holding an item, so the RightClickItem event is what I want cancelled when the block is in the wrong biome. It actually doesn't work that bad the way I have it, it would just be better if it was based on the targeted block rather than the block the player is on. 

  • Confused 1
Link to comment
Share on other sites

You can use Minecraft#objectMouseOver. You can also look at the ray trading that the debug overlay does to show you your targeted block and block (at a surprisingly far range)

  • Thanks 1

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Okay so the BlockRayTraceResult constructor takes the following : Vec3d, Direction, BlockPos, Boolean. I think I got the correct Vec3d and Direction, but I am not sure how to get the targeted Block, so I can get it's position. 

 

 @SuppressWarnings("deprecation")
	@SubscribeEvent
    public void rightClickItem(RightClickItem event) {
    	
    	BlockRayTraceResult result;
    	
    	result = new BlockRayTraceResult(event.getEntityPlayer().getLookVec(), event.getFace(), event.getPos(), false);
    	
    	if ((event.getEntityPlayer().getHeldItemMainhand().getItem() == Items.GLASS_BOTTLE ||
    		event.getEntityPlayer().getHeldItemMainhand().getItem() == Items.WATER_BUCKET) &&
    	    (!event.getWorld().getBiome(result.getPos()).toString().contains("River"))) {
    		
    			event.setCanceled(true);
    	}
    }
Link to comment
Share on other sites

...You have to run a ray trace. Take the existing client side code, copy it, and put it where you need it (common code).

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

I'm not sure what you need docs for to copy-paste a function.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Some examples of code that do raytracing:

- debug overlay’s targeted block

- throwable entity’s update code (before it calls onImpact)

- Minecraft’s code that’s sets objectMouseOver 

  • Thanks 1

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

1 hour ago, MineModder2000 said:

what existing client side code?

 

This:

12 hours ago, Cadiboo said:

Minecraft#objectMouseOver.

  • Thanks 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

47 minutes ago, Draco18s said:

 

This:

 if (this.leftClickCounter <= 0 && !this.player.isHandActive()) {
         if (leftClick && this.objectMouseOver != null && this.objectMouseOver.getType() == RayTraceResult.Type.BLOCK) {
            BlockRayTraceResult blockraytraceresult = (BlockRayTraceResult)this.objectMouseOver;
            BlockPos blockpos = blockraytraceresult.getPos();
            if (!this.world.isAirBlock(blockpos)) {
               Direction direction = blockraytraceresult.getFace();
               if (this.playerController.onPlayerDamageBlock(blockpos, direction)) {
                  this.particles.addBlockHitEffects(blockpos, blockraytraceresult);
                  this.player.swingArm(Hand.MAIN_HAND);

 

I don't understand this code, objectMouseOver is not set anywhere in the class, so how is it being used? 

Link to comment
Share on other sites

1 hour ago, Cadiboo said:

Some examples of code that do raytracing:

- debug overlay’s targeted block

- throwable entity’s update code (before it calls onImpact)

- Minecraft’s code that’s sets objectMouseOver 

 

I tried to implement the code from debug overlay :

 

RayTraceResult result;
    	BlockPos blockpos = null;
    	
    	result = event.getPlayer().func_213324_a(20.0D, 0.0F, true);
    	
    	if (result.getType() == RayTraceResult.Type.BLOCK) {
    		
            blockpos = ((BlockRayTraceResult)result).getPos();
    	}
    	
    	if ((event.getPlayer().getHeldItemMainhand().getItem() == Items.GLASS_BOTTLE ||
    		event.getPlayer().getHeldItemMainhand().getItem() == Items.WATER_BUCKET) &&
    	    (!event.getWorld().getBiome(blockpos).toString().contains("River"))) {
    		
    			event.setCanceled(true);
    	}

 

But its still going by the block that the player is standing on, not looking at. 

Link to comment
Share on other sites

On 1/22/2020 at 1:19 AM, MineModder2000 said:

its still going by the block that the player is standing on

Are you sure that you are getting the correct BlockPos? You are searching with up to a 20 block range. What happens if the BlockPos is null?

Link to comment
Share on other sites

1 hour ago, MineModder2000 said:

If it's null the game crashes. 

You should fix that.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

1 hour ago, MineModder2000 said:

Well it's never naturally null

What if you’re not looking at a block...

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.