Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

How would I send a SUpdateTileEntityPacket?


DJ1TJOO
 Share

Recommended Posts

I have an tile with an gui and I do all the calculations on the server side then I want to send the nbt data to the client. In another topic I saw someone using the SUpdateTileEntityPacket. This was an old topic from 1.11 and that doesn't work any more does someone have any idea?

 

PacketHandler.INSTANCE.send(PacketDistributor.ALL, this.getUpdatePacket());

This is what I tried but it can't see the getUpdatePacket as a MSG:
The method send(PacketDistributor.PacketTarget, MSG) in the type SimpleChannel is not applicable for the arguments (PacketDistributor<Void>, SUpdateTileEntityPacket)

Link to comment
Share on other sites

Don’t send it yourself, vanilla will send the packet for you.

 

Edit: Yeah, if you only need it for the GUI there is a better way of doing it

Edited by Cadiboo

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

8 minutes ago, diesieben07 said:

If the data is only needed in a GUI then that packet is the wrong choice. You would need to create your own packet for that case and only send it when then GUI is opened.

 

If the data is needed on the client in general, check out this:

 

So you say that I need to send the notifyBlockUpdate but how would I get the old state and wich flag should I use?

Link to comment
Share on other sites

Or should I use packets then I have the question: how would I get the client world in the handle:
 

private final BlockPos pos;
	private final int completed;
	
	public ResearchTableCompletedUpdatePacket(BlockPos pos, int completed) {
		this.pos = pos;
		this.completed = completed;
	}
	
	public static void encode(ResearchTableCompletedUpdatePacket msg, PacketBuffer buffer) {
		buffer.writeBlockPos(msg.pos);
		buffer.writeByte((byte)msg.completed);
	}
	
	public static ResearchTableCompletedUpdatePacket decode(PacketBuffer buffer) {
		return new ResearchTableCompletedUpdatePacket(buffer.readBlockPos(), buffer.readUnsignedByte());
	}
	
	public static void handle(ResearchTableTile msg, Supplier<NetworkEvent.Context> context) {
		context.get().enqueueWork(() -> {
			TileEntity te = **WORLD**.getTileEntity(msg.pos);
			if(te instanceof ResearchTableTile) {
				ResearchTableTile dtt = (ResearchTableTile) te;
				
			}
		});
		context.get().setPacketHandled(true);
	}

 

Link to comment
Share on other sites

Just now, DJ1TJOO said:

how would I get the client world in the handle:

The client world is always Minecraft#world.

 

4 minutes ago, DJ1TJOO said:

So you say that I need to send the notifyBlockUpdate but how would I get the old state and wich flag should I use? 

Only if you want to use the default syncing implementation.

Old and new state are the same in this case. flags are actually not used in notifyBlockUpdate on the server.

  • Thanks 1
Link to comment
Share on other sites

4 minutes ago, diesieben07 said:

For which part of that GUI are you using the update packet? I don't see any reason to use it there.

@Override
	public void tick() {
		if(world.isRemote) {//client
			//Fantasy20.LOGGER.info("ResearchTableTile.tick-client");
		} else {//server
			handler.ifPresent(h -> {
				second++;
				if(second > 19) {
					second = 0;
				//Fantasy20.LOGGER.info("ResearchTableTile.tick-server");
				if(currentRecipe == null) {
						if(h.getStackInSlot(INPUT_SLOT).getItem().equals(ModItems.SCRAP)) {
							ResearchTableRecipe recipe = ResearchTable.getRecipe(h.getStackInSlot(INPUT_SLOT_2));
							if(recipe != null) {
								if(h.getStackInSlot(INPUT_SLOT).getCount() >= recipe.getScrap()) {
									second = 0;
									timer = 0;
									completed = 0;
									currentRecipe = recipe.copy();
									markDirty();
									world.notifyBlockUpdate(pos, getBlockState(), getBlockState(), 2);
								}
							}
						}
				} else {
						if(h.getStackInSlot(INPUT_SLOT).getCount() < currentRecipe.getScrap() || !h.getStackInSlot(INPUT_SLOT_2).getItem().equals(currentRecipe.getInputItem())) {
							currentRecipe = null;
							second = 0;
							timer = 0;
							completed = 0;
							markDirty();
							world.notifyBlockUpdate(pos, getBlockState(), getBlockState(), 2);
						} else {
							timer++;
							//System.err.println(timer/100);
						//	System.err.println(timer/currentRecipe.getTime() * 100);
							if(timer > currentRecipe.getTime()) {
								h.extractItem(INPUT_SLOT, currentRecipe.getScrap(), false);
								h.extractItem(INPUT_SLOT_2, 1, false);
								h.insertItem(OUTPUT_SLOT, currentRecipe.getResultBlueprint(), false);
								//System.err.println(" " + currentRecipe.toString());
								
								currentRecipe = null;
								second = 0;
								timer = 0;
								completed = 0;
							}
							if(currentRecipe != null) {
								completed = (int)(((double)((double)timer/(double)currentRecipe.getTime())) * 100);
								//System.err.println(completed);
							}
							//PacketHandler.INSTANCE.send(PacketDistributor.ALL, this.getUpdatePacket());
							markDirty();
							world.notifyBlockUpdate(pos, getBlockState(), getBlockState(), 2);
						}
					}
				}
				});
		}
	}

In the tileentity
 

private ResearchTableTile tileEntity;
	private PlayerEntity playerEntity;
    private IItemHandler playerInventory;

	public ResearchTableContainer(int id, World world, BlockPos pos, PlayerInventory playerInventory, PlayerEntity playerEntity) {
		super(ModBlocks.RESEARCH_TABLE_CONTAINER, id);
		tileEntity = (ResearchTableTile) world.getTileEntity(pos);
		this.playerEntity = playerEntity;
        this.playerInventory = new InvWrapper(playerInventory);
        
		//tileEntity.getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY).ifPresent(h -> {
        tileEntity.getHandler().ifPresent(h -> {
            addSlot(new SlotItemHandler(h, tileEntity.INPUT_SLOT, 19, 33));
            addSlot(new SlotItemHandler(h, tileEntity.INPUT_SLOT_2, 55, 33));
            addSlot(new SlotItemHandler(h, tileEntity.OUTPUT_SLOT, 137, 33));
        });
        //});
        layoutPlayerInventorySlots(8, 83);
	}

	@Override
	public boolean canInteractWith(PlayerEntity player) {
		return isWithinUsableDistance(IWorldPosCallable.of(tileEntity.getWorld(), tileEntity.getPos()), playerEntity, ModBlocks.RESEARCH_TABLE);
	}
	
	 private int addSlotRange(IItemHandler handler, int index, int x, int y, int amount, int dx) {
        for (int i = 0 ; i < amount ; i++) {
            addSlot(new SlotItemHandler(handler, index, x, y));
            x += dx;
            index++;
        }
        return index;
    }

    private int addSlotBox(IItemHandler handler, int index, int x, int y, int horAmount, int dx, int verAmount, int dy) {
        for (int j = 0 ; j < verAmount ; j++) {
            index = addSlotRange(handler, index, x, y, horAmount, dx);
            y += dy;
        }
        return index;
    }

    private void layoutPlayerInventorySlots(int leftCol, int topRow) {
        // Player inventory
        addSlotBox(playerInventory, 9, leftCol, topRow, 9, 18, 3, 18);

        // Hotbar
        topRow += 58;
        addSlotRange(playerInventory, 0, leftCol, topRow, 9, 18);
    }
	
	public ResearchTableTile getTileEntity() {
		return tileEntity;
	}

	public void setTileEntity(ResearchTableTile tileEntity) {
		this.tileEntity = tileEntity;
	}

In the Container
 

private ResearchTableTile tileEntity;
    private ResourceLocation GUI = new ResourceLocation(Fantasy20.MODID, "textures/gui/research_table/gui.png");
	
	public ResearchTableScreen(ResearchTableContainer screenContainer, PlayerInventory inv, ITextComponent titleIn) {
		super(screenContainer, inv, titleIn);
		tileEntity = getContainer().getTileEntity();
	}
	
	@Override
	public boolean mouseDragged(double mouseX, double mouseY, int button,
			double mouseXVel, double mouseYVel) {
		return super.mouseDragged(mouseX, mouseY, button, mouseXVel,
				mouseYVel);
	}
	
	@Override
	public boolean mouseClicked(double mouseX, double mouseY, int button) {
		return super.mouseClicked(mouseX, mouseY, button);
	}
	
	@Override
	public boolean mouseReleased(double mouseX, double mouseY, int button) {
		return super.mouseReleased(mouseX, mouseY, button);
	}
	
	@Override
	public void mouseMoved(double mouseX, double mouseY) {
		super.mouseMoved(mouseX, mouseY);
	}
	
	@Override
	public void render(int mouseX, int mouseY, float partialTicks) {
		this.renderBackground();
		super.render(mouseX, mouseY, partialTicks);
		this.renderHoveredToolTip(mouseX, mouseY);
	}
	
	@Override
	protected void drawGuiContainerForegroundLayer(int mouseX, int mouseY) {
		this.font.drawString(this.title.getFormattedText(), 8.0F, 6.0F, 4210752);
	}

	@Override
	protected void drawGuiContainerBackgroundLayer(float partialTicks, int mouseX, int mouseY) {
		GlStateManager.color4f(1.0F, 1.0F, 1.0F, 1.0F);
		this.minecraft.getTextureManager().bindTexture(GUI);
		int relX = (this.width - this.xSize) / 2;
        int relY = (this.height - this.ySize) / 2;
        this.blit(relX, relY, 0, 0, this.xSize, this.ySize);
       // System.err.println(getContainer().getTileEntity().getCompleted());
        if(tileEntity.getCurrentRecipe() != null) {
        	int k = getCompletedLeft(24);
        	//System.err.println(k);
        	this.blit(relX + 91, relY + 33, 176, 0, k, 17);
        }
	}
	
	private int getCompletedLeft(int pixels) {
		int i = tileEntity.getCompleted();
		return (int)(((double)i / (double)100) * (double)pixels);
	}

In the screen

Edit: Its used for the completed int to see the progressbar in the gui
And I know that my code is a mess sometimes

Edited by DJ1TJOO
Anwser
Link to comment
Share on other sites

  • Items do not need to be synchronized, they are synchronized by the Container infrastructure already.
  • Do not use notifyBlockUpdate for stuff that is needed only in the GUI, especially fast-updating things like the progressbar. notifyBlockUpdate is expensive. Use a custom packet or look at how the vanilla furnace synchronizes it's progressbar.
Link to comment
Share on other sites

1 minute ago, diesieben07 said:
  • Items do not need to be synchronized, they are synchronized by the Container infrastructure already.
  • Do not use notifyBlockUpdate for stuff that is needed only in the GUI, especially fast-updating things like the progressbar. notifyBlockUpdate is expensive. Use a custom packet or look at how the vanilla furnace synchronizes it's progressbar.

Then what is the right way to do it
Edit: And how do I remove the disapearing of my items

Edited by DJ1TJOO
Question
Link to comment
Share on other sites

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • We have created a pickaxe.json below MInecraft-MOD-1.17/src/main/resources/data/minecraft.tags.blocks/mineable/pickaxe.json github link  https://github.com/ocome85/MInecraft-MOD-1.17    I can't add Tag and you can't dig. Please help me.
    • Thank you I completely forgot about that. I will attempt to put a delay in  
    • While chugging along making the JSONs by hand (to get an idea of how they need to be generated for each type of block), I cam up with a possibly brilliant idea. Could I somehow make template JSONs and when a new block of a certain type is being generated it will just pull the template and replace certain keywords like "NAME" and "COLOR" instead of all of this getVariantBuilder stuff
    • Hello everyone!     I'm quite new to forge, I used to do development for spigot. I needed to create a GUI Overlays and I found an article https://emxtutorials.wordpress.com/simple-in-game-gui-overlay/ on how to create a gui overlay, but as I understood the classes were renamed. Can you           share a sample code that would perform this function? Thank you in advance
    • I am at my wit's end trying to figure out what keeps going wrong. Reading the error log tells me absolutely nothing I can understand, and after making a blank new server and finally having it work after so long, just to have it break again, is extremely irritating. I would love for someone to decipher what this error log says and point me in a direction, at least, so I'm not swinging blindly. Minecraft 1.16.5 and Forge 36.2.2   [14:47:37] [Server thread/INFO] [minecraft/PlayerList]: Hyratos[/192.168.1.195:64650] logged in with entity id 45 at (481.30365299459726, 78.0, 426.6331819365098) [14:47:37] [Server thread/INFO] [minecraft/DedicatedServer]: Hyratos joined the game [14:47:37] [Netty Server IO #2/ERROR] [tconstruct/]: MaterialRecipeSerializer: Error reading recipe from packet java.lang.NullPointerException: null     at slimeknights.tconstruct.library.recipe.material.MaterialRecipeSerializer.writeSafe(MaterialRecipeSerializer.java:70) ~[tconstruct:1.16.5-3.1.1.252]     at slimeknights.tconstruct.library.recipe.material.MaterialRecipeSerializer.writeSafe(MaterialRecipeSerializer.java:20) ~[tconstruct:1.16.5-3.1.1.252]     at slimeknights.tconstruct.common.recipe.LoggingRecipeSerializer.func_199427_a_(LoggingRecipeSerializer.java:49) ~[tconstruct:1.16.5-3.1.1.252]     at net.minecraft.network.play.server.SUpdateRecipesPacket.func_218771_a(SourceFile:64) ~[?:?]     at net.minecraft.network.play.server.SUpdateRecipesPacket.func_148840_b(SourceFile:43) ~[?:?]     at net.minecraftforge.network.VanillaPacketSplitter.appendPackets(VanillaPacketSplitter.java:100) ~[forge:?]     at net.minecraftforge.network.ForgeConnectionNetworkFilter.splitPacket(ForgeConnectionNetworkFilter.java:85) ~[forge:?]     at net.minecraftforge.network.VanillaPacketFilter.encode(VanillaPacketFilter.java:75) ~[forge:?]     at net.minecraftforge.network.VanillaPacketFilter.encode(VanillaPacketFilter.java:38) ~[forge:?]     at io.netty.handler.codec.MessageToMessageEncoder.write(MessageToMessageEncoder.java:88) ~[server-1.16.5-20210115.111550-extra.jar:?]     at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:738) ~[server-1.16.5-20210115.111550-extra.jar:?]     at io.netty.channel.AbstractChannelHandlerContext.invokeWriteAndFlush(AbstractChannelHandlerContext.java:801) ~[server-1.16.5-20210115.111550-extra.jar:?]     at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:814) ~[server-1.16.5-20210115.111550-extra.jar:?]     at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:794) ~[server-1.16.5-20210115.111550-extra.jar:?]     at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:831) ~[server-1.16.5-20210115.111550-extra.jar:?]     at io.netty.channel.DefaultChannelPipeline.writeAndFlush(DefaultChannelPipeline.java:1071) ~[server-1.16.5-20210115.111550-extra.jar:?]     at io.netty.channel.AbstractChannel.writeAndFlush(AbstractChannel.java:300) ~[server-1.16.5-20210115.111550-extra.jar:?]     at net.minecraft.network.NetworkManager.lambda$sendPacket$5(NetworkManager.java:196) ~[?:?]     at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163) [server-1.16.5-20210115.111550-extra.jar:?]     at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:404) [server-1.16.5-20210115.111550-extra.jar:?]     at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:465) [server-1.16.5-20210115.111550-extra.jar:?]     at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:884) [server-1.16.5-20210115.111550-extra.jar:?]     at java.lang.Thread.run(Unknown Source) [?:1.8.0_301] [14:47:38] [Server thread/WARN] [Mekanism/]: Failed to retrieve username for UUID 594cf1d3-7a0c-4e6f-bd16-5df4bb7ce72b, you might want to add it to the JSON cache [14:47:38] [Server thread/WARN] [minecraft/EntityDataManager]: defineId called for: class dev.itsmeow.whisperwoods.entity.EntityMoth from class dev.itsmeow.whisperwoods.imdlib.entity.EntityTypeContainer [14:47:38] [Server thread/WARN] [minecraft/EntityDataManager]: defineId called for: class dev.itsmeow.whisperwoods.entity.EntityMoth from class dev.itsmeow.whisperwoods.imdlib.entity.util.EntityTypeContainerContainable [14:47:38] [Server thread/WARN] [minecraft/EntityDataManager]: defineId called for: class its_meow.betteranimalsplus.common.entity.EntityButterfly from class dev.itsmeow.betteranimalsplus.imdlib.entity.EntityTypeContainer [14:47:38] [Server thread/WARN] [minecraft/EntityDataManager]: defineId called for: class its_meow.betteranimalsplus.common.entity.EntityButterfly from class dev.itsmeow.betteranimalsplus.imdlib.entity.util.EntityTypeContainerContainable [14:47:38] [Server thread/WARN] [minecraft/EntityDataManager]: defineId called for: class dev.itsmeow.whisperwoods.entity.EntityZotzpyre from class dev.itsmeow.whisperwoods.imdlib.entity.EntityTypeContainer [14:47:38] [Server thread/INFO] [survive/]: Syncing Armor Data To Client (Hyratos) [14:47:38] [Server thread/INFO] [minecraft/ServerPlayNetHandler]: Hyratos lost connection: Internal Exception: io.netty.handler.codec.EncoderException: java.lang.NullPointerException [14:47:38] [Server thread/INFO] [minecraft/DedicatedServer]: Hyratos left the game  
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.