Jump to content

Here's an Oddity - Two different results from the same code


Draco18s

Recommended Posts

Below is the entire class for an extending ladder block I made.  When updating it to 1.5.1 (below code is for 1.5.1) I noticed that when broken under certain conditions, it will drop 1 item less than it should.

 

Basic premise: place the block then activate it (right click) and it will auto-place more ladders vertically (going up) until it a ladder is placed in a "supporting" position (against a solid block), you run out of item-copies in your inventory, or it hits the build height.  All of that works correctly.  The ladder can be removed (broken) only from the top-most or bottom-most block.

 

Here's the fun part.

 

If you're breaking it from the bottom most block and the top-most block is in a supported location, the correct number of items drop (so if you start with 10, you'll end with 10).  But if the top most block is adjacent to air, one less item will drop (so if you started with 10, you'll have 9).

(Breaking from the top seems to work just fine, but not as extensively tested).

 

But as far as I can tell, the code neither cares what the adjacent blocks are (it should only check the adjacent top blocks when breaking from the top, in order to determine where it should drop the items so they don't fall down the hole), nor does the harvest function iterate differently in the two scenarios.

 

Why is this?  What's going on that I'm not seeing?

 

 

package draco18s.micromods.extendingladders.blocks;

import static net.minecraftforge.common.ForgeDirection.*;

import java.util.Random;

import cpw.mods.fml.relauncher.*;
import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.client.renderer.texture.IconRegister;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.enchantment.EnchantmentHelper;
import net.minecraft.entity.player.*;
import net.minecraft.item.ItemStack;
import net.minecraft.network.packet.Packet3Chat;
import net.minecraft.server.MinecraftServer;
import net.minecraft.stats.StatList;
import net.minecraft.util.AxisAlignedBB;
import net.minecraft.util.EnumChatFormatting;
import net.minecraft.util.Icon;
import net.minecraft.world.*;

public class ExtendingLadder extends Block {
private Icon ropeA;
private Icon ropeB;
    public ExtendingLadder(int par1, Material par2Material)
    {
        super(par1, par2Material);
        setCreativeTab(CreativeTabs.tabDecorations);
        setUnlocalizedName("Extending Ladder");
        setHardness(0.4F);
        setStepSound(soundLadderFootstep);
    }

    public AxisAlignedBB getCollisionBoundingBoxFromPool(World par1World, int par2, int par3, int par4)
    {
        this.setBlockBoundsBasedOnState(par1World, par2, par3, par4);
        return super.getCollisionBoundingBoxFromPool(par1World, par2, par3, par4);
    }

    @SideOnly(Side.CLIENT)
    public AxisAlignedBB getSelectedBoundingBoxFromPool(World par1World, int par2, int par3, int par4)
    {
        this.setBlockBoundsBasedOnState(par1World, par2, par3, par4);
        return super.getSelectedBoundingBoxFromPool(par1World, par2, par3, par4);
    }

    public void setBlockBoundsBasedOnState(IBlockAccess par1IBlockAccess, int par2, int par3, int par4)
    {
        this.updateLadderBounds(par1IBlockAccess.getBlockMetadata(par2, par3, par4));
    }
    
    public void registerIcons(IconRegister par1IconRegister)
    {
        blockIcon = par1IconRegister.registerIcon("ExtendingLadders:extend-ladder");
        //these two icons are part of the custom renderer to make the ladder
        //look kind of like this:
        //http://www.rishabqualityladders.com/aluminium-extension-ladder.htm
        ropeA = par1IconRegister.registerIcon("ExtendingLadders:extend-rope1");
        ropeB = par1IconRegister.registerIcon("ExtendingLadders:extend-rope2");
    }
    
    @SideOnly(Side.CLIENT)
    public Icon getBlockTextureFromSideAndMetadata(int side, int meta){
    	if(side <= 1)
    		return blockIcon;
    	else if(side == 2)
    		return ropeA;
    	else
    		return ropeB;
    }

    public void updateLadderBounds(int par1)
    {
        float var3 = 0.125F;

        if (par1 == 2)
        {
            this.setBlockBounds(0.0F, 0.0F, 1.0F - var3, 1.0F, 1.0F, 1.0F);
        }

        if (par1 == 3)
        {
            this.setBlockBounds(0.0F, 0.0F, 0.0F, 1.0F, 1.0F, var3);
        }

        if (par1 == 4)
        {
            this.setBlockBounds(1.0F - var3, 0.0F, 0.0F, 1.0F, 1.0F, 1.0F);
        }

        if (par1 == 5)
        {
            this.setBlockBounds(0.0F, 0.0F, 0.0F, var3, 1.0F, 1.0F);
        }
    }

    public boolean isOpaqueCube()
    {
        return false;
    }

    public boolean renderAsNormalBlock()
    {
        return false;
    }

    public int getRenderType()
    {
        return ExtendingLaddersBase.extLadderRenderID;
        //normal ladder renderer ( would be a sufficient replacement
    }

    public boolean canPlaceBlockAt(World world, int x, int y, int z, int side)
    {
        if (side == 2 && world.isBlockSolidOnSide(x, y, z + 1, NORTH))
        {
            return true;
        }

        if (side == 3 && world.isBlockSolidOnSide(x, y, z - 1, SOUTH))
        {
            return true;
        }

        if (side == 4 && world.isBlockSolidOnSide(x + 1, y, z, WEST))
        {
            return true;
        }

        if (side == 5 && world.isBlockSolidOnSide(x - 1, y, z, EAST))
        {
            return true;
        }
        return false;
    }

    public boolean canPlaceBlockAt(World par1World, int par2, int par3, int par4)
    {
        return par1World.isBlockSolidOnSide(par2 - 1, par3, par4, EAST) ||
                par1World.isBlockSolidOnSide(par2 + 1, par3, par4, WEST) ||
                par1World.isBlockSolidOnSide(par2, par3, par4 - 1, SOUTH) ||
                par1World.isBlockSolidOnSide(par2, par3, par4 + 1, NORTH);
    }

    public int onBlockPlaced(World world, int x, int y, int z, int par5, float par6, float par7, float par8, int par9)
    {
        int var10 = par9;

        if ((var10 == 0 || par5 == 2) && world.isBlockSolidOnSide(x, y, z + 1, NORTH))
        {
            var10 = 2;
        }

        if ((var10 == 0 || par5 == 3) && world.isBlockSolidOnSide(x, y, z - 1, SOUTH))
        {
            var10 = 3;
        }

        if ((var10 == 0 || par5 == 4) && world.isBlockSolidOnSide(x + 1, y, z, WEST))
        {
            var10 = 4;
        }

        if ((var10 == 0 || par5 == 5) && world.isBlockSolidOnSide(x - 1, y, z, EAST))
        {
            var10 = 5;
        }
        return var10;
    }

    @Override
    public void updateTick(World world, int x, int y, int z, Random par5Random)
    {
        this.onNeighborBlockChange(world, x, y, z, 0);
    }

    public void onNeighborBlockChange(World world, int x, int y, int z, int par5)
    {
        if (world.getBlockId(x, y + 1, z) != blockID && world.getBlockId(x, y - 1, z) != blockID)
        {
            int var6 = world.getBlockMetadata(x, y, z);
            boolean var7 = false;

            if (var6 == 2 && world.isBlockSolidOnSide(x, y, z + 1, NORTH))
            {
                var7 = true;
            }

            if (var6 == 3 && world.isBlockSolidOnSide(x, y, z - 1, SOUTH))
            {
                var7 = true;
            }

            if (var6 == 4 && world.isBlockSolidOnSide(x + 1, y, z, WEST))
            {
                var7 = true;
            }

            if (var6 == 5 && world.isBlockSolidOnSide(x - 1, y, z, EAST))
            {
                var7 = true;
            }

            if (!var7)
            {
                harvestBlock(world, world.getClosestPlayer(x, y, z, 6), x, y, z, 0);
                world.setBlockToAir(x, y, z);
            }
        }

        super.onNeighborBlockChange(world, x, y, z, par5);
    }

    @Override
    public void onBlockAdded(World world, int x, int y, int z)
    {
        onBlockPlaced(world, x, y, z, 1, 0F, 0F, 0F, 0);
    }

    public int quantityDropped(Random par1Random)
    {
        return 1;
    }

    @Override
    public boolean isLadder(World world, int x, int y, int z)
    {
        return true;
    }

    public void harvestBlock(World world, EntityPlayer par2EntityPlayer, int x, int y, int z, int par6)
    {
        int meta = 0;
        int n = 1;

        if (world.getBlockId(x, y + 1, z) != blockID)
        {
            while (world.getBlockId(x, y - n, z) == blockID)
            {
                if (meta == 0)
                {
                    meta = world.getBlockMetadata(x, y - n, z);
                }

                world.setBlock(x, y - n, z, 0);

                if (!par2EntityPlayer.capabilities.isCreativeMode)
                {
                    if (meta == 2)
                    {
                        if (world.getBlockId(x, y + 1, z + 1) == 0)
                        {
                            dropBlockAsItem(world, x, y + 1, z + 1, meta, 0);
                        }
                        else if (world.getBlockId(x, y + 1, z - 1) == 0)
                        {
                            dropBlockAsItem(world, x, y + 1, z - 1, meta, 0);
                        }
                        else
                        {
                            dropBlockAsItem(world, x, y + 1, z, meta, 0);
                        }
                    }
                    else if (meta == 3)
                    {
                        if (world.getBlockId(x, y + 1, z - 1) == 0)
                        {
                            dropBlockAsItem(world, x, y + 1, z - 1, meta, 0);
                        }
                        else if (world.getBlockId(x, y + 1, z + 1) == 0)
                        {
                            dropBlockAsItem(world, x, y + 1, z + 1, meta, 0);
                        }
                        else
                        {
                            dropBlockAsItem(world, x, y + 1, z, meta, 0);
                        }
                    }
                    else if (meta == 4)
                    {
                        if (world.getBlockId(x + 1, y + 1, z) == 0)
                        {
                            dropBlockAsItem(world, x + 1, y + 1, z, meta, 0);
                        }
                        else if (world.getBlockId(x - 1, y + 1, z) == 0)
                        {
                            dropBlockAsItem(world, x - 1, y + 1, z, meta, 0);
                        }
                        else
                        {
                            dropBlockAsItem(world, x, y + 1, z, meta, 0);
                        }
                    }
                    else if (meta == 5)
                    {
                        if (world.getBlockId(x - 1, y + 1, z) == 0)
                        {
                            dropBlockAsItem(world, x - 1, y + 1, z, meta, 0);
                        }
                        else if (world.getBlockId(x + 1, y + 1, z) == 0)
                        {
                            dropBlockAsItem(world, x + 1, y + 1, z, meta, 0);
                        }
                        else
                        {
                            dropBlockAsItem(world, x, y + 1, z, meta, 0);
                        }
                    }
                    else
                    {
                        dropBlockAsItem(world, x, y + 1, z, meta, 0);
                    }
                }

                n++;
            }
        }
        else if (world.getBlockId(x, y - 1, z) != blockID)
        {
            while (world.getBlockId(x, y + n, z) == blockID)
            {
                if (meta == 0)
                {
                    meta = world.getBlockMetadata(x, y + n, z);
                }

                world.setBlock(x, y + n, z, 0);

                if (!par2EntityPlayer.capabilities.isCreativeMode)
                {
                    dropBlockAsItem(world, x, y, z, meta, 0);
                }

                n++;
            }
        }
        else
        {
            if (meta == 0)
            {
                meta = world.getBlockMetadata(x, y + n, z);
            }

            world.setBlock(x, y, z, blockID, meta, 3);
            world.markBlockForUpdate(x, y, z);
        }

        if (par2EntityPlayer != null && !par2EntityPlayer.capabilities.isCreativeMode)
        {
            if (meta == 2)
            {
                if (world.getBlockId(x, y + 1, z + 1) == 0)
                {
                    dropBlockAsItem(world, x, y + 1, z + 1, meta, 0);
                }
                else if (world.getBlockId(x, y + 1, z - 1) == 0)
                {
                    dropBlockAsItem(world, x, y + 1, z - 1, meta, 0);
                }
                else
                {
                    dropBlockAsItem(world, x, y + 1, z, meta, 0);
                }
            }
            else if (meta == 3)
            {
                if (world.getBlockId(x, y + 1, z - 1) == 0)
                {
                    dropBlockAsItem(world, x, y + 1, z - 1, meta, 0);
                }
                else if (world.getBlockId(x, y + 1, z + 1) == 0)
                {
                    dropBlockAsItem(world, x, y + 1, z + 1, meta, 0);
                }
                else
                {
                    dropBlockAsItem(world, x, y + 1, z, meta, 0);
                }
            }
            else if (meta == 4)
            {
                if (world.getBlockId(x + 1, y + 1, z) == 0)
                {
                    dropBlockAsItem(world, x + 1, y + 1, z, meta, 0);
                }
                else if (world.getBlockId(x - 1, y + 1, z) == 0)
                {
                    dropBlockAsItem(world, x - 1, y + 1, z, meta, 0);
                }
                else
                {
                    dropBlockAsItem(world, x, y + 1, z, meta, 0);
                }
            }
            else if (meta == 5)
            {
                if (world.getBlockId(x - 1, y + 1, z) == 0)
                {
                    dropBlockAsItem(world, x - 1, y + 1, z, meta, 0);
                }
                else if (world.getBlockId(x + 1, y + 1, z) == 0)
                {
                    dropBlockAsItem(world, x + 1, y + 1, z, meta, 0);
                }
                else
                {
                    dropBlockAsItem(world, x, y + 1, z, meta, 0);
                }
            }
        }
    }

    public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer par5EntityPlayer, int par6, float par7, float par8, float par9)
    {
        int n = 1;
        int var10 = world.getBlockMetadata(x, y, z);

        while (y+n < MinecraftServer.getServer().getBuildLimit()-1 && world.getBlockId(x, y + n, z) == 0 && !canPlaceBlockAt(world, x, y + n, z, var10))
        {
            if (par5EntityPlayer.capabilities.isCreativeMode || par5EntityPlayer.inventory.consumeInventoryItem(blockID))
            {
                world.setBlock(x, y + n, z, blockID, var10, 3);
                n++;
            }
            else
            {
                break;
            }
        }
        
        if(!world.isRemote && y+n >= MinecraftServer.getServer().getBuildLimit()-1) {
        	EntityPlayerMP p = (EntityPlayerMP) par5EntityPlayer;
        	p.playerNetServerHandler.sendPacketToPlayer(new Packet3Chat("" + EnumChatFormatting.GRAY + "Hit world ceiling."));
        }

        if (world.getBlockId(x, y + n, z) == 0 && canPlaceBlockAt(world, x, y + n, z, var10) && (par5EntityPlayer.capabilities.isCreativeMode || par5EntityPlayer.inventory.consumeInventoryItem(blockID)))
        {
            world.setBlock(x, y + n, z, blockID, var10, 3);
        }

        return true;
    }

    public void onBlockDestroyedByPlayer(World world, int x, int y, int z, int par6)
    {
        //if solo block, do a drop, as the harvestBlock function will not drop any in such a case
    	if(world.getBlockId(x, y - 1, z) != blockID && world.getBlockId(x, y + 1, z) != blockID)
    		dropBlockAsItem(world, x, y + 1, z, 0, 0);
        harvestBlock(world, world.getClosestPlayer(x, y, z, 6), x, y, z, par6);
    }
}

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.