Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.14.4] Any way to hook into Elytras code?


SkylorBeck
 Share

Recommended Posts

Sorry if you've seen this many times before. I've been looking for days about how to make an item work like Elytra. I found many posts where people have said it's not possible and many more where people have successfully done it. But not a single person has posted their code or explained how they did it. I've already stared at the ElytraItem.java and scoured through PlayerEntity.java and I just cannot figure it out.

 

So anyone have any ideas?

 

Thank you.

Link to comment
Share on other sites

23 minutes ago, MoxLotus said:

Have you searched for usages of Items.ELYTRA?

In PlayerEntity I find a reference to a flag for "elytra flying".

There is also logic in ClientPlayerEntity that appears to submit a request for that flag to be set when the right conditions are met.

I did search for Items.Elytra and I also found that flag. I cannot seem to figure out how to trigger it though. 

Ah I see. 

if (this.movementInput.jump && !flag && !this.onGround && this.getMotion().y < 0.0D && !this.isElytraFlying() && !this.abilities.isFlying) {
   ItemStack itemstack = this.getItemStackFromSlot(EquipmentSlotType.CHEST);
   if (itemstack.getItem() == Items.ELYTRA && ElytraItem.isUsable(itemstack)) {
      this.connection.sendPacket(new CEntityActionPacket(this, CEntityActionPacket.Action.START_FALL_FLYING));
   }
}

FALL_FLYING appears to be a pose as I can only find it referenced here and in a pose list.

Here is what I have 

 

public class elytron extends ArmorItem{
    public elytron(IArmorMaterial p_i48534_1_, EquipmentSlotType p_i48534_2_, Properties p_i48534_3_) {
        super(p_i48534_1_, p_i48534_2_, p_i48534_3_);
        setRegistryName("elytron");}


    private void glide(PlayerEntity entity) {
        if (!entity.onGround && !entity.isElytraFlying() && !entity.isInWater()) {
            ItemStack itemstack = entity.getItemStackFromSlot(EquipmentSlotType.CHEST);
            if (itemstack.getItem() == elytronitem.elytronitem){
//MYSTERY ELYTRA CODE GOES HERE
            }
        }
    }


    @Override
    public void onArmorTick(ItemStack stack, World world, PlayerEntity player) {


        if (!player.onGround) {
            glide(player);

        }

    }
}
Link to comment
Share on other sites

I'm looking at the 1.15 code, but it's substantially similar. My understanding is that when a player jumps in midair while Elytra are equipped, the client sends that packet to the server. The server receives the packet and double checks the criteria for flying.

public void processEntityAction(CEntityActionPacket packetIn) {

...

case START_FALL_FLYING:
   if (!this.player.func_226566_ei_()) {
      this.player.func_226568_ek_();
   }
   break;

The server calls another function which sets flag 7.

public void func_226568_ek_() {
   this.setFlag(7, true);
   this.setFlag(7, false);
}
Link to comment
Share on other sites

See this bit?

13 hours ago, SkylorBeck said:

itemstack.getItem() == Items.ELYTRA

This is the troublesome bit.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

23 minutes ago, MoxLotus said:

I'm looking at the 1.15 code, but it's substantially similar. My understanding is that when a player jumps in midair while Elytra are equipped, the client sends that packet to the server. The server receives the packet and double checks the criteria for flying.


public void processEntityAction(CEntityActionPacket packetIn) {

...


case START_FALL_FLYING:
   if (!this.player.func_226566_ei_()) {
      this.player.func_226568_ek_();
   }
   break;

The server calls another function which sets flag 7.


public void func_226568_ek_() {
   this.setFlag(7, true);
   this.setFlag(7, false);
}

Yes exactly. In my mappings 

public void setElytraFlying() {
   this.setFlag(7, true);
}

public void clearElytraFlying() {
   this.setFlag(7, true);
   this.setFlag(7, false);
}

is what I need to trigger. I cannot find Fall_Flying in anything but 

 public static enum Action {
      START_SNEAKING,
      STOP_SNEAKING,
      STOP_SLEEPING,
      START_SPRINTING,
      STOP_SPRINTING,
      START_RIDING_JUMP,
      STOP_RIDING_JUMP,
      OPEN_INVENTORY,
      START_FALL_FLYING;
   }
}

 

20 minutes ago, Draco18s said:

See this bit?

This is the troublesome bit.

Ah, the guy who always tells everyone it can't be done is here. I am aware. That is why I replicated that code in my code shown above. I know it can be done and I know to use the search function. I know minecraft calls from PlayerEntity and not from Elytra. I've seen every comment you've posted about Elytra and if you're going to tell me that it's not possible like you have everyone else who tried, please leave.

Edited by SkylorBeck
Link to comment
Share on other sites

30 minutes ago, MoxLotus said:

I'm looking at the 1.15 code, but it's substantially similar. My understanding is that when a player jumps in midair while Elytra are equipped, the client sends that packet to the server. The server receives the packet and double checks the criteria for flying.


public void processEntityAction(CEntityActionPacket packetIn) {

...


case START_FALL_FLYING:
   if (!this.player.func_226566_ei_()) {
      this.player.func_226568_ek_();
   }
   break;

The server calls another function which sets flag 7.


public void func_226568_ek_() {
   this.setFlag(7, true);
   this.setFlag(7, false);
}

Can you tell me where you found that Fall_Flying case? That seems like a good missing piece of my puzzle.

Link to comment
Share on other sites

13 minutes ago, SkylorBeck said:

I know minecraft calls from PlayerEntity and not from Elytra. I've seen every comment you've posted about Elytra and if you're going to tell me that it's not possible like you have everyone else who tried, please leave.

I have never said it's not possible, I've said that you have to replicate the behavior yourself in an event handler because the vanilla code cannot be used.

Edited by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

1 minute ago, Draco18s said:

I have never said it's not possible, I've said that you have to replicate the behavior yourself in an event handler because the vanilla code cannot be used.

and as you can see, I have already done that. 

14 hours ago, SkylorBeck said:

 


    private void glide(PlayerEntity entity) {
        if (!entity.onGround && !entity.isElytraFlying() && !entity.isInWater()) {
            ItemStack itemstack = entity.getItemStackFromSlot(EquipmentSlotType.CHEST);
            if (itemstack.getItem() == elytronitem.elytronitem){
//MYSTERY ELYTRA CODE GOES HERE
            }
        }
    }


    @Override
    public void onArmorTick(ItemStack stack, World world, PlayerEntity player) {


        if (!player.onGround) {
            glide(player);

        }

    }
}

Please stop derailing the thread by being a jerk for no reason.

Link to comment
Share on other sites

12 minutes ago, SkylorBeck said:

Can you tell me where you found that Fall_Flying case? That seems like a good missing piece of my puzzle.

In ServerPlayNetHandler::processEntityAction

 

But if you call that setElytraFlying method from PlayerEntity does that have the desired effect? The setFlag method is protected, but all setElytraFlying appears to do is set it. I don't see any additional checks after it is called. It won't fully replicate the behavior of Elytra, but my guess is that it is in charge of the flying part.

  • Thanks 1
Link to comment
Share on other sites

18 minutes ago, MoxLotus said:

In ServerPlayNetHandler::processEntityAction

 

But if you call that setElytraFlying method from PlayerEntity does that have the desired effect? The setFlag method is protected, but all setElytraFlying appears to do is set it. I don't see any additional checks after it is called. It won't fully replicate the behavior of Elytra, but my guess is that it is in charge of the flying part.

Thanks for the info/idea.

 

If I try to call setElytraFlying like so,

public void glide(PlayerEntity player) {
    if (!player.onGround && !player.isElytraFlying() && !player.isInWater()) {
        ItemStack itemstack = player.getItemStackFromSlot(EquipmentSlotType.CHEST);
        if (itemstack.getItem() == elytronitem.elytronitem) {
            player.setElytraFlying();
        }
    }
}

I cannot resolve setElytraFlying in PlayerEntity. If I change it to 

public void glide(ServerPlayerEntity player) {

then it calls but then the onArmorTick doesn't function anymore as 

@Override
        public void onArmorTick (ItemStack stack, World world, PlayerEntity player){
            if (!player.onGround) {
                glide(player); }

}

is calling for a PlayerEntity. If I changed that to ServerPlayerEntity then the @Override stops working because Method does not override Method from Super.

 

I really feel like I'm missing something here. 

Link to comment
Share on other sites

Check if the player is an instanceof ServerPlayerEntity, then cast.

  • Thanks 1

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

ServerPlayerEntity extends PlayerEntity. No idea where which one is used, but you can run an instanceof and try casting. And yes, changing the method signature would invalidate the @Override, but basic Java is normally outside the scope of this forum.

You can try:

if (player instanceof ServerPlayerEntity){
    ServerEntityPlayer serverPlayer = (ServerEntityPlayer)player;
    glide(serverPlayer);
}else {System.out.println("player is not a ServerPlayerEntity :(");}

and feel free to look up appropriate Java tutorials for casting and polymorphism.

 

But like I said, I'm not sure exactly when PlayerEntity is or is not an instance of ServerPlayerEntity.

  • Thanks 1
Link to comment
Share on other sites

9 hours ago, MoxLotus said:

ServerPlayerEntity extends PlayerEntity. No idea where which one is used

ServerPlayerEntity is used by the server.

The client uses ClientPlayerEntity (the player you are controlling) and RemoteClientPlayerEntity (other players).

PlayerEntity is the (abstract) superclass for all these.

  • Thanks 1
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Hi, So as the title says it seems im the only one with this issue, it was working fine yesterday. basically the server just keeps saying Pinging.... and doesn't load, i added a vanilla server to see if all servers would behave the same but no, my modded server was the only one. i asked some of my friends to try connecting and no problem so it seems on my end. I tried connecting even when it says pinging and it just stuck on Encrypting and then timed out Client log https://gist.github.com/thekingtoonboy/1c53875b856e0563b9313a8cc060a4a0.js latest Server log [19Sep2021 06:06:35.440] [Netty Epoll Server IO #2/INFO] [codechicken.lib.config.ConfigSyncManager/]: Skipping config sync, No mods have registered a syncable config. [19Sep2021 06:06:35.529] [Netty Epoll Server IO #2/WARN] [com.connectivity.Connectivity/]: Login payload for Registry minecraft:item is using 111.6286% of max allowed size and will cause errors during login if connectivity is not present on client side. [19Sep2021 06:06:35.543] [Netty Epoll Server IO #2/WARN] [com.connectivity.Connectivity/]: Login payload for Registry minecraft:block is using 87.6082% of max allowed size [19Sep2021 06:06:37.491] [User Authenticator #1/INFO] [net.minecraft.network.login.ServerLoginNetHandler/]: UUID of player KiingSultan is e69dbe58-dd8d-4d26-9317-a643a0ffde12 [19Sep2021 06:08:37.721] [Server thread/INFO] [net.minecraft.network.login.ServerLoginNetHandler/]: com.mojang.authlib.GameProfile@1b416c43[id=e69dbe58-dd8d-4d26-9317-a643a0ffde12,name=KiingSultan,properties={textures=[com.mojang.authlib.properties.Property@38939441]},legacy=false] (/5.193.109.22:50035) lost connection: Timed out [19Sep2021 06:13:10.808] [Netty Epoll Server IO #0/INFO] [codechicken.lib.config.ConfigSyncManager/]: Skipping config sync, No mods have registered a syncable config. [19Sep2021 06:13:10.867] [Netty Epoll Server IO #0/WARN] [com.connectivity.Connectivity/]: Login payload for Registry minecraft:item is using 111.6286% of max allowed size and will cause errors during login if connectivity is not present on client side. [19Sep2021 06:13:10.880] [Netty Epoll Server IO #0/WARN] [com.connectivity.Connectivity/]: Login payload for Registry minecraft:block is using 87.6082% of max allowed size [19Sep2021 06:13:18.792] [User Authenticator #2/INFO] [net.minecraft.network.login.ServerLoginNetHandler/]: UUID of player KiingSultan is e69dbe58-dd8d-4d26-9317-a643a0ffde12 [19Sep2021 06:15:19.013] [Server thread/INFO] [net.minecraft.network.login.ServerLoginNetHandler/]: com.mojang.authlib.GameProfile@28a892fa[id=e69dbe58-dd8d-4d26-9317-a643a0ffde12,name=KiingSultan,properties={textures=[com.mojang.authlib.properties.Property@53a47b26]},legacy=false] (/5.193.109.22:50239) lost connection: Timed out Thanks in advance.
    • This isn't something we can fix (or even work around) without someone on the Dev team having an M1 Mac. For context, this is not a Forge issue, Apple being Apple they decided M1's didn't need backwards compatiblity with their old graphics API when they made the new one and the update to GLFW to accomodate the change hasn't made its way through LWJGL as of this writing
    • Hello. I am trying to add custom ores. Everything seems to be called and executed (when print statements are added), but nothing changes in game. I had it working in 1.16, but not in 1.17. I changed some of it to work with the new forge version, and it compiles without errors, but nothing changes in game. Any help figuring this out is appreciated.   Code: @Mod.EventBusSubscriber public class OreGeneration { public static ImmutableList<TargetBlockState> ORE_TARGET_LIST; public static final ArrayList<ConfiguredFeature<?, ?>> overworldOres = new ArrayList<ConfiguredFeature<?, ?>>(); public static void registerOres(){ ORE_TARGET_LIST = ImmutableList.of(OreConfiguration.target(Predicates.NATURAL_STONE, Blocks.STONE.defaultBlockState())); overworldOres.add(register("tin_ore_block", Feature.ORE.configured(new OreConfiguration(ORE_TARGET_LIST, 5)) .rangeUniform(VerticalAnchor.absolute(0), VerticalAnchor.absolute(48)) .squared() .count(20) )); } private static <FC extends FeatureConfiguration> ConfiguredFeature<FC, ?> register(String name, ConfiguredFeature<FC, ?> configuredFeature) { return Registry.register(BuiltinRegistries.CONFIGURED_FEATURE, new ResourceLocation(Extras.MODID, name), configuredFeature); } @SubscribeEvent(priority = EventPriority.HIGHEST) public static void registerBiomeModification(BiomeLoadingEvent event) { BiomeGenerationSettingsBuilder generation = event.getGeneration(); for(ConfiguredFeature<?, ?> ore : overworldOres){ if (ore != null) { generation.getFeatures(Decoration.UNDERGROUND_ORES).add(() -> { return ore; }); } } } }
    • you haven't, you still store the ModEventBus in a static Field and you register the Renderer of your Entity in FMLCommonSetupEvent and not in FMLClientSetupEvent Edit: you still use static initializer for your EntityTypes, I would recommend you to look again at the basics for the Registry System: FCW or the Forge doc
    • post debug log, if you use java 17 downgrade to java 16, since at the moment not supported by Forge
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.