[1.15.2] Does my OreGen Function work?

[DragonITA 12]

Hello, i have looked to find the Vanilla Code, but i simply cant find it. I followed a tutorial on youtube for the 1.15.2 and i have this code: 

https://github.com/DragonGamerDevelopers/NewFantasyMod/blob/1.15.2/src/main/java/mod/dragonita/fantasymod/world/gen/FantasyOreGen.java#L25 Then i looked into my World to see if it worked or not, but nothing, i cant find my Ore. I ask here: does my Code actually work and if not, then why?

[OBCLetter 2]

100% sure all world generation events get loaded in FMLCommonSetupEvent. Try moving FantasyOreGen.generateOre() into setup in Main. Works for me with my custom structure generation.

Edited February 20, 2020 by OBCLetter

[DragonITA 12]

Ok, i will try, thanks!

[diesieben07 7619]

For a start, Biome#addFeature is not threadsafe. So you cannot call that method in FMLCommonSetupEvent or any other parallel-mod-loading event. It must be delayed using DeferredWorkQueue.

[DragonITA 12]

Ehm, sorry to boring you, but i dont have any idea on how use it.

[diesieben07 7619]

7 minutes ago, DragonITA said:

Ehm, sorry to boring you, but i dont have any idea on how use it.

Did you read the Javadocs? Did you look at the available methods?

[DragonITA 12]

Ok, i read the Javadocs, but it still dont work. Why? i implemented DeferredWorkQueue.CheckedRunnable to my Main class, but still dont work. Why?

[diesieben07 7619]

3 hours ago, DragonITA said:

Ok, i read the Javadocs, but it still dont work. Why? i implemented DeferredWorkQueue.CheckedRunnable to my Main class, but still dont work. Why?

Why did you do that? That doesn't accomplish anything.

[DragonITA 12]

On 2/21/2020 at 12:10 PM, diesieben07 said:

Did you read the Javadocs? Did you look at the available methods?

 

3 hours ago, diesieben07 said:

Why did you do that? That doesn't accomplish anything.

 

I have read the Docs and see the Methods, and the only thing i have see was a interface. Then i tried with implementing it and have see the run function. I have think that it should work but no. How should i then use it? It only has a Inerface.

 

Edit: I false used it and now see a couple of functions, now i am trying to use it (Dont have a Idea on how using Runnable).

Edited February 23, 2020 by DragonITA

[DragonITA 12]

Ok, i have implemented Runnable to my OreGen class, but still dont know how to pass it in the Parameters of DeferredWorkQueue.runLater. Any Idea? Realy need help pls.

[diesieben07 7619]

Do you actually understand what runLater does?

[DragonITA 12]

37 minutes ago, diesieben07 said:

Do you actually understand what runLater does?

Yes, it load the Thread after something has accomplished (my Laptop battery was empty and i am writting from mobile), i think after the World has loaded?

[diesieben07 7619]

14 hours ago, DragonITA said:

Yes, it load the Thread after something has accomplished

This doesn't make any sense.

 

It runs the runnables you give it after parallel mod loading has completed and it runs them on the main thread (so it is safe to access things that are not threadsafe).

[DragonITA 12]

Ok, but how can i the use it? Any idea? I dont know how to work with the DeferredWorkqueue. I implemented Runnable to my Oregen, but still dont know how to pass my class to the parameters of from the function.

[diesieben07 7619]

Implementing Runnable "to your Oregen" doesn't make sense.

You need to pass in a Runnable that will use Biome#addFeature like you already do now.

[DragonITA 12]

Ok, then it is pretty simple  When i come to my home (after the school) then i will try what you suggest. Thanks for helping me!

[DragonITA 12]

 

9 hours ago, diesieben07 said:

Implementing Runnable "to your Oregen" doesn't make sense.

You need to pass in a Runnable that will use Biome#addFeature like you already do now.

Ehm nope, i am getting a error when launching the game: Registry Object non present. I the have see the Log and it sems to see that it dont work because it dont find my custom Ore. Ok, yet i really understanding nothing. Was this a problem from DeferredWorkQueue, that it run before the DeferredRegister? Log: https://github.com/DragonGamerDevelopers/Minecraft-Modding-Logs/blob/master/LOG.log

Main.java: https://github.com/DragonGamerDevelopers/NewFantasyMod/blob/1.15.2/src/main/java/mod/dragonita/fantasymod/Main.java

 

Edited February 24, 2020 by DragonITA

[DragonITA 12]

@diesieben07Is this the reason that it was deprecated?