Jump to content

Custom Block GUI - Why do my items fall out when picked up?


Draco18s

Recommended Posts

Ok, I have a working custom GUI with inventory slots and all that jazz.

 

But here's the thing:

 

I want to have some locked slots (effectively output slots), several storage slots (like a chest), and an input slot.

 

But it seems that every time I move items from one slot to another in the code (e.g. taking the input stack and moving to an output slot or to a storage slot) when I go to pick that stack up, I pick up a stack of size one and drop it into the world.

 

What gives?

 

Update entity function:

 

public void updateEntity() {
    	if (chestContents[30] != null) {
    	    	//if the input slot has something in it
    		for(int i = 18; i < 24; i++) {
    	    	    	//find an output slot that has the same item, or an empty one
    			if(chestContents[i] != null && chestContents[i].getItem() == chestContents[30].getItem()) {
    	    	    	    	//if output matches, stick the rest in storage and quit
    				placeItemInChest(30);
    				return;
    			}
    			else if (chestContents[i] == null) {
    	    	    	    	//if an empty output slot, put one in the output and the rest in storage, then quit
    				chestContents[i] = chestContents[30].splitStack(1);
    				placeItemInChest(30);
    				return;
    			}
    		}
    	}
    }
    
    private void placeItemInChest(int slotID) {
    	if(chestContents[slotID] == null || chestContents[slotID].stackSize == 0) {
    		return;
    	}
	for(int i = 0; i < 18; i++) {
    		    if(chestContents[i] == null) {
		    //copy to new slot, null old slot
   			    chestContents[i] = chestContents[slotID].copy();
    			    chestContents[slotID] = null;
    			    return;
    			}
    		}
    }

 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Exactly the same problem as I have inn my fucked up GUI thread.

I've got the feeling that this is a subtle but quite stupid bug we have somehow managed to implement :P

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

Exactly the same problem as I have inn my fucked up GUI thread.

I've got the feeling that this is a subtle but quite stupid bug we have somehow managed to implement :P

 

I discovered late last night that placing the Slots at negative values is what does it:

 

for (int i = 0; i < 6; i++) {//down
			for (int j = 0; j < 3; j++) {//across
				addSlotToContainer(new Slot(shopEntity, j + i * 3, mod -35 + j * 18, 0 + i * 18));
			}
		}

 

See that mod in there?  It's equal to 35, so that when j is 0, the x position of the slot doesn't go negative.  Which means the farthest left you can put a slot is where the left most hotbar item is.

 

The problem is, I can't find a way to shift the leftmost edge of the Gui to the left, that is, make the actual GUI bigger.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

To set the GUI size set xSize and ySize to the appropriate values in your initGui method in the GuiContainer.

 

Ok, so, here's the thing:

 

In order to make a gui that is wider than it is tall, the texture doesn't render properly.

 

I set xSize to 291 (256+35) and increase my texture's width by the same amount (transparent pixels on the right edge):

width=800 height=449http://s21.postimg.org/if7xg385z/2013_05_05_17_08_45.png[/img]

 

Ok, so maybe the texture needs to be square, add 35 pixels to the height (centering it), and increase the GUI size to 291 tall as well.

width=800 height=449http://s18.postimg.org/h1f77j5mh/2013_05_05_17_10_58.png[/img]

 

Yeah, I have no idea what's going on.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.