Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

PlayerInteract is called multiple times


Recommended Posts

Hey so I'm working on a Survival Games mod right now and I'm using the PlayerInteractEvent for some things. However, it is called multiple times and I have no clue why. It is only registered once but gets called more than once, when aiming on something that isn't air. Can someone help me please :D

Link to post
Share on other sites
25 minutes ago, DragonITA said:

First, if you need help show the full mod on Github or Gitlab. Second: are you working on a weapon or what else? Third: Are you use it on the on both sides or Client or Server side?

First: I don't have it on github, but I can do it if necessary
Second: I'm just using a piece of paper to vote for a map. 

Third: I have a check if it's serverside

 

It gets called twice when aiming on a block and I found out that there is PlayerInteractEvent.RightClickEmpty but that only works Clientside, though the mod is completely serverside

Link to post
Share on other sites
1 minute ago, diesieben07 said:

Need more info.

How many times? Show your code.


	@SubscribeEvent
	public void onInteract(PlayerInteractEvent.RightClickEmpty event) {
		if (event.getWorld() instanceof ServerWorld) {
			if (event.getSide() == LogicalSide.SERVER) {
				if (event.getHand() == Hand.MAIN_HAND) {
					if (event.getPlayer().getHeldItem(Hand.MAIN_HAND) != null) {
						ItemStack item = event.getPlayer().getHeldItem(Hand.MAIN_HAND);
						ServerPlayerEntity player = (ServerPlayerEntity) event.getPlayer();
						String displayName = item.getDisplayName().getFormattedText();
						if (item.getItem() == Items.PAPER) {
							if (HungerGames.getInstance().getMapManager().maps.contains(displayName)) {
								HungerGames.getInstance().getVoteManager().vote(displayName, player);
							}
						} else if (item.getItem() == Items.ANVIL) {
							boolean selecting = HungerGames.getInstance().getKitManager().kitSelecting.get(player);

							if (selecting) {
								HungerGames.getInstance().getVoteManager().addItems(player);
								HungerGames.getInstance().getTeamManager().addItems(player);
								HungerGames.getInstance().getKitManager().addItems(player);

								ChatUtil.sendMessage(player, HungerGames.getInstance().getMessageManager().messages
										.get("kitChosen").replaceAll("%kit%", displayName));
								HungerGames.getInstance().getKitManager().chosenKits.put(player, displayName);

							} else {
								HungerGames.getInstance().getKitManager().addKitItems(player);
							}
							HungerGames.getInstance().getKitManager().kitSelecting.put(player, !selecting);
						} else if (item.getItem() == Items.BOOK) {
							if (HungerGames.getInstance().getMapManager().maps.contains(displayName)) {
								HungerGames.getInstance().getAdminManager().selectMap(displayName, player);
							}
						}
					}
				}
			}
		}
	}

This is the code. It gets executed once when looking in the air and twice when aiming on a block

Link to post
Share on other sites
12 minutes ago, diesieben07 said:

RightClickEmpty is fired when aiming at nothing ("looking in the air"). It is not fired when aiming at a block.

It is not possible for this event handler to fire when right-clicking a block.

oh, yea, sorry. I only had PlayerInteractEvent in there before, I tried it out with RightClickEmpty, then it wasn't fired at all. Looks like it is a client-side event. 

This was my actual code

@SubscribeEvent
	public void onInteract(PlayerInteractEvent event) {
		if (event.getWorld() instanceof ServerWorld) {
			if (event.getSide() == LogicalSide.SERVER) {
				if (event.getHand() == Hand.MAIN_HAND) {
					if (event.getPlayer().getHeldItem(Hand.MAIN_HAND) != null) {
						ItemStack item = event.getPlayer().getHeldItem(Hand.MAIN_HAND);
						ServerPlayerEntity player = (ServerPlayerEntity) event.getPlayer();
						String displayName = item.getDisplayName().getFormattedText();
						if (item.getItem() == Items.PAPER) {
							if (HungerGames.getInstance().getMapManager().maps.contains(displayName)) {
								HungerGames.getInstance().getVoteManager().vote(displayName, player);
							}
						} else if (item.getItem() == Items.ANVIL) {
							boolean selecting = HungerGames.getInstance().getKitManager().kitSelecting.get(player);

							if (selecting) {
								HungerGames.getInstance().getVoteManager().addItems(player);
								HungerGames.getInstance().getTeamManager().addItems(player);
								HungerGames.getInstance().getKitManager().addItems(player);

								ChatUtil.sendMessage(player, HungerGames.getInstance().getMessageManager().messages
										.get("kitChosen").replaceAll("%kit%", displayName));
								HungerGames.getInstance().getKitManager().chosenKits.put(player, displayName);

							} else {
								HungerGames.getInstance().getKitManager().addKitItems(player);
							}
							HungerGames.getInstance().getKitManager().kitSelecting.put(player, !selecting);
						} else if (item.getItem() == Items.BOOK) {
							if (HungerGames.getInstance().getMapManager().maps.contains(displayName)) {
								HungerGames.getInstance().getAdminManager().selectMap(displayName, player);
							}
						}
					}
				}
			}
		}
	}

 

Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.