[1.14.4] Renderer not working I assume

[Ezio214]

Hello There!

So I'm new to this so please don't flame me. I want to create a custom Entity. I done the modeling with tabula and exported it as a java file.

 

As you can see here:

Spoiler

package morecraft.entity.models;

import morecraft.entity.Monster1;
import net.minecraft.client.renderer.entity.model.EntityModel;
import net.minecraft.client.renderer.entity.model.RendererModel;

public class Monster1Model extends EntityModel<Monster1> 
{
	public RendererModel leftleg;
    public RendererModel rightleg;
    public RendererModel lowerbody;
    public RendererModel upperbody;
    public RendererModel upperarmleft;
    public RendererModel upperrightarm;
    public RendererModel lowerleftarm;
    public RendererModel lowerrightarm;
    public RendererModel Head;
    public RendererModel Eye;
    
	public Monster1Model() {
        this.textureWidth = 128;
        this.textureHeight = 32;
        this.upperbody = new RendererModel(this, 0, 17);
        this.upperbody.setRotationPoint(-7.0F, 6.0F, -4.0F);
        this.upperbody.addBox(0.0F, 0.0F, 0.0F, 15, 5, 10, 0.0F);
        this.setRotateAngle(upperbody, -0.3141592653589793F, 0.0F, 0.0F);
        this.upperrightarm = new RendererModel(this, 46, 0);
        this.upperrightarm.setRotationPoint(-7.0F, 9.0F, -4.0F);
        this.upperrightarm.addBox(0.0F, 0.0F, 0.0F, 4, 10, 4, 0.0F);
        this.setRotateAngle(upperrightarm, -0.3490658503988659F, 0.0F, 0.0F);
        this.lowerleftarm = new RendererModel(this, 62, 0);
        this.lowerleftarm.setRotationPoint(1.0F, 15.0F, -7.0F);
        this.lowerleftarm.addBox(3.0F, 2.0F, 0.0F, 4, 7, 4, 0.0F);
        this.setRotateAngle(lowerleftarm, -0.12217304763960307F, 0.0F, 0.0F);
        this.Head = new RendererModel(this, 50, 22);
        this.Head.setRotationPoint(-2.0F, 4.0F, -7.0F);
        this.Head.addBox(0.0F, 0.0F, 0.0F, 5, 5, 5, 0.0F);
        this.lowerbody = new RendererModel(this, 0, 0);
        this.lowerbody.setRotationPoint(-7.0F, 9.0F, 5.0F);
        this.lowerbody.addBox(0.0F, 0.0F, 0.0F, 15, 5, 8, 0.0F);
        this.setRotateAngle(lowerbody, -0.7853981633974483F, 0.0F, 0.0F);
        this.lowerrightarm = new RendererModel(this, 62, 0);
        this.lowerrightarm.setRotationPoint(-10.0F, 15.0F, -7.0F);
        this.lowerrightarm.addBox(3.0F, 2.0F, 0.0F, 4, 7, 4, 0.0F);
        this.setRotateAngle(lowerrightarm, -0.12217304763960307F, 0.0F, 0.0F);
        this.Eye = new RendererModel(this, 50, 16);
        this.Eye.setRotationPoint(-1.0F, 5.0F, -8.0F);
        this.Eye.addBox(0.0F, 0.0F, 0.0F, 3, 3, 3, 0.0F);
        this.leftleg = new RendererModel(this, 78, 0);
        this.leftleg.setRotationPoint(3.0F, 16.0F, 6.0F);
        this.leftleg.addBox(0.0F, 0.0F, 0.0F, 4, 8, 4, 0.0F);
        this.setRotateAngle(leftleg, 0.22689280275926282F, 0.0F, 0.0F);
        this.rightleg = new RendererModel(this, 78, 0);
        this.rightleg.setRotationPoint(-7.0F, 16.0F, 6.0F);
        this.rightleg.addBox(1.0F, 0.0F, 0.0F, 4, 8, 4, 0.0F);
        this.setRotateAngle(rightleg, 0.22689280275926282F, 0.0F, 0.0F);
        this.upperarmleft = new RendererModel(this, 46, 0);
        this.upperarmleft.setRotationPoint(4.0F, 9.0F, -4.0F);
        this.upperarmleft.addBox(0.0F, 0.0F, 0.0F, 4, 10, 4, 0.0F);
        this.setRotateAngle(upperarmleft, -0.3490658503988659F, 0.0F, 0.0F);
    }
	
    @Override
    public void render(Monster1 entity, float f, float f1, float f2, float f3, float f4, float f5) {
        this.upperbody.render(f5);
        this.upperrightarm.render(f5);
        this.lowerleftarm.render(f5);
        this.Head.render(f5);
        this.lowerbody.render(f5);
        this.lowerrightarm.render(f5);
        this.Eye.render(f5);
        this.leftleg.render(f5);
        this.rightleg.render(f5);
        this.upperarmleft.render(f5);
    }
    
    public void setRotateAngle(RendererModel RendererModel, float x, float y, float z) {
        RendererModel.rotateAngleX = x;
        RendererModel.rotateAngleY = y;
        RendererModel.rotateAngleZ = z;
    }
	 
}

 

 

I also made a renderer for it. Renderer class:

Spoiler

package morecraft.entity.renders;

import morecraft.Reference;
import morecraft.entity.Monster1;
import morecraft.entity.models.Monster1Model;
import net.minecraft.client.renderer.entity.EntityRenderer;
import net.minecraft.client.renderer.entity.EntityRendererManager;
import net.minecraft.client.renderer.entity.LivingRenderer;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.fml.client.registry.IRenderFactory;

public class Monster1Render extends LivingRenderer<Monster1, Monster1Model>
{
	public Monster1Render(EntityRendererManager manager)
	{
		super(manager, new Monster1Model(), 0f);
	}

	@Override
	protected ResourceLocation getEntityTexture(Monster1 entity) 
	{
		return new ResourceLocation(Reference.modid, "textures/entity/Monster1.png");
	}

	public static class RenderFactory implements IRenderFactory<Monster1>
	{
		@Override
		public EntityRenderer<? super Monster1> createRenderFor(EntityRendererManager manager)
		{
			return new Monster1Render(manager);
		}
	}
}

 

 

And I made a class where I create it:

Spoiler

package morecraft.entity;

import morecraft.lists.EntityList;
import net.minecraft.entity.EntityType;
import net.minecraft.entity.SharedMonsterAttributes;
import net.minecraft.entity.ai.goal.LookRandomlyGoal;
import net.minecraft.entity.ai.goal.NearestAttackableTargetGoal;
import net.minecraft.entity.ai.goal.RandomWalkingGoal;
import net.minecraft.entity.ai.goal.SwimGoal;
import net.minecraft.entity.monster.MonsterEntity;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.world.World;

public class Monster1 extends MonsterEntity{

	@SuppressWarnings("unchecked")
	public Monster1(EntityType<? extends MonsterEntity> type, World worldIn) {
		super((EntityType<? extends MonsterEntity>) EntityList.MONSTER1, worldIn);
	}
	
	protected void registerGoals() {
		this.goalSelector.addGoal(1, new SwimGoal(this));
		this.goalSelector.addGoal(2, new NearestAttackableTargetGoal<>(this, PlayerEntity.class, true));
		this.goalSelector.addGoal(3, new LookRandomlyGoal(this));
		this.goalSelector.addGoal(4, new RandomWalkingGoal(this, 3));
	}
	
	protected void registerAttributes() {
    
        super.registerAttributes();
        
        this.getAttribute(SharedMonsterAttributes.MAX_HEALTH).setBaseValue(50.0d);
        this.getAttribute(SharedMonsterAttributes.MOVEMENT_SPEED).setBaseValue(0.75d);
        this.getAttribute(SharedMonsterAttributes.ATTACK_DAMAGE).setBaseValue(5.0d);
        this.getAttribute(SharedMonsterAttributes.ARMOR).setBaseValue(20.0d);
        this.getAttribute(SharedMonsterAttributes.KNOCKBACK_RESISTANCE).setBaseValue(2.0d);
        
    }
}

 

 

 Here I create the Entities:

Spoiler

package morecraft.lists;

import morecraft.Reference;
import morecraft.entity.Monster1;
import net.minecraft.entity.EntityClassification;
import net.minecraft.entity.EntityType;
import net.minecraft.item.Item;
import net.minecraft.item.ItemGroup;
import net.minecraft.item.SpawnEggItem;
import net.minecraft.util.ResourceLocation;
import net.minecraft.world.biome.Biome;
import net.minecraft.world.biome.Biome.SpawnListEntry;
import net.minecraft.world.biome.Biomes;
import net.minecraftforge.event.RegistryEvent;

public class EntityList 
{
	public static EntityType<?> MONSTER1 = EntityType.Builder.create(Monster1::new, EntityClassification.MONSTER).build(Reference.modid + ":monster1").setRegistryName(Reference.modid, "monster1");
	
	public static void registerEntitySpawnEggs(final RegistryEvent.Register<Item> event)
	{
		event.getRegistry().registerAll
		(
				ItemList.monster1_egg = registerEntitySpawnEgg(MONSTER1, 0x191919, 0x515151, "monster1")
		);
	}
	
	public static void registerEntityWorldSpawns()
	{
		registerEntityWorldSpawn(MONSTER1, Biomes.PLAINS, Biomes.DESERT);
	}

	public static Item registerEntitySpawnEgg(EntityType<?> type, int color1, int color2, String name)
	{
		SpawnEggItem spawnegg = new SpawnEggItem(type, color1, color2, new Item.Properties().group(ItemGroup.COMBAT));
		spawnegg.setRegistryName(location(name));
		return spawnegg;
	}
	
	private static ResourceLocation location(String name)
	{
		return new ResourceLocation(Reference.modid, name);
	}
	
	public static void registerEntityWorldSpawn(EntityType<?> entity,Biome...biomes)
	{
		for(Biome biome : biomes)
		{
			if(biome != null)
			{
				biome.getSpawns(entity.getClassification()).add(new SpawnListEntry(entity, 10, 1, 10));
			}
		}
	}
}

 

 

And on my main class I added this:

Spoiler

@SubscribeEvent
		public static void registerEntities(final RegistryEvent.Register<EntityType<?>> event)
		{
			event.getRegistry().registerAll
			(
					EntityList.MONSTER1
			);
			
			EntityList.registerEntityWorldSpawns();
		}

 

 

 

Still when I spawn the Entity it looks like this (which is not the model I did):

 

I hope someone can help me with this, because I'm unable to find the mistake myself.

[imacatlolol]

Did you forget to register your entity's renderer? You need to use RenderingRegistry#registerEntityRenderingHandler in the FMLClientSetupEvent.

[Ezio214]

Yes I forgot. Thank you. I registered them at the FMLClientSetupEvent as you can see here:

 

private void clientRegisteries(final FMLClientSetupEvent event)
	{
		logger.info("ClientRegistries works!");
		MorecraftRenderRegistry.registryEntityRenders();
	}

 

And here is the class for the RenderingRegistry:

Spoiler

package morecraft.entity.renders;

import morecraft.entity.Monster1;
import net.minecraftforge.fml.client.registry.RenderingRegistry;

public class MorecraftRenderRegistry 
{
	public static void registryEntityRenders()
	{
		RenderingRegistry.registerEntityRenderingHandler(Monster1.class, new Monster1Render.RenderFactory());
	}

}

 

 

 

But now I got a diffrent problem. On the Logs it says:

 

[29Feb2020 11:48:04.760] [Client thread/ERROR] [net.minecraft.client.renderer.entity.LivingRenderer/]: Couldn't render entity net.minecraft.util.ResourceLocationException: Non [a-z0-9/._-] character in path of location: morecraft:textures/entity/Monster1.png

at net.minecraft.util.ResourceLocation.<init>(SourceFile:38) ~[forge-1.14.4-28.2.1_mapped_snapshot_20200119-1.14.4.jar:?]
    at net.minecraft.util.ResourceLocation.<init>(SourceFile:47) ~[forge-1.14.4-28.2.1_mapped_snapshot_20200119-1.14.4.jar:?]
    at morecraft.entity.renders.Monster1Render.getEntityTexture(Monster1Render.java:22) ~[main/:?]
    at morecraft.entity.renders.Monster1Render.getEntityTexture(Monster1Render.java:12) ~[main/:?]

 

Here is the Monster1Render class:

19 hours ago, Ezio214 said:

I also made a renderer for it. Renderer class:

  Hide contents

package morecraft.entity.renders;

import morecraft.Reference;
import morecraft.entity.Monster1;
import morecraft.entity.models.Monster1Model;
import net.minecraft.client.renderer.entity.EntityRenderer;
import net.minecraft.client.renderer.entity.EntityRendererManager;
import net.minecraft.client.renderer.entity.LivingRenderer;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.fml.client.registry.IRenderFactory;

public class Monster1Render extends LivingRenderer<Monster1, Monster1Model>
{
	public Monster1Render(EntityRendererManager manager)
	{
		super(manager, new Monster1Model(), 0f);
	}

	@Override
	protected ResourceLocation getEntityTexture(Monster1 entity) 
	{
		return new ResourceLocation(Reference.modid, "textures/entity/Monster1.png");
	}

	public static class RenderFactory implements IRenderFactory<Monster1>
	{
		@Override
		public EntityRenderer<? super Monster1> createRenderFor(EntityRendererManager manager)
		{
			return new Monster1Render(manager);
		}
	}
}

 

[Ezio214]

Nevermind got it. I had to change this line

return new ResourceLocation(Reference.modid, "textures/entity/Monster1.png");

into this:

return new ResourceLocation(Reference.modid, "textures/entity/monster1.png");

 

I didn't knew it had to be all in lower case. Would be nice if someone could explain why.

[imacatlolol]

It's a standard enforced by vanilla, i.e. Mojang. I believe it's for compatibility reasons, but it also helps ensure consistency. If I had to guess, it may also prevent weird conflicts as "Monster1" and "monster1" are technically different but may look the same, so requiring things to be lowercase likely helps with any strange issues that may arise from that.