Jump to content

onItemRightClick return an item [1.15.1]


Dr.Nickenstein

Recommended Posts

46 minutes ago, Dr.Nickenstein said:

So I want this item to check the block that it hits on right click, and if it is a certain block, it returns a certain item

 

Don't do it on the item, do it on the block. If it is your block override onBlockActivated and check if the player is holding your item. If it is a vanilla block use events to achieve the same thing.

Link to comment
Share on other sites

55 minutes ago, Dr.Nickenstein said:

Yes, it is. It's called "RubberStreamingRubberWoodLog", that's the class that I created.

 

Then go to your block class, override onBlockActivated and check there if the player is holding your item. If it is, do stuff. onBlockActivated provides you with the player that right clicked the block and the hand he used, so you have pretty much all you need.

 

Alternatively, you can subscribe to PlayerInteractEvent.RightClickBlock and check there if the player is holding your item.

Edited by Cerandior
Link to comment
Share on other sites

3 minutes ago, Cerandior said:

Then go to your block class, override onBlockActivated and check there if the player is holding your item. If it is, do stuff. onBlockActivated provides you with the player that right clicked the block and the hand he used, so you have pretty much all you need.

 

Alternatively, you can subscribe to PlayerInteractEvent.RightClickBlock and check there if the player is holding your item.

so this? player.getHeldItem(handIn); and then how do i check which item it is?

Edited by Dr.Nickenstein
Link to comment
Share on other sites

Just now, Dr.Nickenstein said:

so this? player.getHeldItem(handIn); and then how do i check which item it is?

That will return an itemstack I believe. 
itemstack.getItem() will give you the item and then you use instanceof to check whether that item is the same with what you want or not.

Link to comment
Share on other sites

Just now, Cerandior said:

That will return an itemstack I believe. 
itemstack.getItem() will give you the item and then you use instanceof to check whether that item is the same with what you want or not.

Yeah i want this block to drop a certain item when it is right clicked (activated) with another item.

Link to comment
Share on other sites

10 minutes ago, Cerandior said:

That will return an itemstack I believe. 
itemstack.getItem() will give you the item and then you use instanceof to check whether that item is the same with what you want or not.

@Override
    public ActionResultType onBlockActivated(BlockState state, World worldIn, BlockPos pos, PlayerEntity player,
            Hand handIn, BlockRayTraceResult hit)
    {    
        ItemStack itemstack = player.getHeldItem(handIn);
        itemstack.getItem();
        if
        {
            itemstack = ItemInit.RUBBER_EXTRACTOR.get();
        }
        
    }
   

I've done this, but on itemstack = ItemInit.RUBBER_EXTRACTOR.get(); it gives me an error it says it can't convert from ItemStack to Item. How do I fix it?

The problem is item and itemstack are different things apparently, and the methods work with itemstack. Help

Edited by Dr.Nickenstein
Link to comment
Share on other sites

4 minutes ago, Dr.Nickenstein said:

@Override
    public ActionResultType onBlockActivated(BlockState state, World worldIn, BlockPos pos, PlayerEntity player,
            Hand handIn, BlockRayTraceResult hit)
    {    
        ItemStack itemstack = player.getHeldItem(handIn);
        itemstack.getItem();
        if
        {
            itemstack = ItemInit.RUBBER_EXTRACTOR.get();
        }
        
    }
   

I've done this, but on itemstack = ItemInit.RUBBER_EXTRACTOR.get(); it gives me an error it says it can't convert from ItemStack to Item. How do I fix it?

The problem is item and itemstack are different things apparently, and the methods work with itemstack. Help

 

I have no clue what the hell are you doing there. Don't mean to insult you, but based on that I am assuming you don't have much experience with programming in general.

I'll help you this time and write it for you, but you will not get far if you don't know much programming.
 

Item item = player.getHeldItem(handIn).getItem();

if(item instanceof ItemInit.RUBBER_EXTRACTOR){
	//Do stuff
}

 

What you did wrong before:
1) itemstack.getItem() returns an item and does nothing else. Simply calling it and not assigning the returned value anywhere means that line of code is pretty much useless.

2) That is not how you use if statements. The syntax is:

if(condition){
statement
}

 

Link to comment
Share on other sites

12 minutes ago, Cerandior said:

 

I have no clue what the hell are you doing there. Don't mean to insult you, but based on that I am assuming you don't have much experience with programming in general.

I'll help you this time and write it for you, but you will not get far if you don't know much programming.
 


Item item = player.getHeldItem(handIn).getItem();

if(item instanceof ItemInit.RUBBER_EXTRACTOR){
	//Do stuff
}

 

What you did wrong before:
1) itemstack.getItem() returns an item and does nothing else. Simply calling it and not assigning the returned value anywhere means that line of code is pretty much useless.

2) That is not how you use if statements. The syntax is:


if(condition){
statement
}

 

For the second error, i corrected it later but didn't correct the post with it, for the first one thanks. BTW wehn you do (item instanceof ItemInit.RUBBER_EXTRACTOR)

{

stuff

}

it says rubber extractor isn't a type, and I can't reference any kind of other items

Edited by Dr.Nickenstein
Link to comment
Share on other sites

3 hours ago, Dr.Nickenstein said:

item instanceof ItemInit.RUBBER_EXTRACTOR

Sigh.

Let me break this down.

X instanceof Y requires X to be an object and Y to be a Class.

X == Y requires X to be an object (or primative) and Y to be an object (or primative).

Your code, item instanceof ItemInit.RUBBER_EXTRACTOR, has X is an object, Y is an object.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.