[1.15.2] I can't find updated documentation on ore generation

[Nyanar]

Hi, I am new to modding and was testing a very basic mod where a custom ore drops a custom item. However, I can't find a way to make it generate naturally in the overworld. Some posts I have been looking into point to the following method:

@SubscribeEvent
    public static void onInitBiomesGen(WorldTypeEvent.BiomeSize event) {
        for (Biome biome : ForgeRegistries.BIOMES) {
            biome.addFeature(
                    GenerationStage.Decoration.UNDERGROUND_ORES, Feature.ORE.func_225566_b_(
                            new OreFeatureConfig(
                                    OreFeatureConfig.FillerBlockType.NATURAL_STONE, ModBlocks.LYNITE_ORE, 8
                            )
                    )
                    .func_227228_a_(Placement.COUNT_RANGE.func_227446_a_(new CountRangeConfig(1, 0, 0, 16))
                )
            );
        }
    }

However, the function

func_225566_b_

and the function

func_227446_a_

don't seem to exist for Forge. They might have gotten a proper name in the last updates, but I can't find any way to know which. What I'm asking for is somewhere to find updated documentation and some help with ore generation. Thank you.

 

PS.: I know that my code is terrible; I'm not new to Java but I know nothing about modding.

 

Edited March 15, 2020 by Nyanar

[Cyborgmas]

Seems outdated to me (could be wrong), try doing this: 

 

https://github.com/SilentChaos512/ScalingHealth/blob/1.14/src/main/java/net/silentchaos512/scalinghealth/world/SHWorldFeatures.java#L22 

 

You need to use deferredWorkQueue for ore gen as in 

https://github.com/SilentChaos512/ScalingHealth/blob/1.14/src/main/java/net/silentchaos512/scalinghealth/SideProxy.java#L47

[Nyanar]

Thank you; I had also tried that, but Forge 1.15.2 (latest) does not recognise the method 

Biome.createDecoratedFeature(Feature, OreFeatureConfig)

in net.minecraft.world.biome.Biome. I'm guessing it has been changed in the 1.15 update, but can't find any info on that.

[Cyborgmas]

oh right i was on 1.14. Only thing I can offer you right now is your method names

1st one is withConfiguration

 

2nd one is configure

[Nyanar]

This is my take now, IntelliJ desn't point out any syntax errors, but it is still not working for some reason:

    @SubscribeEvent
    public static void onInitBiomesGen(WorldTypeEvent.BiomeSize event) {
        for (Biome biome : ForgeRegistries.BIOMES) {
            biome.addFeature(GenerationStage.Decoration.UNDERGROUND_ORES, Feature.ORE.withConfiguration(new OreFeatureConfig(OreFeatureConfig.FillerBlockType.NATURAL_STONE, ModBlocks.LYNITE_ORE.getDefaultState(), 17)).withPlacement(Placement.COUNT_RANGE.configure(new CountRangeConfig(20, 0, 0, 128))));
        }
    }

I have taken a look at Minecraft's source code and can't figure out what's wrong in the above code.

[Cyborgmas]

A github repo would be nice. Also what do you mean not working. Is it crashing? if so provide the log. Is it not generating? 

[Nyanar]

Oh, yes, sure. This is my GitHub Repository. Plus, I have managed to solve it (by solving it I mean that the ore does generate as intended without any issue) by changing WorldTypeEvent.BiomeSize to FMLLoadCompleteEvent, but I still don't know why the former did not work. Also, what I meant by not working was that everything ran fine, except the ore did not generate at all. I'm sorry for being so vague.

However all that, I have two questions: why does WorldTypeEvent.BiomeSize not work and what do the values for bottomOffset and topOffset (the two zeroes in the WorldFeatures class) mean?

[Cyborgmas]

So even if it is generating I think that is still the wrong way to do it. I showed you my code on how to use deferredworkqueue. It can cause trouble if you load it immediately. 

 

If you take a look at the BiomeSize event, it tells you it is for modifying the biome size, so not at all what you need.

 

 

For the offset my best guess is that they limit the distance between ground level and the ore? Not sure tbh...

[Nyanar]

Well, according to this documentation, BiomeSize is fired when vanilla Minecraft attempts to generate biomes, so it sounds quite fine to me... Also, what do you mean by the wrong way to do it? What trouble could it cause?

Thank you very much for your assistance, by the way ;)

[Nyanar]

/**
 * BiomeSize is fired when vanilla Minecraft attempts to generate biomes.<br>
 * This event is fired during biome generation in
 * {@link GenLayer#initializeAllBiomeGenerators(long, WorldType, ChunkProviderSettings)}. <br>
 * <br>
 * {@link #originalSize} the original size of the Biome. <br>
 * {@link #newSize} the new size of the biome. Initially set to the {@link #originalSize}. <br>
 * If {@link #newSize} is set to a new value, that value will be used for the Biome size. <br>
 * <br>
 * This event is not {@link Cancelable}.<br>
 * <br>
 * This event does not have a result. {@link HasResult} <br>
 * <br>
 * This event is fired on the {@link MinecraftForge#TERRAIN_GEN_BUS}.<br>
 **/

This is the comment on the event on net.minecraftforge.event.terraingen.WorldTypeEvent.BiomeSize. To me it does seem like the proper event to go with, but again I feel that I'm missing something...

[Cyborgmas]

Would need someone else to confirm but with their size definition it seems that Forge intends this event only for changing biome size.

Using deferredWorkQueue will ensure that other mods will have properly done their stuff before the features are added. I don't know the details but it's basically a let forge handle it case.