[SOLVED!]My Ores are not generated

[me1]

So I have these Blocks(white_empty_block & black_empty_block) witch I want to spawn underground just like Ores. Sadly it isn't working. I don't know where the problem is. I added some logs and all methods I want to be called are called. Here are some parts of my code:

    @SubscribeEvent
    public static void loadCompleteEvent(FMLLoadCompleteEvent event)
    {
        BlockInit.onOreGeneration();
        OreGenerator.generateOre();
    }

// ^ This is in my main Class

public static void onOreGeneration()
    {
        Biome[] overWorld = getBiomes(BiomeDictionary.Type.OVERWORLD);
        OreGenerator.Ores.add(new OreGenerator.OreType(white_empty_block.getDefaultState(), overWorld, new CountRangeConfig(1180, 8, 8, 124), OreFeatureConfig.FillerBlockType.NATURAL_STONE, 2));
        OreGenerator.Ores.add(new OreGenerator.OreType(black_empty_block.getDefaultState(), overWorld, new CountRangeConfig(1140, 8, 8, 124), OreFeatureConfig.FillerBlockType.NATURAL_STONE, 2));
    }

//^ This is in my BlockInit

public class OreGenerator {
    public static class OreType {
        public final BlockState ore;
        public final Biome[] biomes;
        public final CountRangeConfig countRangeConfig;
        public final OreFeatureConfig.FillerBlockType fillerBlockType;
        public final int size;

        public OreType(BlockState ore, Biome[] biomesIn, CountRangeConfig countRangeConfig, OreFeatureConfig.FillerBlockType fillerBlock, int maxGroupSize) {
            this.ore = ore;
            biomes = biomesIn;
            this.countRangeConfig = countRangeConfig;
            fillerBlockType = fillerBlock;
            size = maxGroupSize;
        }
    }

    public static final ArrayList<OreType> Ores = new ArrayList<OreType>();

    public static void generateOre() {
        for (Object oreType : Ores.toArray())
            for (int i = 0; i < ForgeRegistries.BIOMES.getValues().size(); ++i) {
                for (Biome biomeCan : ((OreType) oreType).biomes)
                    if (ForgeRegistries.BIOMES.getValues().contains(biomeCan)) {
                        OreType ore = (OreType) oreType;
                        ConfiguredPlacement placement = Placement.COUNT_RANGE.configure(ore.countRangeConfig);
                        ((Biome)ForgeRegistries.BIOMES.getValues().toArray()[i]).addFeature(GenerationStage.Decoration.UNDERGROUND_ORES, Feature.ORE.withConfiguration(
                                new OreFeatureConfig(ore.fillerBlockType, ore.ore, ore.size)).withPlacement(placement));
                    }
            }
    }

    public static Biome[] getBiomes(BiomeDictionary.Type type) {
        Object[] _biomes = BiomeDictionary.getBiomes(type).toArray();
        Biome[] biomes = new Biome[_biomes.length];
        for (int i = 0; i < _biomes.length; ++i)
            biomes[i] = (Biome) _biomes[i];
        return biomes;
    }
}

//^ This is My OreGenerator Class

 

Please help.

Edited April 7, 2020 by me1
SOLVED

[me1]

Someone help please!

[Ugdhar]

8 minutes ago, me1 said:

Someone help please!

Please don't bump threads after so short amount of time, it is considered rude. Give it at least a day.

 

If someone that knows how to help you sees your thread, they will do so.

[Animefan8888]

1 hour ago, me1 said:

for (int i = 0; i < ForgeRegistries.BIOMES.getValues().size(); ++i) {
	for (Biome biomeCan : ((OreType) oreType).biomes)
		if (ForgeRegistries.BIOMES.getValues().contains(biomeCan)) {
			OreType ore = (OreType) oreType;
			ConfiguredPlacement placement = Placement.COUNT_RANGE.configure(ore.countRangeConfig);
			((Biome)ForgeRegistries.BIOMES.getValues().toArray()[i]).addFeature(GenerationStage.Decoration.UNDERGROUND_ORES, Feature.ORE.withConfiguration(new OreFeatureConfig(ore.fillerBlockType, ore.ore, ore.size)).withPlacement(placement));
		}
}
    

 

What are you trying to do here?

You iterate every biome for the oreType for every biome in the game.

News flash

Quote

(Biome)ForgeRegistries.BIOMES.getValues().toArray()

This is not the biome that you want to add it to. Right now your code will try to add it to every biome.

 

1 hour ago, me1 said:

FMLLoadCompleteEvent

This is not the correct event to do this in. You should be doing this in the FMLCommonSetupEvent.

[me1]

I change the whole double loop nonesence, translated the FMLLoadCompleteEvent to to FMLCommonSetupEvent and added it to DefferedWorkQueue and... it still soesn't work

Here is some more information some might find usefull:

-I don't you Deferred Registers. I use the othe method(dunno how it's called).

-I also can't find my biomes.

-The blocks work when. I can place them, I can craft them, I just can't find them under the ground(I seearched for multiple minuets)

[Animefan8888]

5 minutes ago, me1 said:

I change the whole double loop nonesence, translated the FMLLoadCompleteEvent to to FMLCommonSetupEvent and added it to DefferedWorkQueue and... it still soesn't work

Post your new code.

 

5 minutes ago, me1 said:

-I don't you Deferred Registers. I use the othe method(dunno how it's called)

Registry Events?

 

5 minutes ago, me1 said:

-I also can't find my biomes.

Did you tell them to generate? Also a separate issue.

[me1]

Here's my new code:

private void setup(final FMLCommonSetupEvent event) {
        for(int i = 0; i < 5000; ++i)
            LOGGER.info("SETUP");
        BlockInit.onOreGeneration();
        OreGenerator.generateOre();
    }

    public static void deferredWorkQueue(DeferredWorkQueue  queue)
    {
        for(int i = 0; i < 5000; ++i)
            LOGGER.info("SETUP");
        BlockInit.onOreGeneration();
        OreGenerator.generateOre();
    }

//^ MainClass Updated

public static void generateOre() {
        for (Object oreType : Ores.toArray())
                for (int i = 0; i < ((OreType)oreType).biomes.length; ++i)
                    {Biome biome = ((OreType)oreType).biomes[i];
                        OreType ore = (OreType) oreType;
                        ConfiguredPlacement placement = Placement.COUNT_RANGE.configure(ore.countRangeConfig);
                        biome.addFeature(GenerationStage.Decoration.UNDERGROUND_ORES, Feature.ORE.withConfiguration(
                                new OreFeatureConfig(ore.fillerBlockType, ore.ore, ore.size)).withPlacement(placement));
                    }
    }

//^ OreGenerator Updated

[Animefan8888]

6 minutes ago, me1 said:

public static void deferredWorkQueue(DeferredWorkQueue queue) { for(int i = 0; i < 5000; ++i) LOGGER.info("SETUP"); BlockInit.onOreGeneration(); OreGenerator.generateOre(); }

This is not what using DeferredWorkQueue means. You need to use DeferredWorkQueue.runLater to run your code on the main thread.

[me1]

Ok, it worked but I also had to set the rareity to 20. So I actually had 2 Bugs and kept fixing one and initiating the other at the same time