Jump to content

[1.15.2] How to check if player is blocking with a shield?


ultra_reemun

Recommended Posts

22 minutes ago, Ugdhar said:

I would say take a look at LivingAttackEvent

Thanks for the reply, I've looked into it but there's nothing specific to blocking with a Shield.

 

Unfortunately I don't think there's a specific event for what I'm after, which means I need another way around it.

 

Link to comment
Share on other sites

Just now, ultra_reemun said:

Thanks for the reply, I've looked into it but there's nothing specific to blocking with a Shield.

 

Unfortunately I don't think there's a specific event for what I'm after, which means I need another way around it.

 

That's what I came up with, I was just looking into it myself earlier today for S&Gs, not for any real reason. In the event you can check for a shield, and probably check for if it's being raised (haven't tried that myself at all) and then do what you want.

  • Thanks 1
Link to comment
Share on other sites

5 minutes ago, Ugdhar said:

That's what I came up with, I was just looking into it myself earlier today for S&Gs, not for any real reason. In the event you can check for a shield, and probably check for if it's being raised (haven't tried that myself at all) and then do what you want.

Ah, clearly I didn't look for long enough!

Thank you greatly, how did you check for a shield?

Link to comment
Share on other sites

On 4/8/2020 at 10:51 PM, ultra_reemun said:

Is there an event for this that I can hook onto?

 

I'm looking to:

  • Detect when the player is blocking with a shield
  • Detect when the player's shield blocks an attack

 

Thanks for your help!

Sorry to revisist this but I'm still having trouble, even after looking through all the entity events myself.

 

When the player blocks with a shield, LivingAttackEvent is not fired, does anyone know of any events that would be?

I can also confirm that LivingKnockBackEvent isn't either.

 

I'm using LivingEntityUseItemEvent to determine when I'm blocking, but I can't tell when an attack is actually blocked.

Edited by ultra_reemun
Link to comment
Share on other sites

Just a heads up, the isActiveItemStackBlocking method inside LivingEntity might be more useful for this case.

As for the events not firing, I'm not sure. What is your code, and what are you doing to test it? In some cases, LivingAttackEvent doesn't always fire on players (like if a player is in creative, I think).

In fact, it should actually be firing twice on players if I'm reading the code right... Wait nevermind, I think it only fires once. The code is just confusing.

Edited by imacatlolol
  • Like 1
  • Thanks 1

I'm eager to learn and am prone to mistakes. Don't hesitate to tell me how I can improve.

Link to comment
Share on other sites

10 hours ago, imacatlolol said:

Just a heads up, the isActiveItemStackBlocking method inside LivingEntity might be more useful for this case.

As for the events not firing, I'm not sure. What is your code, and what are you doing to test it? In some cases, LivingAttackEvent doesn't always fire on players (like if a player is in creative, I think).

In fact, it should actually be firing twice on players if I'm reading the code right...

I think my conditional must have been to restrictive as I've simplified it and it's firing now,

Thanks for reminding me to test it!

 

Edit: I realised what's up, it's not registering an attack from a zombie for whatever reason

Edited by ultra_reemun
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.