[1.15.2] Can't use attackEntityFrom to fully kill player

[ketchup_god]

I am trying to make it so that when the player takes any damage, they instantly die with a custom death message. To display message, I needed to use attackEntityFrom(CustomDamageSource, 100). However, what happens is when the player is "killed" the death message appears and the player dies but you can see the player still has full health, and when the player is damaged again another death message is shown. I'm guessing this is because attackEntityFrom makes the game think the player is dead, but when they get damaged again the game realizes and then actually kills the player. Is there a way to avoid this and kill the player with a custom death message?

[Draco18s]

Show your code. All of it. Preferably as a git repo.

[ketchup_god]

@Mod.EventBusSubscriber(modid = BadMinecraftFeatures.MOD_ID, bus = Bus.FORGE, value = Dist.CLIENT)
public class OnPlayerDamage
{
	@SuppressWarnings("resource")
	@SubscribeEvent
	public static void onPlayerDamage(LivingDamageEvent event) throws InterruptedException
	{
		World world = Minecraft.getInstance().world;
		Entity entity = event.getEntity();
		if (entity instanceof PlayerEntity) 
		{
			Item MainItem = ((PlayerEntity) entity).getHeldItemMainhand().getItem();
			if (MainItem == ItemInit.totem_of_dying) 
			{
				double x = entity.getPosX();
				double y = entity.getPosY();
				double z = entity.getPosZ();
				((PlayerEntity) entity).inventory.deleteStack(((PlayerEntity) entity).getHeldItemMainhand());
				Minecraft.getInstance().gameRenderer.displayItemActivation(new ItemStack(ItemInit.totem_of_dying, 1));
				world.playSound( x, y, z, SoundEvents.ITEM_TOTEM_USE, SoundCategory.MASTER, 1.0F, 1.0F, false);
				entity.attackEntityFrom(CustomDamageSources.TotemDamage, 100);
				for (int i = 0; i < 5; i++) 
				{
					Minecraft.getInstance().particles.addParticleEmitter(entity, ParticleTypes.TOTEM_OF_UNDYING);
					TimeUnit.MILLISECONDS.sleep(100);
				}
			}
		}
	}
}

Here's the code. I haven't set up a git repo yet, will in the future

[Animefan8888]

8 minutes ago, ketchup_god said:

World world = Minecraft.getInstance().world;

No. Minecraft is a client only class. Use the World inside the Entity.

[ketchup_god]

27 minutes ago, diesieben07 said:

You cannot do this. This is reaching across logical sides.

Alright, I'm guessing I need to send a packet to the server or do something along those lines because those methods are all serverside, right?

 

[ketchup_god]

52 minutes ago, diesieben07 said:

No.

LivingDamageEvent already fires on server (and maybe on the client, too). Just check that World#isRemote is false and do not use client-only classes.

I set up a server to test the mod after adding the World#isRemote test and compiled the mod. I could connect to the server fine and everything worked, but the LivingDamageEvent just wouldn't run.

[ketchup_god]

3 minutes ago, diesieben07 said:

Did you install the mod on the server?

Yeah, it's definitely there

[ketchup_god]

@Mod.EventBusSubscriber(modid = BadMinecraftFeatures.MOD_ID, bus = Bus.FORGE, value = Dist.CLIENT)
public class OnPlayerDamage
{
	@SuppressWarnings("resource")
	@SubscribeEvent
	public static void onPlayerDamage(LivingDamageEvent event) throws InterruptedException
	{
		Entity entity = event.getEntity();
		if (!entity.world.isRemote()) 
		{
			if (entity instanceof PlayerEntity) 
			{
				Item MainItem = ((PlayerEntity) entity).getHeldItemMainhand().getItem();
				if (MainItem == ItemInit.totem_of_dying)
				{
					double x = entity.getPosX();
					double y = entity.getPosY();
					double z = entity.getPosZ();
					((PlayerEntity) entity).inventory.deleteStack(((PlayerEntity) entity).getHeldItemMainhand());
					//Minecraft.getInstance().gameRenderer.displayItemActivation(new ItemStack(ItemInit.totem_of_dying, 1));
					entity.world.playSound( x, y, z, SoundEvents.ITEM_TOTEM_USE, SoundCategory.MASTER, 1.0F, 1.0F, false);
					entity.attackEntityFrom(CustomDamageSources.TotemDamage, 100);
					//Minecraft.getInstance().particles.addParticleEmitter(entity, ParticleTypes.TOTEM_OF_UNDYING);
				}
			}
		}
		else
		{
			return;
		}
	}
}

I did multiple tests with removing some parts of the code, and every time it worked fine in singleplayer but just didn't run in multiplayer. The items were initialized and everything, it's just that the event didn't run.

[DavidM]

Your event bus subscriber is set to client (parameter of the annotation). It will only run on the client distribution.

[ketchup_god]

43 minutes ago, DavidM said:

Your event bus subscriber is set to client (parameter of the annotation). It will only run on the client distribution.

Ah of course, somehow didn’t notice. Thanks for the help, I’ll try it out.