Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.15.2] Can't use attackEntityFrom to fully kill player


ketchup_god
 Share

Recommended Posts

I am trying to make it so that when the player takes any damage, they instantly die with a custom death message. To display message, I needed to use attackEntityFrom(CustomDamageSource, 100). However, what happens is when the player is "killed" the death message appears and the player dies but you can see the player still has full health, and when the player is damaged again another death message is shown. I'm guessing this is because attackEntityFrom makes the game think the player is dead, but when they get damaged again the game realizes and then actually kills the player. Is there a way to avoid this and kill the player with a custom death message?

Link to comment
Share on other sites

Show your code. All of it. Preferably as a git repo.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

@Mod.EventBusSubscriber(modid = BadMinecraftFeatures.MOD_ID, bus = Bus.FORGE, value = Dist.CLIENT)
public class OnPlayerDamage
{
	@SuppressWarnings("resource")
	@SubscribeEvent
	public static void onPlayerDamage(LivingDamageEvent event) throws InterruptedException
	{
		World world = Minecraft.getInstance().world;
		Entity entity = event.getEntity();
		if (entity instanceof PlayerEntity) 
		{
			Item MainItem = ((PlayerEntity) entity).getHeldItemMainhand().getItem();
			if (MainItem == ItemInit.totem_of_dying) 
			{
				double x = entity.getPosX();
				double y = entity.getPosY();
				double z = entity.getPosZ();
				((PlayerEntity) entity).inventory.deleteStack(((PlayerEntity) entity).getHeldItemMainhand());
				Minecraft.getInstance().gameRenderer.displayItemActivation(new ItemStack(ItemInit.totem_of_dying, 1));
				world.playSound( x, y, z, SoundEvents.ITEM_TOTEM_USE, SoundCategory.MASTER, 1.0F, 1.0F, false);
				entity.attackEntityFrom(CustomDamageSources.TotemDamage, 100);
				for (int i = 0; i < 5; i++) 
				{
					Minecraft.getInstance().particles.addParticleEmitter(entity, ParticleTypes.TOTEM_OF_UNDYING);
					TimeUnit.MILLISECONDS.sleep(100);
				}
			}
		}
	}
}

Here's the code. I haven't set up a git repo yet, will in the future

Link to comment
Share on other sites

8 minutes ago, ketchup_god said:

World world = Minecraft.getInstance().world;

No. Minecraft is a client only class. Use the World inside the Entity.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

9 minutes ago, ketchup_god said:

World world = Minecraft.getInstance().world;

You cannot do this. This is reaching across logical sides.

 

10 minutes ago, ketchup_god said:

Minecraft.getInstance().gameRenderer.displayItemActivation(new ItemStack(ItemInit.totem_of_dying, 1));

Again, you can't do this.

 

10 minutes ago, ketchup_god said:

Minecraft.getInstance().particles.addParticleEmitter(entity, ParticleTypes.TOTEM_OF_UNDYING);

Again, you can't do this.

 

10 minutes ago, ketchup_god said:

TimeUnit.MILLISECONDS.sleep(100);

This will halt the main game thread for 100 milliseconds. The game will not do anything else during these 100ms. Considering Minecraft's ticks take 50ms each, you are effectively freezing the game for two whole ticks here. And you do that 5 times in a loop. You have to count ticks if you want a delay instead of just freezing the thread.

Link to comment
Share on other sites

Just now, ketchup_god said:

Alright, I'm guessing I need to send a packet to the server or do something along those lines because those methods are all serverside, right?

 

No.

LivingDamageEvent already fires on server (and maybe on the client, too). Just check that World#isRemote is false and do not use client-only classes.

Link to comment
Share on other sites

52 minutes ago, diesieben07 said:

No.

LivingDamageEvent already fires on server (and maybe on the client, too). Just check that World#isRemote is false and do not use client-only classes.

I set up a server to test the mod after adding the World#isRemote test and compiled the mod. I could connect to the server fine and everything worked, but the LivingDamageEvent just wouldn't run.

Link to comment
Share on other sites

@Mod.EventBusSubscriber(modid = BadMinecraftFeatures.MOD_ID, bus = Bus.FORGE, value = Dist.CLIENT)
public class OnPlayerDamage
{
	@SuppressWarnings("resource")
	@SubscribeEvent
	public static void onPlayerDamage(LivingDamageEvent event) throws InterruptedException
	{
		Entity entity = event.getEntity();
		if (!entity.world.isRemote()) 
		{
			if (entity instanceof PlayerEntity) 
			{
				Item MainItem = ((PlayerEntity) entity).getHeldItemMainhand().getItem();
				if (MainItem == ItemInit.totem_of_dying)
				{
					double x = entity.getPosX();
					double y = entity.getPosY();
					double z = entity.getPosZ();
					((PlayerEntity) entity).inventory.deleteStack(((PlayerEntity) entity).getHeldItemMainhand());
					//Minecraft.getInstance().gameRenderer.displayItemActivation(new ItemStack(ItemInit.totem_of_dying, 1));
					entity.world.playSound( x, y, z, SoundEvents.ITEM_TOTEM_USE, SoundCategory.MASTER, 1.0F, 1.0F, false);
					entity.attackEntityFrom(CustomDamageSources.TotemDamage, 100);
					//Minecraft.getInstance().particles.addParticleEmitter(entity, ParticleTypes.TOTEM_OF_UNDYING);
				}
			}
		}
		else
		{
			return;
		}
	}
}

I did multiple tests with removing some parts of the code, and every time it worked fine in singleplayer but just didn't run in multiplayer. The items were initialized and everything, it's just that the event didn't run.

Link to comment
Share on other sites

Your event bus subscriber is set to client (parameter of the annotation). It will only run on the client distribution.

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.