[1.15.2] Access tile entity from container

[Budschie]

I've recently tried to add a tile entity with a gui and a container. To add a slot for the tile entity, I need to access it, but I have no idea how...

 

Container:

public class DeepNetherBlastFurnaceContainer extends Container
{
	public static final ContainerType<DeepNetherBlastFurnaceContainer> TYPE = new ContainerType<DeepNetherBlastFurnaceContainer>(DeepNetherBlastFurnaceContainer::new);
	
	PlayerInventory playerInv;
	ItemStackHandler iStackHandler;
	
	public DeepNetherBlastFurnaceContainer(int id, PlayerInventory playerInv, ItemStackHandler teInventory)
	{
		super(TYPE, id);
		
		this.playerInv = playerInv;
		this.iStackHandler = teInventory;
		
		this.addSlot(new SlotItemHandler(iStackHandler, 1, 56, 17));
        this.addSlot(new SlotItemHandler(iStackHandler, 0, 56, 53));
        this.addSlot(new SlotItemHandler(iStackHandler, 2, 116, 35));

        for (int i = 0; i < 3; ++i)
        {
            for (int j = 0; j < 9; ++j)
            {
                this.addSlot(new Slot(playerInv, j + i * 9 + 9, 8 + j * 18, 84 + i * 18));
            }
        }

        for (int k = 0; k < 9; ++k)
        {
            this.addSlot(new Slot(playerInv, k, 8 + k * 18, 142));
        }
	}
	
	public DeepNetherBlastFurnaceContainer(int id, PlayerInventory playerInv)
	{
		super(TYPE, id);
		
		this.playerInv = playerInv;
	}

	@Override
	public boolean canInteractWith(PlayerEntity playerIn)
	{
		return true;
	}
	
}

The code to open the container:

	@Override
	public ActionResultType onBlockActivated(BlockState state, World worldIn, BlockPos pos, PlayerEntity player, Hand handIn, BlockRayTraceResult p_225533_6_)
	{
		if(!worldIn.isBlockLoaded(pos))
		{
			return ActionResultType.FAIL;
		}
		if(!worldIn.isRemote)
		{
			TileEntity te = worldIn.getTileEntity(pos);
			if(te != null && te instanceof DeepNetherBlastFurnaceTileEntity)
			{
				NetworkHooks.openGui((ServerPlayerEntity) player, ((INamedContainerProvider)te), pos);
			}
		}
		
		return ActionResultType.SUCCESS;
	}

TileEntity:

public class DeepNetherBlastFurnaceTileEntity extends TileEntity implements ICapabilityProvider, INamedContainerProvider
{
	//Code
	@Override
	public Container createMenu(int p_createMenu_1_, PlayerInventory p_createMenu_2_, PlayerEntity p_createMenu_3_)
	{
		return new DeepNetherBlastFurnaceContainer(p_createMenu_1_, p_createMenu_2_, this.inventory);
	}

	@Override
	public ITextComponent getDisplayName()
	{
		return new StringTextComponent("Test String");
	}
}

 

[Animefan8888]

22 minutes ago, Budschie said:

I need to access it, but I have no idea how...

Pass it in via the constructor. Probably instead of the ItemStackHandler.

[Budschie]

2 minutes ago, diesieben07 said:

First of all, do not create registry entries (like ContainerType) in static initializers. Use the appropriate registry event or, even better, DeferredRegister.

So, I've changed my registry class a bit, it now looks like this:

Registry class:

@EventBusSubscriber(bus = Bus.MOD)
public class ContainerRegistry
{
	@SubscribeEvent
	public static void registerContainer(RegistryEvent.Register<ContainerType<?>> event)
	{
		IForgeRegistry<ContainerType<?>> registry = event.getRegistry();
		
		registry.register(new ContainerType<DeepNetherBlastFurnaceContainer>(DeepNetherBlastFurnaceContainer::new).setRegistryName(new ResourceLocation(References.MODID, "nether_blast_furnace_container")));
	}
}

 

Container class:

public class DeepNetherBlastFurnaceContainer extends Container
{
	@ObjectHolder(value = References.MODID+":nether_blast_furnace_container")
	public static final ContainerType<DeepNetherBlastFurnaceContainer> TYPE = null;
	
	PlayerInventory playerInv;
	ItemStackHandler iStackHandler;
	
	public DeepNetherBlastFurnaceContainer(int id, PlayerInventory playerInv, ItemStackHandler teInventory)
	{
		super(TYPE, id);
		
		this.playerInv = playerInv;
		this.iStackHandler = teInventory;
		
		this.addSlot(new SlotItemHandler(iStackHandler, 1, 56, 17));
        this.addSlot(new SlotItemHandler(iStackHandler, 0, 56, 53));
        this.addSlot(new SlotItemHandler(iStackHandler, 2, 116, 35));

        for (int i = 0; i < 3; ++i)
        {
            for (int j = 0; j < 9; ++j)
            {
                this.addSlot(new Slot(playerInv, j + i * 9 + 9, 8 + j * 18, 84 + i * 18));
            }
        }

        for (int k = 0; k < 9; ++k)
        {
            this.addSlot(new Slot(playerInv, k, 8 + k * 18, 142));
        }
	}
	
	public DeepNetherBlastFurnaceContainer(int id, PlayerInventory playerInv)
	{
		super(TYPE, id);
		
		this.playerInv = playerInv;
	}

	@Override
	public boolean canInteractWith(PlayerEntity playerIn)
	{
		return true;
	}
	
}

I've did some debugging too, and the problem seems to be that the constructor without the ItemStackHandler gets called on the client side.

[Budschie]

Maybe I should just get the ItemStackHandler on the client side by parsing the block pos of the tile entity into the extra data packet and processing it on the client side.

[Budschie]

19 minutes ago, diesieben07 said:

You need to create a proper IContainerFactory for your container. Which constructor gets called is entirely controlled by your code, so if the wrong one gets called then your code is wrong.

I've now implemented IContainerFactory , parsed the block pos into the custom packet buffer, and now it seemed to work:

IContainerFactory implementation:

registry.register(new ContainerType<DeepNetherBlastFurnaceContainer>(new IContainerFactory<DeepNetherBlastFurnaceContainer>()
		{

			@Override
			public DeepNetherBlastFurnaceContainer create(int windowId, PlayerInventory inv, PacketBuffer data)
			{
				if(data != null)
				{
					BlockPos tePos = new BlockPos(data.readInt(), data.readInt(), data.readInt());
					TileEntity te = Minecraft.getInstance().world.getTileEntity(tePos);
					
					if(te != null && te instanceof DeepNetherBlastFurnaceTileEntity)
					{
						return new DeepNetherBlastFurnaceContainer(windowId, inv, ((DeepNetherBlastFurnaceTileEntity)te));
					}
				}
				
				return new DeepNetherBlastFurnaceContainer(windowId, inv);
			}
			
		}).setRegistryName(new ResourceLocation(References.MODID, "nether_blast_furnace_container")));

Block Class:

	@Override
	public ActionResultType onBlockActivated(BlockState state, World worldIn, BlockPos pos, PlayerEntity player, Hand handIn, BlockRayTraceResult p_225533_6_)
	{
		if(!worldIn.isBlockLoaded(pos))
		{
			return ActionResultType.FAIL;
		}
		if(!worldIn.isRemote)
		{
			TileEntity te = worldIn.getTileEntity(pos);
			if(te != null && te instanceof DeepNetherBlastFurnaceTileEntity)
			{
				NetworkHooks.openGui((ServerPlayerEntity) player, ((INamedContainerProvider)te), new Consumer<PacketBuffer>()
				{

					@Override
					public void accept(PacketBuffer t)
					{
						t.writeInt(pos.getX());
						t.writeInt(pos.getY());
						t.writeInt(pos.getZ());
					}
				});
			}
		}
		
		return ActionResultType.SUCCESS;
	}

Thanks.

[TheGreyGhost]

Howdy

Containers, TileEntity, and ContainerScreen synchronisation has a few traps, you might find the working examples in this tutorial project useful (mbe30, mbe31)

https://github.com/TheGreyGhost/MinecraftByExample

 

The main trap is: your server-side Container will access the TileEntity, but your client side should not, otherwise you will probably get synchronisation problems because your client-side container is getting two copies of information: one via the container update packets, and one via tile-entity update packets.

 

This page also has more background information

http://greyminecraftcoder.blogspot.com/2020/04/containers-1144.html

-TGG

Edited April 19, 2020 by TheGreyGhost
clarification