Adding a new EnchantedBookItem to ItemGroup, Item doesn't show

[hoodzeay]

Goal: Add a custom enchantment to an enchantment book, place that enchanted book into a custom creative tab

 

I've tried a few different methods, but I finally gave in and came for help when trying to add it via fillItemGroup on the item. I'm probably doing everything wrong, but I'm solely working off of what I can find in the code base. The first attempt I tried to directly add the group through a new instance of EnchantmentBookItem and setting new properties. Second attempt grabbing the items creative tab and setting it, this caused an error (probably for a good reason). I've primarily been working on trying to find how the game adds them, but it's not easily found since it's not calling the ItemGroup's directly. I've traced ENCHANTED_BOOK back through every usage and didn't see anything, but I'm working on finding where they are added. I'm working through all the methods I find relevant right now. 

 

I'm guessing I'm not properly creating the EnchantmentBookItem, applying the enchantment and registering it (which happens to be everything). I'm looking for some guidance as where to go, a point in the right direction would be appreciated. I provided the latest log and debug log just as a safeguard. 

 

NOTE: This is never going public, it's a learning environment. So please point out anything that's a mess and could cause problems in the future if applicable.

 

 

ItemRegistry.java

package pooter.pot.pie.StompingGround.items;

import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.item.Items;
import net.minecraft.util.NonNullList;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;
import pooter.pot.pie.StompingGround.enchantment.ModEnchantmentsRegistry;
import pooter.pot.pie.StompingGround.inventory.StompingGroundItemGroup;

@Mod.EventBusSubscriber(modid="stompingground",bus=Mod.EventBusSubscriber.Bus.MOD)
public class ItemRegistry {

    @SubscribeEvent
    public static void registerItems(RegistryEvent.Register<Item> event) {
        ItemStack enchantedBook = new ItemStack(Items.ENCHANTED_BOOK);
        enchantedBook.addEnchantment(ModEnchantmentsRegistry.CONCUSSIVEINATOR,1);

        NonNullList<ItemStack> itemStackList = NonNullList.create();
        itemStackList.add(enchantedBook);

        enchantedBook.getItem().fillItemGroup(StompingGroundItemGroup.STOMPING_GROUND,itemStackList);
        event.getRegistry().registerAll(enchantedBook.getItem());
    }
}

 

StompingGroundItemGroup.java

package pooter.pot.pie.StompingGround.inventory;

import net.minecraft.item.ItemGroup;
import net.minecraft.item.ItemStack;
import net.minecraft.item.Items;
import pooter.pot.pie.StompingGround.StompingGround;

import java.util.function.Supplier;

public class StompingGroundItemGroup extends ItemGroup {

    public final Supplier<ItemStack> iconSupplier;
    public static final ItemGroup STOMPING_GROUND = new StompingGroundItemGroup(StompingGround.MODID,()->new ItemStack(Items.CAMPFIRE));

    public StompingGroundItemGroup(String name, Supplier<ItemStack> supplier){
        super(name);
        this.iconSupplier = supplier;
        this.setTabPath("stomping_ground");
    }

    @Override
    public ItemStack createIcon(){
        return iconSupplier.get();
    }

}

 

Debug Log: https://gist.github.com/johnslw26/5a0217bb989490b062826a520543f6b6

latest.log

[Draco18s]

1 hour ago, hoodzeay said:

enchantedBook.getItem().fillItemGroup(StompingGroundItemGroup.STOMPING_GROUND,itemStackList);

This doesn't do what you seem to think it does.

 

Especially not when you do this afterwards:

  

1 hour ago, hoodzeay said:

event.getRegistry().registerAll(enchantedBook.getItem());

 

Edited April 21, 2020 by Draco18s

[hoodzeay]

I see, I’ll look into it more. Thank you. 

[hoodzeay]

I have figured out how the fillItemGroup method works. I've iterated through all the ItemGroup.SEARCH ItemStack's and found my two by comparing the id to my resource path. I feel like I'm over complicating this. New files are below, had an issue where the two enchantments didn't exist yet so I moved them to the class that registers the enchantments. I thought I could just copy the ItemStack and add the ItemGroup in to it's properties but I was wrong. Mind pushing me in the right direction again?

 

package pooter.pot.pie.StompingGround.enchantment;

import net.minecraft.enchantment.Enchantment;
import net.minecraft.item.ItemGroup;
import net.minecraft.item.ItemStack;
import net.minecraft.item.Items;
import net.minecraft.nbt.INBT;
import net.minecraft.util.NonNullList;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;

@Mod.EventBusSubscriber(bus=Mod.EventBusSubscriber.Bus.MOD)
public class ModEnchantmentsRegistry {
    public static final SwinglineInator SWINGLINEINATOR = new SwinglineInator();
    public static final ConcussiveInator CONCUSSIVEINATOR = new ConcussiveInator();

    @SubscribeEvent
    public static void registerEnchantment(RegistryEvent.Register<Enchantment> event){
        event.getRegistry().registerAll(SWINGLINEINATOR,CONCUSSIVEINATOR);

        NonNullList<ItemStack> enchantedBooks = NonNullList.create();
        Items.ENCHANTED_BOOK.fillItemGroup(ItemGroup.SEARCH, enchantedBooks);

        for (ItemStack enchantedBook : enchantedBooks) {
            if(getStoredEnchantment(enchantedBook).getString() == ModEnchantmentsRegistry.CONCUSSIVEINATOR.getRegistryName().toString()){
                ItemStack enchantedBookCopy = enchantedBook.copy();
            }
        }
    }

    /**
     * Return the enchantment id from the StoredEnchantments tag
     * @param itemstack
     * @return
     */
    public static INBT getStoredEnchantment(ItemStack itemstack){
        return !itemstack.getTag().isEmpty() ? itemstack.getTag().getList("StoredEnchantments",10).getCompound(0).get("id") : itemstack.getOrCreateTag();
    }
}

 

[hoodzeay]

I appreciate the help, It has been a few years since I’ve worked with Java. Should have known to use .equals instead of comparing object references and apologies for bringing basic Java errors in. I’ll try this out and hopefully I can call this solved.

[hoodzeay]

Solely for clarification regarding the first point, I should be using a single class to handle all of the registry events. Is that what's meant by

Quote

Do not create registry entries in static initializers.

 

I've looked through a few of your previous posts mentioning this and one corrected the issue, but some mods were not updated. The diff looks like that's the solution. 

[hoodzeay]

package pooter.pot.pie.StompingGround.enchantment;

import net.minecraft.enchantment.Enchantment;
import net.minecraft.item.ItemGroup;
import net.minecraft.item.ItemStack;
import net.minecraft.item.Items;
import net.minecraft.nbt.INBT;
import net.minecraft.util.NonNullList;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;

@Mod.EventBusSubscriber(bus=Mod.EventBusSubscriber.Bus.MOD)
public class ModEnchantmentsRegistry {


    @SubscribeEvent
    public static void registerEnchantment(RegistryEvent.Register<Enchantment> event){
        SwinglineInator SWINGLINEINATOR = new SwinglineInator();
        ConcussiveInator CONCUSSIVEINATOR = new ConcussiveInator();
        
        event.getRegistry().registerAll(SWINGLINEINATOR,CONCUSSIVEINATOR);

        NonNullList<ItemStack> enchantedBooks = NonNullList.create();
        Items.ENCHANTED_BOOK.fillItemGroup(ItemGroup.SEARCH, enchantedBooks);

        for (ItemStack enchantedBook : enchantedBooks) {
            if(getStoredEnchantment(enchantedBook).getString() == CONCUSSIVEINATOR.getRegistryName().toString()){
                ItemStack enchantedBookCopy = enchantedBook.copy();
            }
        }
    }

    /**
     * Return the enchantment id from the StoredEnchantments tag
     * @param itemstack
     * @return
     */
    public static INBT getStoredEnchantment(ItemStack itemstack){
        return !itemstack.getTag().isEmpty() ? itemstack.getTag().getList("StoredEnchantments",10).getCompound(0).get("id") : itemstack.getOrCreateTag();
    }
}

 

I moved the following inside the registerEnchantment event so the two enchantments are no longer a static variable:

 

public static final SwinglineInator SWINGLINEINATOR = new SwinglineInator();
public static final ConcussiveInator CONCUSSIVEINATOR = new ConcussiveInator();

 

Is this what's meant then? My main purpose with this is to improve my skills, so please pardon my ignorance. I understand many here answer these questions multiple times a day, but it's not mentioned. I've researched what a static initializer is and the explanation from oracle confused me with this application.

[hoodzeay]

Thank you. 

[Draco18s]

3 hours ago, hoodzeay said:

        for (ItemStack enchantedBook : enchantedBooks) {
            if(getStoredEnchantment(enchantedBook).getString() == CONCUSSIVEINATOR.getRegistryName().toString()){
                ItemStack enchantedBookCopy = enchantedBook.copy();
            }
        }

This code does actively nothing.

[hoodzeay]

Yeah, wasn’t sure where to go from there but I was informed it was wrong anyways. So removed that attempt.