Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.15.2] Trouble adding Entities to the game


Recommended Posts

I've managed to add entities to the mod, but not with spawn eggs and natural spawns. To start off with, I don't know when to add the entity spawns. Secondly, I don't know if my current spawn code actually works since I haven't tried it, but if you see some problem with it, please point that out. And lastly, the spawn eggs. I know how to add a spawn egg, unfortunately, since i'm using deferred registries for the entities etc. the normal "Entitytype.MYENTITY" does not work, and neither does "Entitytype.MYENTITY.get()" nor "RegistryObject.of(Entitytype.MYENTITY.getId(), ForgeRegistries.ENTITIES)". So to fix this, i decided to pretty much copy the original spawnEggItem class, and change it so it can work with deferred registries. But, some problem has arisen there as well. Specifically, the coloring of the egg; it's always white and grey. 

 

 

 

	public static void registerSpawns() 
	{
		spawnEntities(RegistryObject.of(EtauricEntities.CHUPNUT.getId(), ForgeRegistries.ENTITIES), 25, 1, 3, Biome.Category.FOREST);
		spawnEntities(RegistryObject.of(EntityType.IRON_GOLEM.getRegistryName(), ForgeRegistries.ENTITIES), 25, 1, 3, Biome.Category.FOREST);
	}
	
	private static void spawnEntities(RegistryObject<? extends EntityType<? extends LivingEntity>> entityType, int weightIn, int minGroupCountIn, int maxGroupCountIn, Biome.Category...biomes) 
	{
		Utils.getLogger().info("EntityType: " + entityType);
		
		for (int i = 0; i < biomes.length; i++)
		{
			for (Biome biome : ForgeRegistries.BIOMES)
			{
				if (biome.getCategory() == biomes[i])
				{
					biome.getSpawns(EntityClassification.MONSTER).add(new Biome.SpawnListEntry(entityType.get(), weightIn, minGroupCountIn, maxGroupCountIn));
				}
			}
		}
	}

This is my entity spawn method. 

 

public class EtauricSpawnEggItem extends Item
{
	private static final Map<RegistryObject<? extends EntityType<?>>, EtauricSpawnEggItem> EGGS = Maps.newIdentityHashMap();
	private final int primaryColor;
	private final int secondaryColor;
	private final RegistryObject<? extends EntityType<?>> typeIn;
	
	public EtauricSpawnEggItem(RegistryObject<? extends EntityType<?>> typeIn, int primaryColorIn, int secondaryColorIn, Properties builder) 
	{
		super(builder);
		this.typeIn = typeIn;
		this.primaryColor = primaryColorIn;
		this.secondaryColor = secondaryColorIn;
		EGGS.put(typeIn, this);
	}
	
	public ActionResultType onItemUse(ItemUseContext context) 
	{
		World world = context.getWorld();
		if (world.isRemote) 
		{
			return ActionResultType.SUCCESS;
		} 
		else 
		{
			ItemStack itemstack = context.getItem();
			BlockPos blockpos = context.getPos();
			Direction direction = context.getFace();
			BlockState blockstate = world.getBlockState(blockpos);
			Block block = blockstate.getBlock();
			if (block == Blocks.SPAWNER) 
			{
				TileEntity tileentity = world.getTileEntity(blockpos);
				if (tileentity instanceof MobSpawnerTileEntity) 
				{
					AbstractSpawner abstractspawner = ((MobSpawnerTileEntity)tileentity).getSpawnerBaseLogic();
					RegistryObject<? extends EntityType<?>> entitytype1 = this.getType(itemstack.getTag());
					abstractspawner.setEntityType(entitytype1.get());
					tileentity.markDirty();
					world.notifyBlockUpdate(blockpos, blockstate, blockstate, 3);
					itemstack.shrink(1);
					return ActionResultType.SUCCESS;
				}
			}

			BlockPos blockpos1;
			if (blockstate.getCollisionShape(world, blockpos).isEmpty()) 
			{
				blockpos1 = blockpos;
			} 
			else 
			{
				blockpos1 = blockpos.offset(direction);
		    }
			RegistryObject<? extends EntityType<?>> entitytype = this.getType(itemstack.getTag());
			if (entitytype.get().spawn(world, itemstack, context.getPlayer(), blockpos1, SpawnReason.SPAWN_EGG, true, !Objects.equals(blockpos, blockpos1) && direction == Direction.UP) != null) 
			{
				itemstack.shrink(1);
		    }

			return ActionResultType.SUCCESS;
		}
	}

		   /**
		    * Called to trigger the item's "innate" right click behavior. To handle when this item is used on a Block, see
		    * {@link #onItemUse}.
		    */
	public ActionResult<ItemStack> onItemRightClick(World worldIn, PlayerEntity playerIn, Hand handIn) 
	{
		ItemStack itemstack = playerIn.getHeldItem(handIn);
		RayTraceResult raytraceresult = rayTrace(worldIn, playerIn, RayTraceContext.FluidMode.SOURCE_ONLY);
		if (raytraceresult.getType() != RayTraceResult.Type.BLOCK) 
		{
			return ActionResult.resultPass(itemstack);
		} 
		else if (worldIn.isRemote) 
		{
			return ActionResult.resultSuccess(itemstack);
		} 
		else 
		{
			BlockRayTraceResult blockraytraceresult = (BlockRayTraceResult)raytraceresult;
			BlockPos blockpos = blockraytraceresult.getPos();
			if (!(worldIn.getBlockState(blockpos).getBlock() instanceof FlowingFluidBlock)) 
			{
				return ActionResult.resultPass(itemstack);
			} 
			else if (worldIn.isBlockModifiable(playerIn, blockpos) && playerIn.canPlayerEdit(blockpos, blockraytraceresult.getFace(), itemstack)) 
			{
				RegistryObject<? extends EntityType<?>> entitytype = this.getType(itemstack.getTag());
				if (entitytype.get().spawn(worldIn, itemstack, playerIn, blockpos, SpawnReason.SPAWN_EGG, false, false) == null) 
				{
					return ActionResult.resultPass(itemstack);
				} 
				else 
				{
					if (!playerIn.abilities.isCreativeMode) 
					{
						itemstack.shrink(1);
					}
					playerIn.addStat(Stats.ITEM_USED.get(this));
					return ActionResult.resultSuccess(itemstack);
				}
			} 
			else 
			{
				return ActionResult.resultFail(itemstack);
			}
		}
	}

	public boolean hasType(@Nullable CompoundNBT p_208077_1_, RegistryObject<? extends EntityType<?>> type) 
	{
		return Objects.equals(this.getType(p_208077_1_), type);
	}

	@OnlyIn(Dist.CLIENT)
	public int getColor(int tintIndex) 
	{
		return tintIndex == 0 ? this.primaryColor : this.secondaryColor;
	}

	@Nullable
	@OnlyIn(Dist.CLIENT)
	public static EtauricSpawnEggItem getEgg(@Nullable RegistryObject<? extends EntityType<?>> type) 
	{
		return EGGS.get(type);
	}

	public static Iterable<EtauricSpawnEggItem> getEggs() 
	{
		return Iterables.unmodifiableIterable(EGGS.values());
	}

	public RegistryObject<? extends EntityType<?>> getType(@Nullable CompoundNBT p_208076_1_) 
	{
		if (p_208076_1_ != null && p_208076_1_.contains("EntityTag", 10)) 
		{
			CompoundNBT compoundnbt = p_208076_1_.getCompound("EntityTag");
			if (compoundnbt.contains("id", 8)) 
			{
				return RegistryObject.of(new ResourceLocation(compoundnbt.getString("id")), ForgeRegistries.ENTITIES);
			}
		}
		return this.typeIn;
	}
}

This is my spawn egg class. 

 

	public static final RegistryObject<Item> CHUPNUT_SPAWN_EGG = ITEMS.register("chupnut_spawn_egg", () -> new EtauricSpawnEggItem(RegistryObject.of(EtauricEntities.CHUPNUT.getId(), ForgeRegistries.ENTITIES), 4993583, 12692382, (new Item.Properties().group(ItemGroup.MISC))));

And this is how I register it in my Items register. 

 

Any sort of help is very much appreciated. 

Edited by Triphion
Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Ok so, i changed the entity in this way:   public class SmokeBulletEntity extends DamagingProjectileEntity implements IRendersAsItem { private static final DataParameter<Boolean> ACTIVATED = EntityDataManager.defineId(SmokeBulletEntity.class, DataSerializers.BOOLEAN); private static final ItemStack STACK = new ItemStack(ModItems.BULLET.get()); private int duration; public SmokeBulletEntity(World world) { super(ModEntities.SMOKE_BULLET.get(), world); } @Override public ItemStack getItem() { return STACK; } @Override protected void onHitBlock(BlockRayTraceResult rayTraceResult) { if (this.isActivated()) return; if (!this.level.isClientSide) { this.activate(); } super.onHitBlock(rayTraceResult); } @Override protected void onHitEntity(EntityRayTraceResult entityRayTraceResult) { //Must be Empty } private void activate() { this.setActivated(true); this.duration = 200; this.setDeltaMovement(0, 0, 0); this.xPower = 0; this.yPower = 0; this.zPower = 0; System.out.println("Active Smoke Projectile"); } @Override public void tick() { if (this.isActivated()) { for (int i = 0; i < 100; i++) { this.level.addParticle(ParticleTypes.FLAME, this.getX(), this.getY() + i, this.getZ(), 0, 0, 0); } this.duration--; if (this.duration <= 0) { this.remove(); } } else { super.tick(); } } @Override public void addAdditionalSaveData(CompoundNBT nbt) { super.addAdditionalSaveData(nbt); nbt.putBoolean("activated", this.isActivated()); nbt.putInt("duration", this.duration); } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.set(ACTIVATED, false); } public void setActivated(boolean activated) { this.entityData.set(ACTIVATED, activated); } public boolean isActivated() { return this.entityData.get(ACTIVATED); } @Override public EntityDataManager getEntityData() { return super.getEntityData(); } @Override public void readAdditionalSaveData(CompoundNBT nbt) { super.readAdditionalSaveData(nbt); if (nbt.contains("activated")) { this.setActivated(nbt.getBoolean("activated")); } if (nbt.contains("duration")) { this.duration = nbt.getInt("duration"); } } @Override public IPacket<?> getAddEntityPacket() { return NetworkHooks.getEntitySpawningPacket(this); } } But now, when i spawn it i encounter this error: [15:39:10] [Server thread/FATAL] [minecraft/ThreadTaskExecutor]: Error executing task on Server java.lang.NullPointerException: null at net.minecraft.network.datasync.EntityDataManager.set(EntityDataManager.java:122) ~[forge:?] {re:classloading} at com.ike.gunmod.entity.SmokeBulletEntity.defineSynchedData(SmokeBulletEntity.java:93) ~[?:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.entity.Entity.<init>(Entity.java:216) ~[forge:?] {re:classloading,pl:accesstransformer:B} at net.minecraft.entity.projectile.ProjectileEntity.<init>(ProjectileEntity.java:25) ~[forge:?] {re:classloading} at net.minecraft.entity.projectile.DamagingProjectileEntity.<init>(DamagingProjectileEntity.java:26) ~[forge:?] {re:classloading} at com.ike.gunmod.entity.SmokeBulletEntity.<init>(SmokeBulletEntity.java:35) ~[?:?] {re:classloading,pl:runtimedistcleaner:A} at com.ike.gunmod.item.gun.SmokeGunItem.getBullet(SmokeGunItem.java:32) ~[?:?] {re:classloading} at com.ike.gunmod.item.gun.AbstractGunItem.use(AbstractGunItem.java:42) ~[?:?] {re:classloading} at net.minecraft.item.ItemStack.use(ItemStack.java:217) ~[forge:?] {re:classloading,xf:fml:forge:filled_map.4,xf:fml:forge:itemstack} at net.minecraft.server.management.PlayerInteractionManager.useItem(PlayerInteractionManager.java:287) ~[forge:?] {re:classloading} at net.minecraft.network.play.ServerPlayNetHandler.handleUseItem(ServerPlayNetHandler.java:982) ~[forge:?] {re:classloading} at net.minecraft.network.play.client.CPlayerTryUseItemPacket.handle(CPlayerTryUseItemPacket.java:28) ~[forge:?] {re:classloading} at net.minecraft.network.play.client.CPlayerTryUseItemPacket.handle(CPlayerTryUseItemPacket.java:9) ~[forge:?] {re:classloading} at net.minecraft.network.PacketThreadUtil.lambda$ensureRunningOnSameThread$0(PacketThreadUtil.java:19) ~[forge:?] {re:classloading} at net.minecraft.util.concurrent.TickDelayedTask.run(TickDelayedTask.java:17) ~[forge:?] {re:classloading} at net.minecraft.util.concurrent.ThreadTaskExecutor.doRunTask(ThreadTaskExecutor.java:136) ~[forge:?] {re:classloading,pl:accesstransformer:B} at net.minecraft.util.concurrent.RecursiveEventLoop.doRunTask(RecursiveEventLoop.java:22) ~[forge:?] {re:classloading} at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:734) ~[forge:?] {re:classloading,pl:accesstransformer:B} at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:159) ~[forge:?] {re:classloading,pl:accesstransformer:B} at net.minecraft.util.concurrent.ThreadTaskExecutor.pollTask(ThreadTaskExecutor.java:109) ~[forge:?] {re:classloading,pl:accesstransformer:B} at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:717) ~[forge:?] {re:classloading,pl:accesstransformer:B} at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:711) ~[forge:?] {re:classloading,pl:accesstransformer:B} at net.minecraft.util.concurrent.ThreadTaskExecutor.managedBlock(ThreadTaskExecutor.java:119) ~[forge:?] {re:classloading,pl:accesstransformer:B} at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:697) ~[forge:?] {re:classloading,pl:accesstransformer:B} at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:646) ~[forge:?] {re:classloading,pl:accesstransformer:B} at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:232) ~[forge:?] {re:classloading,pl:accesstransformer:B} at java.lang.Thread.run(Thread.java:748) [?:1.8.0_231] {} Why this happen?
    • nvidia gtx 2060 we found out the cause. it is with the mana and artifice mod and not having optifine, unfortunately our modpack crashes with optifine installed  
    • The log does not even contain an attempted connection. Again, please post the client log. What do you mean by "customer"?
    • マインクラフト
    • nobody connected because we can't and I don't know where the customer is
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.