Jump to content

Custom Damage source in Forge 1.15.2


sccreeper

Recommended Posts

Here is my code so far, I have managed to make it give the potion effects to the entity (the poison effect does not do any damage). My problem is my custom damage sources are not working, they do not do any damage to the player with the item in their inventory. The identifier of the damage source is the same as the in game item, I'm not sure whether that is the problem. All this is inside my main mod class.

public static final DamageSource NOVICHOK_DAMAGE = new DamageSource("novichok");

@SubscribeEvent
public void onPlayerTick(TickEvent.PlayerTickEvent e) {


    if (!e.player.world.isRemote) return;

    if (e.player.inventory.hasItemStack(new ItemStack(RegistryHandler.NOVICHOK_RAW.get()))) {
        e.player.addPotionEffect(new EffectInstance(Effects.POISON, 1000, 5));
        e.player.addPotionEffect(new EffectInstance(Effects.NAUSEA, 1000, 5));
        if((e.player.getHealth()-0.05) < 0) {
            //e.player.

            e.player.attackEntityFrom(NOVICHOK_DAMAGE, 1.0F);
        } else {
            //e.player.playSound();
            e.player.attackEntityFrom(NOVICHOK_DAMAGE, 1.0F);
        }

        //e.player.setHealth((float) (e.player.getHealth()-0.05));
    } else {
        e.player.removeActivePotionEffect(Effects.POISON);
        e.player.removeActivePotionEffect(Effects.NAUSEA);
    }
}

Any help with this would be greatly appreciated.

 

Link to comment
Share on other sites

I have read the documentation but what excactly would I have to put in my

@Mod.EventBusSubscriber(modid = WeaponsMod.MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD)

for it to be logical server side only. I have tried using Dist as a argument e.g

@Mod.EventBusSubscriber(modid = WeaponsMod.MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD,dist=)

but am not sure what to pass for the dist argument. I have tried Dist.DEDICATED_SERVER but that does not make any sense to me as it seems it is referring to a dedicated server and it also results in a error in my IDE (IntelliJ) saying that it cannot resolve dist.

Link to comment
Share on other sites

15 minutes ago, sccreeper said:

I have now tried value=Dist.DEDICATED_SERVER and value=Dist.CLIENT and it is still not working, I have also moved the code to a new events package to clean up my file structure.

To check if you're on the server use World#isRemote, if it returns false you're on the server, if it's true you're on the client.

It's sad how much time mods spend saying "x is no longer supported on this forum. Please update to a modern version of Minecraft to receive support".

Link to comment
Share on other sites

Howdy

You might find this documentation-with-diagrams helpful:

logical sides (isRemote etc)

http://greyminecraftcoder.blogspot.com/2020/02/the-client-server-division-1144.html

 

dedicated server distribution vs client distribution (Dist.DEDICATED_SERVER etc)

http://greyminecraftcoder.blogspot.com/2020/02/minecraft-distributions-client-vs.html

 

I.e. there's nothing wrong with your @SubscribeEvent.  This line is the problem:

 

    if (!e.player.world.isRemote) return;
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.