Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

Projectile that extends off ArrowEntity not shooting


thomask
 Share

Recommended Posts

Hey guys, I am trying to make a projectile that extends off of ArrowEntity fire from my item based off of BowEntity. Here is my code for the Bow-based item:

public class ExplosionStaff extends BowItem {
    public ExplosionStaff() {
        super(new Item.Properties().group(ItemGroup.COMBAT));
    }

    @Override
    public void onPlayerStoppedUsing(ItemStack stack, World worldIn, LivingEntity playerIn, int timeLeft) {
        ExplosionSpellEntity spell = new ExplosionSpellEntity(worldIn, playerIn);
        spell.shoot(playerIn, playerIn.rotationPitch, playerIn.rotationYaw, 0.0F, 50.0F, 0.0F);
        System.out.println("Debug: player stopped using staff");
    }

}

 

And here is the code for the arrow-based projectile:

 

public class ExplosionSpellEntity extends ArrowEntity {
    public ExplosionSpellEntity(EntityType<? extends ArrowEntity> type, World worldIn) {
        super(type, worldIn);
    }

    public ExplosionSpellEntity(World worldIn, double x, double y, double z) {
        super(worldIn, x, y, z);
    }

    public ExplosionSpellEntity(World worldIn, LivingEntity shooter) {
        super(worldIn, shooter);
    }

    @Override
    public void shoot(Entity shooter, float pitch, float yaw, float p_184547_4_, float velocity, float inaccuracy) {
        float f = -MathHelper.sin(yaw * ((float)Math.PI / 180F)) * MathHelper.cos(pitch * ((float)Math.PI / 180F));
        float f1 = -MathHelper.sin(pitch * ((float)Math.PI / 180F));
        float f2 = MathHelper.cos(yaw * ((float)Math.PI / 180F)) * MathHelper.cos(pitch * ((float)Math.PI / 180F));
        this.shoot((double)f, (double)f1, (double)f2, velocity, inaccuracy);
        this.setMotion(this.getMotion().add(shooter.getMotion().x, shooter.onGround ? 0.0D : shooter.getMotion().y, shooter.getMotion().z));
        System.out.println("Debug: Shooted!!");
    }

    @Override
    public void onHit(RayTraceResult raytraceResultIn) {
        System.out.println("Debug: spell entity hit");
        this.world.createExplosion(this, this.getPosX(), this.getPosY(), this.getPosZ(), 20, false, Explosion.Mode.BREAK);
    }

}

 

As you can see, I put various debugging messages here. When I let go of the staff item, it displays the "Shooted!!" and "player stopped using staff" messages, but there is no arrow, so the onHit() debug doesn't print.

What do i need to do? I couldn't find any tutorials on how to make projectiles for 1.15.2 so this is just my guess on where to start. I know I have to "register" entities but not sure how to do that. 

Thank you!

Link to comment
Share on other sites

1 hour ago, thomask said:

Hey guys, I am trying to make a projectile that extends off of ArrowEntity fire from my item based off of BowEntity. Here is my code for the Bow-based item:


public class ExplosionStaff extends BowItem {
    public ExplosionStaff() {
        super(new Item.Properties().group(ItemGroup.COMBAT));
    }

    @Override
    public void onPlayerStoppedUsing(ItemStack stack, World worldIn, LivingEntity playerIn, int timeLeft) {
        ExplosionSpellEntity spell = new ExplosionSpellEntity(worldIn, playerIn);
        spell.shoot(playerIn, playerIn.rotationPitch, playerIn.rotationYaw, 0.0F, 50.0F, 0.0F);
        System.out.println("Debug: player stopped using staff");
    }

}

 

And here is the code for the arrow-based projectile:

 


public class ExplosionSpellEntity extends ArrowEntity {
    public ExplosionSpellEntity(EntityType<? extends ArrowEntity> type, World worldIn) {
        super(type, worldIn);
    }

    public ExplosionSpellEntity(World worldIn, double x, double y, double z) {
        super(worldIn, x, y, z);
    }

    public ExplosionSpellEntity(World worldIn, LivingEntity shooter) {
        super(worldIn, shooter);
    }

    @Override
    public void shoot(Entity shooter, float pitch, float yaw, float p_184547_4_, float velocity, float inaccuracy) {
        float f = -MathHelper.sin(yaw * ((float)Math.PI / 180F)) * MathHelper.cos(pitch * ((float)Math.PI / 180F));
        float f1 = -MathHelper.sin(pitch * ((float)Math.PI / 180F));
        float f2 = MathHelper.cos(yaw * ((float)Math.PI / 180F)) * MathHelper.cos(pitch * ((float)Math.PI / 180F));
        this.shoot((double)f, (double)f1, (double)f2, velocity, inaccuracy);
        this.setMotion(this.getMotion().add(shooter.getMotion().x, shooter.onGround ? 0.0D : shooter.getMotion().y, shooter.getMotion().z));
        System.out.println("Debug: Shooted!!");
    }

    @Override
    public void onHit(RayTraceResult raytraceResultIn) {
        System.out.println("Debug: spell entity hit");
        this.world.createExplosion(this, this.getPosX(), this.getPosY(), this.getPosZ(), 20, false, Explosion.Mode.BREAK);
    }

}

 

As you can see, I put various debugging messages here. When I let go of the staff item, it displays the "Shooted!!" and "player stopped using staff" messages, but there is no arrow, so the onHit() debug doesn't print.

What do i need to do? I couldn't find any tutorials on how to make projectiles for 1.15.2 so this is just my guess on where to start. I know I have to "register" entities but not sure how to do that. 

Thank you!

You actually don't need to register your arrow since it extends ArrowEntity, which causes Minecraft to treat it as a normal arrow but still execute your custom logic. You do however need to register your custom item. To do that you need to use Registry Events. Here's an example from my mod (This part goes inside your main class):

 

@Mod.EventBusSubscriber(bus=Mod.EventBusSubscriber.Bus.MOD)
    public static class RegistryEvents {
        @SubscribeEvent
        public static void onItemRegistry(final RegistryEvent.Register<Item> event) {
          //This is how you register your Bow. However, in setRegistryName(), your mod should pass your own Mod ID for the first argument, not "minecraft". I'm only doing this in my mod because I'm overriding vanilla Bows. The second argument is whatever you name your custom Bow as. And to receive your Custom Bow you would do /give <your-name> modid:name-of-your-bow
            bow = new ItemForgeBow((new Item.Properties()).maxDamage(384).group(ItemGroup.COMBAT));
        	bow.setRegistryName("minecraft", "bow");
        	event.getRegistry().registerAll(bow);
        }
        
    }

In any case, my mod does work and causes vanilla Bows to fire custom Arrows, so I'm confident that this is all you need for your special Bows to work

Link to comment
Share on other sites

6 hours ago, _vertig0 said:

You actually don't need to register your arrow since it extends ArrowEntity, which causes Minecraft to treat it as a normal arrow but still execute your custom logic. You do however need to register your custom item. To do that you need to use Registry Events. Here's an example from my mod (This part goes inside your main class):

 


@Mod.EventBusSubscriber(bus=Mod.EventBusSubscriber.Bus.MOD)
    public static class RegistryEvents {
        @SubscribeEvent
        public static void onItemRegistry(final RegistryEvent.Register<Item> event) {
          //This is how you register your Bow. However, in setRegistryName(), your mod should pass your own Mod ID for the first argument, not "minecraft". I'm only doing this in my mod because I'm overriding vanilla Bows. The second argument is whatever you name your custom Bow as. And to receive your Custom Bow you would do /give <your-name> modid:name-of-your-bow
            bow = new ItemForgeBow((new Item.Properties()).maxDamage(384).group(ItemGroup.COMBAT));
        	bow.setRegistryName("minecraft", "bow");
        	event.getRegistry().registerAll(bow);
        }
        
    }

In any case, my mod does work and causes vanilla Bows to fire custom Arrows, so I'm confident that this is all you need for your special Bows to work

 

Hey, I was originally following a tutorial for my mod which registered the bow item like this 

public class RegistryHandler {

    public static final DeferredRegister<Item> ITEMS = new DeferredRegister<>(ForgeRegistries.ITEMS, Megumin.MOD_ID);

    public static void init() {
        ITEMS.register(FMLJavaModLoadingContext.get().getModEventBus());
    }

    // Items
    public static final RegistryObject<Item> STAFF = ITEMS.register("explosion_staff", ExplosionStaff::new);

}

Do i need both of these?

When I inserted your code into my main class along with what i already have (above code), I got this error https://pastebin.com/47ag730Q

The interesting part seems to be this

[23:46:22] [Server-Worker-3/WARN] [ne.mi.re.ForgeRegistry/REGISTRIES]: Registry Item: Override did not have an associated owner object. Name: megumin:explosion_staff Value: air

 

Also, when I delete my registry handler and just use your thing, it's just the same problem as before. The same debug messages print, but no arrow.

Edited by thomask
Link to comment
Share on other sites

3 hours ago, thomask said:

 

Hey, I was originally following a tutorial for my mod which registered the bow item like this 


public class RegistryHandler {

    public static final DeferredRegister<Item> ITEMS = new DeferredRegister<>(ForgeRegistries.ITEMS, Megumin.MOD_ID);

    public static void init() {
        ITEMS.register(FMLJavaModLoadingContext.get().getModEventBus());
    }

    // Items
    public static final RegistryObject<Item> STAFF = ITEMS.register("explosion_staff", ExplosionStaff::new);

}

Do i need both of these?

When I inserted your code into my main class along with what i already have (above code), I got this error https://pastebin.com/47ag730Q

The interesting part seems to be this


[23:46:22] [Server-Worker-3/WARN] [ne.mi.re.ForgeRegistry/REGISTRIES]: Registry Item: Override did not have an associated owner object. Name: megumin:explosion_staff Value: air

 

Also, when I delete my registry handler and just use your thing, it's just the same problem as before. The same debug messages print, but no arrow.

Oh, my bad. I didn't realise you already registered your Bow. You're registering it correctly, ignore what I said

Link to comment
Share on other sites

9 hours ago, TheGreyGhost said:

Hi

 

You don't appear to spawn your entity?

 

Look at BowItem::onPLayerStoppedUsing


                  worldIn.addEntity(abstractarrowentity);

 

-TGG

 

 

Thank you so much, it works now. Guess I missed that while reading through BowItem lol

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Ok i didnt undertand absolutely anything, even that i learned minecraft modding 1 year ago, can you post a image with code of how can i do that please?
    • check if your event is getting fired, first (and you must be in 3rd person on singleplayer for it to work). second, modifying those values doesn't do anything. It is already rendered (in post) or the values will be overwritten for rendering (in pre). You need to cancel the rendering and do it yourself. I do it with the field model#visible = false in pre, then in post, set it to true, then modify the rotation points and angles, then render it using the render method that takes the buffer, vertex builder, ... it would be much easier to use rightArmPose = ... in PRE. 
    • Have you registered your class as EventBusSubscriber on the correct bus?
    • Nope, 1.16 is going to stay as LTS and 1.17 is getting a 1 month grace period.
    • I downloaded ATM7 on the curseforge launcher and installed it, I can launch it and play it just fine the first time. I can play for as long as I want; when I close the game and exit I can re-launch the game just fine. I turn my PC off and back on again in the morning and try to launch it, that's when it errors out and can't "complete the mod scan". The only way around it I've found is making a new profile for it in curseforge, basically re-downloading it and playing it for "the first time" again. I have a RTX 2080 Ti Strix, an i5 8600K and 32 GB of ram with 8 GB allocated to Minecraft. The crash report as follows:  ---- Minecraft Crash Report ---- // Shall we play a game? Time: 11/30/21, 12:09 PM Description: Initializing game java.lang.IllegalStateException: Failed to complete mod scan     at net.minecraftforge.fml.loading.moddiscovery.BackgroundScanHandler.waitForScanToComplete(BackgroundScanHandler.java:103) ~[fmlloader-1.17.1-37.0.109.jar%2322!:?] {}     at net.minecraftforge.fml.ModLoader.gatherAndInitializeMods(ModLoader.java:153) ~[fmlcore-1.17.1-37.0.109.jar%23218!:?] {}     at net.minecraftforge.fmlclient.ClientModLoader.lambda$begin$1(ClientModLoader.java:108) ~[forge-1.17.1-37.0.109-universal.jar%23221!:?] {re:classloading,pl:runtimedistcleaner:A}     at net.minecraftforge.fmlclient.ClientModLoader.lambda$createRunnableWithCatch$4(ClientModLoader.java:129) ~[forge-1.17.1-37.0.109-universal.jar%23221!:?] {re:classloading,pl:runtimedistcleaner:A}     at net.minecraftforge.fmlclient.ClientModLoader.begin(ClientModLoader.java:108) ~[forge-1.17.1-37.0.109-universal.jar%23221!:?] {re:classloading,pl:runtimedistcleaner:A}     at net.minecraft.client.Minecraft.<init>(Minecraft.java:460) ~[client-1.17.1-20210706.113038-srg.jar%23217!:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A}     at net.minecraft.client.main.Main.main(Main.java:151) ~[client-1.17.1-20210706.113038-srg.jar%23217!:?] {re:classloading,pl:runtimedistcleaner:A}     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] {}     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78) ~[?:?] {}     at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] {}     at java.lang.reflect.Method.invoke(Method.java:567) ~[?:?] {}     at net.minecraftforge.fml.loading.targets.CommonClientLaunchHandler.lambda$launchService$0(CommonClientLaunchHandler.java:45) ~[fmlloader-1.17.1-37.0.109.jar%2322!:?] {}     at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.Launcher.run(Launcher.java:106) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.Launcher.main(Launcher.java:77) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:90) [bootstraplauncher-0.1.17.jar:?] {} A detailed walkthrough of the error, its code path and all known details is as follows: --------------------------------------------------------------------------------------- -- Head -- Thread: Render thread Stacktrace:     at net.minecraftforge.fml.loading.moddiscovery.BackgroundScanHandler.waitForScanToComplete(BackgroundScanHandler.java:103) ~[fmlloader-1.17.1-37.0.109.jar%2322!:?] {}     at net.minecraftforge.fml.ModLoader.gatherAndInitializeMods(ModLoader.java:153) ~[fmlcore-1.17.1-37.0.109.jar%23218!:?] {}     at net.minecraftforge.fmlclient.ClientModLoader.lambda$begin$1(ClientModLoader.java:108) ~[forge-1.17.1-37.0.109-universal.jar%23221!:?] {re:classloading,pl:runtimedistcleaner:A}     at net.minecraftforge.fmlclient.ClientModLoader.lambda$createRunnableWithCatch$4(ClientModLoader.java:129) ~[forge-1.17.1-37.0.109-universal.jar%23221!:?] {re:classloading,pl:runtimedistcleaner:A}     at net.minecraftforge.fmlclient.ClientModLoader.begin(ClientModLoader.java:108) ~[forge-1.17.1-37.0.109-universal.jar%23221!:?] {re:classloading,pl:runtimedistcleaner:A}     at net.minecraft.client.Minecraft.<init>(Minecraft.java:460) ~[client-1.17.1-20210706.113038-srg.jar%23217!:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A} -- Initialization -- Details: Stacktrace:     at net.minecraft.client.main.Main.main(Main.java:151) ~[client-1.17.1-20210706.113038-srg.jar%23217!:?] {re:classloading,pl:runtimedistcleaner:A}     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] {}     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78) ~[?:?] {}     at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] {}     at java.lang.reflect.Method.invoke(Method.java:567) ~[?:?] {}     at net.minecraftforge.fml.loading.targets.CommonClientLaunchHandler.lambda$launchService$0(CommonClientLaunchHandler.java:45) ~[fmlloader-1.17.1-37.0.109.jar%2322!:?] {}     at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.Launcher.run(Launcher.java:106) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.Launcher.main(Launcher.java:77) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:90) [bootstraplauncher-0.1.17.jar:?] {} -- System Details -- Details:     Minecraft Version: 1.17.1     Minecraft Version ID: 1.17.1     Operating System: Windows 10 (amd64) version 10.0     Java Version: 16.0.1, Microsoft     Java VM Version: OpenJDK 64-Bit Server VM (mixed mode), Microsoft     Memory: 1436850640 bytes (1370 MiB) / 2885681152 bytes (2752 MiB) up to 9663676416 bytes (9216 MiB)     CPUs: 6     Processor Vendor: GenuineIntel     Processor Name: Intel(R) Core(TM) i5-8600K CPU @ 3.60GHz     Identifier: Intel64 Family 6 Model 158 Stepping 10     Microarchitecture: Coffee Lake     Frequency (GHz): 3.60     Number of physical packages: 1     Number of physical CPUs: 6     Number of logical CPUs: 6     Graphics card #0 name: NVIDIA GeForce RTX 2080 Ti     Graphics card #0 vendor: NVIDIA (0x10de)     Graphics card #0 VRAM (MB): 4095.00     Graphics card #0 deviceId: 0x1e07     Graphics card #0 versionInfo: DriverVersion=30.0.14.9649     Memory slot #0 capacity (MB): 16384.00     Memory slot #0 clockSpeed (GHz): 2.13     Memory slot #0 type: DDR4     Memory slot #1 capacity (MB): 16384.00     Memory slot #1 clockSpeed (GHz): 2.13     Memory slot #1 type: DDR4     Virtual memory max (MB): 34740.69     Virtual memory used (MB): 18387.16     Swap memory total (MB): 2048.00     Swap memory used (MB): 81.51     JVM Flags: 5 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -Xmx9216m -Xms256m -XX:PermSize=256m     Launched Version: forge-37.0.109     Backend library: LWJGL version 3.2.2 SNAPSHOT     Backend API: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 GL version 3.2.0 NVIDIA 496.49, NVIDIA Corporation     Window size: <not initialized>     GL Caps: Using framebuffer using OpenGL 3.2     GL debug messages:      Using VBOs: Yes     Is Modded: Definitely; Client brand changed to 'forge'     Type: Client (map_client.txt)     CPU: 6x Intel(R) Core(TM) i5-8600K CPU @ 3.60GHz     ModLauncher: 9.0.7+91+master.8569cdf     ModLauncher launch target: forgeclient     ModLauncher naming: srg     ModLauncher services:           mixin PLUGINSERVICE           eventbus PLUGINSERVICE           object_holder_definalize PLUGINSERVICE           runtime_enum_extender PLUGINSERVICE           capability_token_subclass PLUGINSERVICE           capability_inject_definalize PLUGINSERVICE           accesstransformer PLUGINSERVICE           runtimedistcleaner PLUGINSERVICE           mixin TRANSFORMATIONSERVICE           fml TRANSFORMATIONSERVICE      FML Language Providers:          minecraft@1.0         kotori_scala@2.13.6-build-4         javafml@null
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.