Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.14-1.15] Item addPropertiesOverride wont work with custom property


Mekelaina
 Share

Recommended Posts

So Im trying to make it so the textures used for my item depends on values that are passed in from a spell object upon creation. so ideally I can just define a new spell with an element and a level and the model will override with the right textures. this probably isnt how the system is supposed to be used, but I was trying to get out of assigning each model manually and could just have each spellbook use the base model with the predicates and such. But idk if mt custom addPropertiesOverride predicates arent registered right or what because they arent working. is there something im missing, do they require a capability or? any help is appreciated.

 

The Item class

package com.mekelaina.gramarye.items;

import com.mekelaina.gramarye.Gramarye;
import com.mekelaina.gramarye.Spell.Spell;
import net.minecraft.client.util.ITooltipFlag;
import net.minecraft.entity.LivingEntity;
import net.minecraft.item.IItemPropertyGetter;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.item.ItemUseContext;
import net.minecraft.nbt.CompoundNBT;
import net.minecraft.util.ActionResultType;
import net.minecraft.util.ResourceLocation;
import net.minecraft.util.text.ITextComponent;
import net.minecraft.util.text.StringTextComponent;
import net.minecraft.world.World;

import javax.annotation.Nullable;
import java.util.List;

public class GenericSpellBook extends Item{
    private final Spell boundSpell;

    public GenericSpellBook(Spell spellToBind) {
        super(new Properties()
                .maxStackSize(1)
                .group(Gramarye.setup.itemGroup)
        );
        this.boundSpell = spellToBind;
        this.addPropertyOverride(new ResourceLocation("gramarye:element"), new IItemPropertyGetter() {
            @Override
            public float call(ItemStack stack, @Nullable World world, @Nullable LivingEntity entity) {
                return boundSpell.getSpellElement().getValue();
            }
        });
        this.addPropertyOverride(new ResourceLocation("gramarye:level"), new IItemPropertyGetter() {
            @Override
            public float call(ItemStack stack, @Nullable World world, @Nullable LivingEntity entity) {
                return boundSpell.getSpellLevel().getValue();
            }
        });


    }

    @Override
    public boolean updateItemStackNBT(CompoundNBT nbt) {
        return super.updateItemStackNBT(nbt);
    }

    @Nullable
    @Override
    public CompoundNBT getShareTag(ItemStack stack) {

        CompoundNBT compoundNBT = stack.getOrCreateTag();
        compoundNBT.putFloat("spellElement", boundSpell.getSpellElement().getValue());
        compoundNBT.putFloat("spellLevel", boundSpell.getSpellLevel().getValue());
        return compoundNBT;
    }

    @Override
    public void readShareTag(ItemStack stack, @Nullable CompoundNBT nbt) {
        super.readShareTag(stack, nbt);
    }

    @Override
    public ActionResultType onItemUse(ItemUseContext context) {
        context.getPlayer().sendStatusMessage(new StringTextComponent(boundSpell.getSpellElement().toString()), false);
        context.getPlayer().sendStatusMessage(new StringTextComponent(boundSpell.getSpellLevel().toString()), false);
        return boundSpell.onSpellCast(context);
    }

}

 

{
	"parent": "item/generated",
	"textures": {
		"layer0": "gramarye:item/book/loot_spellbook"
	},
	"overrides": [
		{
			"predicate":
			{
				"gramarye:element": 0,
				"gramarye:level":  0
			},
			"model": "gramarye:item/book/spellbook_fire_novice"
		}
	]

}

 

{
  "parent": "gramarye:item/book/spellbook_base",
  "textures": {
    "layer0": "gramarye:item/book/loot_spellbook",
    "layer1": "gramarye:item/book/fire",
    "layer2": "gramarye/item/book/novice"
  }
}

 

 

Link to comment
Share on other sites

Hmm. In 1.12 you would have done this with ItemMeshDefinition.

But that's been replaced:

Quote

Custom ItemMeshDefinitions are gone as their functionality can be completely replaced with a custom baked model with custom ItemOverrideList

 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

If your getProperty function is using NBT to return a value (by storing it in the ItemStack), then yes you need to make sure the NBT values are being written.  But in your case I don't think you need NBT, the bound spell should work fine because it's bound to the Item.

 

Is your getProperty function working?  Try putting a breakpoint into it to see if it's being called at all.

Edited by TheGreyGhost
Link to comment
Share on other sites

@TheGreyGhost the what now? I didnt see a get property function. unless you mean the get(propetyname)PropertyOverride method you used for your lamda function. in my case that just returns the float value

 

  private static float getElementPropertyOverride(ItemStack stack, @Nullable World world, @Nullable LivingEntity entity){
        return boundSpell.getSpellElement().getValue();
    }

    private static float getLevelPropertyOverride(ItemStack stack, @Nullable World world, @Nullable LivingEntity entity){
        return boundSpell.getSpellLevel().getValue();
    }

 

Link to comment
Share on other sites

Heyo o/

 

This can be marked as solved, 
For future people with similar problems, the issue comes from us using model inheritance and having the overrides on the ancestor model. 

Essentially our GenericSpellBook class gets instantiated for every spell there is in our mod, this means we have to have many different item JSONs, and we wanted to spice them up with textures. In trying to find a good way to do that we tried property overrides. 

We gave up on this after this post and switched to making our datagens do alot of the grunt work, but I re-visited it and put overrides on the individual JSONs and it worked. 

Tl;DR

Don't do:
 

Item_Model.json
{
	"parent": "mod:item/parent_item"
}

Parent_Model.json
{
	"parent": "item/generated",
	"textures": {
		"layer0": "gramarye:item/book/loot_spellbook"
	},
	"overrides": [
		{
			"predicate":
			{
				"gramarye:element": 0,
				"gramarye:level":  0
			},
			"model": "gramarye:item/book/spellbook_fire_novice"
		}
	]

}

Spellbook_fire_novice.json
{
  "parent": "gramarye:item/book/spellbook_base",
  "textures": {
    "layer0": "gramarye:item/book/loot_spellbook",
    "layer1": "gramarye:item/book/fire",
    "layer2": "gramarye/item/book/novice"
  }
}

 

 

Do this: 

 

Item_Model.json
{
  "parent": "item/book/looted_fire_novice",
  "overrides": [
    {
      "predicate": {
        "gramarye:booktype": 1.0
      },
      "model": "gramarye:item/book/crafted_fire_novice"
    }
  ]
}

crafted_fire_novice.json
{
  "parent": "item/generated",
  "textures": {
    "layer0": "gramarye:item/book/crafted_spellbook",
    "layer1": "gramarye:item/book/fire",
    "layer2": "gramarye:item/book/novice"
  }
}

looted_fire_novice.json
"parent": "item/generated",
  "textures": {
    "layer0": "gramarye:item/book/loot_spellbook",
    "layer1": "gramarye:item/book/fire",
    "layer2": "gramarye:item/book/novice"
  }

 

  • Like 1
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.