Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[Solved] Custom Bow Pullback Animation Only Loading One Frame


fracturx
 Share

Recommended Posts

My custom bow that extends the regular BowItem works perfectly fine with the exception of it not loading the pullback textures besides pulling_0. Here is my code:

diamond_bow.json:

 

{
  "parent": "item/generated",
  "textures": {
    "layer0": "otherutilities:items/diamond_bow"
  },
  "display": {
    "thirdperson_righthand": {
      "rotation": [ -80, 260, -40 ],
      "translation": [ -1, -2, 2.5 ],
      "scale": [ 0.9, 0.9, 0.9 ]
    },
    "thirdperson_lefthand": {
      "rotation": [ -80, -280, 40 ],
      "translation": [ -1, -2, 2.5 ],
      "scale": [ 0.9, 0.9, 0.9 ]
    },
    "firstperson_righthand": {
      "rotation": [ 0, -90, 25 ],
      "translation": [ 1.13, 3.2, 1.13],
      "scale": [ 0.68, 0.68, 0.68 ]
    },
    "firstperson_lefthand": {
      "rotation": [ 0, 90, -25 ],
      "translation": [ 1.13, 3.2, 1.13],
      "scale": [ 0.68, 0.68, 0.68 ]
    }
  },
  "overrides": [
    {
      "predicate": {
        "pulling": 1
      },
      "model": "otherutilities:item/diamond_bow_pulling_0"
    },
    {
      "predicate": {
        "pulling": 1,
        "pull": 0.65
      },
      "model": "otherutilities:item/diamond_bow_pulling_1"
    },
    {
      "predicate": {
        "pulling": 1,
        "pull": 0.9
      },
      "model": "otherutilities:item/diamond_bow_pulling_2"
    }
  ]
}

 

diamond_bow_pulling_0.json:

{
  "parent": "item/bow",
  "textures": {
    "layer0": "otherutilities:items/diamond_bow_pulling_0"
  }
}

 

diamond_bow_pulling_1.json:

{
  "parent": "item/bow",
  "textures": {
    "layer0": "otherutilities:items/diamond_bow_pulling_1"
  }
}

diamond_bow_pulling_2.json:

{
  "parent": "item/bow",
  "textures": {
    "layer0": "otherutilities:items/diamond_bow_pulling_2"
  }
}

I have confirmed that all of the images in the items folder do in fact exist, but only diamond_bow_pulling_0.png loads.

Here is my BaseBow Class:

package com.Silver2040.OtherUtilities.items;

import com.Silver2040.OtherUtilities.OtherUtilities;
import net.minecraft.item.*;
import net.minecraft.util.ResourceLocation;


public class BaseBow extends BowItem {

    public BaseBow(int damage) {
        super((new Item.Properties()).group(OtherUtilities.TAB)
                .maxStackSize(1)
                .maxDamage(damage));


        this.addPropertyOverride(new ResourceLocation("pull"), (stack, world, entity) -> {
            if (entity == null) {
                return 0F;
            } else {
                if (entity.getActiveItemStack().getItem() instanceof BaseBow) {
                    return 0F;
                } else {
                    return (float)(stack.getUseDuration() - entity.getItemInUseCount()) / 20F;
                }
            }
        });

        this.addPropertyOverride(new ResourceLocation("pulling"), (stack, world, entity) -> entity != null && entity.isHandActive() && entity.getActiveItemStack() == stack ? 1F : 0F);

    }

    @Override
    public int getItemEnchantability() {
        return 10;
    }

    
    private boolean isArrow(ItemStack stack) {
        return stack.getItem() instanceof ArrowItem;
    }


}

 

And here is my DiamondBow class:

package com.Silver2040.OtherUtilities.items;

public class DiamondBow extends BaseBow {

    public DiamondBow() {
        super(800);
    }
}

 

To avoid spam and also because I don't think it's really needed, I haven't included the registry file or my main file but if needed I can provide it.

Again, the bow itself loads perfectly, everything works as expected, but the drawback only has 1 pulling frame which is diamond_bow_pulling_0.png 

Thank you in advance.

Edited by fracturx
Link to comment
Share on other sites

it does? what I mean is

    {
      "predicate": {
        "pulling": 1,
        "pull": 0.65
      },
      "model": "otherutilities:item/diamond_bow_pulling_1"
    },
    {
      "predicate": {
        "pulling": 1,
        "pull": 0.9
      },
      "model": "otherutilities:item/diamond_bow_pulling_2"
    }
  ]

pull is always 0 which < 0.65 and 0.9

Link to comment
Share on other sites

you misunderstood what I mean.

                if (entity.getActiveItemStack().getItem() instanceof BaseBow) {
                    return 0F;
                } else {
                    return (float)(stack.getUseDuration() - entity.getItemInUseCount()) / 20F;
                }
            }

change the 0F to 1F does not matter because what are you trying to do is to change the bow's model correspond to the bow's pulling duration (time pulled), which you've done that in the else statement. But the else statement is never going to be reached because the item you are holding is an instance of the custom bow class so it will always return the value in the if statement

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.