Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

Ore Generation Isn't Working


Pyrocake
 Share

Recommended Posts

I have been following TurtyWurty's tutorial on how to add Ore Generation to a mod, and I have followed it fully as much as I am aware. I have created a new world, and I cannot find it anywhere. It does load properly as an item, so that isn't the problem. Here is my code

 

RegistryHandler.java

package com.booktail.newdawn.util;

import com.booktail.newdawn.NewDawn;
import com.booktail.newdawn.blocks.BlockItemBase;
import com.booktail.newdawn.blocks.PrismallonBlock;
import com.booktail.newdawn.blocks.PrismallonOreBlock;
import com.booktail.newdawn.items.ItemBase;
import net.minecraft.block.Block;
import net.minecraft.item.Item;
import net.minecraftforge.fml.RegistryObject;
import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext;
import net.minecraftforge.registries.DeferredRegister;
import net.minecraftforge.registries.ForgeRegistries;

public class RegistryHandler {

    public static final DeferredRegister<Item> ITEMS = new DeferredRegister<>(ForgeRegistries.ITEMS, NewDawn.MOD_ID);
    public static final DeferredRegister<Block> BLOCKS = new DeferredRegister<Block>(ForgeRegistries.BLOCKS, NewDawn.MOD_ID);

    public static void init() {
        ITEMS.register(FMLJavaModLoadingContext.get().getModEventBus());
        BLOCKS.register(FMLJavaModLoadingContext.get().getModEventBus());
    }

    //Item Declaration for "Hello World"
    public static final RegistryObject<Item> DINGUS = ITEMS.register("dingus", ItemBase::new);

    //Items
    public static final RegistryObject<Item> PRISMALLON_INGOT = ITEMS.register("prismallon_ingot", ItemBase::new);

    //Blocks (and Block Items)
    public static final RegistryObject<Block> PRISMALLON_BLOCK = BLOCKS.register("prismallon_block", PrismallonBlock::new);
    public static final RegistryObject<Item> PRISMALLON_BLOCK_ITEM = ITEMS.register("prismallon_block", ()-> new BlockItemBase(PRISMALLON_BLOCK.get()));

    public static final RegistryObject<Block> PRISMALLON_ORE_BLOCK = BLOCKS.register("prismallon_ore_block", PrismallonOreBlock::new);
    public static final RegistryObject<Item> PRISMALLON_ORE_BLOCK_ITEM = ITEMS.register("prismallon_ore_block", ()-> new BlockItemBase(PRISMALLON_ORE_BLOCK.get()));

}

 

NewDawnOreGen.java

package com.booktail.newdawn.world.gen;

import com.booktail.newdawn.util.RegistryHandler;
import net.minecraft.world.biome.Biome;
import net.minecraft.world.gen.GenerationStage;
import net.minecraft.world.gen.feature.Feature;
import net.minecraft.world.gen.feature.OreFeatureConfig;
import net.minecraft.world.gen.placement.ConfiguredPlacement;
import net.minecraft.world.gen.placement.CountRangeConfig;
import net.minecraft.world.gen.placement.Placement;
import net.minecraftforge.registries.ForgeRegistries;

public class NewDawnOreGen {

    public static void generateOre() {
        for(Biome biome : ForgeRegistries.BIOMES){
            ConfiguredPlacement customConfig = Placement.COUNT_RANGE.configure(new CountRangeConfig(20,5,5,25));
            biome.addFeature(GenerationStage.Decoration.UNDERGROUND_ORES, Feature.ORE
                    .withConfiguration(new OreFeatureConfig(OreFeatureConfig.FillerBlockType.NATURAL_STONE, RegistryHandler.PRISMALLON_ORE_BLOCK.get().getDefaultState(), 10))
                    .withPlacement(customConfig));
        }
    }

}

 

and NewDawn.java

package com.booktail.newdawn;

import com.booktail.newdawn.util.RegistryHandler;
import com.booktail.newdawn.world.gen.NewDawnOreGen;
import net.minecraft.block.Block;
import net.minecraft.block.Blocks;
import net.minecraft.item.ItemGroup;
import net.minecraft.item.ItemStack;
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.InterModComms;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.event.lifecycle.*;
import net.minecraftforge.fml.event.server.FMLServerStartingEvent;
import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;

import java.util.stream.Collectors;

@Mod("newdawn")
public class NewDawn {
    private static final Logger LOGGER = LogManager.getLogger();
    public static final String MOD_ID = "newdawn";

    public NewDawn() {
        FMLJavaModLoadingContext.get().getModEventBus().addListener(this::setup);
        FMLJavaModLoadingContext.get().getModEventBus().addListener(this::enqueueIMC);
        FMLJavaModLoadingContext.get().getModEventBus().addListener(this::processIMC);
        FMLJavaModLoadingContext.get().getModEventBus().addListener(this::doClientStuff);
        //FML Listeners setup completed

        RegistryHandler.init();

        MinecraftForge.EVENT_BUS.register(this);
    }

    @SubscribeEvent
    public static void loadCompleteEvent(FMLLoadCompleteEvent event){
        NewDawnOreGen.generateOre();
    }

    private void setup(final FMLCommonSetupEvent event) {
        // some preinit confirmation code
        LOGGER.info("Preinit is successful. Check Dirt registry below.");
        LOGGER.info("DIRT BLOCK >> {}", Blocks.DIRT.getRegistryName());
    }

    private void doClientStuff(final FMLClientSetupEvent event) {
        // client test
        LOGGER.info("Got game settings {}", event.getMinecraftSupplier().get().gameSettings);
    }

    private void enqueueIMC(final InterModEnqueueEvent event) {
        // hello world
        InterModComms.sendTo("newdawn", "helloworld", () -> {
            LOGGER.info("Hello world from the MDK");
            return "Hello world";
        });
    }

    private void processIMC(final InterModProcessEvent event) {
        // some example code to receive and process InterModComms from other mods
        LOGGER.info("Got IMC {}", event.getIMCStream().
                map(m -> m.getMessageSupplier().get()).
                collect(Collectors.toList()));
    }

    // You can use SubscribeEvent and let the Event Bus discover methods to call
    @SubscribeEvent
    public void onServerStarting(FMLServerStartingEvent event) {
        // do something when the server starts
        LOGGER.info("HELLO from server starting");
    }

    // You can use EventBusSubscriber to automatically subscribe events on the contained class (this is subscribing to the MOD
    // Event bus for receiving Registry Events)
    @Mod.EventBusSubscriber(bus = Mod.EventBusSubscriber.Bus.MOD)
    public static class RegistryEvents {
        @SubscribeEvent
        public static void onBlocksRegistry(final RegistryEvent.Register<Block> blockRegistryEvent) {
            // register a new block here
            LOGGER.info("HELLO from Register Block");
        }
    }

    public static final ItemGroup TAB = new ItemGroup("newdawnTab") {

        @Override
        public ItemStack createIcon() {
            return new ItemStack(RegistryHandler.PRISMALLON_INGOT.get());
        }
    };
}

 

I would greatly appreciate any help. I don't know why ore generation isn't happening in new worlds

Link to comment
Share on other sites

Is the loadComplete method running? I would double check via a log msg or breakpoint, just to be sure.

 

Also, I've always seen oregen go in FMLCommonSetupEvent, not FMLLoadCompleteEvent. Probably doesn't matter, I would guess it's a nuance of the tutorial you're following.

Link to comment
Share on other sites

6 hours ago, Maxi07 said:

I think Iyour main class NewDawn has to annotated with @EventBusSubscriber(modid = [your_modid], bus = Bus.MOD), but leave "@Mod"

Then the methods with @SubribeEvent (like your ore gen) will be executed

 

I used 

@Mod.EventBusSubscriber(bus = Mod.EventBusSubscriber.Bus.MOD)

And that made it work, thank you!

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.