Jump to content

ModLoader.addName applies one name to all items. (X-post)


linkseyi

Recommended Posts

I have a mod that's ported to FML from ModLoader.  Everything's working okay as of now except that when I use both ModLoader.addName and LanguageRegistry.addName, all items in the mod resort to being named the last one applied.

 

public class mod_Tools extends BaseMod
{
  public static lx texToolSword;
  public static lx texToolPickaxe;
  public static lx texToolHelmet;
  public static lx texToolPlate;
  //Ignore the addTool/ArmorMaterial stuff.
  public static final wk ToolSword = new ItemToolSword(160, LinkseyiForgeAdapter.addToolMaterial("Rod", 1, 64, 7.0F, 2, 2)).c("ToolSword");
  public static final wk ToolPickaxe = new ItemToolPickaxe(161, LinkseyiForgeAdapter.addToolMaterial("Rod", 1, 64, 7.0F, 2, 2)).c("ToolPickaxe");
  public static final wk ToolHelmet = new ItemToolHelmet(162, LinkseyiForgeAdapter.addArmorMaterial("DiamondTwo", 7, new int[] { 6, 6, 7, 6 }, , ModLoader.addArmor("DiamondTwo"), 0).c("ToolHelmet");
  public static final wk ToolPlate = new ItemToolPlate(163, LinkseyiForgeAdapter.addArmorMaterial("DiamondTwo", 7, new int[] { 6, 6, 7, 6 }, , ModLoader.addArmor("DiamondTwo"), 1).c("ToolPlate");

  public void load()
  {
    // I've tried using LanguageRegistry too; same results.
    ModLoader.addName(ToolSword, "Tool Sword");
    ModLoader.addName(ToolPickaxe, "Tool Pickaxe");
    ModLoader.addName(ToolHelmet, "Tool Helmet");
    ModLoader.addName(ToolPlate, "Tool Plate");
  }
}

 

In this case all items end up being named "Tool Plate".

Link to comment
Share on other sites

First thing first, learn to code using Forge!!!!!!

 

Don't use mod porters, you will most likely get more errors like this. What you need to do is just recode it all into Forge. And its not that hard to do so. All you have to do is change the base mod file (in ModLoader, defined as mod_***) to a Forge one, and then just change all your ModLoader methods to the Forge equivalents. Entity, Item, and Block files will all be the same, the only difference being how you register them (not very different at all since the 1.5 update)  and the name registry, entity registry etcetera.

 

I hope I don't seem like a modder fanatic or something that is the right word for this situation..

I am Mew. The Legendary Psychic. I behave oddly and am always playing practical jokes.

 

I have also found that I really love making extremely long and extremely but sometimes not so descriptive variables. Sort of like what I just did there xD

Link to comment
Share on other sites

First thing first, learn to code using Forge!!!!!!

 

Don't use mod porters, you will most likely get more errors like this. What you need to do is just recode it all into Forge. And its not that hard to do so. All you have to do is change the base mod file (in ModLoader, defined as mod_***) to a Forge one, and then just change all your ModLoader methods to the Forge equivalents. Entity, Item, and Block files will all be the same, the only difference being how you register them (not very different at all since the 1.5 update)  and the name registry, entity registry etcetera.

 

I hope I don't seem like a modder fanatic or something that is the right word for this situation..

lol, hipster

BEWARE OF GOD

---

Co-author of Pentachoron Labs' SBFP Tech.

Link to comment
Share on other sites

First thing first, learn to code using Forge!!!!!!

 

Don't use mod porters, you will most likely get more errors like this. What you need to do is just recode it all into Forge. And its not that hard to do so. All you have to do is change the base mod file (in ModLoader, defined as mod_***) to a Forge one, and then just change all your ModLoader methods to the Forge equivalents. Entity, Item, and Block files will all be the same, the only difference being how you register them (not very different at all since the 1.5 update)  and the name registry, entity registry etcetera.

 

I hope I don't seem like a modder fanatic or something that is the right word for this situation..

lol, hipster

 

Hipster? What do you mean by that sir?

I am Mew. The Legendary Psychic. I behave oddly and am always playing practical jokes.

 

I have also found that I really love making extremely long and extremely but sometimes not so descriptive variables. Sort of like what I just did there xD

Link to comment
Share on other sites

First thing first, learn to code using Forge!!!!!!

 

Don't use mod porters, you will most likely get more errors like this. What you need to do is just recode it all into Forge. And its not that hard to do so. All you have to do is change the base mod file (in ModLoader, defined as mod_***) to a Forge one, and then just change all your ModLoader methods to the Forge equivalents. Entity, Item, and Block files will all be the same, the only difference being how you register them (not very different at all since the 1.5 update)  and the name registry, entity registry etcetera.

 

I hope I don't seem like a modder fanatic or something that is the right word for this situation..

lol, hipster

 

Hipster? What do you mean by that sir?

I mean that I was into Minecraft before it was cool.  8)

BEWARE OF GOD

---

Co-author of Pentachoron Labs' SBFP Tech.

Link to comment
Share on other sites

First thing first, learn to code using Forge!!!!!!

 

Don't use mod porters, you will most likely get more errors like this. What you need to do is just recode it all into Forge. And its not that hard to do so. All you have to do is change the base mod file (in ModLoader, defined as mod_***) to a Forge one, and then just change all your ModLoader methods to the Forge equivalents. Entity, Item, and Block files will all be the same, the only difference being how you register them (not very different at all since the 1.5 update)  and the name registry, entity registry etcetera.

 

I hope I don't seem like a modder fanatic or something that is the right word for this situation..

 

Thank you, but as this is part of an interactive compiler (http://www.minecraftforum.net/topic/1361604-152-windows-linkseyis-modmaker-create-unique-blocks-items-recipes-mobs-and-models-structures-and-biomes-with-a-simple-gui/#entry16594112), changing around large amounts of code is not practical unless ultimately necessary.  Also, I have tried using the Forge equivalent to addName (LanguageRegsitry.addName) and got the same results.

Link to comment
Share on other sites

First thing first, learn to code using Forge!!!!!!

 

Don't use mod porters, you will most likely get more errors like this. What you need to do is just recode it all into Forge. And its not that hard to do so. All you have to do is change the base mod file (in ModLoader, defined as mod_***) to a Forge one, and then just change all your ModLoader methods to the Forge equivalents. Entity, Item, and Block files will all be the same, the only difference being how you register them (not very different at all since the 1.5 update)  and the name registry, entity registry etcetera.

 

I hope I don't seem like a modder fanatic or something that is the right word for this situation..

 

Thank you, but as this is part of an interactive compiler (http://www.minecraftforum.net/topic/1361604-152-windows-linkseyis-modmaker-create-unique-blocks-items-recipes-mobs-and-models-structures-and-biomes-with-a-simple-gui/#entry16594112), changing around large amounts of code is not practical unless ultimately necessary.  Also, I have tried using the Forge equivalent to addName (LanguageRegsitry.addName) and got the same results.

If you don't want to use Forge, don't come complaining to Forge when your mod doesn't work.

BEWARE OF GOD

---

Co-author of Pentachoron Labs' SBFP Tech.

Link to comment
Share on other sites

First thing first, learn to code using Forge!!!!!!

 

Don't use mod porters, you will most likely get more errors like this. What you need to do is just recode it all into Forge. And its not that hard to do so. All you have to do is change the base mod file (in ModLoader, defined as mod_***) to a Forge one, and then just change all your ModLoader methods to the Forge equivalents. Entity, Item, and Block files will all be the same, the only difference being how you register them (not very different at all since the 1.5 update)  and the name registry, entity registry etcetera.

 

I hope I don't seem like a modder fanatic or something that is the right word for this situation..

 

Thank you, but as this is part of an interactive compiler (http://www.minecraftforum.net/topic/1361604-152-windows-linkseyis-modmaker-create-unique-blocks-items-recipes-mobs-and-models-structures-and-biomes-with-a-simple-gui/#entry16594112), changing around large amounts of code is not practical unless ultimately necessary.  Also, I have tried using the Forge equivalent to addName (LanguageRegsitry.addName) and got the same results.

If you don't want to use Forge, don't come complaining to Forge when your mod doesn't work.

I don't think you understand.  I am using the ModLoader class in Forge, which should work fine (it's designed to be ModLoader-compatible).

Link to comment
Share on other sites

First thing first, learn to code using Forge!!!!!!

 

Don't use mod porters, you will most likely get more errors like this. What you need to do is just recode it all into Forge. And its not that hard to do so. All you have to do is change the base mod file (in ModLoader, defined as mod_***) to a Forge one, and then just change all your ModLoader methods to the Forge equivalents. Entity, Item, and Block files will all be the same, the only difference being how you register them (not very different at all since the 1.5 update)  and the name registry, entity registry etcetera.

 

I hope I don't seem like a modder fanatic or something that is the right word for this situation..

 

Thank you, but as this is part of an interactive compiler (http://www.minecraftforum.net/topic/1361604-152-windows-linkseyis-modmaker-create-unique-blocks-items-recipes-mobs-and-models-structures-and-biomes-with-a-simple-gui/#entry16594112), changing around large amounts of code is not practical unless ultimately necessary.  Also, I have tried using the Forge equivalent to addName (LanguageRegsitry.addName) and got the same results.

If you don't want to use Forge, don't come complaining to Forge when your mod doesn't work.

I don't think you understand.  I am using the ModLoader class in Forge, which should work fine (it's designed to be ModLoader-compatible).

 

No, I don't think you understand. YOUR PROBLEM IS COMING FROM MAKING THE MOD IN A MOD MAKER!!!! Since you have done that, it cannot read properly, and editing it is just pointless. So you need to decompile MCP with forge, REWRITE your mod (yes, the whole damn thing because it is already recompiled/reobfuscated) and then recompile/reobfuscate it the normal way.

And ObsequiousNewt is right, don't come complaining about forge related problems if you are making a mod using another API.

 

First thing first, learn to code using Forge!!!!!!

 

Don't use mod porters, you will most likely get more errors like this. What you need to do is just recode it all into Forge. And its not that hard to do so. All you have to do is change the base mod file (in ModLoader, defined as mod_***) to a Forge one, and then just change all your ModLoader methods to the Forge equivalents. Entity, Item, and Block files will all be the same, the only difference being how you register them (not very different at all since the 1.5 update)  and the name registry, entity registry etcetera.

 

I hope I don't seem like a modder fanatic or something that is the right word for this situation..

lol, hipster

 

Hipster? What do you mean by that sir?

I mean that I was into Minecraft before it was cool.  8)

 

What does that have to do with me?

I am Mew. The Legendary Psychic. I behave oddly and am always playing practical jokes.

 

I have also found that I really love making extremely long and extremely but sometimes not so descriptive variables. Sort of like what I just did there xD

Link to comment
Share on other sites

First thing first, learn to code using Forge!!!!!!

 

Don't use mod porters, you will most likely get more errors like this. What you need to do is just recode it all into Forge. And its not that hard to do so. All you have to do is change the base mod file (in ModLoader, defined as mod_***) to a Forge one, and then just change all your ModLoader methods to the Forge equivalents. Entity, Item, and Block files will all be the same, the only difference being how you register them (not very different at all since the 1.5 update)  and the name registry, entity registry etcetera.

 

I hope I don't seem like a modder fanatic or something that is the right word for this situation..

 

Thank you, but as this is part of an interactive compiler (http://www.minecraftforum.net/topic/1361604-152-windows-linkseyis-modmaker-create-unique-blocks-items-recipes-mobs-and-models-structures-and-biomes-with-a-simple-gui/#entry16594112), changing around large amounts of code is not practical unless ultimately necessary.  Also, I have tried using the Forge equivalent to addName (LanguageRegsitry.addName) and got the same results.

If you don't want to use Forge, don't come complaining to Forge when your mod doesn't work.

I don't think you understand.  I am using the ModLoader class in Forge, which should work fine (it's designed to be ModLoader-compatible).

 

No, I don't think you understand. YOUR PROBLEM IS COMING FROM MAKING THE MOD IN A MOD MAKER!!!! Since you have done that, it cannot read properly, and editing it is just pointless. So you need to decompile MCP with forge, REWRITE your mod (yes, the whole damn thing because it is already recompiled/reobfuscated) and then recompile/reobfuscate it the normal way.

And ObsequiousNewt is right, don't come complaining about forge related problems if you are making a mod using another API.

No, I made the ModMaker.  I'm trying to update it to be Forge-compatible (sorry for the misunderstanding).  I can rewrite things to be "completely Forge", but I'd rather know what the immediate problem is before I do that.

Link to comment
Share on other sites

First thing first, learn to code using Forge!!!!!!

 

Don't use mod porters, you will most likely get more errors like this. What you need to do is just recode it all into Forge. And its not that hard to do so. All you have to do is change the base mod file (in ModLoader, defined as mod_***) to a Forge one, and then just change all your ModLoader methods to the Forge equivalents. Entity, Item, and Block files will all be the same, the only difference being how you register them (not very different at all since the 1.5 update)  and the name registry, entity registry etcetera.

 

I hope I don't seem like a modder fanatic or something that is the right word for this situation..

 

Thank you, but as this is part of an interactive compiler (http://www.minecraftforum.net/topic/1361604-152-windows-linkseyis-modmaker-create-unique-blocks-items-recipes-mobs-and-models-structures-and-biomes-with-a-simple-gui/#entry16594112), changing around large amounts of code is not practical unless ultimately necessary.  Also, I have tried using the Forge equivalent to addName (LanguageRegsitry.addName) and got the same results.

If you don't want to use Forge, don't come complaining to Forge when your mod doesn't work.

I don't think you understand.  I am using the ModLoader class in Forge, which should work fine (it's designed to be ModLoader-compatible).

 

No, I don't think you understand. YOUR PROBLEM IS COMING FROM MAKING THE MOD IN A MOD MAKER!!!! Since you have done that, it cannot read properly, and editing it is just pointless. So you need to decompile MCP with forge, REWRITE your mod (yes, the whole damn thing because it is already recompiled/reobfuscated) and then recompile/reobfuscate it the normal way.

And ObsequiousNewt is right, don't come complaining about forge related problems if you are making a mod using another API.

No, I made the ModMaker.  I'm trying to update it to be Forge-compatible (sorry for the misunderstanding).  I can rewrite things to be "completely Forge", but I'd rather know what the immediate problem is before I do that.

I would recommend rewriting things to be "completely Forge" first. I don't know what the specific problem is, but I conjecture you need to tell Forge the mod context.

First thing first, learn to code using Forge!!!!!!

 

Don't use mod porters, you will most likely get more errors like this. What you need to do is just recode it all into Forge. And its not that hard to do so. All you have to do is change the base mod file (in ModLoader, defined as mod_***) to a Forge one, and then just change all your ModLoader methods to the Forge equivalents. Entity, Item, and Block files will all be the same, the only difference being how you register them (not very different at all since the 1.5 update)  and the name registry, entity registry etcetera.

 

I hope I don't seem like a modder fanatic or something that is the right word for this situation..

lol, hipster

 

Hipster? What do you mean by that sir?

I mean that I was into Minecraft before it was cool.  8)

 

What does that have to do with me?

"...or something that is the right word for this situation"

Not that "hipster" especially fits, I just felt a need to say "lol, hipster"

BEWARE OF GOD

---

Co-author of Pentachoron Labs' SBFP Tech.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.